From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.15999.1646016429922821624 for ; Sun, 27 Feb 2022 18:47:11 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=KCigzP89; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646016429; x=1677552429; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=idggMudWgitj1vL3qKiZKoeIXbZJSGj+nty/JInFgQw=; b=KCigzP89GLaWiDN/U7COPV0wbscHV/qs3qxFKEBH1wl7/UNnnjs6ESgD EKixf27qgfoV9kCn/5wVY1a6d5JhEaAkLTBC1uAgUYZxHkaVY/Nf3CYq4 ik9GPchoEQJa8eHY3gG9nXIAz/IsNH2akKoPkfZc14L7nrKwrXjx0eSnl s/DVRhsLkNxRE3Bpk1FNXgxNiuSPvTOx3BpGw/zRWKj+Im9U2OnBb6eC5 pPFfKxrDz2MtTRuXHP7OwpXSMkN43eyjNPvpvis+UwJngr/Hx+KIxMz4u EP68bgs1o8F1clJ1TInxqRyStDQua/aUPsYen1wX5BXk4PwG8+QKubbGW g==; X-IronPort-AV: E=McAfee;i="6200,9189,10271"; a="232757394" X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="232757394" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2022 18:47:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="593062045" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga008.fm.intel.com with ESMTP; 27 Feb 2022 18:47:09 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sun, 27 Feb 2022 18:47:09 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sun, 27 Feb 2022 18:47:08 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Sun, 27 Feb 2022 18:47:08 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 27 Feb 2022 18:47:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TySXP599l5QolpvFNCwlsCYPKohpTchtbIcjn3JrjpGQ3Jn/hd3DivkbW/CjUuAXnpykzyemvzZd4KFBizz/JBvFm061DqnXUMmZORQ1M3luHueyVzsaEgkSa7wHzQ6H20mundY/JHvRAC92J/ilqjGcx3mHl1DtLa5vsDnGtZl8xkOFKJEYBVSqumUr7QJz/bfxBAkNEv6VOSZiMgn8FwV0bDgFLc5xbPXynttum4E9nMFFQByJy7WNsjPxAJmI6biYx+ctt2l80tUojLvZ0m/sVJp6TymbEqiyhg1GVzIb5EaGFcMAH+ha1k+x7Eifmndi7FN+/Tjyc2pHyalw0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b/zx2mHUWUIIUyi7VLqtRaf0R6WIGM3odCeqLD3mDSw=; b=lERlzOLeosYlwVGKzS6aWsmO3n17qRFeplDOKp/VDFpLr36VEhMJ+WZZeQWCVBWvNLlUdoyvJXIjt7lMqy+t25vdJPBiHva1FwyVt9xul0ws8FY7JlOvYBlvWDvYII0a/r/HNDL4FtbKT2HpR8By1XYnnaM7IoX6J72D/ESYJ0Gk3MjoGoiV6SXxUvpFxNWHe1u0ZBWDZyuwV9U+6/Lwo87NFAHwgGJ7QUF2kxHzWd7vvqHRfWPtRbYzUUkqp8XrMxuFKuZR0NnEvedfb90CZdjXwkUfc6JDdvWeqGYhfNtyuevawFa8CSCFjiQRUWz4KufF0xnK1furEkNMKqrTfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CY4PR1101MB2133.namprd11.prod.outlook.com (2603:10b6:910:17::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Mon, 28 Feb 2022 02:47:04 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::21db:e2fd:b9a3:9292]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::21db:e2fd:b9a3:9292%5]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022 02:47:04 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , Brijesh Singh CC: James Bottomley , "Xu, Min M" , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , "Aktas, Erdem" , Michael Roth , Gerd Hoffmann , "aaron.young@oracle.com" Subject: Re: [edk2-devel] [PATCH v2 0/2] SEV BaseMemEncryptLib cleanup Thread-Topic: [edk2-devel] [PATCH v2 0/2] SEV BaseMemEncryptLib cleanup Thread-Index: AQHYJzOtgQ3h5cqpYECuXYIHpuk87qyoRufAgAAFf4A= Date: Mon, 28 Feb 2022 02:47:04 +0000 Message-ID: References: <20220221145914.1972322-1-brijesh.singh@amd.com> <16D7D2238C7EE163.30539@groups.io> In-Reply-To: <16D7D2238C7EE163.30539@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c71c37c0-9cdf-4c06-589e-08d9fa649a7f x-ms-traffictypediagnostic: CY4PR1101MB2133:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qxJMIXnpyuesrH+d4e/7loeu2jtkSWnDNAWnh6qcBRIz90tUOwyK54Rg1vWvoKoPcSpCVFORhbhAOR1NVmla528NISn6qts4CtFCtAu5aQVV06OEncUZR33mxTiJkAkLDcf4fdIcW5ZJcK2rggTfRL6lDbmy+PBOyZRSwXiL62j/Pdt6QmIGOgiCVQoTsdpwBVwb+zjLSpTg1vP2gENObbajE+WM39TuMEbg0+VBc5KprD55gz6Nm0zXtm/UI2WhfJeKG43HbvKcnN3mtCYADjNXDincN+B76dDh1Bl+KhSX6NU/iuTGgEhdmCz4BBYnBMc1OZtGDv/auq0YuB4te3D9QzeLs4z2toiPXS29+WT/gG7t5w+XVZ3gy/n+djdm+3yqNXNzbNZCFYIlEYMvWnr/Yrzmb6wKb0/9L1CBuBpW0Bh2Xc/TudY7sPAl926f4rVtyY4iECsF/uvTXJYSnXOSe3pl5ZUjwsEQYIS+ijrqKMAZhyNEAq4dYoG1Nfa6t/SnBKofH1A7ejZL9Ye7Fi5eW4vN80ZrSGXuEIV3iiDzFBHHX/dEJTA1g46onnNBjKe3RuHW42t+gnThEWP1BADU88l+CuCqAxRrCWgsq1q0FSlxB0zDkykkU1bdzz1TlFFWeTvAYcQFzWHBjfrym/E/T0Hc6iVY/yRDblxd2Mkc4MbqYjp/RuKIzpAgc7hZlJxe2D51Jdp71kZ8beCkbrapBtyj0vzKN1tp8oW+5TBIIQ6cmoa2fHeLobxxdrllkZ6nF6xlXVSwk7QKb5rFhCbwVnHtX+1QsiREJl+5Pb9hoqKSY/AHVCmDvTxh+vIjkCeb/LkPrMbmo4qJiiZDVw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(26005)(110136005)(86362001)(19627235002)(7696005)(9686003)(4326008)(186003)(53546011)(71200400001)(8676002)(83380400001)(316002)(38070700005)(2906002)(76116006)(66446008)(66476007)(66556008)(66946007)(64756008)(6506007)(52536014)(38100700002)(8936002)(55016003)(5660300002)(82960400001)(33656002)(966005)(122000001)(508600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?K2Q8H7zLcAgk0ln1ZZRvEyMuSl0IMS4QeS+8O8OIr3W018nrfjm9yA/5kXSX?= =?us-ascii?Q?9Y3UNpRBIGoxGIQJ5QLTfJLPAlv2fpQsyA/bwRLHSL9/gthpP7Tb7z9cWgXV?= =?us-ascii?Q?f9zP5pUCIrvMix7ILxSzMrmy/Sd/ON11RmM5iMAapDImta+5ZF5OKLVQgZz3?= =?us-ascii?Q?Zcf5gfeQxsXeHCCIMFw63xThm1Z0fzNkWaaDk57piUBXsbdM5hoVhcNzh10L?= =?us-ascii?Q?D05pcwHXpnrSBoUhAR8zZyqSKZ80m5Lpec54wHHjYG1DC9BCPe6P0IalXzkc?= =?us-ascii?Q?udl0XWsqoX7LACm9nPrk51k1M1HmWjrV3Wu1J8KO404ROarbVGXHLqWGSUBV?= =?us-ascii?Q?g20ozL1msOaUMHa+sYNXoiKJGQX8o5EHmnF7DzcHgYvtTlA9JkAvr4Lfi9f6?= =?us-ascii?Q?XnSbZzEAbXTZdiKxh79WmRtNeVUnItzgCp7asLm+3cs8tpAWAoKFguN0egLa?= =?us-ascii?Q?bauDbWMqhNwtUDW3hAet95IMe6bbzLyuyXwpEHZHVgfKfgsw+/a58Cz2yNT2?= =?us-ascii?Q?mcTeJApQI30uaMugnX4LCcwNFoC+OwqHJ6wy1cG4+zfHggt1UnObtEBo1lxW?= =?us-ascii?Q?EGU/M/w7pVuIMuSYzPJ2YzUyDLtiRN/T1fhARvkTMWTY4VUeUXfhzI2AwYEd?= =?us-ascii?Q?STj/sI1F5OWwO3nLo0fdx6e8crpahsYTH3MDXr6p4AekEmSnvwxzXOiUw21N?= =?us-ascii?Q?TZtotkacXrKIYVq5gQjMaHKT8oxuFCfSQ5iwrZKZIkHcFVCOj6Rs8OGCt8ZF?= =?us-ascii?Q?mBE//6umEFYiniVfEUsf9oJ8WTwevsuukte0tfenbQSVKhOAZDiPZD7A7oyF?= =?us-ascii?Q?rPW46HS5FS0NyvKEQDqWVx4CxFO8f0bK055U0sOoB7CK0NpQZN+G7cnSOZaE?= =?us-ascii?Q?Pzca//SRvIOnF0nsW2SOj0IPZ4sJ3Sdx691s+F16IJyPV97JlC1+QQwFw0C/?= =?us-ascii?Q?FveM+YQUv4AEdRvQBra2NBaAMdZglD6Pcbk/qC6TeZA37cQZOV4ddGObwRRV?= =?us-ascii?Q?U76Y80YbJckU7syjmCm062w6KjroCbkozDSKymbFDh0WL1CgR4lGPrSxfFsY?= =?us-ascii?Q?VoJC3LP5DEv1S0lMpK8ZlG7kHAEzVrxD919tl0pC4laHD8uitGM1HEW/m7aa?= =?us-ascii?Q?UtaT36dZbAgeSz+BEAW1jAZnzt3Ppm9otRm0gvM52fulIH7q9CxHNSz2vYwl?= =?us-ascii?Q?LoXhwlPhv1ruluhfuHn0CA4r8KsaSrzMMcKlxHJ2+bkJ9bPnkTDQ2Vymnsdr?= =?us-ascii?Q?GRMND0m9VaP/Dj4Zgd6QrOIpjDPZc2+lACfZJnodlBFyDSH0A3TV3RnEgLHX?= =?us-ascii?Q?OeOOv2WnO/e48g5SjTQBRaNTIZiHv5hM5yde91eXrc0sDeCESDIsBZp8eOmk?= =?us-ascii?Q?TqSg5WR6YbTzC3GdVN62KATh8LPt1Fps+qBIkjKqe8Zctmd0KVmY3nwPKqno?= =?us-ascii?Q?+9lSoAfeDiz7NvrFvkHABwFpenVrVVGlKxtQst5e/CCeLTt6Zoc+tsysPWLI?= =?us-ascii?Q?OnxqvtuENp4udexgh/wXy14lDee/OCvxeqsMB8/gVj/hpzPwXnylqSLJvyvm?= =?us-ascii?Q?1YCS/ldLWVccBxNwkHnzRc/dGZuAz5TUmou5Khd1hylQODTKlbxB24Tl36dN?= =?us-ascii?Q?xfHWycgN8pHcM+k6+S0f+a8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c71c37c0-9cdf-4c06-589e-08d9fa649a7f X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 02:47:04.5033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bN6zpRkEJqu2OB16BBr1ZXAw6SHky2wFI0GMUC2vrNJW46Vs7zeTNPdlOz7Byt+3YDQHk1uPqM0dGg7rSU8cHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2133 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged - 534e411, 3a60389 https://github.com/tianocore/edk2/pull/2553 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewe= n > Sent: Monday, February 28, 2022 10:27 AM > To: Brijesh Singh ; devel@edk2.groups.io > Cc: James Bottomley ; Xu, Min M ; > Tom Lendacky ; Justen, Jordan L > ; Ard Biesheuvel ; > Aktas, Erdem ; Michael Roth > ; Gerd Hoffmann ; > aaron.young@oracle.com > Subject: Re: [edk2-devel] [PATCH v2 0/2] SEV BaseMemEncryptLib cleanup >=20 > Acked-by: Jiewen Yao >=20 > > -----Original Message----- > > From: Brijesh Singh > > Sent: Monday, February 21, 2022 10:59 PM > > To: devel@edk2.groups.io > > Cc: James Bottomley ; Xu, Min M > ; > > Yao, Jiewen ; Tom Lendacky > > ; Justen, Jordan L = ; > > Ard Biesheuvel ; Aktas, Erdem > > ; Michael Roth ; Gerd > > Hoffmann ; aaron.young@oracle.com; Brijesh Singh > > > > Subject: [PATCH v2 0/2] SEV BaseMemEncryptLib cleanup > > > > This is the first of cleanup for SEV MemEncryptLib. The library uses > > the CPUID followed by the MSR read to determine whether SEV is enabled. > > > > Now that we have a workarea concept, the logic can be simplified to > > store the msr status in workarea and use that to build PCDs and then > > later simply use the PCDs instead of going through the CPUID and RDMSR. > > > > The complete branch is available at > > https://github.com/codomania/edk2/tree/sev-workarea-cleanup > > > > The series also fixes one of the issue raised in the bug > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3582 > > > > Changes since v1: > > * Cache the PCD reads so that we can avoid reading PCD while performin= g the > > virtual pointer conversion. > > > > Brijesh Singh (2): > > OvmfPkg/ResetVector: cache the SEV status MSR value in workarea > > OvmfPkg/BaseMemEncryptLib: use the SEV_STATUS MSR value from > workarea > > > > .../DxeMemEncryptSevLib.inf | 1 + > > .../PeiMemEncryptSevLib.inf | 1 + > > .../SecMemEncryptSevLib.inf | 1 + > > OvmfPkg/Include/WorkArea.h | 12 +- > > .../DxeMemEncryptSevLibInternal.c | 145 ++++++++---------- > > .../PeiMemEncryptSevLibInternal.c | 139 ++++++----------- > > .../SecMemEncryptSevLibInternal.c | 80 +++++----- > > OvmfPkg/Sec/AmdSev.c | 2 +- > > OvmfPkg/ResetVector/Ia32/AmdSev.asm | 38 +++-- > > OvmfPkg/ResetVector/Ia32/Flat32ToFlat64.asm | 3 +- > > OvmfPkg/ResetVector/ResetVector.nasmb | 3 + > > 11 files changed, 194 insertions(+), 231 deletions(-) > > > > -- > > 2.25.1 >=20 >=20 >=20 >=20 >=20