From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 11988D80696 for ; Thu, 7 Sep 2023 08:13:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Odxh6Q1LZW50U3DM4s3uXxfYQ1qz069oi9p5waVdykg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694074411; v=1; b=lPixM98P16ZNM7ldEyuRmN9YpDggpaBdmmSoa86rEH+djGJ/wOOyovbrMRyBgwf7WFN0PAs8 z8tIn+dPCP1xDh1vMEfNKhFfF9UuG4nndgxgyHVAagWdIHPkFnsw41s6KNCBsOPOT+Ih1mNSICw H/uUXFr1Ay/SqV4wCT+9xR0A= X-Received: by 127.0.0.2 with SMTP id 4TI4YY7687511x7MsZEgmNHA; Thu, 07 Sep 2023 01:13:31 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.8213.1694074408252102322 for ; Thu, 07 Sep 2023 01:13:30 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10825"; a="441278072" X-IronPort-AV: E=Sophos;i="6.02,234,1688454000"; d="scan'208";a="441278072" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 01:13:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10825"; a="812047398" X-IronPort-AV: E=Sophos;i="6.02,234,1688454000"; d="scan'208";a="812047398" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Sep 2023 01:13:11 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 7 Sep 2023 01:13:11 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 7 Sep 2023 01:13:11 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 7 Sep 2023 01:13:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U0lOTF91Ch7XQdvhB/tnh/Ejf9B3FOI2YHWXBVEuVfGwBXJ9wo4feM7FWlJkivzsUukEDzZzK1nTK8HbVpklEecLoWAt4+hNecygk6Z0wOoDWAY37wZ5NDPb5G9NHudRJFl18Va5cJ8zePIDvHLRlKE9resol874YCtSfxEFEVH1o1GQoXDQZj2igF0MHBd2t0fjAW1VmKLbXK3h7ZFCNndjZb/uu3ad60B4STw/5A35PseA0HsbRQMRL50e/p6QYcYERj8FuAdtlrRDKKPELHiLiBbO2Cu2SwpuFL4oc0upQCIcORIPydPL70sDt9EbaZfuFuTNWJK4shKT8hyznw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LVaWhsj6r/PzH4rUzoMkuwMYZgFUV6Y77JDbm20j7uU=; b=EDbzvgg/ug0T2KuiD2yzlE/Ehdh7bLcjPP+/svsF61mq+uvgCk2l9c483Am1c6i8IhEoPCYzkjWgO12ArIOsrdIEb0UCsqpRGQlmHby+IcCuMucQ13+6/NLDMQLHr0Xka/6VfJw5jSMuXVbXpUXFUGQwV9I+QjeBXCj6h76vNgPApRY4nzOxNt3fOhJBYZDfwCB0qU2+09stQidt5F58S0oVLr0e/mDQ+fB2FkU/rULNRYb+2FYAwazKY8jCpdJoT5mhXQhZvP0v18KrqZOkNC6rYfAVTM+5SGKHvQknxOoCJUfUeUT/jHdQTvhLqA/f+lLYUP/k7gVrE05jtkGb3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BN9PR11MB5559.namprd11.prod.outlook.com (2603:10b6:408:104::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.34; Thu, 7 Sep 2023 08:13:09 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b%4]) with mapi id 15.20.6745.034; Thu, 7 Sep 2023 08:13:09 +0000 From: "Yao, Jiewen" To: "Liu, Linus" , "devel@edk2.groups.io" CC: "Zhang, Qi1" , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v1] Pyrite support - Secure erase is only available if encryption is supported. Thread-Topic: [PATCH v1] Pyrite support - Secure erase is only available if encryption is supported. Thread-Index: AQHZ3ws/G+SBKH7R7U6O42VML+Gv9rAPB4eA Date: Thu, 7 Sep 2023 08:13:09 +0000 Message-ID: References: <20230904083815.412-1-linus.liu@intel.com> In-Reply-To: <20230904083815.412-1-linus.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|BN9PR11MB5559:EE_ x-ms-office365-filtering-correlation-id: 46d10265-d1a4-4f72-4dc9-08dbaf7a45cf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ZjzZfxL6NhlzCgwShVFeDP0uXifrLPY7gzICRpG2N8kjl39deyQ5t40QG4LUqUvL6Fo1mooirZBT6bG82ChztNWZprm5Da+piNGO0m9LBbVKMaQZLT+D2uUKOpAoaSOsQqzf/LyejghosMmdD4KNIj3qMtAPzsN+4qC3W0CGLE5vIK96/ADUpbG8H9zt5kp7zgt+46N/ZCc6U9K1TQvNuJ2IwlxnuiYTQ9X7oIULXOAU1NrZOKArJbI/vqqPvKf9EkX7yZJyujib930DmMEFfuBJcYACqHU0cAZzGNEn18U5U46t02lmoxPZEoPJ8iyJQ9FU8cVM6SA6LZLC48Z3AThpXKmTbzJunrnqUZGydNMS0yJAoQW3cvYdUxrIF77bNNQ6aqWrbZoI2QAQrp7Q3t2PaPXJnWMvhlk2+tZUjxu4mKunHluvMaH9h5uCjnZArOAYDG5xgkPpg/4lWIIkjvmhrV1QXPqAWqEpaOGVYxvgU3qU5XPi3aG5MLoISV8Blc+168H1zauanRPQu8NTvMhoBL0KdGOhu385Dt0iFoA9Zo/tBTYFoyRyiT8/gUim7ycUlynKwKPw5586jptGRe8AaihMxpngitn0Gqa/emk= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z1HYJAd1J4TLHdnoKoZ7F5da3dJ9cJ/klHLXd5FL8cBt9M4o/AoZe5aLhngZ?= =?us-ascii?Q?fbhQCYQY22N+6q3XPk1WBxO5eGlIJOEQ8vTKK1Bdcu6LE4DubWUpCDX/Hdvs?= =?us-ascii?Q?knlDRkcfbtqtmBBdIs+XiWA3TNOSMP8jIl0GFrGX8iP7M67uJHcRu0UbZGWD?= =?us-ascii?Q?CQ0AXiWNbNXAkylUixNNZnEIYw+eYgkcMeICNBuSIgn3p3x2d0WxWASs1ILI?= =?us-ascii?Q?SmFzROHnL0gfvkOCY64q6/lVsN8Y/VsNFF+B9n/yio1dFkkoliwKwL4BFel3?= =?us-ascii?Q?yXZ0+y4ep67w7R1nueyCw2nHHY0sT+HlCUhF1CvswQuMdTedbMu4fyryrFH4?= =?us-ascii?Q?eRgO7EfgQvpCqGfLoypMecZLh0PdHO/PolmxQw2zzRyWVZ3GV2o8ulykA5Ae?= =?us-ascii?Q?XjBD3NroUAwNFhaAloAaYzBvQ6jyxoebhfu049H4zPFsnyMoYCSi5EmRIOMm?= =?us-ascii?Q?J9UDEE5F9qGDG/UErJUosed+wDHmgFAZtVchPhoE8gEeh0FC4JoERIB/2lbf?= =?us-ascii?Q?Sxpo3TexICtwy6zCdd/IPrzmHKVfQM9+ggy+79TUjoSwiBC9a3FfKdOZ1Bv1?= =?us-ascii?Q?yGnC2rRNNaCtLJ5hYQMNDXDHo2jlwaq49duJXRqiyGUg2ReDo7IRmtLhAgFu?= =?us-ascii?Q?GsN/ku1uRjuo+JK92AU12XPTEIuQli5kc/9ST0oLIzXtP/2JA8qd5SfpwqpD?= =?us-ascii?Q?BOFj2ETT9+l2mgeEDNsg6PzsXnqebBm/aGv9uaEoRCwBYyU+2xPKwDaJO0Bz?= =?us-ascii?Q?o0/0xFwIRJZhso+p07zhPfOh9Yrc6hMKBt1sLcEa5ND1kbrP1hFaf3Qg3F7Y?= =?us-ascii?Q?lGG+PqQq6Q1WHW0qOjsyHUBGDDB/scDdPhLwyBu91qXclO0hDFVqTJ/ZPym1?= =?us-ascii?Q?CxFekOkrlImqG64+hhEPaPZqVhIF7dmLELLPA5fbdFVxoTSJEA8Q+9aqBeKF?= =?us-ascii?Q?AR6oJWFF9M/9jlb8Aj7ik6yL+9ddOD+HpyES2p1rWYrHKC758Q81mb7ccw2v?= =?us-ascii?Q?xkcgMc+DuGoWX+cd3JXDnmL63Gr629h1UnM6s9+zPPyY9uIWoi1kvT4uLp7o?= =?us-ascii?Q?2nHLdnciVlz1uLl8WyScSX1XqMe+XdT4UqfJSc6q2/cOLGeb/edRP6mwAox2?= =?us-ascii?Q?rjQNvUOOnNCJ1tw1Yzgyi9KtuNlWMCFGFpgblY7+0iNiHtM0H9/kcvptLzV2?= =?us-ascii?Q?tGkM6XHAhDMNzQqUZCWyNjjyPVmWZ6vzC4oJI0ORW7pZoVso2d2g552hPbE4?= =?us-ascii?Q?fa27TzrWXYhLF9LM6oePn72jt0+zp3JADco42bQBG/GJEJDRB4COssR17m8J?= =?us-ascii?Q?f266a3NiHrtbaQini0JQREoQhHx8WMj6xLv5np2siuY/etPIO1k7QmYnO9bJ?= =?us-ascii?Q?oONhVT/IZbpCYTxmIVdwZAVWUnb/5YMa4b97BMYdTpQWOxZ0EFAfyhlbAMyQ?= =?us-ascii?Q?MzeORiwwS5zJ/ZQIZuy6Kf131PzCxd9TfIQrdMntE7sKZjBlUfLCbWmSwFC7?= =?us-ascii?Q?113uTXj1y8xPEntyaIpyMNgYo2yCzqrfmHUeQzxWwW3YAEcPW75j/Z/P3jAC?= =?us-ascii?Q?CF00DKLR45vRUZ1ip96UKcdA0zmYlzESfaAdDdqO?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46d10265-d1a4-4f72-4dc9-08dbaf7a45cf X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2023 08:13:09.4545 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DF5bzSdqgbktXRWcwLnHPE3sEqCMKZTEW3UmLtFLMDs0ik7Nyj9d9r4FGcR+dwvvwxguOhWkrylhCWWtghVF6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5559 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zE0Vg8i0LLBpNoenDpOPlXWBx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=lPixM98P; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Thanks. 1) I think we need an else branch for " SupportedAttributes->MediaEncryptio= n ", to assign " AvalDiskActions->SecureErase =3D 0;" > - AvalDiskActions->SecureErase =3D 1; >=20 > + if (SupportedAttributes->MediaEncryption) { >=20 > + AvalDiskActions->SecureErase =3D 1; >=20 > + } >=20 > } else { >=20 > AvalDiskActions->PsidRevert =3D 0; >=20 > AvalDiskActions->SecureErase =3D 0; 2) May I know what test you have done? > -----Original Message----- > From: Liu, Linus > Sent: Monday, September 4, 2023 4:38 PM > To: devel@edk2.groups.io > Cc: Liu, Linus ; Zhang, Qi1 ; K= umar, > Rahul R ; Yao, Jiewen > Subject: [PATCH v1] Pyrite support - Secure erase is only available if en= cryption is > supported. >=20 > From: Linus Liu >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3004 >=20 > Cc: Qi Zhang > Cc: Rahul Kumar > Cc: Jiewen Yao > --- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > index e2e77cbc24..88650a28dc 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c > @@ -87,7 +87,9 @@ OpalSupportGetAvailableActions ( > // Secure erase is performed by generating a new encryption key >=20 > // this is only available if encryption is supported >=20 > // >=20 > - AvalDiskActions->SecureErase =3D 1; >=20 > + if (SupportedAttributes->MediaEncryption) { >=20 > + AvalDiskActions->SecureErase =3D 1; >=20 > + } >=20 > } else { >=20 > AvalDiskActions->PsidRevert =3D 0; >=20 > AvalDiskActions->SecureErase =3D 0; >=20 > -- > 2.39.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108365): https://edk2.groups.io/g/devel/message/108365 Mute This Topic: https://groups.io/mt/101144585/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-