* [PATCH] OvmfPkg/OvmfXen: Fix Xen build
@ 2021-12-10 19:05 Jason Andryuk
2021-12-11 15:07 ` Yao, Jiewen
[not found] ` <16BFBBCA8EAD02CD.24693@groups.io>
0 siblings, 2 replies; 3+ messages in thread
From: Jason Andryuk @ 2021-12-10 19:05 UTC (permalink / raw)
To: devel
Cc: Jason Andryuk, Ard Biesheuvel, Jiewen Yao, Jordan Justen,
Gerd Hoffmann, Anthony Perard, Julien Grall
commit 202fb22be6e9 "OvmfPkg/SecMain: validate the memory used for
decompressing Fv" broke building OvmfXen with:
edk2/OvmfPkg/OvmfXen.dsc(...): error 1001: Module type [SEC] is not
supported by library instancer
[edk2/OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLib.inf]
consumed by [edk2/OvmfPkg/Sec/SecMain.inf]
The above commit added a reference to MemEncryptSevLib into SecMain.inf,
but OvmfXen.dsc doesn't have a MemEncryptSevLib entry for SEC. Add one
like OvmfPkgX64.dsc has.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Julien Grall <julien@xen.org>
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
The error messages was long, so I wrapped it.
OvmfPkg/OvmfXen.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
index 383cb03d2a..a465c0cc60 100644
--- a/OvmfPkg/OvmfXen.dsc
+++ b/OvmfPkg/OvmfXen.dsc
@@ -247,6 +247,7 @@
!else
CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf
!endif
+ MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLib.inf
[LibraryClasses.common.PEI_CORE]
HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] OvmfPkg/OvmfXen: Fix Xen build
2021-12-10 19:05 [PATCH] OvmfPkg/OvmfXen: Fix Xen build Jason Andryuk
@ 2021-12-11 15:07 ` Yao, Jiewen
[not found] ` <16BFBBCA8EAD02CD.24693@groups.io>
1 sibling, 0 replies; 3+ messages in thread
From: Yao, Jiewen @ 2021-12-11 15:07 UTC (permalink / raw)
To: Jason Andryuk, devel@edk2.groups.io
Cc: Ard Biesheuvel, Justen, Jordan L, Gerd Hoffmann, Anthony Perard,
Julien Grall
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: Jason Andryuk <jandryuk@gmail.com>
> Sent: Saturday, December 11, 2021 3:06 AM
> To: devel@edk2.groups.io
> Cc: Jason Andryuk <jandryuk@gmail.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen,
> Jordan L <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> Anthony Perard <anthony.perard@citrix.com>; Julien Grall <julien@xen.org>
> Subject: [PATCH] OvmfPkg/OvmfXen: Fix Xen build
>
> commit 202fb22be6e9 "OvmfPkg/SecMain: validate the memory used for
> decompressing Fv" broke building OvmfXen with:
>
> edk2/OvmfPkg/OvmfXen.dsc(...): error 1001: Module type [SEC] is not
> supported by library instancer
> [edk2/OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLib.inf]
> consumed by [edk2/OvmfPkg/Sec/SecMain.inf]
>
> The above commit added a reference to MemEncryptSevLib into SecMain.inf,
> but OvmfXen.dsc doesn't have a MemEncryptSevLib entry for SEC. Add one
> like OvmfPkgX64.dsc has.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> ---
> The error messages was long, so I wrapped it.
>
> OvmfPkg/OvmfXen.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> index 383cb03d2a..a465c0cc60 100644
> --- a/OvmfPkg/OvmfXen.dsc
> +++ b/OvmfPkg/OvmfXen.dsc
> @@ -247,6 +247,7 @@
> !else
>
>
> CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCp
> uExceptionHandlerLib.inf
>
> !endif
>
> +
> MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptS
> evLib.inf
>
>
>
> [LibraryClasses.common.PEI_CORE]
>
> HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
>
> --
> 2.33.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH] OvmfPkg/OvmfXen: Fix Xen build
[not found] ` <16BFBBCA8EAD02CD.24693@groups.io>
@ 2021-12-11 15:41 ` Yao, Jiewen
0 siblings, 0 replies; 3+ messages in thread
From: Yao, Jiewen @ 2021-12-11 15:41 UTC (permalink / raw)
To: devel@edk2.groups.io, Yao, Jiewen, Jason Andryuk
Cc: Ard Biesheuvel, Justen, Jordan L, Gerd Hoffmann, Anthony Perard,
Julien Grall
Merged - https://github.com/tianocore/edk2/pull/2289
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> Sent: Saturday, December 11, 2021 11:08 PM
> To: Jason Andryuk <jandryuk@gmail.com>; devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Anthony
> Perard <anthony.perard@citrix.com>; Julien Grall <julien@xen.org>
> Subject: Re: [edk2-devel] [PATCH] OvmfPkg/OvmfXen: Fix Xen build
>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>
> > -----Original Message-----
> > From: Jason Andryuk <jandryuk@gmail.com>
> > Sent: Saturday, December 11, 2021 3:06 AM
> > To: devel@edk2.groups.io
> > Cc: Jason Andryuk <jandryuk@gmail.com>; Ard Biesheuvel
> > <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen,
> > Jordan L <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> > Anthony Perard <anthony.perard@citrix.com>; Julien Grall <julien@xen.org>
> > Subject: [PATCH] OvmfPkg/OvmfXen: Fix Xen build
> >
> > commit 202fb22be6e9 "OvmfPkg/SecMain: validate the memory used for
> > decompressing Fv" broke building OvmfXen with:
> >
> > edk2/OvmfPkg/OvmfXen.dsc(...): error 1001: Module type [SEC] is not
> > supported by library instancer
> > [edk2/OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLib.inf]
> > consumed by [edk2/OvmfPkg/Sec/SecMain.inf]
> >
> > The above commit added a reference to MemEncryptSevLib into SecMain.inf,
> > but OvmfXen.dsc doesn't have a MemEncryptSevLib entry for SEC. Add one
> > like OvmfPkgX64.dsc has.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Anthony Perard <anthony.perard@citrix.com>
> > Cc: Julien Grall <julien@xen.org>
> > Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> > ---
> > The error messages was long, so I wrapped it.
> >
> > OvmfPkg/OvmfXen.dsc | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> > index 383cb03d2a..a465c0cc60 100644
> > --- a/OvmfPkg/OvmfXen.dsc
> > +++ b/OvmfPkg/OvmfXen.dsc
> > @@ -247,6 +247,7 @@
> > !else
> >
> >
> >
> CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCp
> > uExceptionHandlerLib.inf
> >
> > !endif
> >
> > +
> >
> MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptS
> > evLib.inf
> >
> >
> >
> > [LibraryClasses.common.PEI_CORE]
> >
> > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
> >
> > --
> > 2.33.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-11 15:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-10 19:05 [PATCH] OvmfPkg/OvmfXen: Fix Xen build Jason Andryuk
2021-12-11 15:07 ` Yao, Jiewen
[not found] ` <16BFBBCA8EAD02CD.24693@groups.io>
2021-12-11 15:41 ` [edk2-devel] " Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox