From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 601AD7803CD for ; Fri, 27 Oct 2023 05:49:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=VYzBxKlHibe2X/C4MBWMWKfMiKwWoxOTwFBidDl3scE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698385749; v=1; b=NaG3ajLIRgpBHmCU7L3fmlC09WUnbPBZVP7gRs6dfoaDWLTUtJX3nXT6ZTf2M7812Hl+ihGQ XcKBvClM2Naes5bpa6TPr5Pf0Jyj+0m6SlR0eaNDxynd6r9XkzyFrM1kGPn5rNChLSq33Pic1f7 n4AUvmoT2CYfjkHteTxTwfX4= X-Received: by 127.0.0.2 with SMTP id V2BSYY7687511xtHN4PtS2LP; Thu, 26 Oct 2023 22:49:09 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mx.groups.io with SMTP id smtpd.web10.951.1698385748485507352 for ; Thu, 26 Oct 2023 22:49:08 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="6341022" X-IronPort-AV: E=Sophos;i="6.03,255,1694761200"; d="scan'208";a="6341022" X-Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 22:49:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,255,1694761200"; d="scan'208";a="7544096" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Oct 2023 22:48:56 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 26 Oct 2023 22:49:07 -0700 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 26 Oct 2023 22:49:07 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 26 Oct 2023 22:49:07 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 26 Oct 2023 22:49:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cKJbe1tt9PwggN9FXc2j8fz40kSinFMLk9GzLjxZPYOQMo4QbOOh1T6slxS01f26QZ9YTMLluu33xOs+m+g2P+Gsm1F3wieRi5skq4cAjYP42frKisq+4vwp45g9zVuYDsgy2GE0fy/0BGBoGWrp+z1lNKFAfTk3m8sKwNUFh1FoW4u22A/RS8zt1ZnAGlh4RrqwPY7rIz513DoOgZvjVgPO+WWxK3A0yJnJCFsqivRVXElnwVZuBk/P7K+JpBnH1Z7+PPoZDxYAs1Oshy/VLgWFN6+tsGMC1mGKs0AFb8RAfu/S/+aKIv1xYL1/j1dBkTpWLU7NwR+BvRCeaJ/k6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hVgwqeJgu6mtpTtPX6XeejzAOsaCQ/xKQPB33gIJIK0=; b=SlWz/jyz0TLs/UuC7lZB5O1t414XnY0u3TroEIfifjnomHK8AbVGF63Uwe39jRjX5xAS0xCYkTQsjQsDBIcsMpCnBILZ4Xsu1E0t6l7oCCgZ2DOArAkAxKB0wSQIpVcZS22Mpq+9D6Ei/fbq50w2ohoTzKRiKAyf2gOB4iYxThrr5aBfoWLBdOy3fQ/3UpkeR8tyVeFonwZRL8layMy+7Am4kw4H480OX6gx5aVcKBMyi4Qvk30PugRheO3p6d7idjfgoZ99lAx4YQR6NfIISH98zEfjbzlL4A7TKTB8cK0j2H33Glx7hQtu4ePeMBKA8qnDuLdLQ0s1nqO6U5Mj8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SJ2PR11MB8516.namprd11.prod.outlook.com (2603:10b6:a03:56c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.19; Fri, 27 Oct 2023 05:49:05 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2f2f:41ab:b556:7257]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2f2f:41ab:b556:7257%3]) with mapi id 15.20.6907.032; Fri, 27 Oct 2023 05:49:05 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Tan, Dun" Subject: Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev Thread-Topic: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev Thread-Index: AQHaCJiEbq0hqvyGs0+1Tmniw3oYDbBdIKug Date: Fri, 27 Oct 2023 05:49:05 +0000 Message-ID: References: <20231027054300.1382-1-dun.tan@intel.com> In-Reply-To: <20231027054300.1382-1-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|SJ2PR11MB8516:EE_ x-ms-office365-filtering-correlation-id: 57909fa6-a372-4729-c6ac-08dbd6b06e48 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 4Q4P2rU57fweCEWfhjF4MQ6TX2pBsJm8pzVbEXtolcprBz9i19Qe+byDY/8vJwRtvpwGnAVRh2v/r1XMz7NswzCBOKTSoetIpfgNszEhYsO69yVnM3FWpZ8e3DrH/p6aueK/Ktuv+NYMcpQEGZmzqSBsFLxLfpzLQsvgDU99KPPkhIdmS0w5BRUeizPmlgHdZ9fM+1cgL1VbdZQ5w4TS13ZUq2vHWNcdNdyvthzIxG5fwsI91df01QMEl+EacoEUtE+xnkiqdYrfPZ2hFc976zIqtxMbmrHaW3dyK6sJQQfeqiiyCYsvb3ScSpRK1lsRGVcGJg1gnUGeg7FRFYs7jTrR8Y9TYE71IyD9d40N9/VFeBOm+/5EQxx0U4YO1m1dx/rRs9wSroBUUH4bKfCP8pDZpWbdv76iZrONa6+u2VYI5GSOATt5NYElW7yyo2niJ1aFZMRtqnhQE10ymUwZPRbpRqIG0Mqs/ZDG+tiywYiN9W+gdCxY/GK+km7Uz+gjR8TCoikJMGq9K1lvzilZOP6wClVA6gaZEGTqaRNvy3WmlFY8C7LhL0h98O01aviEX5sS4fvgFkMDoIj7ahzLY7XK5k2wy4Bg3wylP6yJRDkDn5cb6fZQQhM/cYewjk2JXcnvR8LHFNGF7AVNL1RGYw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a5aHjlro5Xl+7zlScxwxVZbD4bNYsbB/3dL/8Jpd8zBI7FOYiLuByzLL1lLw?= =?us-ascii?Q?FyMlRpLsjxXok7XOVJRPOvMN7VnlRMLDRbym2goSbwBZYUBCJv4gpja9eKoa?= =?us-ascii?Q?kKsWcN/9tRt0oBcLDghsaYNBdqW1wCAXdKvQLmSBiqOUaOcyy0EhTvwth36U?= =?us-ascii?Q?OfSVb0W9W3+lNKagArRiY38cWJHSY3KurdgpgJji66rI1KycED5OnwQQMDoX?= =?us-ascii?Q?tMw9H8jtvHru9Sfo7kMjzOpUZfU4YJZlu06wchmRW9th31uKYLUu5Vg4QIJj?= =?us-ascii?Q?a8o09jXSTEBPhCfTSa7bFSoZXxxZvAGPD5LtTpGB3OL4heEpYB99ZRMGlBj6?= =?us-ascii?Q?c+J4mhhYu8nnpyvk3FwvQK7K7EbkDWd2UPA2NzFHrE6RX0riZMd1KpTRNVao?= =?us-ascii?Q?JJnjY4uwxiVcOpOLAnD79Rb2HDHdxVJrDpcqfUEqqJsKXhY8/UYiimGNHd+a?= =?us-ascii?Q?IH/+I9eAhx9hX5rPhBaOEWyKE8RUdLfEU6oY3zlgsuTAER8E9kDnnPN4sRNL?= =?us-ascii?Q?Si9hYSCoypcH/KXefCycP2HHC6l1Jt6+cRlsXfbdVZezfOt+QpS8chXWomhm?= =?us-ascii?Q?2ugDXFXcETa1pJTAPJeqB9buNhIDXuMGFx55vtWAYfOlU8dAq+ZssbpBTSQW?= =?us-ascii?Q?KRoOg8JlWxhp6RhEeWs7i6EEYL1s6JbSPGz3hGT13ToTs06o+SjZ6WO7PgJc?= =?us-ascii?Q?Pa6H/AIcM2+ecIji7yHWwfBPWvz6SMj3ztP6sXETrLxb6AYWuu4Us0yBD0qv?= =?us-ascii?Q?5CdWDdDRX6xz7eJ0hmkA/uU5oxPVifeRcHarrs+ux+5e6BZo5AUbGRioKOl/?= =?us-ascii?Q?Cy8CpbyYicJuOgynAeNGpvhYUO1bVjwFL0vcFQKZ65+upI9SqN6+vLsOHMal?= =?us-ascii?Q?sOmCDQPClHuIy8WJOxN7R6dATTHVSFKlc5gaceg8HVWYzfN6ErabZGmHXrHw?= =?us-ascii?Q?hRlB0wyKsUZhkPrepIjERh5aLhuf4sTk9ufTuSbl/1A4jX29ryPmvXLW+shg?= =?us-ascii?Q?5fZrJWVpQ0EVBg4+hsZ7hwXp0JIfZB8BnHY8whYXqOm8zIh+Zp6slEtl6rGI?= =?us-ascii?Q?lTwb61JhHKNUtQXK/QJi08Tx5be71+1nNnnvoW+AR5sychIAE1/Y5QcuwOBg?= =?us-ascii?Q?SHX+P6JSqUjbCW19z5Q0E1FzIWOBkPkJ2oRYNQDOPqNQMOzCLhi0BdAv3/ng?= =?us-ascii?Q?PzNbCLISy34IFZa5BVEPG2DNr4AMzg+gtJVUcif12sh+Yu9Cu1bpPyMwMM2E?= =?us-ascii?Q?a6uyCrrFU4CQGk9caTY/IIpFhIDvnj9otLcX/kp/2pJ10sc1eur0pH8Ee0Ju?= =?us-ascii?Q?d1acbSmGZ3UnfNWxQfUkx8bTaqaqY341iXvZRnWEDK+TkAqHzj321027+dKa?= =?us-ascii?Q?1nI/uTuM0GmAzkyAvOtjCwhPgtwAirOK2hnMGAw4KG+roTRU90iUi1DG3xOh?= =?us-ascii?Q?+PcWKfjpQAHFIQLoZQdX/fwHsoNG4q4WSerNzaqk1+XgvZqSRvOBcrv9r2c5?= =?us-ascii?Q?MhNLJjzCt2sLdi7FyZIn8RYksdiqCzOnRpa9AW7Xg4j9TkHw9t5Z5Uhnl9Ds?= =?us-ascii?Q?Trq6zmZa5kdBf3DPCN+vbd3eE7FwSm+alnaf8tZv?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57909fa6-a372-4729-c6ac-08dbd6b06e48 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2023 05:49:05.5652 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s7XQbGvx7M00mCbdjcQ1qE+eEuURVJz9uxMn2+DkkbKhwHZz0UblnP0ngzW9WaxfSUbCZrwJqLQ/L1xaZkMHew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8516 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NxIPfNcRPTa0XPcltnWjo7wex7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=NaG3ajLI; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io HI Since this impact TDX and SEV, would you please let me know what kind of te= st you have done? Have you validated TDX and SEV before you submit the patch? Please describe= that clearly in your patch description. Also please include AMD SEV reviewer in this patch series. Thank you Yao, Jiewen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Friday, October 27, 2023 1:43 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrins= ic and > remove BaseIoLibIntrinsicSev >=20 > The goal is to have single BaseIoLibIntrinsic instance that can also used= for sev > and Tdx. > In this patch set, string I/O instructions are deleted in IoRead/WriteFif= o API. > Then change the source file of BaseIoLibIntrinsic to also support Tdx and= sev > feature. So BaseIoLibIntrinsicSev and related assembly code can be remove= d. >=20 > Dun Tan (7): > MdePkg: Create TdxLibNull.inf instance > MdePkg: Add CcProbeLibNull and TdxLibNull implement > MdePkg: simplify IoRead/WriteFifo in IoLibFifo.c > MdePkg:support Tdx and sev in BaseIoLibIntrinsic > OvmfPkg: Add CcProbeLib in PlatformInitLib.inf > OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files > MdePkg:remove BaseIoLibIntrinsicSev related code >=20 > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 14 ++++++= ++++---- > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf | 61 ------= ------------ > ------------------------------------------- > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm | 131 ------= -------------- > -------------------------------------------------------------------------= ------------------------- > ------------- > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm | 293 ------= ------------ > -------------------------------------------------------------------------= ------------------------- > -------------------------------------------------------------------------= ------------------------- > -------------------------------------------------------------------------= ------ > MdePkg/Library/BaseIoLibIntrinsic/IoLibFifo.c | 45 > +++++++++++++++++++++++++++++++++++++-------- > MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h | 166 ------= ------------------ > -------------------------------------------------------------------------= ------------------------- > -------------------------------------------- > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm | 120 ------= -------------- > -------------------------------------------------------------------------= ------------------------- > -- > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm | 282 ------= ------------ > -------------------------------------------------------------------------= ------------------------- > -------------------------------------------------------------------------= ------------------------- > -------------------------------------------------------------------- > MdePkg/Library/TdxLib/TdxLibNull.inf | 21 > +++++++++++++++++++++ > MdePkg/MdeLibs.dsc.inc | 4 +++- > MdePkg/MdePkg.dsc | 2 +- > OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- > OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf | 3 ++- > OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- > OvmfPkg/OvmfPkgIa32.dsc | 2 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > OvmfPkg/OvmfXen.dsc | 2 +- > 21 files changed, 83 insertions(+), 1077 deletions(-) > delete mode 100644 > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm > create mode 100644 MdePkg/Library/TdxLib/TdxLibNull.inf >=20 > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110190): https://edk2.groups.io/g/devel/message/110190 Mute This Topic: https://groups.io/mt/102215661/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-