Re: [PATCH V3 7/9] MdePkg: Define CC Measure EventLog ACPI Table

["Yao, Jiewen" <jiewen.yao@intel.com>]

+typedef struct {
+  EFI_ACPI_DESCRIPTION_HEADER    Header;
+  EFI_CC_TYPE                    CcType;
+  UINT32                         Rsvd; <== HERE!
+  UINT64                         Laml;
+  UINT64                         Lasa;
+} EFI_CC_EVENTLOG_ACPI_TABLE;

Would you please double check the spec? The Rsvd should be 2 bytes.

Thank you
Yao Jiewen

> -----Original Message-----
> From: Xu, Min M <min.m.xu@intel.com>
> Sent: Monday, April 18, 2022 8:00 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M <min.m.xu@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu,
> Zhiguang <zhiguang.liu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Lu, Ken <ken.lu@intel.com>; Sami
> Mujawar <sami.mujawar@arm.com>; Gerd Hoffmann <kraxel@redhat.com>
> Subject: [PATCH V3 7/9] MdePkg: Define CC Measure EventLog ACPI Table
> 
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853
> 
> TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass the
> event-log information. The event log created by the TD owner contains
> the hashes to reconstruct the MRTD and RTMR registers.
> 
> Please refer to Sec 4.3.3 in blow link:
> https://www.intel.com/content/dam/develop/external/us/en/documents/
> intel-tdx-guest-hypervisor-communication-interface-1.0-344426-002.pdf
> 
> Please be noted, the definition of EFI_CC_EVENTLOG_ACPI_TABLE is a
> little different from the above document. This difference is based on
> below discussion:
> - https://edk2.groups.io/g/devel/message/87396
> - https://edk2.groups.io/g/devel/message/87402
> 
> This change will be reflected in the next version of the above document.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ken Lu <ken.lu@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
> ---
>  MdePkg/Include/Protocol/CcMeasurement.h | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/MdePkg/Include/Protocol/CcMeasurement.h
> b/MdePkg/Include/Protocol/CcMeasurement.h
> index 68029e977fac..58123ca72163 100644
> --- a/MdePkg/Include/Protocol/CcMeasurement.h
> +++ b/MdePkg/Include/Protocol/CcMeasurement.h
> @@ -299,4 +299,25 @@ typedef struct {
> 
>  extern EFI_GUID  gEfiCcFinalEventsTableGuid;
> 
> +//
> +// Define the CC Measure EventLog ACPI Table
> +//
> +#pragma pack(1)
> +
> +typedef struct {
> +  EFI_ACPI_DESCRIPTION_HEADER    Header;
> +  EFI_CC_TYPE                    CcType;
> +  UINT32                         Rsvd;
> +  UINT64                         Laml;
> +  UINT64                         Lasa;
> +} EFI_CC_EVENTLOG_ACPI_TABLE;
> +
> +#pragma pack()
> +
> +//
> +// Define the signature and revision of CC Measurement EventLog ACPI Table
> +//
> +#define EFI_CC_EVENTLOG_ACPI_TABLE_SIGNATURE  SIGNATURE_32('C', 'C',
> 'E', 'L')
> +#define EFI_CC_EVENTLOG_ACPI_TABLE_REVISION   1
> +
>  #endif
> --
> 2.29.2.windows.2