From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web09.34528.1650245039334135086 for ; Sun, 17 Apr 2022 18:23:59 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=cqXzGeDb; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650245039; x=1681781039; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fDpF1IEujJ6sU3YAOZc7dSVmKalwZdCg4BQ5GNsMTdY=; b=cqXzGeDb5/5WzUGIOznxYe+uAKUd5Pu7XQt8AiMGZgeHjhiOa2qljadd ydiOdLLa+5gSYU0gpDGwU1gZaIxqysmsbfpjrdwQvqa1PvYTffL4YBJBL mc0qifttJHlgSVtuvMAjHnNguvHuF3uDs7vCEMyaxE8y4EAuECJpdrN1W SKxxHzoS/+N0czFNEuFRmTI9EmLP5lSmpLPgsLouZZ/OsA8C2P5aACoxX NjchULzyDIlQlqmI4JXL52ZLqUDQVzX9PGLhPXpJyyDUHhf7+hTAguTWS KBL4EkpXhAomlRm02SNMJarNHPam/XX7MfzjaXOGoU67DJ6JMwiEZ/RrO w==; X-IronPort-AV: E=McAfee;i="6400,9594,10320"; a="245318298" X-IronPort-AV: E=Sophos;i="5.90,267,1643702400"; d="scan'208";a="245318298" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2022 18:23:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,267,1643702400"; d="scan'208";a="804129008" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 17 Apr 2022 18:23:57 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 17 Apr 2022 18:23:57 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 17 Apr 2022 18:23:56 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 17 Apr 2022 18:23:56 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 17 Apr 2022 18:23:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y2wgjzLA8lgBgKqoSR95VDPXrfK6LDgplh/xTxtNigiwKK+SbKi9+v4Ibj4gKP0OMx7aKNTQZmR3YYu7bF5FGdhe9Mk6NUZvPc8KLyR8kpbKMefGW2wMj4nJZFMlezl2pW3SLz9c0oXL9T7rgfIQv1zFD9zmZx1gcgL3FWWIBQPpURCRLEk43dP0G3UpzK92vuGTUbqzbiIOPZjl2QWpkHgpJmd1YZIxG26mqhfY2lCGqxCaYkPskGJEF/mIpixbwriz6TTv+C0Lo/pa1Pabsucgab2pI07+gy0ArkKfHY9k1PGsomkEaInw785SU7sQNpRjui3nXSdmIiuVAR1VPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lf0ThxoQiUzSf+NRuSaRdXZTmQX2dQnM+3DKsoD8Lho=; b=d6JQ8H3/wegtoXi+Ivq5TFL1YIT5kksE7d5t4hk2qNFkT7+SuabFBiTauLTzQFJrDSuZEAZeReXIUEi+eVBCM2Wx3iaV18bbzSEfwVM5oLDfo7deq++lI1p0iw7bgoY6fD/RodFS0AJvyr8uZJtBEcKA9lVbfT50/QHCATSTsLLSZsQ8ubrWq9THRxVdyB4SnbZT40IT7XIyyc1xdOT8LPq0fMsFrCIuoDZBj0hyMoMO8f6PxRAdth36SLubAMIE8MWXFkUxRB30IWZlt6XbEMzRmCW4pE1KGkfj7yB2j6uReFpUtOID/OfhfOpeBK9ICLVEyZLeFMq2JS8G0QmI4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BL0PR11MB3523.namprd11.prod.outlook.com (2603:10b6:208:33::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr 2022 01:23:53 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::198e:ea23:c83b:b93a]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::198e:ea23:c83b:b93a%4]) with mapi id 15.20.5164.025; Mon, 18 Apr 2022 01:23:53 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , "Wang, Jian J" , "Lu, Ken" , Sami Mujawar , Gerd Hoffmann Subject: Re: [PATCH V3 7/9] MdePkg: Define CC Measure EventLog ACPI Table Thread-Topic: [PATCH V3 7/9] MdePkg: Define CC Measure EventLog ACPI Table Thread-Index: AQHYUrdrbiVvijIf9E+mQ+einRZyy6z04DtA Date: Mon, 18 Apr 2022 01:23:53 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f3e1eb98-4ba9-4f1b-3bf8-08da20da19ba x-ms-traffictypediagnostic: BL0PR11MB3523:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: woKzBtUgsjydNVwd/D8hhSwmuFB1PKzYys1cDG4bIDE75YtknzAJXEX+pi60QhR6XaJyGf3GFgyNdWSFdV4Xr7dRCxnR7NdPvCQedzkvy6kU8PYcBXJWdLEVUZ3RDEdB3BIWBk6n7MKY8V0PvhleS2oI0/fShStJPAMuj79P3sCxSadwWrBJLlFDcagblwdgBTTUxE7KO51otv5KDbZkMJbeQGk5QS7UE2Bo9RkMgWRIL9tSQqg79n8KUi0AV1nGgKcMdRBN5oRjlHa91uzXHN+E8WnnIrEFWocO2Nz0zioYwZZFWOPT6eOcuiqqczL77bSGHI/rf54CQFOrMQSeN149rZ6s5QopKDHeSV1X1duQsOa0bwQyVAhLKJTNIhMkFL0Xksy9pFv8oQUinj6xoqP68nGjePRdu6ZmUZC7zPpFHGTcydb+6tf839loNGbDVJmgFH47p86mH698dVQmq0V9uuQzfikRdhGZ9yOhtrwEzfMeilMSXfVBJp2fXj1jgPhT2DnDWV8Znm4ISRrom4DYijjR90jpyYsPYcbrDDe0Acq0g/75RTnO2HRisJxjfDms67BIzRCS/rwOvxecJwmGl2Ln+3/Jum/lDZpAk8xI6ZyxTKJurtanyTXZDQmtTfXhFr0151fFOI55cW6ACGBa/v/6bDt3wVUn3z/E4y37jZiJpswQyar2j9vfUdx6vB7cB6d9M+OWREwfwK4YEB6bUKtnuR2G0XM2uCVO3P8GyFdChfngnpWeeEA5SJdGzBrpjonmPbmc6sUvsOc4WwHKFQgfEPFWGs4OaM8YfLxs+RWpSVmfkp8Ymt8hf1Y7fKmCs5F10oSp55bf3BfRzQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(53546011)(6506007)(2906002)(26005)(83380400001)(66476007)(7696005)(55016003)(9686003)(33656002)(66446008)(8936002)(66946007)(76116006)(4326008)(5660300002)(508600001)(64756008)(8676002)(66556008)(52536014)(122000001)(71200400001)(966005)(82960400001)(38070700005)(38100700002)(86362001)(54906003)(316002)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rqkqSezqJE3pd2Hz0EskhStsYdSn2fH4/11zHultCOmSbjdyZRT2/yOF9VWK?= =?us-ascii?Q?AsVK8wLw8OJIYgVUeH1HJ3p50ek+W3lhLVPVZzGuiqSdnWDnb0A7du6JFbQJ?= =?us-ascii?Q?HvUf6ordBVkiLS/Iz7RVsduJUtKv5rhfr9kidevgxsaHaRGfBhENknBBLoKX?= =?us-ascii?Q?f+bocyAbmIvSMPVqrq7/wJNo/G/Vc5is48TeOP6Bq0Cn1aibYw0dwt7AXj2E?= =?us-ascii?Q?Ne10LHs9yYuBB2fNLPAjWJufDMwmur8U9Jqh8uGK9Hrfv4Ih3Dyqf2YmOUx4?= =?us-ascii?Q?itA6bl9G3kF/z+hScF/ppUgGv9T9YYrtdRrxJNLu+aFe+m2StwtchiIc0dSD?= =?us-ascii?Q?qnHezLrRuta/jHmF+EHvtS+1bPFeDxuqCxD95WDXuLIJASi0gzVwLhqy2iV5?= =?us-ascii?Q?ysUvUmmS700DpIOVHra2bHvpobJCvF6XYAzlRH8VmQ0fOu0G8x+qzE1qI10k?= =?us-ascii?Q?NrLeM3cJVXEUfCZkZO9H431DAt7cUDWJjBFslPOn85hMkvbxlrZXJWPFBQdd?= =?us-ascii?Q?FWfitbdHpeivP7p2D2/LffBqVPMrxa/Wfa51+C5nRiyhBCXdeCTbiD1UG3ME?= =?us-ascii?Q?Ist7WcR8e/iUajoj2kY/ev+mQ7IJXrqlY7C0jhrHKutyPoI8dVTj7FFRiK9G?= =?us-ascii?Q?W5+T+EXYKFttU+zAdh6BV6eW2KwusjQ6H42snmgBNQglpqpwnfJGf2SSXZ8n?= =?us-ascii?Q?k5Yz/idlPvKSL2A79ZijqWTTALpktIFqgHlHzZMHb3V+u4a7NNo7rTbIG4DJ?= =?us-ascii?Q?WB/tqAXO8fKF75hWWOAxXMo8K4v2BkDF7eHG/Af9GRgA6/j2ABNSlRmONAm7?= =?us-ascii?Q?2xtyr5GR3ybIEl7bBRrRaYam6UDux/PvCeUMjImo9DhDpnidCRMHPtr/rFPS?= =?us-ascii?Q?UGFBKFGNdc8CX1FQWGRm5jaXBn0T59pi4EdJH/JpAM4EGuFDVl//3DT8CYff?= =?us-ascii?Q?KDXI02Q6mvqmle65CPFZ9bbE/yPZoMg+D37SGKnMaoXMwIcOAflwxdXXdW1Y?= =?us-ascii?Q?tERA23NKrDq/S71G8J1qpBI/h7W/K1Sy7pN2vp6hbIaA9oqhXHggkhn6Ta6y?= =?us-ascii?Q?v01mjiwicFSOlwmQRBKwIntOHh0ELmNscWheApRpsMpL0auzJCp6lxzqPakY?= =?us-ascii?Q?pYxQmKLZTuwl9F1v0MOJepb5WRkxGEcuWm3QHqlzar2+nohtXVAg22JYDXJs?= =?us-ascii?Q?jrgQt+pD/sraxHNygPHEvx9eCFWRRXJXxba6e9ccvUND6gzhIlFSbdEYGnRw?= =?us-ascii?Q?MxCMGKvJsK5s0RTKgF2TlNn7pFoO8e6j0regOnqtlLntYHu79l2xlVga1OFx?= =?us-ascii?Q?B29C2VwSaYsVgJGDTHOyrjcg46MgnVPYJBBmmROXB1+DiC8w3fG7o224Bw0r?= =?us-ascii?Q?EXz3ohfEJykdB3e994K6MQUrB2IkqzjknhBaASP78C2bz10BKnD+GVCs18uz?= =?us-ascii?Q?Pnb6O6PUMZ87/0GmM04PzkxYsDyRpdLNtNoHsQoA+RwwJh7pUXG+DrJs+5FG?= =?us-ascii?Q?AZE7GUBdnCBBO0frZxjPUpgM125F4K2Qgu28B9QZHBlE5La9CCihmizgla7U?= =?us-ascii?Q?XvBmtMHp3F/SHg+JGwQwBiaDrbSxNk4W4DiCGCJ0huuWytOi3AJK/2eHcmug?= =?us-ascii?Q?hQItE4hcwkqTMJHBOYYK7XRtXK9PhHI9f+0dS1v79DeeFFD96Y3NtxmDgetB?= =?us-ascii?Q?3WVZjVEA2PwDPlwN8sO8ohkGUwnhQOnhTVphNhMXKu5zFPPNEbgupIDJWR3r?= =?us-ascii?Q?EaC+rF1r3w=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3e1eb98-4ba9-4f1b-3bf8-08da20da19ba X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2022 01:23:53.1379 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GRWIOCK3O9cCaJgXcTuFPk0FGGg+W4nFUprykUwdp2or1hcLAN9F3nE+sWUCfOR2ri+e42MZZq0E4ZumDkSC+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3523 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable +typedef struct { + EFI_ACPI_DESCRIPTION_HEADER Header; + EFI_CC_TYPE CcType; + UINT32 Rsvd; <=3D=3D HERE! + UINT64 Laml; + UINT64 Lasa; +} EFI_CC_EVENTLOG_ACPI_TABLE; Would you please double check the spec? The Rsvd should be 2 bytes. Thank you Yao Jiewen > -----Original Message----- > From: Xu, Min M > Sent: Monday, April 18, 2022 8:00 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Kinney, Michael D > ; Gao, Liming ; Liu= , > Zhiguang ; Yao, Jiewen ; > Wang, Jian J ; Lu, Ken ; Sami > Mujawar ; Gerd Hoffmann > Subject: [PATCH V3 7/9] MdePkg: Define CC Measure EventLog ACPI Table >=20 > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3853 >=20 > TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass the > event-log information. The event log created by the TD owner contains > the hashes to reconstruct the MRTD and RTMR registers. >=20 > Please refer to Sec 4.3.3 in blow link: > https://www.intel.com/content/dam/develop/external/us/en/documents/ > intel-tdx-guest-hypervisor-communication-interface-1.0-344426-002.pdf >=20 > Please be noted, the definition of EFI_CC_EVENTLOG_ACPI_TABLE is a > little different from the above document. This difference is based on > below discussion: > - https://edk2.groups.io/g/devel/message/87396 > - https://edk2.groups.io/g/devel/message/87402 >=20 > This change will be reflected in the next version of the above document. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Ken Lu > Cc: Sami Mujawar > Cc: Gerd Hoffmann > Reviewed-by: Liming Gao > Reviewed-by: Jiewen Yao > Signed-off-by: Min Xu > --- > MdePkg/Include/Protocol/CcMeasurement.h | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) >=20 > diff --git a/MdePkg/Include/Protocol/CcMeasurement.h > b/MdePkg/Include/Protocol/CcMeasurement.h > index 68029e977fac..58123ca72163 100644 > --- a/MdePkg/Include/Protocol/CcMeasurement.h > +++ b/MdePkg/Include/Protocol/CcMeasurement.h > @@ -299,4 +299,25 @@ typedef struct { >=20 > extern EFI_GUID gEfiCcFinalEventsTableGuid; >=20 > +// > +// Define the CC Measure EventLog ACPI Table > +// > +#pragma pack(1) > + > +typedef struct { > + EFI_ACPI_DESCRIPTION_HEADER Header; > + EFI_CC_TYPE CcType; > + UINT32 Rsvd; > + UINT64 Laml; > + UINT64 Lasa; > +} EFI_CC_EVENTLOG_ACPI_TABLE; > + > +#pragma pack() > + > +// > +// Define the signature and revision of CC Measurement EventLog ACPI Tab= le > +// > +#define EFI_CC_EVENTLOG_ACPI_TABLE_SIGNATURE SIGNATURE_32('C', 'C', > 'E', 'L') > +#define EFI_CC_EVENTLOG_ACPI_TABLE_REVISION 1 > + > #endif > -- > 2.29.2.windows.2