From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.48]) by mx.groups.io with SMTP id smtpd.web11.172241.1672189021896468679 for ; Tue, 27 Dec 2022 16:57:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=a9ax3IDp; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.101.48, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eC6pz3zHthf0mq1y30QkKHFzSfRId9FkEaISiJISjcISVyVJKaofd7kqlSMNSDzL7llPN1WtNBAPcfQB5Jnz/+xAKxewG5yWJBF5dTJ/oaJlKB/tUH+LhJ/9ENu9LBSM4nUnX+7uLl2iBx4uZ7kQYTUfboP8JM34iDoSk6h4nAiUshinKy6z0+0iZwI3yCyzV1CfHCaL+Hwtr7xU7rIBnUaXCexchpfiVrbz/fkrKEviCHufKx/EmK+KUdX0sJd3lv23yA2IVw4/XswqrhTfJVvRIxGUXCfxj9B5HDh//mXDMZxu/JByZkoekUcwbylfFpqBC6ZSol0nqItvTccoVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JRGOC2/DfaIT34Fa+blu8IJu9M2IU4A5IRFA4+lXsAU=; b=MhFB71WjY3bgky/egUSLlP3WpBTmAhoqTO54KLxkGa/4MJK+WRFKaGEphf+SBvC7rrmDzvCFkERQtve+TN3/03VBGzJ5qDkq7rGltnawkQrelJY5J2ykJALUjWs+zkcaNHN/iu0n5fnpQTXQ8im8uUbewuRQASTlYxWRLVUS9LXQIIdMNidx89S6eWyaIl41eNjrVTr9p3L8blZR7Ff3uxV3+MT+84R6T/dAWlEqz2Mf7rTLRZgMzQIQCqixMzRud7zGeOpXjfmbHUzj1OSGZmuDaI+izBRaOihb6OpaVC1rl0tOMOJLHDbhHuImIbFqS/H8jVh5UrO17G8hgw+tyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JRGOC2/DfaIT34Fa+blu8IJu9M2IU4A5IRFA4+lXsAU=; b=a9ax3IDpcvLhZBGI2pI6xrnxhZr7ENMjGnpDycnoQtWCVgQHGUwwMmnNmk3olBt/cgeR0TxKOt1B5vyZMNMhm9aWDn+m3/zTLimEbImPewQlVnJDCaZ1rxr+QWeG6daxVY+D4xWn9ST1eADmTJXT0sNPviy5h13CtacQ1G1oDR3XSZtFH3is4P1Cvkn9lWWiQo8KIq44wAp+ko9LfZXZq/gT9ifT6jr3NZGPg43bb33LwBstquJs5DPqDHYHrTtHPEVpHXfxG0jJuzZ91+JexMQnVOmhi13z/sfmKqOM1x+5PVwdnJP4tZOQ1eyemfqojOOflqI0cnMOJ6k7KwKkxQ== Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by CH2PR12MB4905.namprd12.prod.outlook.com (2603:10b6:610:64::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Wed, 28 Dec 2022 00:56:58 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::6b34:f6ce:b778:4075]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::6b34:f6ce:b778:4075%7]) with mapi id 15.20.5944.016; Wed, 28 Dec 2022 00:56:58 +0000 From: "Nickle Wang" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [PATCH 3/3] RedfishPkg/Include: Redfish USB Interface V2 update Thread-Topic: [PATCH 3/3] RedfishPkg/Include: Redfish USB Interface V2 update Thread-Index: AQHZFsrfPrlNpqhtOUypyM2stlt/Ba6CgDug Date: Wed, 28 Dec 2022 00:56:58 +0000 Message-ID: References: <20221223123336.2014-1-abner.chang@amd.com> <20221223123336.2014-4-abner.chang@amd.com> In-Reply-To: <20221223123336.2014-4-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|CH2PR12MB4905:EE_ x-ms-office365-filtering-correlation-id: aeb55148-3834-490f-961d-08dae86e6c3b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hWXt8GKSfbXtJImJV+T31mrm73cwLgUNiZSAmTSKqVSDEN4c57fu1SyYJY54DB5PeX41yclns8BvE+ji1T6PsWH3pki7DKV5FjAWTemlLobJ+6b1XmmKo6HpPI9bg+GUEP6FxcjDk4UA0vnLhnhkP7xt8Yi3BG+yg6QdVGUW+oN5FHnvHZLXPsQQXM8a8sSlkgGfCfjPQESO0K9i6sbEzzoQvOO5Ks6kOiZtjTWhcHd9Prhwh8gplNymNQ8z7N7/xMNLi6NZB+7Uin5rwsPRMkr70vn8iqddzIKT9X4jwiqgqr4VBCas0Ww4qaZq1oHO8qUkXRqjdX+HMOsTn7A4Dpsq+2ucHTqn5BeKnAxAyGLBpVy+Vb+9QedFsUwTQdILVlh9vbjd2UGJZnszTXLKWoO+zJuu8Q062I+xtLaT5S5txWG8btRlIakliZoKNqOxDqCJUd5Hx90MFXSxIIAfpFO4nTOfAUjloLSzTfOksEckk8vlJvt51rm+i1hpzYLNYpt4Z+KlzbON4IYyQ+643PkYu+AOtnQL1dmCzcyNUmGCYupdxUtvi2HQyI6e68UKUH43U1jVfnRYThOUCGLfLlfCeLaJeT/Ph7IsLGPyyZC6G//5Os74kfzCR70SPzcMu/5wjhXXHlbLifDUdeR/U23WyTJ5TjyEhxRRElDK0vMcO1ab7jFycMMhTYY75tsW4ZYIBAkbVfLIfqdR9tGwpSnWiv8BrPM+R5++vLmimO8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR12MB7031.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(451199015)(38070700005)(41300700001)(478600001)(9686003)(6506007)(53546011)(966005)(55016003)(186003)(26005)(33656002)(110136005)(316002)(86362001)(71200400001)(2906002)(8936002)(52536014)(7696005)(15650500001)(83380400001)(5660300002)(4326008)(8676002)(76116006)(64756008)(66476007)(66556008)(66446008)(66946007)(38100700002)(122000001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4Z4MDJ4RgWoI7KN5nOYETXENGnC7IyimBZG45Pr1m03cIdVORFFw79a+7iYZ?= =?us-ascii?Q?mBBeMZuw7iW0IOXQTAW/pQvwv/mHQSnK5r03i9A4v2uHO1MPLBSjH0RviQZf?= =?us-ascii?Q?Ur0Xf4xOv+jKK+ngWmsHVEsUHGYAgxdwahydNtnGjxD/fX7hSfWaSQgPi+q3?= =?us-ascii?Q?+GvqXhptGW6DQkumyxvKjRC4JePrJzNLfcw0zlM5MAk6+JldUyf8vrOnpUrQ?= =?us-ascii?Q?dxpUr5upvOCFeXzIiEsIggvaOGGJHi0NLx6diAXphO2PMPR8saCRCat8zin1?= =?us-ascii?Q?zzP1OScBJX/K/dAhiQymwCuRECb+vdA8QHyKfknqXaycldnn3YvFBoPmFPUg?= =?us-ascii?Q?pNQHvn+1COq8fCO4LfWKIMZMFHz3eyyZKf0rUtmq+CI0f3aNWrShd5pVhqMZ?= =?us-ascii?Q?JeMSMrM2cy5PZHWdAg4JB1SBk3ds3yCjprhtN6wPsFKZf/8HtUes/01mLRa5?= =?us-ascii?Q?heVixkU3xiA3RUtKm0NHticgvj7D5Y/EMXxgiCgFuzi8Tkg1KEQ0pQm7D/qM?= =?us-ascii?Q?TGpYi/Hxc9qMwJIqVNqQ8T34Qm8/I8mWYa3PXNfbjT0jnM1/3ByOyiaXzTMB?= =?us-ascii?Q?ER3Z58Vmp82jo7vl4sE2LFUJQqMjB43qi5cjYNXkD2LHtSpByNpD7h2momm8?= =?us-ascii?Q?XuxwYfgnnVcfOlhZxs7bwPSwf62F1eO5hdo15YPqFTJQlApYXkJ4woXmh0kS?= =?us-ascii?Q?HkVsjF55NWaPlqVI/GaFeYA0XjliqS1TwLl1/eX1j9ZyPnY3prS1tmwo2F70?= =?us-ascii?Q?C9aNLKhwx5zYIwvMeUwQ7q4tmfPvw6jM3bw+MLNvmVe9/sAa7wdGObMs3f4f?= =?us-ascii?Q?fV6jsQiOIk/+Urkqm8PW2zUT+t++gAIZt8bfcN4yLGAMWXptywnR2pwYHAr8?= =?us-ascii?Q?X3D6aJvKYkcVdH24zOOpLYXnGpM/EppbWU+cJeja0sWph5Xa2v+Hax6OZR3z?= =?us-ascii?Q?kTJ/ozxmRmlQV1yvyVU/9+7GwV9Mj4bSfMk4GGKaYxgzEWaHHxvyoqAWDd5F?= =?us-ascii?Q?eWb0GaB0kraKhqfyGeNbdXsO5rxU4UXWhOc2BzsG9j4+3sG67F5e/1UXRN3d?= =?us-ascii?Q?JWo573msyz3qgGRKNBTK1s6wrGYxmSu2+oFDyB4VvjnwWW+a4zVLPJBzl1Hi?= =?us-ascii?Q?jM27eODpONT6/Xqw5eNYcChXfuE4Ij8XhOOa7g2zP8cNpZSLD1Dhs0e+dpF4?= =?us-ascii?Q?/Xfm8EmalmGfaXiLIgX351eOSsXGU7ScOVtcomBtn+N0QDc/oC66fSS8io2v?= =?us-ascii?Q?0BdHI+gV5Yq/pq/oOep6wj+dvt2EVVXUaFyJyptLlSvT6ZO0sZej96Gl8ifw?= =?us-ascii?Q?CYZ3jhimRVtHWT37y9vcfpWcGX/MlW0CHlKOlyn8I84i9dUw/O4QQbHMsZAj?= =?us-ascii?Q?d/AWqu8k4QKIjM0LnxukDa1xREeIUfNsaqD+2ci5kKrOzJi/re2RfAmIScov?= =?us-ascii?Q?BHeN8CsKv99vK2m8dwCW2Ae477rp8pVCSkFDJ64d16TsrO1VhxdVpzeU0uFz?= =?us-ascii?Q?96oWj+N9dWsv20v9yimfpfntLnyvnyqRM4L+EafRcIzCzx80mFzzKJ6JrVZU?= =?us-ascii?Q?F7fubayuGmuDJPMFB+8=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aeb55148-3834-490f-961d-08dae86e6c3b X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2022 00:56:58.5925 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8o9wTV7F5xW633jlqGZSUZeiGFxzHp8KQ9d7JjF8SIXj1xDypIXMlEQepRiXfTMNBYfFtZHHgXKZbVXzy2tNaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4905 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Abner, Could you please also fix the typo in USB_INTERFACE_DEVICE_DESCRIPTOR_V2 st= ructure together?=20 There is typo at line 43: https://github.com/tianocore/edk2/blob/a086f4a63b= c0295b0b02f8ee76381c6b437122bf/RedfishPkg/Include/IndustryStandard/RedfishH= ostInterface.h#L43 UINT8 SecialNumberStr; It should be SerialNumberStr. Thanks, Nickle -----Original Message----- From: abner.chang@amd.com =20 Sent: Friday, December 23, 2022 8:34 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH 3/3] RedfishPkg/Include: Redfish USB Interface V2 update External email: Use caution opening links or attachments From: Abner Chang Support USB_INTERFACE_DEVICE_DESCRIPTOR_V2 which is updated in Redfish Host= Interface spec v1.3. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../IndustryStandard/RedfishHostInterface.h | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h b/R= edfishPkg/Include/IndustryStandard/RedfishHostInterface.h index 49b3ceee39c..5337c3234b2 100644 --- a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h +++ b/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h @@ -3,6 +3,7 @@ Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (C) 2022 Advanced Micro Devices, Inc. All rights=20 + reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -29,6 +30,18 @@ #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP4 0x01 #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP6 0x02 +/// +/// Definitions for IP assignment tyeps. +/// +typedef enum { + RedfishHostIpAssignmentUnknown, + RedfishHostIpAssignmentStatic, + RedfishHostIpAssignmentDhcp, + RedfishHostIpAssignmentAutoConfigure, + RedfishHostIpAssignmentHostSelected, + RedfishHostIpAssignmentReserved +} REDFISH_HOST_IP_ASSIGNMENT; + #pragma pack(1) /// /// Structure definitions of Host Interface device type 04h (USB Network I= nterface V2) @@ -46,6 +59,12 @@ typedef struct { ///< descriptor, and is convert= ed from Unicode to ASCII ///< and is NULL terminated. UINT8 MacAddress[6]; ///< The MAC address of the PCI= /PCIe network device. + + /// + /// Below is defined in Redfish Host Interface spec v1.3 /// + UINT16 Characteristics; ///< Additional device characte= ristics. + UINT16 CredentialBootstrappingHandle; ///< Credential bootstrapping h= andle. } USB_INTERFACE_DEVICE_DESCRIPTOR_V2; // @@ -74,6 +93,10 @@ typedef struct { /// /// Define union for the Host Interface Device Descriptor /// +#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_3 0x11 ///< Leng= th USB interface device v2 defined in + ///< Redf= ish host interface spec v1.3 +#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_2 0x0d ///< Leng= th USB interface device v2 defined in + ///<=20 +Redfish host interface spec v1.2 typedef union { USB_INTERFACE_DEVICE_DESCRIPTOR_V2 UsbDeviceV2; ///< Devi= ce type USB V2 device discriptor. PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2 PciPcieDeviceV2; ///< Devi= ce type PCI/PCIe V2 device discriptor. -- 2.37.1.windows.1