From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 53E97D811CA for ; Tue, 26 Mar 2024 13:39:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hyZiPYJ8h9lrlV+TiQECaP0pwd/AXrRRyDR6wl+UnwU=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711460393; v=1; b=cCfjZkyN9jLmvhDm5c0CH8UNY9rvG7Ip0I8xIREL49Keahy5Yh3GIg5MzDRSvb65opf6lvWW 9Dmvfcc6gjHeQ2KUm/ZqbluwXgTr6/I3Xdk9lRL0klNgSpsgRLA6xLv6kx8Qa6nsy5t0UkjYWVd r55FgZoKn4t3fR+6PV2AUpNglhRwgeZ6ifslMip8X00pNXLJcj+cL2Ve/dtnEiUcpa3rLUxXEi7 RYlAhU3hzEBR0MTr8vCoJ6igPJEW/lV/XXQxCEzbAvxpz99tt2u81H+RX5eYVrvwo92h81hWikP T7kP6CqQY/9gPbvQxNYwvxKXcA/BGu9fNGzdIPOEdDj1w== X-Received: by 127.0.0.2 with SMTP id szJtYY7687511xiJmh4tmjoi; Tue, 26 Mar 2024 06:39:53 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.131]) by mx.groups.io with SMTP id smtpd.web10.9158.1711460392161130893 for ; Tue, 26 Mar 2024 06:39:52 -0700 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by DM4PR12MB6133.namprd12.prod.outlook.com (2603:10b6:8:ae::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Tue, 26 Mar 2024 13:39:45 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50%2]) with mapi id 15.20.7409.031; Tue, 26 Mar 2024 13:39:44 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: Abner Chang , Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 3/3] RedfishClientPkg: fix the first node processing in GetRedpathNodeByIndex() Thread-Topic: [edk2-redfish-client][RFC PATCH 3/3] RedfishClientPkg: fix the first node processing in GetRedpathNodeByIndex() Thread-Index: AQHafRnNkhhsXXJU6EurJ1mTIdT0i7FKC+KQ Date: Tue, 26 Mar 2024 13:39:44 +0000 Message-ID: References: <20240323120050.53834-1-mike.maslenkin@gmail.com> <20240323120050.53834-4-mike.maslenkin@gmail.com> In-Reply-To: <20240323120050.53834-4-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|DM4PR12MB6133:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: BJmq4jU6zPL74IqYZicZNwvyxjURrVMDlAIVyKj8Qdyox3f1GDTlXTxD3bbAYGUL84fTRNNuIhDGk9/GPlQaDOZt0Jld3YTpCYGyqo6Fs69w+Si6fNNQGjonUP/yR8mFuonw6bdBpXAbryTIVfuU9SeQ/zjcAWDUoqj/yswYPbP+cpYX6NBhemxTpkLbrFSFjerEYhBk7/RSivgKcy3seddF/mY03cc5++xgqdgkB5I4TvHix2hB7Cp4BmdrwAGvnnfjnTv08l0jtdMIPzi5CdmSGpwDgDnMcOAJ4stxyWIvLYFpbVN/OA6uT9Vrwqa8EyTy7O2z/r6F8+4t1x2J3gs/jLMu0rRCw5OnkmC6R8dENu+IdfjBDXhwlUVRxxAOYFLmC3k/f6R3Ui07yaITfSgwX9hukw/Ittw0EGQtL3ALF2kdSMgTd1o4UPnkSXt1UVas6I/W0mYHvL5doG/GBNQ1yplxjlifXZyJ5DhF0syag8bg7hhkU9jGoZ66BGHrooLEvHy2CpspU4ROGuMvsydEvV5v+aNNSXjWFdvMF+/sCFiFZu+qNLZe1tHZUNp3O9BoFUZ/6KPnomtnPBqOZaOa+Brt/3R7Z/woWT1rq5msDAKSg9vo45nKyhoSB/Y52wiDmRApJYZhuHrWfwrr0myuxllvwOpRSwKxfBGcqUM= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Cdqp513kl/Lp8QcGD92bcUVnVuBYIELQhcMjovvYqmSN69fE+g1ojMRwofjO?= =?us-ascii?Q?VLh/hlKhJaLLJtQQbsb5jr+t+lHTL93cNvInjt54FMYHGqjqKkCdoNHtwn7/?= =?us-ascii?Q?J5ldZ+YNRUsoD4kL5/BkiCKxds3RKmfqYnq6SRH0n4r6snkTWwBoL/8g7LZs?= =?us-ascii?Q?7qrqBKFbe5acXe2AD7edyFKFvPAILbiAxn76uIDoQpWmbYhPpo4n51BMYWfJ?= =?us-ascii?Q?6FXBRWuWVD+oVOQKsZcmOGnYNwTg7aSkkctcUrg6mCWJGxUm6DXLnVNiFyMt?= =?us-ascii?Q?nwKtE1vK+Q/3w3h07zLUN8IOCJviV/txaSTsiXPicxM4sDtVJumeTpulZWXw?= =?us-ascii?Q?xXoepSrUilqeY92+fbWqWy7KBkaXGOgjkfnQMhs4Msx/9IJvkNhxzmrtxdIv?= =?us-ascii?Q?KlUOFKmujXBixAqZdh+o1xqPhkZCRCajDI5ZszkYFVP+J2IlS2gMzhn08vry?= =?us-ascii?Q?ZeaFGN2eBzL0OYBdSJyiKpcAfBAVX88Pf4cQkC+NfME3tZ1Yb+Bf3kW1bMal?= =?us-ascii?Q?E50SHnFsE8hRRYp+57Gylzdqg/haPHk6hbhXW930/NW8FL+WfpnsdUkE8Pl8?= =?us-ascii?Q?4Gaw7OjHkvwdY169iDRzGVO7qzrdowZq68nHIPFUWzJFk6xVjsM4A9meEc2M?= =?us-ascii?Q?SZIIgeIsIm5suaxtSkdK0UJ8aDqUhtDOiS/UBTm0tqksru5HnzJ4167Nf96r?= =?us-ascii?Q?LCkejtCkoNdX2HqMfuiYynad8ZYxMnC4o6vUcYy1hlne7+nIyEUaV97oBPtx?= =?us-ascii?Q?ALFyZ8cSVy7iASTY6jc42W2hUXB9TOuGf8a2Uim6cjGEVE+wReV3MvWtoVlP?= =?us-ascii?Q?GTllNAP69fjT8gX2ct34MxUrSfYdr64QrTMkQK9i1MRZX8GBs0/nGuGlylVU?= =?us-ascii?Q?EPKEQTkPhcv+GnYq7/R6sIw8d5WJOn+Mi+L2ImANheIQS5TEGEjiQVQVLLGA?= =?us-ascii?Q?WxyHXPEHaylPERIKfb+uAUEj8GmIHuhSk5gXuFfbt+IutinqIY3AwjatkfGF?= =?us-ascii?Q?u64DHiUAMShsYvH+wbUUQFqQfgewjz1LRP8H4C5lNWqWKidnL1FnTAWnQNJt?= =?us-ascii?Q?EcdNUjpSMjerkcpt14ykPoQIGGAsjnqzZVQ3spcKdAXZS6M2vWiagNc2JhFl?= =?us-ascii?Q?WsWOUHD5WLpT3UtcTGJ3APNLcwPRIz95ggnAcjdfKlbQw5nocAJQRrZsBCf7?= =?us-ascii?Q?nHPntCwZ9aozKkKq1oK5Kn7Yk6DPyOj/c/64F5FwkfX1zvN1xUaGOM+veG2I?= =?us-ascii?Q?lXYrH65f5zvYWBVIV95/fI6ro5g7VSpgTJi1R2l29C17zbvUnssJ9qhdbRNh?= =?us-ascii?Q?6Hda4OkWiWAQjvymYuVjYMJVYtNSKLJC+dkHGIpmlvL2iRaLdC829wQv7OmP?= =?us-ascii?Q?NCRXKfsYCuJgPVk1PmCZBJIV3HyCYfZ9w8si4qa8eaBx/vvOcTtFyadILVLp?= =?us-ascii?Q?uSGg368qYFRYo+W4zEVrVaOkA6WnVn+WIRZ/YmARUV51GGuWv1lh6b5R8pd1?= =?us-ascii?Q?v+c/3kN7GBVYBN0QdamaSxEwbcBrxDUQtn6eQf92B0xZItewwqPwyii4+/iG?= =?us-ascii?Q?L2yU6mVCoYkKEQF6v+g=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3405ce9b-8a3e-4e1a-dd23-08dc4d9a3256 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2024 13:39:44.4401 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5Zizljc9cwO+97eipbTZN4nnkOVi7+ikt8qPn4YyRI6yP7UqduFeorXSKfj7z0QiK83nMU0Qh5KC5m4JYaWndQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6133 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 26 Mar 2024 06:39:52 -0700 Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Rk0RJQVqbrFkCkzA53DrFHFlx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=cCfjZkyN; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Saturday, March 23, 2024 8:01 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > > Subject: [edk2-redfish-client][RFC PATCH 3/3] RedfishClientPkg: fix the f= irst node > processing in GetRedpathNodeByIndex() >=20 > External email: Use caution opening links or attachments >=20 >=20 > For node with index 0, the result of this function contains leading L'/' > character. But for other nodes no such characters (separators) returned. > Make processing of all fields consistent. >=20 > After this patch the debug output for specified URI is the following: >=20 > @Redfish.Settings found:/redfish/v1/Systems/system/Bios/Settings > GetNumberOfRedpathNodes:6 > GetRedpathNodeByIndex[0]:redfish/v1/Systems/system/Bios/Settings > GetRedpathNodeByIndex[1]:v1/Systems/system/Bios/Settings > GetRedpathNodeByIndex[2]:Systems/system/Bios/Settings > GetRedpathNodeByIndex[3]:system/Bios/Settings > GetRedpathNodeByIndex[4]:Bios/Settings > GetRedpathNodeByIndex[5]:Settings >=20 > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nickle Wang > Signed-off-by: Mike Maslenkin > --- > .../Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib.c > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib.c > index b0a3b20a40bd..c55dc2ee6d05 100644 > --- > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib.c > +++ > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib.c > @@ -1304,7 +1304,7 @@ GetRedpathNodeByIndex ( > NumberNodes =3D 0; >=20 > StringLen =3D StrLen (NodeString); >=20 > StringIndex =3D 1; // ConfigLang always starts with '/'. >=20 > - NodeStart =3D NodeString; >=20 > + NodeStart =3D NodeString + StringIndex; >=20 > if (EndOfNodePtr !=3D NULL) { >=20 > *EndOfNodePtr =3D NULL; >=20 > } >=20 > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117117): https://edk2.groups.io/g/devel/message/117117 Mute This Topic: https://groups.io/mt/105101993/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-