public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nickle Wang" <nicklew@nvidia.com>
To: Mike Maslenkin <mike.maslenkin@gmail.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "abner.chang@amd.com" <abner.chang@amd.com>,
	"igork@ami.com" <igork@ami.com>
Subject: Re: [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__
Date: Tue, 4 Jul 2023 13:14:50 +0000	[thread overview]
Message-ID: <MW4PR12MB7031104E391E6D8D0FDC5C71D92EA@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230703213748.63317-2-mike.maslenkin@gmail.com>


Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Tuesday, July 4, 2023 5:38 AM
> To: devel@edk2.groups.io
> Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for
> output __func__
> 
> External email: Use caution opening links or attachments
> 
> 
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
>  .../ComputerSystemCollectionDxe/ComputerSystemCollectionDxe.c   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo
> llectionDxe.c
> b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo
> llectionDxe.c
> index 3ba2529c9cea..8f2054e1e161 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo
> llectionDxe.c
> +++
> b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo
> llectionDxe.c
> @@ -44,7 +44,7 @@ HandleResource (
>    // Check and see if this is target resource that we want to handle.
> 
>    // Some resource is handled by other provider so we have to make sure this
> first.
> 
>    //
> 
> -  DEBUG ((REDFISH_DEBUG_TRACE, "%s Identify for %s\n", __func__, Uri));
> 
> +  DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri));
> 
>    ConfigLang = RedfishGetConfigLanguage (Uri);
> 
>    if (ConfigLang == NULL) {
> 
>      Status = EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Private-
> >InformationExchange);
> 
> --
> 2.32.0 (Apple Git-132)


  reply	other threads:[~2023-07-04 13:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03 21:37 [PATCH 0/2][edk2-redfish-client] fix trivial misprint Mike Maslenkin
2023-07-03 21:37 ` [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__ Mike Maslenkin
2023-07-04 13:14   ` Nickle Wang [this message]
2023-07-05  2:38   ` Chang, Abner
2023-07-03 21:37 ` [PATCH 2/2][edk2-redfish-client] Tools: fix script name in README Mike Maslenkin
2023-07-04 13:15   ` Nickle Wang
2023-07-05  2:38   ` Chang, Abner
2023-07-05  2:39 ` [PATCH 0/2][edk2-redfish-client] fix trivial misprint Chang, Abner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR12MB7031104E391E6D8D0FDC5C71D92EA@MW4PR12MB7031.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox