From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web10.58284.1688476493264007732 for ; Tue, 04 Jul 2023 06:14:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=SgfjUInr; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.236.40, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TADJStAsMHg9CK/SxETQcADHhQajhyccArOhMb63hoiNQmzHHHdU2jrDWy6rzzSXBzQ34LRhb/RAEXZUMojp/K/cCVoNbyyG0670VmBxo8EcK1Oww0WaZpG9p7EV3ZBZtLHWWF+bcf4g4bJ7NCRcINa5pZT7dNmSJeuYXm8vTpov0vc9gYNJOMnAWHA3tDqy24iDUCFPueZ2N65V0o6SfprAFESyIs3WRFVv4kTcESwbnXLPd8cwtYAG42DbHRI1vWYXpF5ddrwPPVPHbXy78AiDDCGLeaqxKo0yWWrbi7jjo0b37UfsXBvXffglaBlG7DrSQ/lAc/ggiP6EFmV0Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rJGsDwPUtncWzePSffPR01ia+DuiA/VGlEL8wHksirQ=; b=ZBwV6O8n30Z/92tw46djpi0Fiq/G/2EkKLeIibepDeEQBvVLh8QV+cTKP5aAwYPAiiLJj8Ch3JHDi4coJggvJLUosKlnXjYJkE7kKPJdnoDtEjjdDkTFxLKzhsBlQynppNjriSsF9G/GP0//rlBkC/ZsE+HfpLQIfs205Ttg5xrWBoD4BG1kLWSxt6lbPxvKQU256lxn7+fQnjA7+DgbzwI0SapK/h0rtW6GS9wNN/S5JtvSEqrmrKn+JyGTyoeW9p8+kUwV4SI4KOBQiLbGqRQfDYycTR65BapJR3xyhp1NXLqjHafpD/cW209np+iN/Ezv8RI0VeRDhyroMyNEFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rJGsDwPUtncWzePSffPR01ia+DuiA/VGlEL8wHksirQ=; b=SgfjUInr6G3+5C0i4g0b4BWUrpf1k08Bak0O17+w9W4rXi3hWnoVUIlW2QPDQ7UupgAAWgIZ5ddJxBqwSVbEoCzgcZkJU/xnhBivtgpY/nQXxE4Qm+C3VEOfrlaQxFx00h0Ds8lbbNXRiyu2bQvv6uWyvjhBEhv/ywnwcet83Pkk1zwqGmiyQ/pE/KnOF9XVD59shYQvcX2gWufmksNDb++i6J+I5zKA79aGpem20KS75KZ/WgpqQB5xO87GGo0WUlMHasYjfiDG2t17eMOpTKZ0iPIZCjAE29iK7OYVGwhAI90YhmWIFKPTO90WwXjRR8b8qPZYSBy+JJZ0aoSF5w== Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by MN6PR12MB8590.namprd12.prod.outlook.com (2603:10b6:208:47c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 13:14:50 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::820f:3158:c86f:9bca]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::820f:3158:c86f:9bca%7]) with mapi id 15.20.6565.016; Tue, 4 Jul 2023 13:14:50 +0000 From: "Nickle Wang" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "abner.chang@amd.com" , "igork@ami.com" Subject: Re: [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__ Thread-Topic: [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__ Thread-Index: AQHZrfaqJ3taN6FJCEqicdP8N8IAkK+plwIg Date: Tue, 4 Jul 2023 13:14:50 +0000 Message-ID: References: <20230703213748.63317-1-mike.maslenkin@gmail.com> <20230703213748.63317-2-mike.maslenkin@gmail.com> In-Reply-To: <20230703213748.63317-2-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|MN6PR12MB8590:EE_ x-ms-office365-filtering-correlation-id: 1ce7a15c-fa36-4513-4bcb-08db7c90a5bf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ztx2H3KeDmi8vq9YQ6xslE/l6WP/3gzzp3I2R/lTvJ/tRIpQ5QHqW/0j6GcXVDNSQYNw1BIa3ByoDSMQ6DQb0PD5wamDPIGcmqq2PCMKO+cZi/NMksKeYT5yMx2kc6gWLNHFEHGS6QmHIdbhpUAGkBINsQgHMKJnab46LLGRkNwb9Qro6Aowxz6uXM5Btmuoy9IiT1ovEZL4DjLr0LP7RrlUMBimGQziCvk2h1E5WcXZjg2Nl0ozK+0ZW6XItIcUUZlVDsI7RRH5Z4qPkpZRemqkQHGEwtr+uOR45LPtBn6l2TFvsF7D6tn/tD+My+bhIbDnCnlziY9EFLAcsHLFuJlTayBpR2FqEEmjMefaM6ApjebP7B9/vMeygX+1DuPVY+xHVnPdAHfGSnxhluSsnm+YftT+zdjRMx/K0YxhwrJPSqihokCFhYltk28ijLYHPN6tZNBUbl8N+Q3CHuY6sDw07dLyaAP10OqnV+Iy44XeQhE47ONKpExmDzeEF4hZNeyCO2Hp4afDtdI6FLQCA0GnPfes4p/YL9v+8rCxnmarM1qA63zoXYbS+kXMNHpjmLePBNh7y+XzbFe2Y/OtlEiF4F699mHhrkWREMLeRD2rSEzrMMoWe7E5oiFacH49 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR12MB7031.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(39860400002)(366004)(346002)(376002)(451199021)(66556008)(66946007)(64756008)(4326008)(76116006)(66476007)(66446008)(478600001)(316002)(2906002)(8676002)(33656002)(8936002)(52536014)(5660300002)(41300700001)(54906003)(86362001)(9686003)(55016003)(110136005)(38070700005)(7696005)(38100700002)(53546011)(6506007)(26005)(186003)(71200400001)(122000001)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WaECGOE0eLRMAUbtuLwBSaq5Ui60GElhLUaPE1NEdux62gx44pZq1DckvpHp?= =?us-ascii?Q?iQ1ywKi8hwmFA+xZO98C0Pu4fUxGHyMMvMk/7wvANaYaYsfJG6UFxxrt2kUL?= =?us-ascii?Q?lnq4bEf49TcIChGXLbQLoBgK9cWn/tF8oEOZk7xAspFdxwt4eDJY96cD9ZYh?= =?us-ascii?Q?IGPQo/G/+x7Li9MmIbDqm4qcF6qw7RaphvinG4i9uHYSh04PvFMNXzva4YOB?= =?us-ascii?Q?lmzWogwL9e5TgJjRmEJqPN15c59PLnq4iag0L89o2YT0u1Lg/ujBcMFNQZvo?= =?us-ascii?Q?POIERfdnpcYqd+z0teWWYeJW0xxIerSOe2xSozd9WuNisnznPAAbI7dakxqn?= =?us-ascii?Q?vjdF0tPoFIVNQzsJyerYUw/SwHb9pjXaT0xmfrIkewESvsIn3kgxlkXCCQU8?= =?us-ascii?Q?4ZC9LUlspEyxUG5JJUf9H+RBdTkMKm0YCeB6Pt2ERRqj8ytALJAkBnHFJqyj?= =?us-ascii?Q?ofMjbjMq43P1q4uMOqutHHwIGLfyYEp54kqnrzovZ6zXNZVTeYIGePVzKTg6?= =?us-ascii?Q?+Be2GT5DmKRdilmr2o0Ex0aOkSaQKmP0AljtI6WfD12ydcHqDPvafmbBwPng?= =?us-ascii?Q?/m+vOhiAzzJWYdKPjLKiA+TUAtd1Lmtc56VvfEfKrifjcJy1Fy/EqV74Fpqf?= =?us-ascii?Q?y8odgjFn1up78mL7N7RtAWM8YFzJYTnmcc9hyLN/HsHMXUgg1jwCPq7gQA0B?= =?us-ascii?Q?vKKM//gqTO/PM26RKkat61/DnF6o8Uz0S1+rNf908iMBX2wZHHbOUyhkJevA?= =?us-ascii?Q?p0eRWXlV3Gk0UoRSrpaVV8avTbY9h52RVlDYspIJHE43h1ZAGF/9faSnMUcF?= =?us-ascii?Q?u2LPDCAb6MhOEtTCELILbLM5+EECRAXcrGKgJXLvooeGln8WvjCpaE+EXamJ?= =?us-ascii?Q?3dYFb6jgRwlGJLMO47kgyMxPvRkZp2/3739Zhhn/fin1XOhBkQ2N6RLXoV5P?= =?us-ascii?Q?32AI7yqEs0H0Y7s1+ikUzN1fCl1n8r5wqRoTLZdYisxn0MSHRGcBqSMcSsAI?= =?us-ascii?Q?c484128aSgNvJkPYNYBs2ZlXzwBkfsksXJdpCJO2VDAcwT4NhOvm0nMUT5jS?= =?us-ascii?Q?Hg9Zse6GwPwr6eiiaygRRQtM3jq69KubeV0L5AlNPjEmeipQvI5qVc4G0rXR?= =?us-ascii?Q?8KvLUUsJWHbqQEjUCfcZeTw+AweG6A+wFgKMqkzY8SfzF5gkjvrl4ccI9SCK?= =?us-ascii?Q?ppik7mgy8h/cwB0/GYlP/GoUr2fQD7vQu7uI8LWvbZMT1GjCfWSf2J33AzQH?= =?us-ascii?Q?IZaoyRvCJzNnaVucFTADtBCA8PrdEycMNYSAvjAHoTugR+75rSzo+xwptarH?= =?us-ascii?Q?Z+fdlEc4WYJCmYVYGkMidf9Vxv3Cfz+ggSg2b397+2QK9YXfjQFs+UvkIf0T?= =?us-ascii?Q?mVTi1dA7xYteZaFFRjuVoWgckrXjNqq/XNheqwcMiF11HIWgoenf5V56Dmnr?= =?us-ascii?Q?NS4M3Rtlp5PvDTIePFx5CwR7xFe9gJTRrvlRDd/wPo/La6RYMgvmO8r6Muav?= =?us-ascii?Q?djhHaFvqiA6T+DpbLuOXVeTIgT29N+tofpktBmL9C/0X+nSVJ+bQz/G6XTXz?= =?us-ascii?Q?DR5mSkcMHDy2ThA47L4=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ce7a15c-fa36-4513-4bcb-08db7c90a5bf X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2023 13:14:50.0736 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cHeN9ySSAB6qIfVYYbuBgiME+OepnAc95ElKJe+RPRYSSElAH5fL9XPihRpC7nVsP++F6UCwk6CP4GLENGHkqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8590 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Tuesday, July 4, 2023 5:38 AM > To: devel@edk2.groups.io > Cc: abner.chang@amd.com; Nickle Wang ; > igork@ami.com; Mike Maslenkin > Subject: [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format us= ed for > output __func__ >=20 > External email: Use caution opening links or attachments >=20 >=20 > Signed-off-by: Mike Maslenkin > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > --- > .../ComputerSystemCollectionDxe/ComputerSystemCollectionDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo > llectionDxe.c > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo > llectionDxe.c > index 3ba2529c9cea..8f2054e1e161 100644 > --- > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo > llectionDxe.c > +++ > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo > llectionDxe.c > @@ -44,7 +44,7 @@ HandleResource ( > // Check and see if this is target resource that we want to handle. >=20 > // Some resource is handled by other provider so we have to make sure = this > first. >=20 > // >=20 > - DEBUG ((REDFISH_DEBUG_TRACE, "%s Identify for %s\n", __func__, Uri)); >=20 > + DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri)); >=20 > ConfigLang =3D RedfishGetConfigLanguage (Uri); >=20 > if (ConfigLang =3D=3D NULL) { >=20 > Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Pri= vate- > >InformationExchange); >=20 > -- > 2.32.0 (Apple Git-132)