From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 397DDD80CF6 for ; Wed, 21 Feb 2024 07:31:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=vzMBiBQ3OfXjTehJGc7KgOh8Et5BNgLVn5mkH18otXU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708500663; v=1; b=okEKbbpOSFPVPZmcrKMo9fcmn71TtX9Ee6gYNjnDdwhGS2d+7TLq5bv2/8dv4rb5Bqsh1/N0 BONHb8J5Qw6Cicn04b/3WmBdhrXu2zIZD1aO9u6BqcISh46zEVMyh7yXIDNbjeyccIqSjT0N/6g 1BU9mZqYkTGf0OeKpYPFfed8= X-Received: by 127.0.0.2 with SMTP id PDkCYY7687511xr3FHFTktyX; Tue, 20 Feb 2024 23:31:03 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.84]) by mx.groups.io with SMTP id smtpd.web10.8207.1708500663060468020 for ; Tue, 20 Feb 2024 23:31:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hByEMzYELd2MQQ/umDhwLG6gurhUc5BcFApZKune3ZemwRNAYnBVQVjXVUeTmfb84o3Z5HPzdcxDxXvG4xUCPRonjfkqx6cSSF9nUAVqCRkEbsd13b+Q82koI0DsCm/eFSN/qfg2tD0W8hj/qs+OaH/VxnsphXh8WqA757KehnqIJaeyF2wEtXwStIuopnjqSgGig87i8NOGCo4t+mnpwlDg5PzAeG820Qe+dQm6u7Ytgvq+Mkqq0uBWbh70Q/xxQj+3/f05BQ/i4DcIGngs5dRd/t79Is9Q3YkAexA+TKAQyF41ijqdzysI0hAVV7uHMFi8NIwf2sFCGwXCv4SqWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hd1bMld9oTvRzr/Yl7lFuHeiUoygmNaNn3fk0ba8D+I=; b=LuLdp9vRw6uCfeuawTM8d8wvMbU05ZjjB4ec0QXc2iOGEHgrTlfPc2qSGXPOrhnazKfWzFDUgV8ea1z8EpzAOkdgy+l7MTklXPwbqUYB6+BFT+lsWCTnFQBJp2w0B3KQGRTDWK5e0bqDM8ChxaUQZoOhS1URQ1x9q3Ufodoqq2y5Ri0MTXyRM/tyiFtXnTdVyfkfITf4tVIa0iYJT598HykYI9kvics/1pmCMDtx2F3qRNUld7Oq0uUhjwsqfPneIv1AO6rHCIDLIw/a+mmZZnPk7Pk72ECFUpw8mo/TjAMgkPpC8xT9mND4ZHr2EwQKuaLoiAiflwtuu+Va+JlHXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by PH7PR12MB9150.namprd12.prod.outlook.com (2603:10b6:510:2eb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.20; Wed, 21 Feb 2024 07:31:00 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::aa79:3ab0:fbcd:d61b]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::aa79:3ab0:fbcd:d61b%5]) with mapi id 15.20.7316.018; Wed, 21 Feb 2024 07:31:00 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: Abner Chang , Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH 4/4] RedfishClientPkg: use Json value from a function argument Thread-Topic: [PATCH 4/4] RedfishClientPkg: use Json value from a function argument Thread-Index: AQHaZFrCP+GzkajYiECbsr+QwQgcM7EUZwuA Date: Wed, 21 Feb 2024 07:31:00 +0000 Message-ID: References: <20240221001303.57384-1-mike.maslenkin@gmail.com> <20240221001303.57384-5-mike.maslenkin@gmail.com> In-Reply-To: <20240221001303.57384-5-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|PH7PR12MB9150:EE_ x-ms-office365-filtering-correlation-id: 782371e0-a048-4074-73e9-08dc32af0d5d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: mt3O1sucOx9SKf8hWsN/JMr40xR3tJreWbQAQCdobjd96RCV8MYI7nabW9ZYvDiLPHaoZ1+8cazauH5ApM6M63CawuFMFwL1JalKR5RRTSWVT4F+Na1Gr5Kd06jLGEhc8Waz0aUBOA18OAg+fZOTsgGKGBtLhfQI4UshJ25aKhBsD+n1sqifYuCTNusQ32rzBKAFYLADHcTvQ0+FNWtIv86mcpTcANYAJcuPdauYJTn2O0MZhIj0ADr9RXSZ+RVbN8QgJ71uLW+a0/47hHoATmKayK6ii+heNtsFFFlk17r0f9EJc/YmRuVWEiPUiLHEUvoeMDelePqVZSf0HtfyBvskvZV2JZmH14hQy4UlQVVjyTZN1GZlgdaUGCvqqkSqvTtPtURKh87hDpbQWBRa4GKxsFwzTSxGwx7CQfp14HbzBZVuro+Yt0EikLuWtHo+EwoxqHkcxHdc/DljgK2LyzWnncuv7VGWmRBEbDTmbudwJghxbe2zPny6Cdt/ERq3N5INKbvZrbDdAnrN3acy2Cv/Ye3qIL8/I+qYyWbNuXHMxDfOLtiXUhCapKhMHe+c12KeWhIg+Wkl4SSdM1YZvhWrYN+n+sVCLfNRWunEVdQKwO1MGqTtw/X2sVdIs/P0 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qANFrXOVUrcsH2F6N54SWyEQXSix2sHlU8S0OW1eUqubsQlYLJvwbzumvY+u?= =?us-ascii?Q?fHNt+YDVDzN+gSQ/l9bg4Dt3tsjkDqdQkDa8juv9Ht0DUPDxqDuZbcd+gDm9?= =?us-ascii?Q?XKX/Ebt63G3og7wbtIJ1qkXYJ0ahHBTBRpr49El4db2IPL71JCPeNWthoFSo?= =?us-ascii?Q?QSBQZ2lqa5vCyopCsROiZxSTTwMOYQrxqmvs7R6SCS8BPzXY3kTmnxcYOetX?= =?us-ascii?Q?aE5CSddQAMOiW8FMW8R2wWryTxFoPGyKT+nYMO4wZt2NJhygNsp1vQ+zbE8d?= =?us-ascii?Q?4LzkR1x/Ps0ENcb+FlWf3a90R5IwfeY7jMSYKZLP1jumF5vCOueMpyeVKiqV?= =?us-ascii?Q?AoK/O2ToYvASaE9Q4jwWFPyPu3SWOwrgFNBDhK5+doz1/aYcCgP0ISkxVrRe?= =?us-ascii?Q?Y+v3SAJJLLQnks7kKdpM2qdryzCVABFHvNWtBXRxfM8/u99utlgtLYoQQSsG?= =?us-ascii?Q?QXq8xtLWdev3Ld/qDJLLqKZ8D4aNx2nnCc8kdT7JqqaP9OEqYqWGormdPveb?= =?us-ascii?Q?FxVIvBSci8oZkbCrfpr3K0XbGAlS7qDSeXs5+PtdNNhy0joF3tMcHP3EkpKs?= =?us-ascii?Q?NujE4bO/R5tc64Y5HF5cKd0l6rJW098J3oFKX0Q4G5J6ewQ5Gsmiuxg5+Umy?= =?us-ascii?Q?fbloUz0Du2Mse2hc2KzaxEUIXh6AaiM7KiPoQpzCpKlpglJjQamWhSzVM2aV?= =?us-ascii?Q?G46e2GpuDXeoUDQKV4rsaltJPCBdjy5wLtQiRcRnXNbHbTHrNgN31vRRV9j7?= =?us-ascii?Q?iBBlN4IW6kbq1rltP0GaX+Jn501UbMlXiYc8GTG1Dczdn83f6mJxnelCTlJ9?= =?us-ascii?Q?P+kD1Xt8oF/2LkXCNJTM99KgSKso7O2PRd83ifpIP0eO/w5oFP8uEe1kn0pu?= =?us-ascii?Q?k1ydbVI+w7cMIaJ+KT00AN/NfZ0NZyM7fOTu9Kic7Im6cRK2UtGSRIe9g0Qz?= =?us-ascii?Q?001ynoG+9oNqhw6GmjcQ00beEo0jm8hLQWCwsS3RsSdhrXIrzitfOPwjk8zM?= =?us-ascii?Q?Ts2JZj4dBxXYrt7GZf5FgVSKyc6444DmpdCYtuGutXyHBwmgc8FfzT3QFEXu?= =?us-ascii?Q?O7BhXvt0Ohf85Ft7CD7QwxQ/L3tT0KgXoSaDGkwjndzNjbK1rabIpfWzEJYo?= =?us-ascii?Q?wvzI3nxfToKX5Dx/qAD4NiPg/S6B2sHE6037i39U7A4gdOqGWuDI8fFIFNSV?= =?us-ascii?Q?AbPn84jSOI6rnzW8853zne19DQknME9/uNjrTdoee4lc2l1PD0GYh3+oiryZ?= =?us-ascii?Q?T/u0qGIvh1dB0+EIxcbb980pBc4a8Qe4kCU7ceOClHv8gae/12KKwlXhLXOp?= =?us-ascii?Q?CjsfGkT4pPljJzNNQMM8g4nf6/8VP+obU2GoVLdiReRMCivlGZYwdBhhoNVr?= =?us-ascii?Q?nzsW/V9mlz4YNUEW4X3pZSDUPWyh0VUq3oeaf/t2cHQPVE8/JuM9Nfnoqs8N?= =?us-ascii?Q?/wHdcnQErDnqGdOT5V6qBx7nVOmy7F+/VTD3oxTcuZ8GIEBQHSMAVsLwNsbz?= =?us-ascii?Q?csP8Ov7TMK1zq3uO3fxbXNBvyLjZcS1mbIbkY5+KkVJhaHTIlvfATIJaqXsB?= =?us-ascii?Q?Od8wdYnXSUZZomFpotk=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 782371e0-a048-4074-73e9-08dc32af0d5d X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 07:31:00.4458 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +LEbQit0IawDJoOgjt9OMoN94beFOd5DG9ceShVbhQRZLFQ0Hk4YfAkdA+5rBacP2AiZqDKEAAumUVoC35t8HQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9150 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vf146fOebvV2CYD4bHaJ8Zu9x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=okEKbbpO; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Wednesday, February 21, 2024 8:13 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Nickle Wang ; Igor Kulchytskyy > > Subject: [PATCH 4/4] RedfishClientPkg: use Json value from a function arg= ument >=20 > External email: Use caution opening links or attachments >=20 >=20 > This patch replaces value Private->Json with Json used as second argument= for > RedfishIdentifyResource(). Currently Json argument is not used at all and= the > pattern for caller side is: > Status =3D RedfishIdentifyResourceCommon (Private, Private->Json); >=20 > So in scope of RedfishIdentifyResourceCommon Json actually is the same va= lue as > Private->Json. Let's make code a bit cleaner. >=20 > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 +- > .../Features/BootOption/v1_0_4/Common/BootOptionCommon.c | 2 +- > .../ComputerSystem/v1_13_0/Common/ComputerSystemCommon.c | 2 +- > .../ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c | 2 +- > RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c | 2 > +- > 5 files changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > index 0ae841499692..f3f993c8782e 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > @@ -729,7 +729,7 @@ RedfishIdentifyResourceCommon ( > EFI_STRING EndOfChar; >=20 > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; >=20 >=20 >=20 > - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json); >=20 > + Supported =3D RedfishIdentifyResource (Private->Uri, Json); >=20 > if (Supported) { >=20 > Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); >=20 > if (EFI_ERROR (Status)) { >=20 > diff --git > a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommon. > c > b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommon. > c > index 0b9f2bf28434..f471c01c3790 100644 > --- > a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommon. > c > +++ > b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommo > +++ n.c > @@ -791,7 +791,7 @@ RedfishIdentifyResourceCommon ( { >=20 > BOOLEAN Supported; >=20 >=20 >=20 > - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json); >=20 > + Supported =3D RedfishIdentifyResource (Private->Uri, Json); >=20 > if (Supported) { >=20 > return EFI_SUCCESS; >=20 > } >=20 > diff --git > a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/ComputerSyst > emCommon.c > b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/ComputerSyst > emCommon.c > index cee6c8bf9ba1..d69fc176ad94 100644 > --- > a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/ComputerSyst > emCommon.c > +++ > b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/ComputerSy > +++ stemCommon.c > @@ -848,7 +848,7 @@ RedfishIdentifyResourceCommon ( > EFI_STRING EndOfChar; >=20 > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; >=20 >=20 >=20 > - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json); >=20 > + Supported =3D RedfishIdentifyResource (Private->Uri, Json); >=20 > if (Supported) { >=20 > Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); >=20 > if (EFI_ERROR (Status)) { >=20 > diff --git > a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste > mCommon.c > b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste > mCommon.c > index a67ef3dac283..11bcb5f76cab 100644 > --- > a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste > mCommon.c > +++ > b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSys > +++ temCommon.c > @@ -1718,7 +1718,7 @@ RedfishIdentifyResourceCommon ( > EFI_STRING EndOfChar; >=20 > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; >=20 >=20 >=20 > - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json); >=20 > + Supported =3D RedfishIdentifyResource (Private->Uri, Json); >=20 > if (Supported) { >=20 > Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); >=20 > if (EFI_ERROR (Status)) { >=20 > diff --git > a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > index eb52c68c5dcb..00a69f748c3c 100644 > --- a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > @@ -2516,7 +2516,7 @@ RedfishIdentifyResourceCommon ( > EFI_STRING EndOfChar; >=20 > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; >=20 >=20 >=20 > - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json); >=20 > + Supported =3D RedfishIdentifyResource (Private->Uri, Json); >=20 > if (Supported) { >=20 > Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); >=20 > if (EFI_ERROR (Status)) { >=20 > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115718): https://edk2.groups.io/g/devel/message/115718 Mute This Topic: https://groups.io/mt/104479574/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-