From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 508E97803CC for ; Wed, 30 Aug 2023 01:49:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=b1bICbVIJbzRIPPh9KzXJ6T3Ywzt1kvnb1Lwswos2cE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693360143; v=1; b=KQcFFOIszYVdKOZVWMdHucV7iO2ZoYi1Jx/PBRO7umpWRAphhqO9XW5j2oofhDWr03Z/CbDG QNp6D502aflcx1bx2I/XyJgwV5UOn/ygCGGNN4aWZiGSDt1Tgzg6ID5uQ5lKwFw8yfboUjJWLBq Ec/GMim08kZ+3wB+/KUhhEpM= X-Received: by 127.0.0.2 with SMTP id LEviYY7687511xVGSHdPDarj; Tue, 29 Aug 2023 18:49:03 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.63]) by mx.groups.io with SMTP id smtpd.web11.4761.1693360143259119261 for ; Tue, 29 Aug 2023 18:49:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jYBMvDU0TN73YCxgktkP2fTgIncA2Cu62jVrxTbvVRd5Qt8SB3SFqDEIjodl8gLQDiQcJ6FEGHJguzbTWO6qxslRCQydkR/w4dPTTXkHjG/1ymJujUBYuBde5ztS/y+PU66F1z3faNHda0xqr4zSIozGoo3O9SqeKSXDJbdjAvyait1V9IzUZgiZBdXmdRLNFuq5vUHuIqEPWxowvUManBW3jyja2TVM8JgfIiLULsT+5eFB1zFMDosbGdPVU5i/o7bahQqEkIS5+VHAQnBdAQHYQvggEJITRnDtWU1ZJuXqU/BgHtqCXRuQFCRHcDZjBXZ8tf2/GdPIsAj4B3TWJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lJl+LplKNViiwn1X9x3HBuoi0nRcUtDfk0HVwerjkuw=; b=XSi2Tej6oXYVfBY0nYdtAzmmhp8belXb6FbB/8E7OGi3cEffCCf2gwNirXfVUiJ/JrZNLQRWOoorfrKWUNyFsBYGC+eycJjwXO8y8FnHSe15W3tFpfBuz2sUNnxIL0y0lt6/3N5RvyaAnY/KHn0xi3xZQbbYgPKNMvVygxy7BQu/ehi1hiah/vU1XQViIbxoRnuRn9epy0uNphsYnkl8jTzVKaBzn5v/fl2cSBaJKsbEYLr201xKJWdMTmOO8AJAMTkTmuF/YpC2/p87LaJwP88yMeSUO7EIwW2Mc9KDhkmPeuvhSDSchNhjvUHCaHmT/Zugt/uK71SDqwY5llQsoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by PH7PR12MB8426.namprd12.prod.outlook.com (2603:10b6:510:241::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.35; Wed, 30 Aug 2023 01:49:01 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::1390:de0a:6b46:9837]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::1390:de0a:6b46:9837%7]) with mapi id 15.20.6699.035; Wed, 30 Aug 2023 01:49:01 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "abner.chang@amd.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 3/6] RedfishClientPkg: fix leak of allocated Etag data Thread-Topic: [PATCH v2 3/6] RedfishClientPkg: fix leak of allocated Etag data Thread-Index: AQHZ2k8BCxBL33P8JUC3h2HR1wHh0rACE6PA Date: Wed, 30 Aug 2023 01:49:01 +0000 Message-ID: References: <20230829080112.12748-1-mike.maslenkin@gmail.com> <20230829080112.12748-4-mike.maslenkin@gmail.com> In-Reply-To: <20230829080112.12748-4-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|PH7PR12MB8426:EE_ x-ms-office365-filtering-correlation-id: 5c03b6ec-8080-49cd-4af4-08dba8fb48ab x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: YcGHxKdIdfU6qLMBSsdUaBlUoEVtaSbPDYSVCTlPLX59oQ2bvHSn6NOiY4uebhJiYjd7PjHrwqhLT6JhDXWIukgVmRsL8SsEFi7vCM1OAgHt+sj442WbExx1Ek4W8xPeosiCZ8gPklZ3CnV+6pxQPF2TeaO59pZxovko+oibV3D+LRLY43YceKbUJRkdZ6rUMafhlj3ICMpH4fR42QLFhmVZ7asZXX9nf094/VjlhUzt7vPidQvD7fOdCqaK2T2+OsJ3DtzEMUH1vztYk5wlGjhgnU+7AJc7jqCRxkGcyHk2khVTDkcHT03qIJ3vyuygxNI3EKKvzMiRrXuwXrObjMthKUXPdVlgixcPV52ToIJGz04hcEyaCprVFJRTkjrpjmXWDnUciFTwEhTC8o3VTpwcILqnDV6XQqIR2+VhjSXeT3LXyFonN/yVqtn0c8KJhR5elE8hgQ0pwOcgsoE3BcEeGIIJODBp2Q2zfG6EC806YTjB8MA3nXEUKoIjCJ2wITq2nVsTLMWhCatHPxVnwmWDtQtL+296zZSS4GxihjBG9RA++GAKT1nbEtqUQlIlTbjSMjntUdBLsm49ibKyJmYr8W6yvS34aIibdjlnFVgbiWsGB85yZDSUv/SExaNf x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uEvzyYHLexvYV2Dn/x/FZgGLcH3gdToyE+Z9FOxEQv5ktyEkbyXKRnlYRvTm?= =?us-ascii?Q?eGw88sxyq8wifgAsKw2tehZzP1op89awZ44Eb0FGepHyW7mRoFuSYzqxPGvZ?= =?us-ascii?Q?sE7M3sPV2mdR0H5sYoUoq/5w1neR7caXUgTInh4HjqbUy3DuRXabgfjel0Dz?= =?us-ascii?Q?enhvO72ws0UUH1lDmq+gD5ArTjUnqvJKLT1HDf+bgsCAKGgZEN3Uq6cCulR2?= =?us-ascii?Q?TViWOYBszncFrgeFleHZi55V6M2rzaOEq94P8w0Wn2Kb+5kN5ibQGuqjBH4i?= =?us-ascii?Q?KQAU8c9EH2WZE2yjkhiI6+TJRuKI6N6yg6w8skfxQFyqXWjoPGzu915LblwJ?= =?us-ascii?Q?f9qalIctZbx6Z7rtsB9V4ScQo2h7UVfh0jhNspJVcY0W9+YGlci8j4UM5N8m?= =?us-ascii?Q?J56v9sGlKCF61+Kw0xugdywm2xCCJ8NAJ3S8C8c3yt3Z0D6t39fRjtsx05fj?= =?us-ascii?Q?+9q9oIDm1IqZ1LIOw8V+d+YD2W9h00zN909a16L8PLhCOpLqnVcyDJW2IIy0?= =?us-ascii?Q?jigi8lUAoob/RrmH08z7mGn7Er/1FzdZIKlPoqe4CboQsKti5imHuKCptZCp?= =?us-ascii?Q?1F4ZyPUovxKlmVK0PxG3CzoK0g+7LJUZN4FKqFY/A3j0Vb38A+ZIy0x8jySu?= =?us-ascii?Q?6JbJC91D6IPFsJFbqvWnJSjD4BZvBq5q/dP/lkFdCoqJYn6hbfzwY8qCc+ED?= =?us-ascii?Q?ty4+VWSgP4nzfoYmoBeKOteM1FUmUd7nByYNbkH/fE9zEQ+1L7ZeNdHx1OWA?= =?us-ascii?Q?29BkzMFI7G9h4KL9sh0Ly5CuwubwtxIEmMO2CvGBwPkWrfI09StUoXLI9M6R?= =?us-ascii?Q?nsYkuqvO0fd+EsvyW6cl31yF9lV9+GlYwCTLB+5nZI2NFjaSkQFS2whM2M1k?= =?us-ascii?Q?aOTsuh1+ugfodiK23CkUj1IFtY9IyehwpCGRDITLFBJxUo9nCnCbl/IDRc3M?= =?us-ascii?Q?FKsMhOPh/anGY0+uoBveiyltGEYCCoCiqESo+UjdZmL7KJ0EslHjAWMoIIAx?= =?us-ascii?Q?IBx/ThswxSTdh4Ztq7EmitAV6GW3sJEjtlBQT0YueaDGJgHm/Calg4sbndJf?= =?us-ascii?Q?2mI+qzANbr3nGjmsd9P4l+hVLor75d828sGkrOvqlUddQ9vQ/EbBb/sfntP3?= =?us-ascii?Q?osNFrNwMFs5fdpYmR3mNjzQ8jpvUPl1pZlKKpGlPwerI26CKsCzjZ6429YZ5?= =?us-ascii?Q?ADM9aihjf/iv4IIY5WEdcAfG3bUBo4i4T34pwV9zu47mQKSffFi+MNGr2uij?= =?us-ascii?Q?oZtMEG9P7/nca8B6yDPNesFEz3rF3wcTw/OZvuv+jLqf3JaJaNoftR9gvO8O?= =?us-ascii?Q?tDbZFwv6c23KspLWUnUf5sviNfSX15VCRPHORjQ8ikOia5t8mRxikVfaH1WH?= =?us-ascii?Q?S9CacuWucABINzDcRAxe2QFKWn4Yg228SKvxB9/WsjGPZbsMg98cT7z2Nhw6?= =?us-ascii?Q?fcz/Q+Qn1UyRn/kGxfcomUrBrAkOgqwjFZk6M6QifpcJCII3hqfmNj0LwI0Y?= =?us-ascii?Q?nsBhzcR5FDIJ6XiraMzc4WkeWzKRIML1clotsShRPdb+cbT5oz0DKiFlg2gr?= =?us-ascii?Q?d2oPB/2kjuFTSgCiMzA=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c03b6ec-8080-49cd-4af4-08dba8fb48ab X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2023 01:49:01.2315 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6qT860pQQYjxZPIwsXF1RvHIAje2kVe0qIFDZDFnO7zw5XCFNrM1vdICrD8qhskJIdtQYzqS2k2Z4ww2Pj/Jqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8426 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: f9yRQGSF8L1WivvOGjsCBkt5x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KQcFFOIs; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.chang@amd.com; Nickle Wang ; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v2 3/6] RedfishClientPkg: fix leak of allocated Etag data >=20 > External email: Use caution opening links or attachments >=20 >=20 > Signed-off-by: Mike Maslenkin > --- > RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++++ > .../Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDxe.c | 4 ++++ > RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 4 ++++ > 3 files changed, 12 insertions(+) >=20 > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > index f5562fb49cab..32dca964aa0a 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > @@ -220,6 +220,10 @@ RedfishResourceConsumeResource ( > Private->Json =3D NULL; >=20 > } >=20 >=20 >=20 > + if (Etag !=3D NULL) { >=20 > + FreePool (Etag); >=20 > + } >=20 > + >=20 > return Status; >=20 > } >=20 >=20 >=20 > diff --git > a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx > e.c > b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx > e.c > index 91968dbe488f..5c2a4eadf2f4 100644 > --- > a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx > e.c > +++ > b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDx > e.c > @@ -164,6 +164,10 @@ RedfishResourceConsumeResource ( > Private->Json =3D NULL; >=20 > } >=20 >=20 >=20 > + if (Etag !=3D NULL) { >=20 > + FreePool (Etag); >=20 > + } >=20 > + >=20 > return Status; >=20 > } >=20 >=20 >=20 > diff --git a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c > b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c > index c55a6848c74e..f34f3266f1ee 100644 > --- a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c > +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c > @@ -164,6 +164,10 @@ RedfishResourceConsumeResource ( > Private->Json =3D NULL; >=20 > } >=20 >=20 >=20 > + if (Etag !=3D NULL) { >=20 > + FreePool (Etag); >=20 > + } >=20 > + >=20 > return Status; >=20 > } >=20 >=20 >=20 > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108107): https://edk2.groups.io/g/devel/message/108107 Mute This Topic: https://groups.io/mt/101027005/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-