From: "Nickle Wang" <nicklew@nvidia.com>
To: "abner.chang@amd.com" <abner.chang@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-redfish-client][PATCH] RedfishClientPkg/Crt: Add CRT header files
Date: Wed, 3 May 2023 09:19:31 +0000 [thread overview]
Message-ID: <MW4PR12MB70311BEC93FB4B07FEB5A975D96C9@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230503080637.1390-1-abner.chang@amd.com>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
Regards,
Nickle
> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Wednesday, May 3, 2023 4:07 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: [edk2-redfish-client][PATCH] RedfishClientPkg/Crt: Add CRT header files
>
> External email: Use caution opening links or attachments
>
>
> From: Abner Chang <abner.chang@amd.com>
>
> Add CRT header files which refer to the ones under RedfishPkg.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
> RedfishClientPkg/RedfishClientPkg.dec | 3 ++-
> RedfishClientPkg/PrivateInclude/Crt/stdarg.h | 14 ++++++++++++++
> RedfishClientPkg/PrivateInclude/Crt/stdio.h | 14 ++++++++++++++
> RedfishClientPkg/PrivateInclude/Crt/stdlib.h | 15 +++++++++++++++
> RedfishClientPkg/PrivateInclude/Crt/string.h | 15 +++++++++++++++
> 5 files changed, 60 insertions(+), 1 deletion(-) create mode 100644
> RedfishClientPkg/PrivateInclude/Crt/stdarg.h
> create mode 100644 RedfishClientPkg/PrivateInclude/Crt/stdio.h
> create mode 100644 RedfishClientPkg/PrivateInclude/Crt/stdlib.h
> create mode 100644 RedfishClientPkg/PrivateInclude/Crt/string.h
>
> diff --git a/RedfishClientPkg/RedfishClientPkg.dec
> b/RedfishClientPkg/RedfishClientPkg.dec
> index 6da0468e65..832cdc6154 100644
> --- a/RedfishClientPkg/RedfishClientPkg.dec
> +++ b/RedfishClientPkg/RedfishClientPkg.dec
> @@ -15,7 +15,8 @@
> [Includes]
> Include
>
> -[LibraryClasses]
> +[Includes.Common.Private]
> + PrivateInclude/Crt # Private header files for C RTL.
>
> [Protocols]
> ## Include/Protocol/EdkIIRedfishFeature.h
> diff --git a/RedfishClientPkg/PrivateInclude/Crt/stdarg.h
> b/RedfishClientPkg/PrivateInclude/Crt/stdarg.h
> new file mode 100644
> index 0000000000..5f458c0a47
> --- /dev/null
> +++ b/RedfishClientPkg/PrivateInclude/Crt/stdarg.h
> @@ -0,0 +1,14 @@
> +/** @file
> + Include file to support building the third-party jansson library.
> +
> + (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> +
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +#ifndef REDFISH_CLIENT_CRT_STDARG_H_
> +#define REDFISH_CLIENT_CRT_STDARG_H_
> +
> +#include <Library/RedfishCrtLib.h>
> +
> +#endif
> diff --git a/RedfishClientPkg/PrivateInclude/Crt/stdio.h
> b/RedfishClientPkg/PrivateInclude/Crt/stdio.h
> new file mode 100644
> index 0000000000..30a0afae6f
> --- /dev/null
> +++ b/RedfishClientPkg/PrivateInclude/Crt/stdio.h
> @@ -0,0 +1,14 @@
> +/** @file
> + Include file to support building the third-party jansson library.
> +
> + (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> +
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +#ifndef REDFISH_CLIENT_CRT_STDIO_H_
> +#define REDFISH_CLIENT_CRT_STDIO_H_
> +
> +#include <Library/RedfishCrtLib.h>
> +
> +#endif
> diff --git a/RedfishClientPkg/PrivateInclude/Crt/stdlib.h
> b/RedfishClientPkg/PrivateInclude/Crt/stdlib.h
> new file mode 100644
> index 0000000000..ff02b9f351
> --- /dev/null
> +++ b/RedfishClientPkg/PrivateInclude/Crt/stdlib.h
> @@ -0,0 +1,15 @@
> +/** @file
> + Include file to support building the third-party jansson library.
> +
> + (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> +
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef REDFISH_CLIENT_CRT_STDLIB_H_
> +#define REDFISH_CLIENT_CRT_STDLIB_H_
> +
> +#include <Library/RedfishCrtLib.h>
> +
> +#endif
> diff --git a/RedfishClientPkg/PrivateInclude/Crt/string.h
> b/RedfishClientPkg/PrivateInclude/Crt/string.h
> new file mode 100644
> index 0000000000..c3b0c65c62
> --- /dev/null
> +++ b/RedfishClientPkg/PrivateInclude/Crt/string.h
> @@ -0,0 +1,15 @@
> +/** @file
> + Include file to support building the third-party jansson library.
> +
> + (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> +
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef REDFISH_CLIENT_CRT_STRING_H_
> +#define REDFISH_CLIENT_CRT_STRING_H_
> +
> +#include <Library/RedfishCrtLib.h>
> +
> +#endif
> --
> 2.37.1.windows.1
prev parent reply other threads:[~2023-05-03 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 8:06 [edk2-redfish-client][PATCH] RedfishClientPkg/Crt: Add CRT header files Chang, Abner
2023-05-03 9:19 ` Nickle Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR12MB70311BEC93FB4B07FEB5A975D96C9@MW4PR12MB7031.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox