Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

["Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>]

Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Thursday, November 23, 2023 8:01 AM
> To: devel@edk2.groups.io
> Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> igork@ami.com
> Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC
> 
> External email: Use caution opening links or attachments
> 
> 
> According to RedfishPkg/Readme.md document:
> "The last byte of host-end USB NIC MAC address is the last byte of BMC-end USB
> NIC MAC address minus 1."
> 
> It is necessary to subtract 1 from IpmiLanChannelMacAddress.
> 
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
>  .../PlatformHostInterfaceBmcUsbNicLib.c                       | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac
> eBmcUsbNicLib.c
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac
> eBmcUsbNicLib.c
> index 95900579118b..20ec89d4fcb0 100644
> ---
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac
> eBmcUsbNicLib.c
> +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI
> +++ nterfaceBmcUsbNicLib.c
> @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress (
>               (VOID *)&IpmiLanChannelMacAddress.Addr,
> 
>               IpmiLanMacAddressSize - 1
> 
>               ) != 0) ||
> 
> -          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] !=
> 
> -           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1)
> 
> +          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] - 1
> + !=
> 
> +           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1))
> 
>            )
> 
>        {
> 
>          DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "    MAC address is not
> matched.\n"));
> 
> --
> 2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111633): https://edk2.groups.io/g/devel/message/111633
Mute This Topic: https://groups.io/mt/102759080/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-