From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DF4F8D80254 for ; Thu, 23 Nov 2023 00:24:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XGp9Zy59GS9FM2mYtdr5bSE/fIH/T094DWnk0/dyJps=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700699045; v=1; b=GjWBeIByQJjEfUc+kO2KpOaVgERH1Va90QZw6MMHCcFgscbu7r+ogvagUb0JbfwfNKW8lbmt BeeLPoIZO5SllZ6Ih2YFBoIqNdghOBB+TB4CXaAUi8u0bTevbZw5EFFcOOVUVwgP0H41tcUAGBa OQFAl67qgbRd8QlZ1UzwVTxw= X-Received: by 127.0.0.2 with SMTP id 4a8GYY7687511xVeCZZFBUAS; Wed, 22 Nov 2023 16:24:05 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.42]) by mx.groups.io with SMTP id smtpd.web11.79911.1700699044929490408 for ; Wed, 22 Nov 2023 16:24:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kKE/7C0YvQP0oo6lIQw+7FZ7Qh1j28X/zvbhDi8TOM5XWFFB+uXjpllQGFbPXbMjt449KLj2GIVG8v3b7b70tCToagY7w0LnfULgSUlren9RHSKoC/YmSeJZKc1tLEm5KHc8MKSpPnVj0QyL+WTdZwvuhRxp+fsup0djxz1HBCFue1tkBwYkmqKPaFJEgAUsI8wlLeauEyjsbvy7SebDpeZfZJRfi/dbQ0lPca/wxPug6KCEqvOamljNN/or/4yjDbOxVyCGtcn2RT7JR6MgTuuv21wb7DeCsDPIs5073XTTxFkpOipTvWiIwqKYcEPK9IsK9Gm75dHx8InvxNPdyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b8yy7y+2NBFuusulqeHhEEmuQfVgF0PBtrHHEqoaCeM=; b=cwu1Q3HPFdGkf1aFhbMKUWm4/IZXuesrnG0NeD6mq2vZlbzsvaMyhgYNi5WeG4L9r8tD8LrfnCS+fInj+xINtxQMTqYBLvMKZvLZJjI3T5LDpjQn5gcohgwLZVZr986V1Li5Wi13LO2WcWLJD/gI/BB1xeNI2Ws0HbI3wRVSewGfkqsS0Pqk1f5t2TaKsWnvcqPf8iQUgw4S4GefdEZi//HRFOPpvQ5ROqtj1r5YPBXC3iJClbFhsTq3jy1Hp36dPQHdrXFt5UujHFPZezqVvZY3Ui2tYkXSITbxrVByKwUt2RJFdxPkQ/h+9nwaboz+VS99mtsQuSugmtYp3pktyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by BL1PR12MB5143.namprd12.prod.outlook.com (2603:10b6:208:31b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.19; Thu, 23 Nov 2023 00:24:02 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4%3]) with mapi id 15.20.7025.019; Thu, 23 Nov 2023 00:24:02 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "abner.chang@amd.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC Thread-Topic: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC Thread-Index: AQHaHaAwg29cnEkKvky82+XIqKM4r7CHCuLg Date: Thu, 23 Nov 2023 00:24:01 +0000 Message-ID: References: <20231123000103.31216-1-mike.maslenkin@gmail.com> <20231123000103.31216-4-mike.maslenkin@gmail.com> In-Reply-To: <20231123000103.31216-4-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|BL1PR12MB5143:EE_ x-ms-office365-filtering-correlation-id: cce0c419-1eb0-421b-91ec-08dbebba7e60 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: sEEkrW4Uhs375YSrzS32lZ4cH/2oKYcdRGoo23WWyeN0F5akWUL0Re7yOqbgwvgSS6s0ILEAN5VBKy+JPE2gwrn3ehpOSTSMsMPe6bh/rwfy9gXaN5RU/ib37+BkjaBoVAztM37/0Xx67Wzy8nCa2iH/h6oW1ffzTvOpUMMyk1Hw+N+XMOBKRQ5C+W21Jdy3kFev2hScXDAttWZHgolPKMVcCCwrTuwR6X3rtWRNz7eU1PJBUpcwpdN54jRgJWLKjK7nYD6UEWVsrWOtci2pH0Z/pPSzF4a07yC+mx1vpfYQG9bMKq0x6N7ef2s1TiGg6Ieq41k5swT8ElsqHZGBfaRRqCUu5uVIVtGX67MLZq030n2pl+7dKfIV1CL2KaEuPgNdpgkxoNNNQu+gMI968iydUDe1/iaxw1YdugiNIobfaulyxw+k3TRYspJWOZ4j8KoXPAEcKsupwy8kDh3aHknM1CeQvrl7fEEr+aDPOQiIYGZoWrWV7y7lzXKD6LpmvKM3EHz8RAjduRO7rKPfwiaUqYKoiNA8W9BsXzAExG2djm6vnLdC5sjFXrZh1Dv7DiMi7dCdk6lQp5P9kn6Mr47JHsyDr7mn+0dTmxSL4SCtNBttMXU7gt3JxSkXHtf2HYj3UzBeyk/7soDK3nLX6dm6vDcOVFzC1T+zfeN91bCTftFjMq+Dtsx5O6b4CY+i x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+OLoBtEPmZvv5XpJn5cF/zT4/ajmlVMKr/uci51OmGzmG2tXsROFHoxnFl+H?= =?us-ascii?Q?diLMJM0VkVp5RahocHXnFNFtXkm9IlYB+swBRDiwIy2pTZM7HnUmIWKkLLwl?= =?us-ascii?Q?z4JPGA/tQc5uoU/IsboD6mkFUaYvgprnCa9hzMwBXoX3FEvZcfknjiCOQA3P?= =?us-ascii?Q?B/yrtJYxKum7EBVAKZQEoxqqsRMe+UlhJFjlQxqIDN41LJEgdxnZn+gWTX28?= =?us-ascii?Q?Mj4jE3RvEb6wihC/kbJdvBU5x2F+5w4JI/SWvrSsA2QxvkuteZDIuKEKeVKB?= =?us-ascii?Q?R6cnhpQWouT7xQ9qecJsgSMvro0CqB0Fluhne7Ua7nOH/WT/mJjzQoT3rLlY?= =?us-ascii?Q?xe/TxWTezNfUjmC30l598e0iyWjkGO1s+msZAYYG9Ljh2Ntsu9pOd60iAGFy?= =?us-ascii?Q?CUYbu+CWY9pfe2qqDATWWWLJH638OzF06J5wLgx5nzDkzznLL3sOZHXsioJf?= =?us-ascii?Q?zDjgPcmCzUkrDHQWh+sMczV+0ZmYo+9ROLP2VXrGlwTLt9R6fMw8HfdCGt0y?= =?us-ascii?Q?9Kg0roBgFbd27dwcLnTSYkzBSNnHpe7MCNRCMxQNk+bP9Fhz9/3KCvWjkpsx?= =?us-ascii?Q?RJ0K9CZOubP8gvifTbxKOG/UdJy3TLp48wvFfOq0Xxph6hdpisIBLhH72Fnq?= =?us-ascii?Q?KEcJs+dyWpUK0rw/jEULYExc6PMn/57u9F1j3yX4qMlDeH4fXmscb7m1oNzL?= =?us-ascii?Q?R3mSOlv1RQP2r9dFHrmC12oAFP670xMynIftC4B9J7GptO+z+F+3Fs81qTHR?= =?us-ascii?Q?bvmLWOSBtcXocMQ5ha+NkCp2Qu0agszUPB5RBNU9tIDeZQS8vU3jwZEpExM6?= =?us-ascii?Q?5jzfUOtSMZgpFQz5heQZf+FeJm3TkW4czy4lKLvbSp5eZUaaEEAincR375Dw?= =?us-ascii?Q?xFgdy3mLt3mc2pSBxZIBwVzAPUdTLALPtJXQ5O2VQpw1XCH5wHTzXjUQS5tc?= =?us-ascii?Q?TsJ2fXGYmXNbp+FZGJJuU71ZpPzX1tvRH1NWvzs5HdHhvUkFopUDDWMGJHHB?= =?us-ascii?Q?SX4r3fyiITTYsMESxW1r2AcxxLNUm1/QoBOLFlY1jO9cRoFunOIN/Z0JFPV4?= =?us-ascii?Q?0oCDOy5A7dyoMbdh68D3rz0hdnPXjZo3zodfXa3XJqJTDkgyji8DkXyyPWl3?= =?us-ascii?Q?JrNhheRX1TJ8H1Bto8IYs1ME3S6+/TYGU+MwE4dXXO+m/DeabR4uo7lhHaqK?= =?us-ascii?Q?+Yr5bGZrNDB70ZXh9gAc9I4M+CPjCM+QooER1gtrMiVcgmKXhUjccq4xzjYP?= =?us-ascii?Q?6uON4HbjQBD8J4oso/BkcI+8rlafANPIAWltEWtnrtHjcXzDOGP8djKAuzzc?= =?us-ascii?Q?SLeIJvZ40Fceyj7r3JVTycrgyHhZjesEf/r7ZLRTpUy0RGEeqIOMFWIfw7BL?= =?us-ascii?Q?jh0ZTXoDUZ7mbYobkcLRLeKlvfkt9U59c4gnaoBPnXLw6ycQlTTVkVnHXOnW?= =?us-ascii?Q?dopwRMmLWSRAVZ0zJrJW2DJi6aGskPkaoJb3K0i91Uq34GWB4Ns0KebtRHqg?= =?us-ascii?Q?4BBxo9NFAPRFH75rGd5oE9IdlKZllzOp7l6fzoGLJCtPbiIPwsf90qBNsJNQ?= =?us-ascii?Q?ati/rL+oRK/12C1fbNg=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cce0c419-1eb0-421b-91ec-08dbebba7e60 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2023 00:24:01.9733 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y4N7A8jEeIp9FcHAYgeRcqvSPWQXIT8lQs+sTa9nDilnr6Za06vc/6pv7EwkBDX9hsQHlkSMbswakVyPzi0vEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5143 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: oxixZCbSLQwa88mDRFWw1jt0x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GjWBeIBy; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Thursday, November 23, 2023 8:01 AM > To: devel@edk2.groups.io > Cc: abner.chang@amd.com; Nickle Wang ; > igork@ami.com > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB= NIC >=20 > External email: Use caution opening links or attachments >=20 >=20 > According to RedfishPkg/Readme.md document: > "The last byte of host-end USB NIC MAC address is the last byte of BMC-en= d USB > NIC MAC address minus 1." >=20 > It is necessary to subtract 1 from IpmiLanChannelMacAddress. >=20 > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > .../PlatformHostInterfaceBmcUsbNicLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > index 95900579118b..20ec89d4fcb0 100644 > --- > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI > +++ nterfaceBmcUsbNicLib.c > @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress ( > (VOID *)&IpmiLanChannelMacAddress.Addr, >=20 > IpmiLanMacAddressSize - 1 >=20 > ) !=3D 0) || >=20 > - (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] !=3D >=20 > - *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1) >=20 > + (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] - 1 > + !=3D >=20 > + *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1)) >=20 > ) >=20 > { >=20 > DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " MAC address is not > matched.\n")); >=20 > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111633): https://edk2.groups.io/g/devel/message/111633 Mute This Topic: https://groups.io/mt/102759080/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-