From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 87158780091 for ; Thu, 23 Nov 2023 00:19:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lup2/ZMg7aBPpNS8qLSRs9wqtMllgt5ry8HE9hqVre4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700698742; v=1; b=g28cHtc6oVVjybuWLIlcZyr0nVahvlMW1+jZJYqG63ltBCiuicQ+e4+uCM7GPEhq3CK6oFF7 ytHTikBbBO/4h4E+TdEp7eWQCMVxnuuH97o4e/przuQo0oIwN8Vj5HAQFMn47PZlXleMylfc6zm QHD+zOHWAbLH86oSod7fNnXo= X-Received: by 127.0.0.2 with SMTP id MhQLYY7687511xZrxAmWMRHl; Wed, 22 Nov 2023 16:19:02 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web11.79833.1700698741556302557 for ; Wed, 22 Nov 2023 16:19:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oMAGHPM0fgicj1Zjx38k8VmDz89avxcsRG8yZ1EyKok9d6Xb9RF4YK+ywjBIqLYBZgvwPMh0k3XM6tJMFyoa74GFXxdcJownIqVQF6Jn7P3Ul4uldW3Kn4N/HH7uNoUvuTITUllL8kxmcbycFOxNdE/BfeZte8MkD/b3wZK+VLrffVOKMaI2GmBK+Y2JcHElmONqT4IZ2GWUCO9aQxGVzufH6hzMKgwlC3eXU3dYfYdOpLbFNUvA1ncVmU96QcXQq0JXifGM4G376I9ERlsISWOjzNE8bIN2SGMItoIKj0VDfdauG6dBcp8T/GjVOKpkp7G1Lcn814Q7gdYCWjEiTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vm7dRbx6PB4hSatSFZK3zVc0X2aMgyuXesg/9LFy5Eg=; b=TpqiAXAZ5USpLUrx4jh9vUABKkZ1GTnuPiswvUlpYdQWUncPKo23PTZ/mRYMOsCW5XkVQc7QNxDv68eCytjnzqHZK67pA6i4Y5UoKhU4Ys4zsMTCcdqrXk9Xt5QIMcyzEuSFuMMkq1/mOto3+lVm+il0o5Gpz2IwiE0gzqphmvFesuYlEfCEVAMLpwSPuwCLAjSmEKOIAip+g9y/Ga7peivAL9k7io1ebV7XjmpZlB6Bo8FyturBrPme2ue57J8p3kJCTobjLsIUbLX4SGNeuan1ZaXW9sQG8iCsw4z/qtwVMYCz8asSidMUy4nlm01Z8csd12GyYKxKeWyuiSTTew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by BL1PR12MB5143.namprd12.prod.outlook.com (2603:10b6:208:31b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.19; Thu, 23 Nov 2023 00:18:58 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4%3]) with mapi id 15.20.7025.019; Thu, 23 Nov 2023 00:18:58 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "abner.chang@amd.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 2/3] RedfishPkg: add explicit variable initialization Thread-Topic: [PATCH v2 2/3] RedfishPkg: add explicit variable initialization Thread-Index: AQHaHaAxBoBPe2x6mUW1Hv9A3s7t4LCHCdhA Date: Thu, 23 Nov 2023 00:18:58 +0000 Message-ID: References: <20231123000103.31216-1-mike.maslenkin@gmail.com> <20231123000103.31216-3-mike.maslenkin@gmail.com> In-Reply-To: <20231123000103.31216-3-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|BL1PR12MB5143:EE_ x-ms-office365-filtering-correlation-id: 1dd9b3a2-d331-415f-87d1-08dbebb9c968 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ApgyDQFQBx/A/uX7PFjX/Tc7DJDyN8OCwNT968s9nNwwoV5xzFH6eDRXW9I/xZSePkjhYXI+bjBn+82Rx4m3egETshA7YIAz2yZamScFF5yjYHpacM4dd3Ne5StL30DPSBw2/O4oMPELsH24La6gmNuTYMY/S8phzg3iu157m1Gm7gXcxtvkuti8SQpUnNlkFTWqvX4No1A74do/zSxd8GyFWAEap6ya4FymFNQIKluJJc5WHZGEkICzaorcTSzHjMK2L4zTq3WWzRakxdAZufcPstbXmYMlmhRkp8YZKuTt4I8sDQTmscRx1GqXdUPiIb7BwGuJLxkF6QTLSQN7vM1IAB/goHQ1+3HfN1k6wB4ZX/oZBOGf/M8f/yVZgYxKtmeLyrnta80qmELb3lrWiVqXE44TyTSzi0bCwgE8LkC9YGbfD2TNQTSihaoenQprdx4wL1tV1MRv+FEFOb9rUBtalp6WLFqiZlyQ/mStkbw4GieXq+bu+fRqH5lQDeSHHNgt1KAJs83esHag//cjzGq0WuwtusAHAy7cK6vfT62Sh/AlC4IisIxlg2EI9xZxAkJyMLXgMW2ioEY+jvJhgq6vbtSo4pP2TfzgpaUzuRC26APyReEuUOlQGVk9kiofQhNrnXTXZAxTuozBGJhqiag5SqiPYubE0PPV4v4U02k= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Tp8pGWc+VfYlu5t5UTXut3Uhk693fOBOLA/98yyURCbYVYgjkXHYn9ca0YyJ?= =?us-ascii?Q?TOFTzdw8b9WrS+uhOdCQf1iBpW75vlW1QhY+x/fTf+OAhBE6sBghxhUsza7r?= =?us-ascii?Q?zu+Ri5+wZ815OdiblPfs2ILdejATx4KrPcUTwUcLBQAwoGo6EUFAGcpIJyAx?= =?us-ascii?Q?Px92N+sAXmnee1WxdbRbai0EhLKGHqdL7KxBDW/emucQJ7epC/s12DZeoDcf?= =?us-ascii?Q?ERaEklTgkg6ENyjUY7BgnFZ39l9EF1bbJX6JLOCookvl4tUBjE2oWTT0MpnW?= =?us-ascii?Q?o8XiDS5/JXhRnKIv00fa4r6WkOvlHF/O9+v6bMxd0QqXC3gH/izNlHjmZqfn?= =?us-ascii?Q?bpctHnLREP2kDeMI46EwrKdMVI1XEw3vRPwBRrPjsWIPH2/Wqdwph/B63VDW?= =?us-ascii?Q?ngUB1+Jjl0OGp/l14miAuSoDnL3cE1XL7LnFHPKdzmSR18FeoRjWthwMvUvG?= =?us-ascii?Q?I3c+ZQvjlxBg/Pf9kF4sML1CKfzykbLqhJk0TxfsW8xpHZlUThqAn6xJPMTB?= =?us-ascii?Q?Gd4XRFriYUbhxxnpxB2OsvwJaTY5jh1cX3VGrPx4n9xN47dqAbIhBVopJhcF?= =?us-ascii?Q?orrBGs/EybsqGkS8Thpg9ijvUepi8O7lH7LGGQ5DXRcLDjeNrqwKLD6wc2h1?= =?us-ascii?Q?YTW7ZSvNhrxxV9Q417mCOfiUKw/t8Yjfk5I2KZYJvRISPuSf+7Y2K6PLNJHk?= =?us-ascii?Q?Tk77YukpLZ1BfE2tQNjNsoHOAS1o+kWdjy3OiXtZ4NBd2SJI7AStAC5cvpjb?= =?us-ascii?Q?ApoelQqrwm3Bfl3c2VOb2/3pXSBn00+cFMV6BMxHK/iiS9sAkvZTIssO9IYl?= =?us-ascii?Q?iPFrAb20SrWSlPl304Bpro5VMZS7FbNPilydxih8auBzILNVHmf0Ml4CoW4c?= =?us-ascii?Q?bvENHUXBmGqbP4bXPMRrXRFOquQh3NwEf48ULf/GJv09MBvvInfYq80R11mZ?= =?us-ascii?Q?m1jrv73Y36l0A4rqGnp9xSSO1zMzTvlkzfVGX2xHqyyjMIUUJKd5d9Zw/8m2?= =?us-ascii?Q?L8/gUy8MrusG/NGkh91D63j5jzJQzglq7vL28huw0CjonAcW48dKCn2siNHs?= =?us-ascii?Q?BC9ia6chc5wNMZkEDRzNypUvMtX432Zm2cD/GA6UcjR092fTPyd1wcUBIegI?= =?us-ascii?Q?MsVAdVwpjmLBFfNKPWz/H5Nn0t+/wdVYwvh664EqsV6zom8gwOKkIXmGf/O1?= =?us-ascii?Q?B+9mQArSCyo8R/iTR7lGxfs0rO/fycWaJGKMBp0qpcoJcKVQ+PZz4jr0qwG4?= =?us-ascii?Q?R30T03gJV+vLEvcMy7xI+V4EBrra8VfvSCg44SQSwwngCu10foeZB0FLTkZi?= =?us-ascii?Q?UdeyDVwCmxm3U2/ryJwn/KFYMckckdmchjZBwoJy9kukv+o1LohC7OqQ0y1G?= =?us-ascii?Q?rCFvTCwXDMh4jYYUeYJIs6NHjEaCyBVa0kN82NRNohYVWdhTIwMLpqIW3MoJ?= =?us-ascii?Q?5Wb5dFomYC9zvVH+EwT1uysCA9SQjuv8moy03cNA+0PSFK03zI/lA+6Ep7/N?= =?us-ascii?Q?VId3XhepP38d73tyPji+wLqvHtLUZNOS0iGMgdKCNVHk22e3UlV9kQ45TpdG?= =?us-ascii?Q?J7HtnI+HFndOpMmktNc=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1dd9b3a2-d331-415f-87d1-08dbebb9c968 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2023 00:18:58.3445 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HzUbH84+JKM/FGEJR4aFxJjHUqik/3bW5ZbatfyaarSSmsi6AgoU9zyyWK/5ZJ0PEsvV6BmSF4Seu/n2sq0u7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5143 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: erDsN7HnnLSO2alDv4Djweqxx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=g28cHtc6; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Yes, it is an issue. Thanks! Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Thursday, November 23, 2023 8:01 AM > To: devel@edk2.groups.io > Cc: abner.chang@amd.com; Nickle Wang ; > igork@ami.com > Subject: [PATCH v2 2/3] RedfishPkg: add explicit variable initialization >=20 > External email: Use caution opening links or attachments >=20 >=20 > Ancient GCC 4.8.5 warned about variable may be unitialied. > And it doesn't look like false alarm. >=20 > The warning is: > edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c: In function > 'GetQuestionDefault': > edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c:5519:6: error: > 'ConfigAccess' may be used uninitialized in this function [-Werror=3Dmayb= e- > uninitialized] > if (ConfigAccess !=3D NULL) { >=20 > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c > b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c > index 80b93beae999..b61b7f5fcdcc 100644 > --- a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c > +++ b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c > @@ -5451,6 +5451,7 @@ GetQuestionDefault ( >=20 >=20 > Status =3D EFI_NOT_FOUND; >=20 > StrValue =3D NULL; >=20 > + ConfigAccess =3D NULL; >=20 > OriginalDefaultId =3D DefaultId; >=20 > DefaultLink =3D GetFirstNode (&FormSet->DefaultStoreListHead); >=20 >=20 >=20 > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111632): https://edk2.groups.io/g/devel/message/111632 Mute This Topic: https://groups.io/mt/102759079/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-