From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.70]) by mx.groups.io with SMTP id smtpd.web11.2369.1681974468286805214 for ; Thu, 20 Apr 2023 00:07:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=STql9pF9; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.237.70, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kvzrPkRgp6fB0TQz95uHBAG57hYkEN3/lxLDNphPIch5wNlk/B9Ht2czcpnA8ng7Mxw0kFMoCObUfGDcX4gotcFpercgqksmiYyX1M557BBu6AJkodWGF1I6cCw9zlJ7GYkptzllG7R8FkKIdt9czU0Sa3ZU0sSgB4JlQxJ2XqEWJ2edb7swuvdua2bhizmIHGd8esjWnsG99k1Q9VCgIHZMJvxxalilpIKVcuqaH8X6H2odpZJeQLFw5x/0yhyyGvU8UOtP6BVzp9mpVb9acUk5rFOGriWKShWYhhZp8gKFG1u9BdcHyc4Lfb4+1+XTbeVThvi0kVn9lHEQNTTl4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/aE5GX0qzwiQQWTH7gdOSl7bNX19z8msa9h1uABoYOc=; b=Z7229IiPUH2Z0TEtHFd/iZast6ROomsYASBKuaNF5EZgAj4LmeoKHyT6jl3LSqHYH853fb4gRhbxLqyQv9qa3WzpMGrkDJMdWugZitjPGWcG7aRuOISfNhQbybDGS7IJ6q9vxBKNlgC6N4dftgFcBgKUdy0TQaGpXzl9IN9zfH8VeqadjdttzrPGVn1aNYX0nokd86hjyy8ZzQN1I4+cyE4QukzwB3Y+sX2JnW7EcGlrcBAljUWfUArASEWZZyf2tthlhyS+jKjVbg/KPWSGvEbYC+CKuR60yxSkOmdngRfdZGEKFUUV4+LwFEYGAB0l+aoT6bmg3InrQ2QRpRy4aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/aE5GX0qzwiQQWTH7gdOSl7bNX19z8msa9h1uABoYOc=; b=STql9pF9nfcnjihM5S2JkSPg59tjInUI5Tq34ah4Wp7zcSkB2KqFjDy9dm+Fxg9EReOdeJTlpjEtnhKQV7KpTXwbeyvbHmlDkYc6v1frCW7B1uUePPGa4wWbwyYN7n9S8XaBGbks2jxqmIYycemrBSSFDKO5F6fQbBdjx9NOBwzdF+TqVwMmEte78JRyYIN4B8dDOPgw6Em0rslU3DXJpGcRJbCjF7sXWpgDcEyrvcB3HIfeDMU49A0uojQYcBLapjimggwtVPH++Rh1A9byXnzpu+SYkLmk9PIh5s5fQkTEK9ILhHW8lIXuZYL26dsurhUMTHM1rJc3OdcSiEGyrQ== Received: from DM6PR12MB4267.namprd12.prod.outlook.com (2603:10b6:5:21e::16) by DM4PR12MB6637.namprd12.prod.outlook.com (2603:10b6:8:bb::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Thu, 20 Apr 2023 07:07:46 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by DM6PR12MB4267.namprd12.prod.outlook.com (2603:10b6:5:21e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.20; Thu, 20 Apr 2023 07:07:45 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9df:b45b:2cc1:f017]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9df:b45b:2cc1:f017%5]) with mapi id 15.20.6319.022; Thu, 20 Apr 2023 07:07:44 +0000 From: "Nickle Wang" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Isaac Oram , Abdul Lateef Attar , Igor Kulchytskyy , Tinh Nguyen Subject: Re: [edk2-platforms][PATCH V2 12/14] ManageabilityPkg: Add Manageability PCDs Thread-Topic: [edk2-platforms][PATCH V2 12/14] ManageabilityPkg: Add Manageability PCDs Thread-Index: AQHZccW2ZsazmCXrr0q2+0uheAOmw68zygDw Date: Thu, 20 Apr 2023 07:07:44 +0000 Message-ID: References: <20230418071543.1951-1-abner.chang@amd.com> <20230418071543.1951-13-abner.chang@amd.com> In-Reply-To: <20230418071543.1951-13-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|DM6PR12MB4267:EE_|DM4PR12MB6637:EE_ x-ms-office365-filtering-correlation-id: fe94479f-2a1b-4768-593d-08db416df0aa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O6/98iK8yiG54gg8Qx1KeazIa9hiXW2NSm6Xh/+HUcekO3x+VzC37ueAZnLPdCiVRm3nwqooURgYYkhQFXEW3p2MdNEhuw/AM5LfHX6J0sPV7t/lf8ctTSo0hvHOhPM3JXeAwRmBl2JQNCrNG74dU4Rkinw3BTNHHo/HM6uPl1ODfiVhuB1zCFlwDW067oG9pZfeArgkX2ZzxZLmotlk4Tw5IY/p6zuyHuX6lAePn4dsuV7Y7naUFTWTtKgtjMl0ldeQkYQLO5MrtTsLyakbT2z9oROUE0fUPiwVwJicqC9o5y+9nQjvPsVi2zVbdWK3tYY/w1DlpVGFXGG/MCpJGcVcwu1IYQuG3eu9cV+V0v0++/2z3xA+6CNIQ/2C9msesCGwZyZa9R3ev2huqdnmWxu2yaZ67baCUIuaJUq9lQFrwp/5wJYrrdi9Dn761aJZtvVDfRbji42F4/DCcGQ0FkqPXaNSMZ2ELQ7yCrcERULGiIdiykXlfeRHQ78N6eX5olzpWrIDmC+33wrWyQC5WcMo+5rMszFo+AbaIB2dzywkctOR+ST14hfx1pKOTWM++bbROpS+mbcfNhitSpy5S+JTCRPNbmD+rVWGJzQxaAK3tt/xbvXMnQTtz8VZQwuk x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4267.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(346002)(39860400002)(376002)(136003)(451199021)(186003)(4326008)(110136005)(54906003)(316002)(66556008)(64756008)(66476007)(76116006)(66446008)(66946007)(55016003)(478600001)(7696005)(71200400001)(8936002)(52536014)(41300700001)(8676002)(5660300002)(86362001)(38070700005)(2906002)(33656002)(122000001)(38100700002)(26005)(53546011)(6506007)(83380400001)(9686003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fbtjQX+/Lo+NZwY08Jza07d9KfyXc0ZYSgnhhEww9Qs1E1J0W0nebDIX84jV?= =?us-ascii?Q?YrY1kq51uZSpKix0uEC1U3vAQAnFA0qP86VSGJoNOi17qZCEHaySzyh5nv/0?= =?us-ascii?Q?p0YBdKAaek1+uMEvfL9jIAjc2UcjT/TmBfBiXGQcjt5vLd4T07u+ut1s7DkR?= =?us-ascii?Q?RA0KiSOvyc9UuGZ9JuEk8ecx84rccgrfYEI+MGjflrFFovEf/ykT0FKa4eRb?= =?us-ascii?Q?OEWNFwCEt5sn8ej+7mhGKkuNuEdiA/LJqjWPhGMsdiJBN4btLyEd5DIG6NQh?= =?us-ascii?Q?jEcoFGrWBYrs9QCupZXP3hBartCC/j7lTqYvaT/AX2oAnSHKzNmtxM52klv4?= =?us-ascii?Q?+kL5eT9BxjV9xA1UxMTDIdJbqtc2MTYv4nqwHfLKAJYDFrdao7hQ7sETcbe3?= =?us-ascii?Q?AiOw7+BNaoWj7za9Z1zxpfvANW+fj0p6ju2B54xDJz2mWmfD6quOuaYzTGOP?= =?us-ascii?Q?oeNRTVB8gAQwcCdeKMlqm55cxLLMGmJGrJvuCpec474rBnkT+ZKSOXqN7yTr?= =?us-ascii?Q?owsRmNGABoieZ1mxRzXXpHC6UKZoYolBSLjgTfajENZSjk6urJaSeXDiwKxY?= =?us-ascii?Q?dXkVJUSQK09vG9dYE20Om9Epy2E1s+YF3CtBp5rb/tc7raanSaGVQy+SuU21?= =?us-ascii?Q?ma2K/KzSecM8ws1pZMM1E4iI213Ye8O2Soaa2Wh3awiQBoulsca9mrV3dfa8?= =?us-ascii?Q?/VSnkTzwaxStxUhpR4E0F7D33r0caB91YvFL8jjDnShf4LsJhK8eY7eQEUW2?= =?us-ascii?Q?fEXYEi2/SPgKgut58U84kn5Bea2EGR272076MClquh7VaVsiIhZSwjEFrAAT?= =?us-ascii?Q?zTQyMCntykL7b0QY++GGQ0AL26B5tFWxG5daMNGngEFs007Siqn7KhEoPBlD?= =?us-ascii?Q?TsUqhS7QueJbVvJZtK/nRyA9JUxwxq0+Ykrg4sSrX1bB0QcVtcVVlyQHu+av?= =?us-ascii?Q?MmsQx8cbc4j0xB71F3ityHsbbTk7WeSDDiqKPTKm9XED/k8/yLNIvr1s+xNl?= =?us-ascii?Q?neWAqsF7XtPdIgfCdgzyIKGkzEZl4ssLoLHmCT4a3yM03eSleSj8AGGJl+tt?= =?us-ascii?Q?FVKzQFvIazhM+FN5rld+fPQ83ljcI/I98Z3ffDagazFNDR7Onz9B4UItJw3B?= =?us-ascii?Q?0yGnlNuaSPdXxISCKGRPNPo8v7ZYkmR58y51uRuMaK9b72o0MpL7quVewZB3?= =?us-ascii?Q?A29kufYdo3zZP8RWx41FApMI9C4rMt2q+9uu0Teg1kBF6WClZy4FaG/RJiXD?= =?us-ascii?Q?Vr74uKPxGqqzgb9YMYV/Xv9NirpEsuy60OVeVPEiOM7buDw2BazQYqkAmVr9?= =?us-ascii?Q?KDFTqu5Zz1GgwNMrkcPXuFKEPm3TzaU+rNyGrsh3+YmRgxSdvCp9MgueJfJS?= =?us-ascii?Q?dir2bL1I+uxMeKYYq9R02mWty+fkXcEUVcWEoFl7ZIrJctlvPKf/cIJugQZ4?= =?us-ascii?Q?zeNdYgjQTaUg8GqUjZlPMo9rFu3fQYYOADMjDw1uj4bfNqFzTbrZM1TAxVY5?= =?us-ascii?Q?D6MZ0K52c1kaAnCcwuCSoUHEYotfyWk4PMVgU+CZw6h+4X5bCAacfhkflEoz?= =?us-ascii?Q?LZ/wUnmxPhYN5pFs6fc=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe94479f-2a1b-4768-593d-08db416df0aa X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2023 07:07:44.7413 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0egep4ypZreZfGA6UUERGX8OwBmV49V0zL4d3ULuizhtqJWE4r+f17woG+a5sDUmIgKrVGDy6XJA9b7CpWwyWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6637 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: abner.chang@amd.com > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Abdul Lateef Attar > ; Nickle Wang ; Igor Kulchytskyy > ; Tinh Nguyen > Subject: [edk2-platforms][PATCH V2 12/14] ManageabilityPkg: Add > Manageability PCDs >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Abner Chang >=20 > Add PCDs to control ManageabilityPkg > modules. >=20 > Signed-off-by: Abner Chang > Cc: Isaac Oram > Cc: Abdul Lateef Attar > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Tinh Nguyen > --- > Features/ManageabilityPkg/ManageabilityPkg.dec | 8 ++++++++ > .../Include/Dsc/Manageability.dsc | 16 +++++++++++++++- > Features/ManageabilityPkg/ManageabilityPkg.dsc | 10 ++++++++++ > 3 files changed, 33 insertions(+), 1 deletion(-) >=20 > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec > b/Features/ManageabilityPkg/ManageabilityPkg.dec > index 6b198e6a3c..6f58ab4f45 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dec > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec > @@ -68,3 +68,11 @@ > # @Prompt MCTP KCS (Memory mapped) I/O base address >=20 > gManageabilityPkgTokenSpaceGuid.PcdMctpKcsBaseAddress|0xca2|UINT32|0x > 00000004 >=20 > +[PcdsFeatureFlag] > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiEnable|FALSE|BO > OLEAN|0x10000001 > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilitySmmIpmiEnable|FALSE|B > OOLEAN|0x10000002 > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiEnable|FALSE|BO > OLEAN|0x10000003 > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable|FALSE|B > OOLEAN|0x10000004 > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable|FALSE|B > OOLEAN|0x10000005 > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferE > nable|FALSE|BOOLEAN|0x10000006 > + > diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > index 0fab562844..5e7cdb885f 100644 > --- a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > +++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > @@ -25,14 +25,28 @@ >=20 > PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiS= ervi > cesTablePointerLib.inf >=20 > [Components.IA32, Components.AARCH64] > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiEnable =3D=3D > TRUE > ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf > +!endif >=20 > [Components.X64, Components.AARCH64] > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiEnable =3D=3D > TRUE > ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf > +!endif >=20 > [Components.X64] > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilitySmmIpmiEnable =3D=3D > TRUE > ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf > +!endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable =3D=3D > TRUE > ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocolDxe.inf > +!endif > + > +!if > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferE > nable =3D=3D TRUE >=20 > ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosTransferDxe.i > nf > - ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > +!endif >=20 > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable =3D=3D > TRUE > + ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > +!endif > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc > b/Features/ManageabilityPkg/ManageabilityPkg.dsc > index 959b3eabd2..41a8957954 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc > @@ -28,6 +28,16 @@ > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE >=20 > + # > + # Manageability modules > + # > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiEnable > |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilitySmmIpmiEnable > |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiEnable > |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable > |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable > |TRUE > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferE > nable|TRUE > + > # > # Include common libraries > # > -- > 2.37.1.windows.1