Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

["Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>]

[-- Attachment #1: Type: text/plain, Size: 5390 bytes --]

Thanks Mike! I merged the pull request.

Regards,
Nickle

From: M M <mike.maslenkin@gmail.com>
Sent: Friday, February 23, 2024 7:32 PM
To: Nickle Wang <nicklew@nvidia.com>
Cc: devel@edk2.groups.io; Abner Chang <abner.chang@amd.com>; Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

External email: Use caution opening links or attachments

Hi Nickle,

I've updated commit message with your R-b and pushed it to PR.

Regards,
Mike.


On 23. 2. 2024., at 12:38, Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>> wrote:

Hi @Mike Maslenkin<mailto:mike.maslenkin@gmail.com>,

Can you please help me to add my reviewed-by to this commit message? https://github.com/tianocore/edk2-redfish-client/pull/76/commits/7110d17629d6131030a3c382ca46d9331e13f2af  Then I can merge this pull request.

Thanks,
Nickle

> -----Original Message-----
> From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Nickle Wang
> via groups.io<http://groups.io/>
> Sent: Thursday, February 22, 2024 10:14 AM
> To: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>; Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg:
> refine RedfishExternalResourceResourceFeatureCallback
>
> External email: Use caution opening links or attachments
>
>
> Thanks for addressing my comment.
>
>
> Reviewed-by: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
>
> Regards,
> Nickle
>
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>
> > Sent: Thursday, February 22, 2024 4:06 AM
> > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> > Cc: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>; Nickle Wang
> > <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>; Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>; Igor
> > Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> > Subject: [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine
> > RedfishExternalResourceResourceFeatureCallback
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Use local variable for BiosUri passed to HandleResource() to avoid
> > problems in case of Private->Uri is overriden down the call stack.
> >
> > Suggested-by: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> > Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> > Cc: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> > Cc: Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>
> > ---
> >  RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> > b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> > index f40f2d85af80..db77ed3dfccb 100644
> > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> > @@ -670,6 +670,7 @@ RedfishExternalResourceResourceFeatureCallback (
> >    REDFISH_SERVICE                  RedfishService;
> >
> >    REDFISH_RESOURCE_COMMON_PRIVATE  *Private;
> >
> >    EFI_STRING                       ResourceUri;
> >
> > +  EFI_STRING                       BiosUri;
> >
> >
> >
> >    if (FeatureAction != CallbackActionStartOperation) {
> >
> >      return EFI_UNSUPPORTED;
> >
> > @@ -707,19 +708,19 @@ RedfishExternalResourceResourceFeatureCallback (
> >    //
> >
> >    // Initialize collection path
> >
> >    //
> >
> > -  Private->Uri = RedfishGetUri (ResourceUri);
> >
> > -  if (Private->Uri == NULL) {
> >
> > +  BiosUri = RedfishGetUri (ResourceUri);
> >
> > +  if (BiosUri == NULL) {
> >
> >      ASSERT (FALSE);
> >
> >      FreePool (ResourceUri);
> >
> >      return EFI_OUT_OF_RESOURCES;
> >
> >    }
> >
> >
> >
> > -  Status = HandleResource (Private, Private->Uri);
> >
> > +  Status = HandleResource (Private, BiosUri);
> >
> >    if (EFI_ERROR (Status)) {
> >
> > -    DEBUG ((DEBUG_ERROR, "%a, process external resource: %a failed: %r\n",
> > __func__, Private->Uri, Status));
> >
> > +    DEBUG ((DEBUG_ERROR, "%a, process external resource: %s failed:
> > + %r\n", __func__, BiosUri, Status));
> >
> >    }
> >
> >
> >
> > -  FreePool (Private->Uri);
> >
> > +  FreePool (BiosUri);
> >
> >    FreePool (ResourceUri);
> >
> >    return Status;
> >
> >  }
> >
> > --
> > 2.32.0 (Apple Git-132)
>
>
>
> 
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115884): https://edk2.groups.io/g/devel/message/115884
Mute This Topic: https://groups.io/mt/104495956/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 19755 bytes --]