From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F19EE941954 for ; Fri, 23 Feb 2024 13:34:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MUmmwHYv0UxdfLragv/RQmgD73h5zoO75uCo9/lgAqY=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1708695245; v=1; b=Laalb1JXS3Lsp8Vbg+4KGwrEI+XvO5Eq7NiZ/3o/P+CDVWT9PyqYOcGtqrEtXAxcHJA2+YQ5 X5M62hLwmD1IrFbr9w5xtvkglr67vqqchV8FeT2xsnanp2pZIimVWo+DCjLW6pkvyE9A1qilRhD 98HTDy/xRdGZ7sXje7F02rS0= X-Received: by 127.0.0.2 with SMTP id zDj0YY7687511xME9CgGxJFP; Fri, 23 Feb 2024 05:34:05 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.61]) by mx.groups.io with SMTP id smtpd.web11.10523.1708695244456689794 for ; Fri, 23 Feb 2024 05:34:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lb+W2IvePrJJMujllCFMbi/VzvTaRP9K29w3qe+o2rWcDx6Ts6TDoD464J9SrhWBgjW56PiThUrs6cK6gXX2vaQANTm48GacnO3qBDG1KVt+GFZefTGSA2nGpUKPU4FDwdtwFLg5U+abnD5OSt4EOOtYitldGy78BdF+qgui4thmqbwjqjhCElrjfwk2Jwxk0CDe9OcAEE2C4t6bbH4gt4sgUJN1XAoYz5CFChw2zh8ajCyICtHBLUS00iQ0bWo/6RsOt6eFGPcKf5A05LIthx/5ykfugsrEBgUpL0kFquRh0OWPexrT4/ZZNc9Q+ifKhVJCdk7tRZSbLKSJaFYCRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EawSDimo0onIM6pLwEibOHPtElc1rEKte9r3NN5iZE0=; b=c838Ph7ho+1OwW+U1qqGxdsh+pXGQaVXZyvUS3lQC+L6GvVzlKM6mum4mQxYuNct35stZsnhHPXEmYkPLGk6nnMX1K6xvQnjtSraQLSNfH+Vm5iIlclEKfHgghaA4PkH8NasYr3Jw3zY+baTNxijCtmY37QXhTNLcZhLgSnDzCtUY6meN+Oa4a73/pJPRT2/DMV7MU20rFV6oTjkaF0iw02hjZt8T3Jt1shzxecukRbJCzy1jZGwsBedL7KDZoOu/X1EYXIvroOIX1QZfS8B0JYd2JZAcOwPiqrtNS6eJSfGZkX0h4sbbgwMbAzX3XXq+a9D6nENkcpedVcIh6TFqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by CY5PR12MB6573.namprd12.prod.outlook.com (2603:10b6:930:43::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.22; Fri, 23 Feb 2024 13:34:00 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::aa79:3ab0:fbcd:d61b]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::aa79:3ab0:fbcd:d61b%5]) with mapi id 15.20.7316.018; Fri, 23 Feb 2024 13:34:00 +0000 From: "Nickle Wang via groups.io" To: M M CC: "devel@edk2.groups.io" , Abner Chang , Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback Thread-Topic: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback Thread-Index: AQHaZQF7sLGBuss+uUC86C7mSphhCbEVn4CAgAIOKjCAACAcgIAAIgyQ Date: Fri, 23 Feb 2024 13:34:00 +0000 Message-ID: References: <20240221200628.74174-1-mike.maslenkin@gmail.com> <20240221200628.74174-3-mike.maslenkin@gmail.com> <17B60D9667B989F2.14827@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|CY5PR12MB6573:EE_ x-ms-office365-filtering-correlation-id: 67386edd-8405-4aa5-20ca-08dc347417d5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 2uhk1JgdnEfaJH37FdY4degEZefUIHhMb4KdONRomUj3y/tC/ui4XN54VC8K22E1L7GdIoqpST5hq9u+wpsaHajry2w3rbWWJPWTcsOLhABrwppMIZT7RykqkQo/InjR1tnITqcTO2gfVRqFyyaA9Llw3jfd8KUvHgOeKp5hCxSXl/Q+tMHh3YpLOKfV2CbhUl5bmZbwQCYJvkdZg6+ifa3+gGe4Cc21FW/AMS1Onv+O3AkKNO8DkoDqJ+H/GzzHuGdRgl1m/y76N0laWPsTNDs/knLsxTafWWHD52KmVOjLpUiVEQcdywB0gsKnR+NP/Rpwedu1nnYxswwAg65N7aOqq+XusO0MoCYeimMyfyQqSjxvrsdbLO/GscP91lAXHXD8jnt9Vd0cMS37IVHeD9WSllj4qM4vCA3rOH4czvyjvY7DlhYu8Jyc5IaMuZHEuNMIGJgTbp/nFJeID3q3OIyUVtvqUpjjQzU6vAAIysNRaQ+M3k/d6RfsONnLfgKOmIta1XRojUCQ+GG6L2zv6zNc+pkt12IVGVa9A5NqK5nFFS6Dgy+r40ZdgmzITgWu8Z7kGaLAWH+cpHgnS7aecc+Y19GRGoaO+ToNy0YlP2E= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?D0dxNAJPj7zWPiRYss5GEUT12HPZydaimEsyoTlSJ52ZqM891HWtPDsZL2nD?= =?us-ascii?Q?zJtNzSYZxol8n2unYt+5jYU1jBMnHdNVZh61zmXe8EfwI6niFuxGl8354BDV?= =?us-ascii?Q?5WKaVyojYwZ6lKnhttgqztBRoW/yk0ebjc19hFccdVk3Y7rzKuUVReEEXeqs?= =?us-ascii?Q?wiaFWzrAJRDjE/QSu0BCQNvDoErpbaEUwgQjDT7IqNGJehVH893ix55JrsHB?= =?us-ascii?Q?oBZ3FS4Tv6Kp2vEEwe0GILBlLPZJ6+QApdJC5m1unwCOFxKLJZ1NWz2zmz3R?= =?us-ascii?Q?ahecgu8uL39tT1upLLniGtyjQH24js/SXo2WupvECescRaPygniyLrcWP8io?= =?us-ascii?Q?VFxqvyJBioiM8PAq15RFEGzT/h9qwdSfTNjwRo9T5oeI37JNip6kVLuyeHQK?= =?us-ascii?Q?Z5eKi5kiOGg8wqQV8bjJaIYcl7H+wBqQ+QL7wkiiNugnwjuSCRZHvA8W7/zF?= =?us-ascii?Q?/59wKkJGL94AP8QsV/ZYxNJSaII64ZPKiogEVPMCbJm3uUoxLMhLmcIsdsIp?= =?us-ascii?Q?aywDX14fSGfaeDFzix3ZlY5fVJn0BfMlmUXL0bDSlUtIglAD6f3nz142C9qx?= =?us-ascii?Q?xxWfY7umHYtk6n5eYIXt3PrDhUY3uEF0Q4+WbMKSMiFHAAWYGf+fwbcdVYlz?= =?us-ascii?Q?KCGRGU9Z2KHy4H4qVP7TMymqPOT3iqVDBgBhZvtQPPSWmXm8sCIwZnbDp/Mm?= =?us-ascii?Q?5l/PqPv+oNItsB5NXUyVAtACn6EEYbgL+ekXQ2T36qpgXWIFTtz4TZYfEW6l?= =?us-ascii?Q?f0cDTzRlPe6yiIQKBPiuDe+X7mZKC8mSYASTItSrQTNSFK+VIP0Rh4WcJKWa?= =?us-ascii?Q?IFWfLJj9e6XBMs9vpRmNzJlucnNo2Hk4a2ydj4AiY7X0EYi3NiG27hIYFyIR?= =?us-ascii?Q?N0GBdmAn0nnjhBn98G/T5cLAu2uHSG3yuZhskaseHOXNiPK8gg5aMQEGH9cg?= =?us-ascii?Q?JvzMfrBkt6ydo031VMrbfZcPfIjGyQh1RMLkyh3ddc2IQxurEmhx8AGVfPUl?= =?us-ascii?Q?w4Xr/V32EGNfMq0qBDi+qOwPhl2rM6GMeKAJjP8HiCLshZozm+ZH1Ebaq6Ek?= =?us-ascii?Q?NtTU067Xwb97vRGZwtsbewuk82TA6r/I5Suq7kGgsKC436fq8hXvn813vr/x?= =?us-ascii?Q?wfio/gT+by8mziOk0PDKeiYBjyDR3s006puwLqzObWa1G5KNxipneMhRpgAD?= =?us-ascii?Q?/LqC30bCaP+OikVSEu6gH47ICskSX4DZOtIirdt76uqKD3yacwIovQZyElQN?= =?us-ascii?Q?F8VEkatDH82r2UfVh2AvU2HDMHJDoBjrzk1AixuBzKaWWrDxkGmB0qiZ1u6/?= =?us-ascii?Q?f8neVQVDdHh8Pba5wYVpYsvsif+8gqMOgNIhN8kGmxZlPt+C7i8GtY0HiqEg?= =?us-ascii?Q?EaHAWavC6VS1w/iJgld87yCNRMAhJhCXuwOlks20mEtShi9F3v1+jUvsDpWM?= =?us-ascii?Q?DsvBJCtRA+KV/KmBYMZJPaaRc/XsInbpz5WH3YCiPd1pYYF5G27UM+sGRdWl?= =?us-ascii?Q?+Yb1/lEkXia8fyf3M/iFztbupchvdqtaSnLgz5R7yVBeMSiHV1MrqUABcIAT?= =?us-ascii?Q?OQEnE748Qcgpe8gDlaw=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67386edd-8405-4aa5-20ca-08dc347417d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 13:34:00.0344 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XxCNhKSPaOI/mOVhCauLe5GB07fOsSZIvbtbWZ21i+dsKpmPESH0wtZMNcFizpbsvEwfSs1w/8Fjd1JK3oarUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6573 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Mh8y5X5c4tb7kjLMXDFyP1yTx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR12MB70312AB4DEAC33B5E162DD1ED9552MW4PR12MB7031namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Laalb1JX; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MW4PR12MB70312AB4DEAC33B5E162DD1ED9552MW4PR12MB7031namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Mike! I merged the pull request. Regards, Nickle From: M M Sent: Friday, February 23, 2024 7:32 PM To: Nickle Wang Cc: devel@edk2.groups.io; Abner Chang ; Igor Kulchytsk= yy Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClient= Pkg: refine RedfishExternalResourceResourceFeatureCallback External email: Use caution opening links or attachments Hi Nickle, I've updated commit message with your R-b and pushed it to PR. Regards, Mike. On 23. 2. 2024., at 12:38, Nickle Wang > wrote: Hi @Mike Maslenkin, Can you please help me to add my reviewed-by to this commit message? https:= //github.com/tianocore/edk2-redfish-client/pull/76/commits/7110d17629d61310= 30a3c382ca46d9331e13f2af Then I can merge this pull request. Thanks, Nickle > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Nickle Wang > via groups.io > Sent: Thursday, February 22, 2024 10:14 AM > To: Mike Maslenkin >; devel@edk2.groups.io > Cc: Abner Chang >; Igor K= ulchytskyy > > Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClie= ntPkg: > refine RedfishExternalResourceResourceFeatureCallback > > External email: Use caution opening links or attachments > > > Thanks for addressing my comment. > > > Reviewed-by: Nickle Wang > > > Regards, > Nickle > > > -----Original Message----- > > From: Mike Maslenkin > > > Sent: Thursday, February 22, 2024 4:06 AM > > To: devel@edk2.groups.io > > Cc: Mike Maslenkin >; Nickle Wang > > >; Abner Chang >; Igor > > Kulchytskyy > > > Subject: [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine > > RedfishExternalResourceResourceFeatureCallback > > > > External email: Use caution opening links or attachments > > > > > > Use local variable for BiosUri passed to HandleResource() to avoid > > problems in case of Private->Uri is overriden down the call stack. > > > > Suggested-by: Nickle Wang > > > Cc: Abner Chang > > > Cc: Nickle Wang > > > Cc: Igor Kulchytskyy > > > Signed-off-by: Mike Maslenkin > > > --- > > RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > > b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > > index f40f2d85af80..db77ed3dfccb 100644 > > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > > @@ -670,6 +670,7 @@ RedfishExternalResourceResourceFeatureCallback ( > > REDFISH_SERVICE RedfishService; > > > > REDFISH_RESOURCE_COMMON_PRIVATE *Private; > > > > EFI_STRING ResourceUri; > > > > + EFI_STRING BiosUri; > > > > > > > > if (FeatureAction !=3D CallbackActionStartOperation) { > > > > return EFI_UNSUPPORTED; > > > > @@ -707,19 +708,19 @@ RedfishExternalResourceResourceFeatureCallback ( > > // > > > > // Initialize collection path > > > > // > > > > - Private->Uri =3D RedfishGetUri (ResourceUri); > > > > - if (Private->Uri =3D=3D NULL) { > > > > + BiosUri =3D RedfishGetUri (ResourceUri); > > > > + if (BiosUri =3D=3D NULL) { > > > > ASSERT (FALSE); > > > > FreePool (ResourceUri); > > > > return EFI_OUT_OF_RESOURCES; > > > > } > > > > > > > > - Status =3D HandleResource (Private, Private->Uri); > > > > + Status =3D HandleResource (Private, BiosUri); > > > > if (EFI_ERROR (Status)) { > > > > - DEBUG ((DEBUG_ERROR, "%a, process external resource: %a failed: %r= \n", > > __func__, Private->Uri, Status)); > > > > + DEBUG ((DEBUG_ERROR, "%a, process external resource: %s failed: > > + %r\n", __func__, BiosUri, Status)); > > > > } > > > > > > > > - FreePool (Private->Uri); > > > > + FreePool (BiosUri); > > > > FreePool (ResourceUri); > > > > return Status; > > > > } > > > > -- > > 2.32.0 (Apple Git-132) > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115884): https://edk2.groups.io/g/devel/message/115884 Mute This Topic: https://groups.io/mt/104495956/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MW4PR12MB70312AB4DEAC33B5E162DD1ED9552MW4PR12MB7031namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Thanks Mike! I merged the pull request.

 

Regards,

Nickle

 

From: M M <mike.maslenkin@gmail.com> Sent: Friday, February 23, 2024 7:32 PM
To: Nickle Wang <nicklew@nvidia.com>
Cc: devel@edk2.groups.io; Abner Chang <abner.chang@amd.com>; I= gor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] Redfis= hClientPkg: refine RedfishExternalResourceResourceFeatureCallback

 

External email: Use caution opening l= inks or attachments

 

Hi Nickle,

 

I've updated commit message with your R-b and pushed= it to PR.

 

Regards,

Mike.



On 23. 2. 2024., at 12:38, Nickle Wang <nicklew@nvidia.com> wrote:=

 

 

Can you please help me to add my reviewed-by to this= commit message? https://g= ithub.com/tianocore/edk2-redfish-client/pull/76/commits/7110d17629d6131030a= 3c382ca46d9331e13f2af  Then I can merge this pull request.

 

Thanks,

Nickle

 

> -----Original Message-----

> From:&nbs= p;devel@edk2.groups.io&n= bsp;<devel@edk2.groups.io> On Behalf Of Nickle Wang

> via = groups.i= o

> Sent: Thursday, February 22, 2024 10:14 AM=

> Cc: Abner Chang <abner.chang@amd.com>= ;; Igor Kulchytskyy <igork@ami.com>

> Subject: Re: [edk2-devel] [edk2-redfish-client]= [PATCH v2 2/4] RedfishClientPkg:

> refine RedfishExternalResourceResourceFeatureCa= llback

> 

> External email: Use caution opening links or at= tachments

> 

> 

> Thanks for addressing my comment.

> 

> 

> Reviewed-by: Nickle Wang <n= icklew@nvidia.com>

> 

> Regards,

> Nickle

> 

> > -----Original Message-----

> > From: Mike Maslenkin <mike.maslenkin@gmail.com>

> > Sent: Thursday, February 22, 2024 4:06 AM<= o:p>

> > To:&= nbsp;devel@edk2.groups.io

> > Cc: Mike Maslenkin <mike.maslenkin@gmail.com>; Nickle Wang

> > Subject: [edk2-redfish-client][PATCH v2 2/= 4] RedfishClientPkg: refine

> > RedfishExternalResourceResourceFeatureCall= back

> >

> > External email: Use caution opening links = or attachments

> >

> >

> > Use local variable for BiosUri passed to H= andleResource() to avoid

> > problems in case of Private->Uri is ove= rriden down the call stack.

> >

> > Suggested-by: Nickle Wang <nicklew@nvidia.com>

> > Cc: Abner Chang <abne= r.chang@amd.com>

> > Cc: Nickle Wang <nickl= ew@nvidia.com>

> > Cc: Igor Kulchytskyy <igork= @ami.com>

> > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>

> > ---

> >  RedfishClientPkg/Features/Bios/v1_0_= 9/Dxe/BiosDxe.c | 11 ++++++-----

> >  1 file changed, 6 insertions(+), 5 d= eletions(-)

> >

> > diff --git a/RedfishClientPkg/Features/Bio= s/v1_0_9/Dxe/BiosDxe.c

> > b/RedfishClientPkg/Features/Bios/v1_0_9/Dx= e/BiosDxe.c

> > index f40f2d85af80..db77ed3dfccb 100644

> > --- a/RedfishClientPkg/Features/Bios/v1_0_= 9/Dxe/BiosDxe.c

> > +++ b/RedfishClientPkg/Features/Bios/v1_0_= 9/Dxe/BiosDxe.c

> > @@ -670,6 +670,7 @@ RedfishExternalResourc= eResourceFeatureCallback (

> >    REDFISH_SERVICE &nb= sp;            =     RedfishService;

> >

> >    REDFISH_RESOURCE_COMMON_= PRIVATE  *Private;

> >

> >    EFI_STRING  &n= bsp;            = ;        ResourceUri;

> >

> > +  EFI_STRING    =             &nb= sp;      BiosUri;

> >

> >

> >

> >    if (FeatureAction !=3D C= allbackActionStartOperation) {

> >

> >      return EFI_U= NSUPPORTED;

> >

> > @@ -707,19 +708,19 @@ RedfishExternalResou= rceResourceFeatureCallback (

> >    //

> >

> >    // Initialize collection= path

> >

> >    //

> >

> > -  Private->Uri =3D RedfishGetUri = (ResourceUri);

> >

> > -  if (Private->Uri =3D=3D NULL) {=

> >

> > +  BiosUri =3D RedfishGetUri (Resourc= eUri);

> >

> > +  if (BiosUri =3D=3D NULL) {

> >

> >      ASSERT (FALS= E);

> >

> >      FreePool (Re= sourceUri);

> >

> >      return EFI_O= UT_OF_RESOURCES;

> >

> >    }

> >

> >

> >

> > -  Status =3D HandleResource (Private= , Private->Uri);

> >

> > +  Status =3D HandleResource (Private= , BiosUri);

> >

> >    if (EFI_ERROR (Status)) = {

> >

> > -    DEBUG ((DEBUG_ERROR, &= quot;%a, process external resource: %a failed: %r\n",

> > __func__, Private->Uri, Status));<= /o:p>

> >

> > +    DEBUG ((DEBUG_ERROR, &= quot;%a, process external resource: %s failed:

> > + %r\n", __func__, BiosUri, Status));=

> >

> >    }

> >

> >

> >

> > -  FreePool (Private->Uri);

> >

> > +  FreePool (BiosUri);

> >

> >    FreePool (ResourceUri);<= o:p>

> >

> >    return Status;

> >

> >  }

> >

> > --

> > 2.32.0 (Apple Git-132)

> 

> 

> 

>

> 

 

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#115884) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MW4PR12MB70312AB4DEAC33B5E162DD1ED9552MW4PR12MB7031namp_--