From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 633EAAC0D06 for ; Mon, 28 Aug 2023 09:03:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=VntRUwoZAo+jolAUX+RTAtu/1oqCl7qCq85ES8uD1GU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693213404; v=1; b=DqEbcWGfx94oObFtWgQcwN69YVWpxiFZE/Smq14G1eeAkVQHv8mZIeQkRSAKKwccDmKQailq 1UOVmrpwjRLOS3Jg4Z1zLLGxeEcO/+6hhw6tVmpiV3Q9WKxicvS2mh4F7+1q2rbTEyV6vVJlvZm XhAczkXnT0kRrGVMxi3fq88c= X-Received: by 127.0.0.2 with SMTP id bVgGYY7687511xtup2RO8qAh; Mon, 28 Aug 2023 02:03:24 -0700 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (NAM04-BN8-obe.outbound.protection.outlook.com [40.107.100.70]) by mx.groups.io with SMTP id smtpd.web11.9424.1693213403202629359 for ; Mon, 28 Aug 2023 02:03:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hK1kF/HMU0SqDGaAViqzDhk+OY2nGryui55vc06/bQECBefaE3w6jBGAsq90b3UuFtDmNKo6Ggx7d8CeIRjp2rOaPGcDJHD8+L0WRoLt/bO2g3I5UzrPmWdESYetpzjVkzD2Sx6d17JS5uTZujXiplwxtM0/UNer0aO1mUH9CQU4EK5ZPkbXTY42j40NuwOWX+sdMJvVEDV68BVWZmp3KiAMVd0sPQr506RvHqcLVcbhkBD8ZfuIbCKqU7mfujP2oF8FYrDAHRzpJkXtmfGKbx5Xvv4sZs6u6EfRjkb+64nWUKle7PQRefyjEVVKtnfeAHxwLiRiXUuakPjUwfpXkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yt+b0rAaxVcD84gIm2e3ZfCE+yVwAwQQozdut5wXei8=; b=R/Fpxf1cXuKzOzGHu95Rb5jLMcPwfJ2zL78o1C9MjUADlGFiSlYe+lX29mIJrztoDWVVkbXM6pE1oJKmrPA6A/Z+msXIYiD6C3faxVh+30R2b6R+uDN3kzuMW4vFpCr6Dwyh5OyhxUebpmXGE1goEVNYU5QVqE5t8O/orssCMzuEmJ7/36Cz+O5w1CANPMBQSrkQ0oz4SECwKczlPD7PsOmQoV3FBvTsGEnIbsyrU8O6/sWW3hXqd/t25dX4YpakTu5m4GbXAkNQ2TAFPmxyGs0rn2rN24QomFUpSk1VxHSMLNwLBRS4nAkAfCUjczrMH6Yc3+mRyEhfE9CqSfyckQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by IA1PR12MB8310.namprd12.prod.outlook.com (2603:10b6:208:3ff::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.34; Mon, 28 Aug 2023 09:03:19 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::1390:de0a:6b46:9837]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::1390:de0a:6b46:9837%7]) with mapi id 15.20.6699.035; Mon, 28 Aug 2023 09:03:19 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "abner.chang@amd.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH 0/5] RedfishClientPkg: fix issues with local variables. Thread-Topic: [PATCH 0/5] RedfishClientPkg: fix issues with local variables. Thread-Index: AQHZ2NVCa0YdJd+H/UimFP4YnECZHq//aI+A Date: Mon, 28 Aug 2023 09:03:19 +0000 Message-ID: References: <20230827105640.94731-1-mike.maslenkin@gmail.com> In-Reply-To: <20230827105640.94731-1-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|IA1PR12MB8310:EE_ x-ms-office365-filtering-correlation-id: d512e3d7-0f90-41c7-f5d6-08dba7a59fd1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: dPK1bJLknjB4LieUpPP9zf8w+OnkzeR0ir7lplyLvR/htooY4iklvIAz2vm/PX3Oa9H5PsAwOENEAIGxsFVx6r8GMcK5KTnGenp/zPr3rGI+x5fMx590dhy95kefQMizsGuNnxpEyaMrmN9Rysd5WghitJsQg88jVBRlyi5lXtoL9Wn8Rmkm7kBI89cACudAPfZhuR9lRdUEP6oiBmOll5VcEehz6AdEhF4V9VMasqNrIatguRHbuDP1DEdeo1e6Rkkv7aNU6ZKpCGs2K3izAS1ivXhaUFj6P3xGEmYyjgTzz2xKWV5NkLnN53kxLBjTAIdAFS86o34QnwQ/o7xLYSU8abNDFYqEodgDlVkRoItGWE6mU3d9latnXP0GwnOb7UdnUqyp8ay9/gccX9RpFjXQkuqZNJ4aaMbsYpVpQzkuGRHOJeYreI8JgCnD5YGqdPScMa3iEq2pRztep7vkC5tvRGIY7GGUOTowBrH7AEKkMezPfPR7BN6fOVwW8iAMqJXUnm+w3URPMXvY/o6kB34FQV0Ag2XUCBtCEFCgPlq9PIOdmwft/Q4OhlIOLh8LWFMpRgEgtQ83TE31ur5kKGyLc6PPGxHDFwWVKetJTgaVAjPpddJYxuPQ6l7KGr/3gGIUxjOX75nb4AffAadUng== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NYKe02h/tLA63dDuo6FjiwSgF5a1HHumECFQxfwfFm65YPG1PGsB7wAlODwt?= =?us-ascii?Q?oxwSeDC2Ht97ycIMSyK3XnPu6TAKHyeIERWaFjxW+S7FxDZmnmeJvdLZMIGr?= =?us-ascii?Q?2dMEabZvGziBcEMzaSfLe2eS6ThxZ6Pa+On9mEupkRvs41nTm0KTMyq00ijp?= =?us-ascii?Q?yKOjZEffZ1CdS4wMlaQJdtA+1Zd4on+iUtQH2qFZiOZaCizjm/7nJ0XkzukO?= =?us-ascii?Q?dKSWALj0WloFEdGIW81QszuQDL7PdpLxtyQhHA54oUAuHnYqEWEJj3JO/+rg?= =?us-ascii?Q?HLQlej4kFieKrzil0QG5wVuer7IHrpBZir6io0n2YM3d1uHN5PNafr8Ff2qZ?= =?us-ascii?Q?iZF7E5twLRwAqjG9h8w6ndgNbRxxJ7GwLLMf65dxupXmIZpH9ZfYpRy7GLs+?= =?us-ascii?Q?HtNC4Q5RG2QPbc7wkcFxDjW8/Ys3+K/61CqVUW4Ls8IZvW7KOR3DfdVkWJwX?= =?us-ascii?Q?V+VZ97QJD0znOrHVvCzfzes9ACExdjn0ekZUcEYPvIy8oyc9wWNyaB2orhqz?= =?us-ascii?Q?+yW1syki0rDgAS67smAf2KP10CJwI0FEab5JI9ftLac9nvYe8wwlMNhUs6Lh?= =?us-ascii?Q?fi1h5qq+jhaCrt6UK0jBResYBOi2IGed+qSqDs8y+h6Dntq2AlCTVmSSfyPR?= =?us-ascii?Q?BdiTwHSvh4B/QlaetOARBGFhimaVAUmTfG8GtvsZi9pmuN62hcaBdc6OwKdj?= =?us-ascii?Q?gtqRJ8TsZU8QCom0CKMU0jfrRvnmbB3pUNWbw8qUvhKhMcnpmz/nAMC5FTG0?= =?us-ascii?Q?o0ZHkUj0FOXNAyRIMopUMSv9j+Vq5tFidnr5skqiPSZJ3giQ8IGXfdmGSarX?= =?us-ascii?Q?8RJxffjK04ZlgRm1Kv0y0cHQ+HFo9zlGGZpVhdRqqGXrygrV+b7M2qbQbUS6?= =?us-ascii?Q?CQ51RKvA7ksEUKOOMAyMHPC7IuL7+sqoQqWlAF7tP1V5CEGm+X07p0p4cu2I?= =?us-ascii?Q?2sLPfA3AWpa0r6eMcyzfzz1Q6QOGidK/z6yvfutP2cIijNmMKeElsCqQML9l?= =?us-ascii?Q?09blqO8L04ksCUVBDtiYC/xd7+dU3leI9MihMVpOGyQsyiEzy0ZVvx+r5/GK?= =?us-ascii?Q?VoLqVnyQjoZLeKU6ULsYAIHVmeRWxfr5qWh1v31937r6DNRslwSRMJlu1KzO?= =?us-ascii?Q?G/ptR159EgcNN4VlAQEJO/LUg0CNOVthK1e9Dl60/sBgUqIG0BXWuDEIaeOP?= =?us-ascii?Q?ZtCiKDm62SKmysB/3en3ts4eTT2c0ixuL2Z92SVCt2zf5zYl1zucTTg+1T3y?= =?us-ascii?Q?cw5ywRXW8z4vPO3zsqcIVepnHwxLO9ifqvwlgAkNzSoIOPiOR+0jjFJJiuWh?= =?us-ascii?Q?weZnIklTQtKRey4rEz7GatUQogVd+pf3bSr88rW+h2gBZzUyXOS1gJHKTywh?= =?us-ascii?Q?gSKnv41Y4TPQ6rUgx4fKkSOz2vfhVHNw5b18S3yfXnrHR6VitHP0KyJb+5Sl?= =?us-ascii?Q?VHQlTAwPsIodRZ6fK+bee4swAsu/0JoISQfSpVl69z3qzMbKCKcq8X18oJKm?= =?us-ascii?Q?Ed4aK75wczv7qszbjuG5VU5eKTWe72hUJkYBnAjDrk1ImPMKVwniiAdJlQ?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d512e3d7-0f90-41c7-f5d6-08dba7a59fd1 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2023 09:03:19.5565 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9JDPPajpOu5IuBqyiIatrOlcR+8whgSy5Pq9tRsb+7lViKbkHeeTDHxpy4k2r5rdedhJQReOOvrc+ciRSmRppw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8310 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uiKaIBu1yW83VCDEUuriq2uix7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Spam-Flag: yes X-Spam-Level: ************ X-GND-Spam-Score: 190 X-GND-Status: SPAM Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=DqEbcWGf; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Mike, > I didn't find any codyng-style issues in uncrustify output. I fetch your branch and run uncrustify tool to fix error in vs code editor.= I push the fix to your branch at this commit for your reference: https://g= ithub.com/ghbaccount/edk2-redfish-client/commit/f22209f7bd5946168326a319700= 6d92856247d35 The uncrustify check on PR is now passed successfully. My com= mit breaks patch check as expected, please incorporate my changes with your= s and do a force push to this PR again. For the way of fixing uncrustify error, I am using the instructions here: h= ttps://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting= #recommended-usage-visual-studio-vs-code-plugin Thanks, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Sunday, August 27, 2023 6:57 PM > To: devel@edk2.groups.io > Cc: abner.chang@amd.com; Nickle Wang ; > igork@ami.com; Mike Maslenkin > Subject: [PATCH 0/5] RedfishClientPkg: fix issues with local variables. > > External email: Use caution opening links or attachments > > > This patchset contains fixes that resolve crashes while working with unin= itialized > variables and a number of fixes for of leaked memory. > Note: looks like uncrustify check is broken at tianocore/edk2-redfish-cli= ent repo, > the corresponding PR failed: > https://github.co/ > m%2Ftianocore%2Fedk2-redfish- > client%2Fpull%2F46&data=3D05%7C01%7Cnicklew%40nvidia.com%7C7cf336153fb > f4e2e821008dba6ec62e0%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0 > %7C638287306436105158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C > &sdata=3DVUxJA017msZzRYd%2FAxi0KeZvLi2s0QI6uKgHsOuDdws%3D&reserved=3D0 > > I didn't find any codyng-style issues in uncrustify output. > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108053): https://edk2.groups.io/g/devel/message/108053 Mute This Topic: https://groups.io/mt/100988470/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-