From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 48F4F94139C for ; Wed, 21 Feb 2024 07:23:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=sQ5Yw+cTLuCS/qC198/n5LZ8CfM7WQS3S2NOwnOK6gM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708500187; v=1; b=Cl/SGeTwN14SJuRyXjlIeQlD1sgwGsdUaekovsRdDIjruwpojfkQzSm/vMTvwU2iMg5E6ovF 0oV3piHGveN4/SBcUD1jGb5NA6fG1XrqWwqG8R/ouSqxsKgw8q+mGgg79nLjC4x4ApGh3QSqxXi Wv+T92cgzVcT2tnN0KEgTSGQ= X-Received: by 127.0.0.2 with SMTP id g8ZSYY7687511xiP7mCyYmcO; Tue, 20 Feb 2024 23:23:07 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.45]) by mx.groups.io with SMTP id smtpd.web10.8136.1708500187008303257 for ; Tue, 20 Feb 2024 23:23:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gg6fmd98IKTB3HDB2I7lNnBOJQ9BOXT2yPKIHlSz14ACpUjH/n5jsOKFFeX20+ik+1xsRrk9bJni6KNN7MAgVIjYsVXn2jD9vNKiRqYTPpucoB5r0M+WKaWEq3hbtTrTGi8HrqaR8ewIl4ycRKTzz7RfH/1l6dtqfZZ8cF/vBALuk9c080J9EnhnogHjxj99AbyQ+5Zbd0E4WPHyRwVIGh9TPu83ONpQrGtSkHTWKJTmmwm4lCK9ckp87XfN+hvSu+sRMakYFRqtd3faSqRKAZ1C9F83gNS+tcJQSxyTZPWYelSFQES+KV4K+DqGYBGKYevudkJ3/CgaJMm50+aXXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OyqMJZw5yCvVtu9q/uT0XexnFqdk7GybxLS5C11EUWU=; b=WeecRaDwseWLFo6MT5uRq7VAtAdkv0ZkfIARg2bkT4DXQku1OkNAx1jq6kzQrpDTVcFR57PAybp+WOQ/HqIFMtuqJiAZHQEZh9y6Kg3vzRG/aya8yc4lHtyTyGgyWp5cD9S1cQqFySToH+aKSkmZ9x5rfwFPdxwLQrBjThca9c6x80C/2c+wt6H43RNOkDwC3x/HvWrwL8eiaTLY4CGB4XZ/kJh9HDAk1Ja23KZzBX0GvKbGjzt+ckOQbFBg28hO/TPIpVqMuphKMEB7At3wjEt3p9WtHxUvt5kGp5hBExSMNSNalzBg3JvOe9mQNr4XBffgKMWZKGL3UgIZRj4w2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by PH7PR12MB9150.namprd12.prod.outlook.com (2603:10b6:510:2eb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.20; Wed, 21 Feb 2024 07:23:03 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::aa79:3ab0:fbcd:d61b]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::aa79:3ab0:fbcd:d61b%5]) with mapi id 15.20.7316.018; Wed, 21 Feb 2024 07:23:03 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Abner Chang Subject: Re: [edk2-devel] [PATCH 1/4] RedfishClientPkg/RedfishFeatureUtilityLib: fix memory leak on error path Thread-Topic: [PATCH 1/4] RedfishClientPkg/RedfishFeatureUtilityLib: fix memory leak on error path Thread-Index: AQHaZFrBcLTli2s5/Ei6Il1XPPck1LEUZNkw Date: Wed, 21 Feb 2024 07:23:03 +0000 Message-ID: References: <20240221001303.57384-1-mike.maslenkin@gmail.com> <20240221001303.57384-2-mike.maslenkin@gmail.com> In-Reply-To: <20240221001303.57384-2-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|PH7PR12MB9150:EE_ x-ms-office365-filtering-correlation-id: a51d31f3-1b7f-4228-30a4-08dc32adf0f8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: R+PwB9/TnY5YsO+llaZBy5yyTcxugzJMyKFpf4+XTpm0GYm4HrI74RXqVuv0YV7DowEhumwxJwQ/SU8EJIieV9K6nEwzPeDNQGJYZxqyYDbW1JknS2quImZDAAfFoHIRvjEBp9PA+okayq0w2yk4fpKHu869hEaX6vbfccYBfRppfp/stIv/DYXDmve+DFGxy7I1w8xrS/Sm1W1u8kUCEklQcj+rPilohrggSfQNpbGHIBb57wqsotqgKQDh5yJDzawd9aex6iY8QQx9RizrS7S6nGoYcGm+h37ySGSt0FxcJngeRHs8RhDUvGPC8RfN6ITyBD0zus3B6RIXgW9NpBEW8F7xEOWBg/stjRkJ9T5tNF10Pfzn3EJq3DA3kE5nQQGmqrEqooxoyPE0gUO/D++uEYpJt8mX9PaRsl/lDk9euJfccOIw8VemCtFkiKxMtQFpopvREXdicgIfEGKzp8c+jfOCaEuQvFl839ttwmT5OAZsjYCjdT/S7xRfcpQ9XRJQMkx5rDnrUTu8HXVMQ0PbdCH/aEAKTGP95eyZWYBTlfs7MAZPurICI70+lFLf/q4u6AOz77OXVB9dpQxNbKTL/RxXvVsjbPb8FBF8RDSjmfeaQF0FJdPikxMRkaMT x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gnG3FzHMDmmTCu6lwxOeTuBqjOY9i75Fbe62AWqHR68ysq1IoWDNWGuK7q/U?= =?us-ascii?Q?bSE7UQkwnakTTEpdzDFSH5f8wlxLB39qfp8z2GNFneHVfSFFpN16ttAS5yY9?= =?us-ascii?Q?rh0MWTqsvSWYVwSL+iZY0HJokgTFQ1bSyQBUsCP8vb4xLOx1JX0Gr8TxSrKi?= =?us-ascii?Q?OFNAFbSPanRMil/LtIA/kluBbue4rsaklZY7jMdas9LitKSR5CIiRvmoORjB?= =?us-ascii?Q?zL1RRu8Gr2r5GiTkEFuZrsmssCwIQLkiSfwkK/lN/fBs8YbjuuwEldhTa5/A?= =?us-ascii?Q?zUYg9oSSRzVd1m6+RU4QnvbfDhp9+0W06CR3ukYENdZmdtpTDxCfIGXzJnMW?= =?us-ascii?Q?naW+YJpWqxkRhLgx+LkJPz2RkK46u8beBifLVK0+HO1RBrdeox/HL+vifW/N?= =?us-ascii?Q?ox/e7qgNrxHc/cPgEAv6+3Bb4RIDznaH63fExxacM2qEOQcPgWj5dck5V5Ma?= =?us-ascii?Q?umh77lEF4lf/aMU+Vgy9uoF4Zcu8ySFvH8UcPvoJSfj51k+YoRZooKWoQTld?= =?us-ascii?Q?30h6G7K10XO4yw4JnFg5Fuq+FT5eXPOwzSPLT5OHefjjYCQVEsSKXIvs+6cA?= =?us-ascii?Q?tnzAeJTlpxWk2l7FI+t3QmZQEzPCP2JlF5cdk2L3SfzAI8HHYadeXhTHIZDu?= =?us-ascii?Q?C7NTn42Xsuos9AbLG80WU8vvXwmtE2zfrAnUyiCGPf1+WxmHaUYL+fvGa1yf?= =?us-ascii?Q?c+2VRrzgQbe8h22NDixv847aPzSbuaRqYTHsuo3O74zDCCaqZbmYuiAY4luK?= =?us-ascii?Q?JdaG/rr4EfBAFXxQTKbE8xrJK8ZLjByynT+X0Mc/R9GL5fnSCTh2AXvJhd4i?= =?us-ascii?Q?iWNpYvwZc0xj1+zHmdOeS9cIK8ARlFyeroJjqgdExYSO5p5bF2h2ovu4QfF3?= =?us-ascii?Q?3gM/NDeNILgzpNtJrwJUoKlyOq0WKbSxudD0Dc8HnehEWF8UE2JLRnLys1dA?= =?us-ascii?Q?WPylpMJBJiO0/RC2hXvvm9/QqpqHVSWCYRnACSJ6lTO6MjLS946xmvlJuCRw?= =?us-ascii?Q?ylGMDaYZUJhoExYbpGUEjidB9rjqCKi/kZPp20ycyUBLOsefFi+PdbByxSdn?= =?us-ascii?Q?cpa89enwvGX0WtXbyESiXGr4Kj0PIAcXN2bM2NhYkTQ1kJvjbQ/6NxRo5reK?= =?us-ascii?Q?TkpBCAvhpW3xrMd6Cm7DdFyZwmxBximARLRv7Gwhg2eY/TJEkxFuIUC5upnu?= =?us-ascii?Q?z4ekN8vUFBzEOAfSH+1X6TObb2qr3w/UZVQq5gdgGyQQo3CpnLl0eBw3EskS?= =?us-ascii?Q?p7+n9Xp2RXtzKqLo1zdQp9Uzg54WtnOAlzGJqdgBoGIcIk59/uW4FYoyz0bm?= =?us-ascii?Q?3dm3JuvTQKab0/yKLARuAKDMZEZpVY3FbhZBFLelszIjGZND2QW95AmI7PcT?= =?us-ascii?Q?8UVclZyWHyADNO0c0Av1VVank3hPwa3EuKPfOkqxGPP+tuPUsxOfIQKnezLL?= =?us-ascii?Q?/iJ9s64teEzuGQUYxD+UShMz1PDtgB2yIJR+tNE10daPRPjpTxJS2qL5mJwy?= =?us-ascii?Q?BNguw7j/LYaUrjngLWnfLjmvDzBcIar7s53yNrMfPCiVuOLfI12Q6sEkKuQq?= =?us-ascii?Q?rUFgGjt9JS7n/dM769M=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a51d31f3-1b7f-4228-30a4-08dc32adf0f8 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 07:23:03.3047 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yhKz+im+1S/wwEPIVBb/t7i9eDB45e23/urUc9AIkk6QyLvuMnf7q5nFD7d7FI9Ok42rIfOZnN+rgY5N2XmeNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9150 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: cc99ONQ7A0B63l6DDTyg3EQyx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Cl/SGeTw"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Wednesday, February 21, 2024 8:13 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Igor Kulchytskyy > ; Nickle Wang ; Abner Chang > > Subject: [PATCH 1/4] RedfishClientPkg/RedfishFeatureUtilityLib: fix memor= y leak > on error path >=20 > External email: Use caution opening links or attachments >=20 >=20 > Cc: Igor Kulchytskyy > Cc: Nickle Wang > Signed-off-by: Mike Maslenkin > Reviewed-by: Abner Chang > --- > .../Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib.c > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib.c > index e1494471038c..21ce8ddad9d5 100644 > --- > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib.c > +++ > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib.c > @@ -4010,6 +4010,7 @@ RedfishRemoveUnchangeableProperties ( > (RedfishCS_uint32)AsciiStrSize (*JsonString) >=20 > ); >=20 > if (Status !=3D RedfishCS_status_success) { >=20 > + FreePool (UpdatedJsonString); >=20 > return EFI_DEVICE_ERROR; >=20 > } >=20 >=20 >=20 > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115715): https://edk2.groups.io/g/devel/message/115715 Mute This Topic: https://groups.io/mt/104479571/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-