From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C7DA4740051 for ; Thu, 26 Oct 2023 13:20:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=BR3BX7VC6uUD/L8LwiWuPx7xdSCz/eWLT9CZ62p+Rks=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698326423; v=1; b=rgmmuNw3AmnJ9wkoy2NaZ9qledqXfhizZkbrCRzoA1zdFejX2Mixj5Nfzs8uMRxiDLNDZiGl K8IuEn4g7zeL6jhR+TI6ZEsklbdN4G0Ki0QBx3Pw722A3EWFVzS3zq5730jX3IkHhZs7hm2KPS5 XypHjKLXN8tFQANioZ3yanE8= X-Received: by 127.0.0.2 with SMTP id bKj8YY7687511x2ri43lJb9I; Thu, 26 Oct 2023 06:20:23 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web11.70225.1698326422663165358 for ; Thu, 26 Oct 2023 06:20:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oGJ8+n3BZltwcy0PejHlNtzX5D3DNdBbRgBUPyK+zZgHVG2Tq5x25gduKQatSUDIGhROO+b2gMMKVSAoUmP6Cqn7QkFmvaJcUoElQg9+apN32Ts2gq5wdlkebZicRcZcMT/a2Dydy6BLyS8Y4UkohLSgLRIZPiDxm+1uLtBz/y/xZi92jfbO4junetH9nzvKo1PQ9CsPJRkKXI07FlfNohaH3QNz5yNwBeKWxfei9XHcyygOr+0KYWAE7pqRf12ZUUeGDVzYahjvET6U+jChxnVj7E/SeyXeiRZK/150mk93X174IZddVWiEkIXtmuQggzTNMxwoZH/q1j3f4h+BZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YzjscbB+CVd12oy+DuUAyLzJ+D9oXsSisefdr+XyoR4=; b=LTwmu+AHxfHU1OhkHuEtX8Wz4LwUbQAcicWgCpoTqne7OfgBjQ0ga6KCsHoPWlgJ26olG/U3I3oo+QijlpRgmjTooXOoxptc1BQvZAvgDBQ81dTRNB9kbe3BEXJ8OznTAMTpCnxMfDlGJK+03r/NBH+CwAXLq3xbXRjSDUSQXqbegnOXXWjy+W6LNd1tIEZfVmjuktwtTW4OQ8yD/bDJgk6cnXUvnJMFgX7rPX9hSDfHFdTJMROIupkDOqLrC93ctFTwiUNk02JFEIfnHMb2DzcVOkDvLTNwyqFOpI2wJOmVZX86BTilbfmSOVVmOBI46r9JKnh4tSH1gNywvmieDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by SJ0PR12MB5673.namprd12.prod.outlook.com (2603:10b6:a03:42b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.19; Thu, 26 Oct 2023 13:20:17 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9e7:5f16:2a5a:7be]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9e7:5f16:2a5a:7be%4]) with mapi id 15.20.6907.032; Thu, 26 Oct 2023 13:20:17 +0000 From: "Nickle Wang via groups.io" To: Igor Kulchytskyy , "Chang, Abner" , "devel@edk2.groups.io" CC: Nick Ramirez Subject: Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller Thread-Topic: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller Thread-Index: AQHaBlWyEJtthRqT+UuBsO9C4/wzpLBbmWhQgABvrYCAAACmIIAABNoAgAAA2+A= Date: Thu, 26 Oct 2023 13:20:17 +0000 Message-ID: References: <20231024083944.16275-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=cfbc3f75-dde8-4c77-a5a6-b619356f2f83;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-26T06:09:54Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|SJ0PR12MB5673:EE_ x-ms-office365-filtering-correlation-id: 04772806-8cbc-4c82-e7e8-08dbd6264c1a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: a9JYVrf5QrlZN3N+OMuqPz8oaXCzgGap2W6EOY16OIb2JVqMW/sPt5lh2TpQsKPu4wzvdJ0quLTeFtO47xpPe/y46vbDcSdFp3MzMoYkQisTjAfgWcBo8T615RyDobnOEsRQk3u8McpNIgvtJKsaCVz69A6s+YTVT9YswieTJLOEx313WjIPbvJoGVtrUA1RnZj3Im1SNM6Le+mHYzi3o9KSaAM+asdMjUXa62vQ3yQzWgaMeZSthWor6NXhlQKCAjaKVK8VyHc+aUP6jqrHPtUdp2NDObzjWeP8aV2Aw5B2ylccoCz8hXFM558IlIydRQA+ovnN6Oj+Cgy34wciTDWx4/H+va5ukY+YocJOiLUlb4/ww3X9NxowAxr743FUp8gCH2jBrTDUKTfLwA/jNoK5ZiF4XILKByOqPvRDK+Syai2a5WQNuraourJBxj9TfgJ/ghWQudg7J842SvQNyWMLUruAK+7Rl/GCTQNcIElaXrRLz2qXzUpvfGpdh5djBKCueP5pBOcuGFeX+MiswVjuDWVmqbxTNPdvsYGIxmNtwhLXpgtADe4vi4uMJRF7SMpPNqbDQocKHJijvEahKUeb5bUe/fuWVYw/X636XrSOBDFTblgLgZRWQLLG1SWh x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9tbVBuN5BS5+37/7Ar3k9UZe0dvVmd5MZuSd0WG51b+mfzuielEh7O71JccX?= =?us-ascii?Q?u3l8JDFs+L3q33fIZJ3/seg1cwZwXtQuyV0pWYy+Ql/YhnDm6F4AOKnzE9W1?= =?us-ascii?Q?CFgd0560P3bGtdhFZtdi/TrwSUt/P4Ywu23SCs3heTOK1bmCjRaDe3vVApnP?= =?us-ascii?Q?7fO68zQTDVSRYREunisdctqn/lwpzt4bTxRO7HpN31Bx4RQV6xW8jwdoBiZa?= =?us-ascii?Q?NgXeQc71kF5i5WTYjABJSfiAHR73x9MiISv2hSBWBwCH3btyvUtCeeNLkaaY?= =?us-ascii?Q?URMxD341W8a7nJaAS/rkdM++hCABnpo9NPzynUWfQID2ErkKfJtG4aC6anWd?= =?us-ascii?Q?qDO5NSRv/8xq5sVZquAvsEwPxLUySdwG0aiw9chaq7LwJgI8qWxvlQb+9bTS?= =?us-ascii?Q?TTFhTcKyt9cHhDRdaHfXHx4MjoobSfGPdpnvvGRJB6+oU13DjKGFNtJQZVRP?= =?us-ascii?Q?S0OMV7GoyX3NdRix+gKvgpuicqBz4b1rnYmcBpRmzpLYfgSj/66XvjVo3LqA?= =?us-ascii?Q?G70AdQcvve0Q2OEmzH9TL/YChMJgUcpVlYYND2RiIIJXJh1LfNH/SrBbfwqP?= =?us-ascii?Q?XKUnZkaqbqoTAUs9WEdsemxT/oaELaJrad6CEsuHwnlhHz+075/eSgudkLl3?= =?us-ascii?Q?1PhT3padW5VWUq1QEwbSr+ZjeOlHa82/AvDbrwumlqHP79y5e2xu95d0vH/s?= =?us-ascii?Q?2US3Bst6PjfuFRcJwMpGpYxGeNflg/RNoxhdYejuHb/n4Yqv3pfbLkWq2Jk3?= =?us-ascii?Q?Ke7EhvQE4IsRGZ6+ybpl9NcILu5Si12BmZp+DXtXoQvACmplC6Vk16frI+PK?= =?us-ascii?Q?GMK4QQzOljrAXlMXGssrCbOXs7rHhZqt4mxFWJXuvkSErTfLvtgjbvYilnYh?= =?us-ascii?Q?ed1rP5XEYkanFFoeB88KOPC4bxFhb+Dcq8i7zn6z2Yg+7w+BDYeNNMR4zSAq?= =?us-ascii?Q?zPoJRdY39yAz5KYJeA/SQBFw/nICLbKwdg13j4ksgawBP4SQOwqNyjgYIKIc?= =?us-ascii?Q?7mvmelDImh2Ad9Chxo4Zjj0o+qy0rou1YmnE0GGiW2DkLHgDyieuE614J5Ye?= =?us-ascii?Q?bfYW2jxaep0d1ZCn2BXV7cvmlBKmX07HDGOf/nQcn/4j0WBjA0ALOzYS61rv?= =?us-ascii?Q?hLmyoephNwk4ZLGmfsJW/gB6mHESL1S2Kw0+H9FqGdZsU2pAkinHa8YZm0Gj?= =?us-ascii?Q?lB/Fi7+mMUkeNROWCWfiz6Q9ty+gtCYfIzK9V9joh/TmLXJW6PK14ZCkFO3u?= =?us-ascii?Q?KNm600SPg5tx+FrD8cDkG4Z/QP3JATW4B8tg/Z85ZqwCJtgNbvBlli06WF0E?= =?us-ascii?Q?tgvHTT+uHe3KMH/e3Tk0/q2HJgKtnVLmF1o3gcdWkiZgiPqwf2w02azygM2M?= =?us-ascii?Q?QYSLo+a9o7wiGA77RKbCkbKtWxECsUbR+JFnMvMg/oHvUEIV+bFtu5I4OF+3?= =?us-ascii?Q?CqmX44z/Feovea0BR0oDgTNEJaUX6ZKbe8Ga7wrbjXNSpCI9a1O/wPqvi1Tl?= =?us-ascii?Q?/rJJkfPBQJz1JkyhIFYziFArQcnbn91i9XlqVn4DsYrItvKynXa7fqNIPfDE?= =?us-ascii?Q?nf3SagB+A17ssQehAI0=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04772806-8cbc-4c82-e7e8-08dbd6264c1a X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2023 13:20:17.6432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /TW7J8ImQcX4FIfAO5ON/iT9q0Ic7SDzagmRrbsHImgwz91y+nuW/qVY8FW8NWS7WFSkIjSwNXWoTJMHxyrBiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5673 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vndrEdupYpGpgIAyd8P4o9osx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=rgmmuNw3; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") According to my experience, BIOS Redfish is usually the owner to handle Red= fish task request, not the user to create task. So, I think that BIOS has n= o chance to read HTTP header in DELETE request/response.=20 But from specification perspective, Redfish task URI can be returned in HTT= P header in DELETE request. Regards, Nickle > -----Original Message----- > From: Igor Kulchytskyy > Sent: Thursday, October 26, 2023 9:09 PM > To: Nickle Wang ; Chang, Abner > ; devel@edk2.groups.io > Cc: Nick Ramirez > Subject: RE: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTT= P > headers to caller >=20 > External email: Use caution opening links or attachments >=20 >=20 > You mean, for the Redfish task functionality other functions will be used= ? > Thank you, > Igor >=20 > -----Original Message----- > From: Nickle Wang > Sent: Thursday, October 26, 2023 8:58 AM > To: Igor Kulchytskyy ; Chang, Abner ; > devel@edk2.groups.io > Cc: Nick Ramirez > Subject: RE: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTT= P > headers to caller >=20 > Hi Igor, >=20 > If the DELETE request to BMC is handled by Redfish task, we need to retur= n HTTP > header to caller so caller can get Task URI. But from BIOS Redfish perspe= ctive, I > don't see this use case yet. >=20 > Thanks, > Nickle >=20 > > -----Original Message----- > > From: Igor Kulchytskyy > > Sent: Thursday, October 26, 2023 8:50 PM > > To: Chang, Abner ; Nickle Wang > > ; devel@edk2.groups.io > > Cc: Nick Ramirez > > Subject: RE: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return > > HTTP headers to caller > > > > External email: Use caution opening links or attachments > > > > > > Hi Nickle, > > Just one quick question. > > Is there any sense to return the headers for DELETE request? > > Thank you, > > Igor > > > > -----Original Message----- > > From: Chang, Abner > > Sent: Thursday, October 26, 2023 2:10 AM > > To: Nickle Wang ; devel@edk2.groups.io > > Cc: Igor Kulchytskyy ; Nick Ramirez > > > > Subject: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP > > headers to caller > > > > > > **CAUTION: The e-mail below is from an external source. Please > > exercise caution before opening attachments, clicking links, or > > following guidance.** > > > > [AMD Official Use Only - General] > > > > Reviewed-by: Abner Chang > > > > > -----Original Message----- > > > From: Nickle Wang > > > Sent: Tuesday, October 24, 2023 4:40 PM > > > To: devel@edk2.groups.io > > > Cc: Chang, Abner ; Igor Kulchytskyy > > > ; Nick Ramirez > > > Subject: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to > > > caller > > > > > > Caution: This message originated from an External Source. Use proper > > > caution when opening attachments, clicking links, or responding. > > > > > > > > > Call Ex interface to get HTTP headers and return to caller. > > > > > > Signed-off-by: Nickle Wang > > > Cc: Abner Chang > > > Cc: Igor Kulchytskyy > > > Cc: Nick Ramirez > > > --- > > > RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c | 10 +++++++--- > > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > > b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > > index f4045044829a..5e06d516ba84 100644 > > > --- a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > > +++ b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > > @@ -356,7 +356,7 @@ RedfishGetByUri ( > > > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > > > - JsonValue =3D getUriFromService (RedfishService, Uri, &= RedResponse- > > > >StatusCode); > > > + JsonValue =3D getUriFromServiceEx (RedfishService, Uri, > &RedResponse- > > > >Headers, &RedResponse->HeaderCount, &RedResponse->StatusCode); > > > RedResponse->Payload =3D createRedfishPayload (JsonValue, > > > RedfishService); > > > > > > // > > > @@ -498,10 +498,12 @@ RedfishPatchToUri ( > > > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > > > - JsonValue =3D (EDKII_JSON_VALUE)patchUriFromService ( > > > + JsonValue =3D (EDKII_JSON_VALUE)patchUriFromServiceEx ( > > > RedfishService, > > > Uri, > > > Content, > > > + &(RedResponse->Headers), > > > + &(RedResponse->HeaderCount), > > > &(RedResponse->StatusCode) > > > ); > > > > > > @@ -661,12 +663,14 @@ RedfishPostToUri ( > > > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > > > - JsonValue =3D (EDKII_JSON_VALUE)postUriFromService ( > > > + JsonValue =3D (EDKII_JSON_VALUE)postUriFromServiceEx ( > > > RedfishService, > > > Uri, > > > Content, > > > ContentSize, > > > ContentType, > > > + &(RedResponse->Headers), > > > + &(RedResponse->HeaderCount), > > > &(RedResponse->StatusCode) > > > ); > > > > > > -- > > > 2.17.1 > > > > -The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is > > intended to be read only by the individual or entity to whom it is > > addressed or by their designee. If the reader of this message is not > > the intended recipient, you are on notice that any distribution of > > this message, in any form, is strictly prohibited. Please promptly > > notify the sender by reply e-mail or by telephone at 770-246-8600, and = then > delete or destroy all copies of the transmission. > -The information contained in this message may be confidential and propri= etary > to American Megatrends (AMI). This communication is intended to be read o= nly by > the individual or entity to whom it is addressed or by their designee. If= the reader > of this message is not the intended recipient, you are on notice that any > distribution of this message, in any form, is strictly prohibited. Please= promptly > notify the sender by reply e-mail or by telephone at 770-246-8600, and th= en > delete or destroy all copies of the transmission. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110098): https://edk2.groups.io/g/devel/message/110098 Mute This Topic: https://groups.io/mt/102154017/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-