public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nickle Wang" <nicklew@nvidia.com>
To: Minh Nguyen <minhnguyen@os.amperecomputing.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "patches@amperecomputing.com" <patches@amperecomputing.com>,
	"abner.chang@amd.com" <abner.chang@amd.com>,
	"igork@ami.com" <igork@ami.com>,
	"nhi@os.amperecomputing.com" <nhi@os.amperecomputing.com>,
	"tinhnguyen@os.amperecomputing.com"
	<tinhnguyen@os.amperecomputing.com>
Subject: Re: [PATCH 4/5] RedfishPkg: Add missing newline character
Date: Fri, 14 Apr 2023 08:53:03 +0000	[thread overview]
Message-ID: <MW4PR12MB703145F6063A155266127200D9999@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230414081903.7892-5-minhnguyen@os.amperecomputing.com>

Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: Minh Nguyen <minhnguyen@os.amperecomputing.com>
> Sent: Friday, April 14, 2023 4:19 PM
> To: devel@edk2.groups.io
> Cc: patches@amperecomputing.com; abner.chang@amd.com; Nickle Wang
> <nicklew@nvidia.com>; igork@ami.com; nhi@os.amperecomputing.com;
> tinhnguyen@os.amperecomputing.com; Minh Nguyen
> <minhnguyen@os.amperecomputing.com>
> Subject: [PATCH 4/5] RedfishPkg: Add missing newline character
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Nhi Pham <nhi@os.amperecomputing.com>
> 
> This adds a missing newline character to make the error log readable in case the
> module is failed.
> 
> Signed-off-by: Minh Nguyen <minhnguyen@os.amperecomputing.com>
> ---
>  RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c
> b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c
> index 45fc6e2182bc..c4fa59193a2f 100644
> --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c
> +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c
> @@ -8,6 +8,7 @@
>    (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
>    Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.<BR>
>    Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> +  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
> 
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> @@ -59,7 +60,7 @@ RedfishCreateSmbiosTable42 (
>    Status = RedfishPlatformHostInterfaceDeviceDescriptor (&DeviceType,
> &DeviceDescriptor);
>    if (EFI_ERROR (Status)) {
>      if (Status == EFI_NOT_FOUND) {
> -      DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is
> provided on this platform.", __func__));
> +      DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is
> + provided on this platform.\n", __func__));
>        return EFI_NOT_FOUND;
>      }
> 
> --
> 2.39.0


  reply	other threads:[~2023-04-14  8:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14  8:18 [PATCH 0/5] Adding necessary changes for RedfishPkg Minh Nguyen
2023-04-14  8:18 ` [PATCH 1/5] RedfishPkg: Correct variable type to prevent memory corruption Minh Nguyen
2023-04-14  8:52   ` Nickle Wang
2023-04-14  8:19 ` [PATCH 2/5] RedfishPkg: Prevent assertion of allocate zero length region Minh Nguyen
2023-04-14  9:03   ` Nickle Wang
2023-04-14  9:17     ` minhn
2023-04-14  9:28       ` Nickle Wang
2023-04-14  9:20     ` Minh Nguyen OS
2023-04-14  8:19 ` [PATCH 3/5] RedfishPkg: Create RestEx child on selected interface Minh Nguyen
2023-04-16  4:36   ` Chang, Abner
2023-04-20  1:23     ` Minh Nguyen OS
2023-04-20  1:28       ` Chang, Abner
2023-04-20  1:33         ` Minh Nguyen OS
2023-04-14  8:19 ` [PATCH 4/5] RedfishPkg: Add missing newline character Minh Nguyen
2023-04-14  8:53   ` Nickle Wang [this message]
2023-04-14  8:19 ` [PATCH 5/5] RedfishPkg: Fix compile issue on Linux Minh Nguyen
2023-04-14 14:13   ` Chang, Abner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR12MB703145F6063A155266127200D9999@MW4PR12MB7031.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox