From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.68]) by mx.groups.io with SMTP id smtpd.web10.4626.1681462386336094278 for ; Fri, 14 Apr 2023 01:53:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=PpkqZd3R; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.93.68, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MF4E2PZ33DCj1a9RvX9j3x/PjVYV4ecQWIlDoFPRqcLIwyW+iy8LfY666MQEqysYc1XsLfAc1fQsyMZnaCATIvXe1RjiaoTVCv4z2jBYoaO9C1xD2FxmiQxa3OBCRbTO0RGueWCD5sLEl1R2c/72eNLnHw+1ZJU3bpbNsuL2UAmw7Dh40bZQFYCwIiV6aqCx8QdhyRhopzdOZiZClYE0UgyNieqMYNjZ6Kgo3RuU5eTZZN13TnPTMhfnNBa5gnalosaA1X+LB6s36NmBwD76/FqAURAhv2wW5j5OZVo38SpBMOiEb39xTgoawn4Lnr0yOQJyjn0ereaWwrXTQFOFnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bkYV0FN0AKmd+IWFCbC4BMO0ycZ+faHwjwb575bpn4U=; b=ga+waruhlDP/DGCDPUMXLnpKAN74CpdG9PgfXbTm+v00NqTIFOfvNMWwhzM01NN+ks/NWAGN2S0iIj9nT8JGJLQdq4HxX85Wf5S/i0Nu8WKON6+DCfO8E3Nk0fdRB/4qW3ROAZ8QtSRJierrjVem+nFJqleknpqlqiXewKhPe6a6YxNnleriBqYQersMkhpOtqEgl4qjJ4x7RpwHTK2/rQgSky9xAmSJQStgbM0Y1N2+UvDn0Wst2Qeu0HZSS/9/1pQH3OWCyP2V3eL/nMRpE5TA/zfQmEhvODkeWiZh9MP69yK5ucw2JkV86R5pzFu/DOAySBnErIjwyERomGF22g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bkYV0FN0AKmd+IWFCbC4BMO0ycZ+faHwjwb575bpn4U=; b=PpkqZd3RlAJTafwkB4g/+TtMUquqG6qjo7kSwCy94YHWdD5q6hQjF+timC7gPncNz6X9xW9GwlD7XF2ZPkayTYqAiQw6Kwqn98i7VX/Cd4PmjVGBpYlqPIKXSd27J/oxFLsJ04Eu+M/8gYPb4eVrao50S06dOAKrq16l6XS1cjXlYexqMRTooenh3A7MJr8Y8J9+SCyE3i1t6wJ5S2eOONsMxfZBDdBzKWDWVCWtV8WHP3nAwXO9dpyWdcUZNUOEttZp5cAigyycsKw6FyMYE2f+gJ6HJCWlY8JAjGOa+SqJnwwe4ro9t7XQsBoZKTsI+4FrhaIRpmXyMthWNfxoKg== Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by SN7PR12MB8789.namprd12.prod.outlook.com (2603:10b6:806:34b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Fri, 14 Apr 2023 08:53:03 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::deb:4184:674f:c674]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::deb:4184:674f:c674%4]) with mapi id 15.20.6277.038; Fri, 14 Apr 2023 08:53:03 +0000 From: "Nickle Wang" To: Minh Nguyen , "devel@edk2.groups.io" CC: "patches@amperecomputing.com" , "abner.chang@amd.com" , "igork@ami.com" , "nhi@os.amperecomputing.com" , "tinhnguyen@os.amperecomputing.com" Subject: Re: [PATCH 4/5] RedfishPkg: Add missing newline character Thread-Topic: [PATCH 4/5] RedfishPkg: Add missing newline character Thread-Index: AQHZbqnvS5wiPTw3LUiSYWTsxEcInq8qf6lQ Date: Fri, 14 Apr 2023 08:53:03 +0000 Message-ID: References: <20230414081903.7892-1-minhnguyen@os.amperecomputing.com> <20230414081903.7892-5-minhnguyen@os.amperecomputing.com> In-Reply-To: <20230414081903.7892-5-minhnguyen@os.amperecomputing.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|SN7PR12MB8789:EE_ x-ms-office365-filtering-correlation-id: b55ef2e7-beda-4d7b-7c1b-08db3cc5a89d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XFjgzjUrB9eplY2fdXETvlq/6ztwvmrHXEFZNUxk/geIRQBQntFUE+Nc6BrNBbVov2f7DVQwAtpR/8AiWqLE8S5/a11PJV5DVzYkBQd7UVaikwuiCOazFzS8O7ZAaklCzs7rKZdfN3XuxcTMEsLok8pb3g/Aum4+W9omMcnyAF8b9ug1NfKP0HQqNh8tW702Dkr/HjHJo/EQ5nFkuHSc687e6IoIDhoEe4MypknJlMgLAtIqZXjbM1l/UcWxgurEBcTn0LR9GBEBdYqrww+tqXpZVyuWDYX0N9E6ahTmV71C/vCXZ+NpkynSNYW3GUZWGFankeWMPfMsLbHfoPfSMFM2/ZFMugkVGFwGI9g8zNMew2fo0lnTvLXoRS7mLBKEnv9psjj9GwITvsbxhGlzSo1hEa9P8tjwgyrn42QoMfelMYtnjIywjr2r4TqYwq1wP6suQASkHHQFT1UIR0YfoerWY0ijdnO67+v+WTYchQ4ltGGAyOYvRw28kp/ZkmI78yRwkWG97XYShnbL7onyja5EXFyXWewD7p8o4tJ4vYGrYxQVVocffgVg6Qud+YfHN4YXJCgDAEASMcRJHAIZTAyT27XXX0rgX1px6dEhZZv2M5ZdJPweiTucX6MGaDDz x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR12MB7031.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(346002)(376002)(396003)(366004)(451199021)(33656002)(7696005)(26005)(9686003)(6506007)(71200400001)(478600001)(83380400001)(66556008)(54906003)(66476007)(66946007)(76116006)(19627235002)(64756008)(53546011)(66446008)(316002)(110136005)(186003)(86362001)(4326008)(8676002)(41300700001)(52536014)(5660300002)(122000001)(55016003)(2906002)(38100700002)(8936002)(38070700005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GIWFrZ/YdeqjpaMEiWUe0Tb1bwXgyPpeHAaATKBgoTgBawlfyA/1pQUhFqjl?= =?us-ascii?Q?8Of59o+tyJmy1B4AquOORe26HY+ff8hCO6Mum0qcXEbIO/U335OicJwd4I1w?= =?us-ascii?Q?V9v0W9IImSxytzq4irg0kBPtXo5vzB6WvxpJalkVbQdphEUthBg3rkJnBxF5?= =?us-ascii?Q?pDYREKx2Uf6Wn1s8dH31Z1elJSck7uMknffV19nWp3ACAi3CyaH4DIW/6Oej?= =?us-ascii?Q?Ifda1x5Eu9oaEswzTd8dq4r3t72ABaLDo+wCY/foiiEsZrOdGp8aokhsF+d+?= =?us-ascii?Q?LCsHXRsPzoSHT6Pxx5Dw0Tc3gZ8E66Qo0MiEpi1H3o0hrQZl2m6nyTK8bW4p?= =?us-ascii?Q?1Z0uRdZ9y74WykDmzLIb6vrK7yV+D8HW9E+yhwgvcUnraaJDhehKhy7CgHi6?= =?us-ascii?Q?M7LJx/W+RqTncAHs8+zUYne/ikt9MVWCoa17kCAz+7BCavSjqIdPpHnPM6Qt?= =?us-ascii?Q?sThDZzeGw4VzLR1MBu5SCTwDgxj4w9S7yXe7uqirt/vuqKjwlvQiNLeQ4MIh?= =?us-ascii?Q?UulQA5aNKLAi2063a8MsDvJ/PIm49kB8ibz2hRRty/ywGRtN56+fWN3BpnNv?= =?us-ascii?Q?jKCFSQmo7xVsAlScbK/RyE06UNH/4G0cP4GwB3hcSKJ/q/hsUis5g2J93+Gd?= =?us-ascii?Q?vKMQkzmoskIR89cWl7+FuPRsp7L/nxIVbAAYaJJT3iq0tF39KFtDrBKFsKah?= =?us-ascii?Q?7+iy7osQZ5682x98FftY+eqTaO1Q0i6KFYcDSmyomDQ6Q1kzz51s5IR1xcxN?= =?us-ascii?Q?b59p4/TQ8Ih2s68yqEZrD5bp1Qg4rEsQP6Kd1OB0KfSVLj/LhXlG9hbPTuJJ?= =?us-ascii?Q?d97ae2ZQUaa9vzkIVx+UZapdVou+xGIgc4P2+KOOIX9s7SeM9fkCETUC3JBP?= =?us-ascii?Q?0MeRWf3chbKiynuZL3IW+cPt+rEe/PK234OY94p7333fxCutf/F+hRo/qkcs?= =?us-ascii?Q?DzbDf78kydxBFjvkXRv6EWWz6QZCLpiVfsIEj6rNyuJyticKt1js+SOnHn6g?= =?us-ascii?Q?u+trSyUQm5rtkxl+SHH6kOfA0yo04YjKsegBX33p9V6bKsS0L/bSSAuhDiQp?= =?us-ascii?Q?UooRzW/w2Yjp+wcJ8dWnzgaxUjfih8tMmcVRe+YrVzwWbGbK1puK0o3GwVaF?= =?us-ascii?Q?37Y1Yq5mwBbTwJgKBRqX4SG+m1SphuGXhY5TAsQ6GI6QEf2KDWqppR1s0GEY?= =?us-ascii?Q?NDp2RXOmFjvE+FKaPI4Xj4+ybuU1uCkA2tFPb+h4SMlSxm1AG0zYVYM5rnFU?= =?us-ascii?Q?zO6DRygMoaPO8lnnWhl7REWIO42+a3fM17TAafEHYJa/RqgKCafO4TCHeMHr?= =?us-ascii?Q?7/Fg27M1GX6z0E6Kyq8IZSm2i8zzQTLZRkslMGKLKLq/DOWkLaIyXWsvdtlJ?= =?us-ascii?Q?Z+HewpPTKiAucp9yKZo82rWfx7yTbEaJn1x2LYuf7XMOQ9JNqJhMCAoN8DgE?= =?us-ascii?Q?ngJebMdZCidOBQnXIQbz22K/VL7nFATBhaT40fJ0aD0fGFLVea2EVUVTipVA?= =?us-ascii?Q?UHhV4m3/7xnTqCFUu8qVB1alcrB+Z7e4lQqT25bm+lZ5iFR1pHTwMfKxDjGK?= =?us-ascii?Q?DGLVEE++c0OOZMCRdHU=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b55ef2e7-beda-4d7b-7c1b-08db3cc5a89d X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2023 08:53:03.7708 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N3tBw3lpcpEIuh1LO8Sz/yYdZ9Jsh8XY+FvXcQtKszGsbuS6QlYRVFCBvHda9Rg4o8CgT/NEuukLvZQ1Igb1MQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8789 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Minh Nguyen > Sent: Friday, April 14, 2023 4:19 PM > To: devel@edk2.groups.io > Cc: patches@amperecomputing.com; abner.chang@amd.com; Nickle Wang > ; igork@ami.com; nhi@os.amperecomputing.com; > tinhnguyen@os.amperecomputing.com; Minh Nguyen > > Subject: [PATCH 4/5] RedfishPkg: Add missing newline character >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Nhi Pham >=20 > This adds a missing newline character to make the error log readable in c= ase the > module is failed. >=20 > Signed-off-by: Minh Nguyen > --- > RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > index 45fc6e2182bc..c4fa59193a2f 100644 > --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > @@ -8,6 +8,7 @@ > (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved. > Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -59,7 +60,7 @@ RedfishCreateSmbiosTable42 ( > Status =3D RedfishPlatformHostInterfaceDeviceDescriptor (&DeviceType, > &DeviceDescriptor); > if (EFI_ERROR (Status)) { > if (Status =3D=3D EFI_NOT_FOUND) { > - DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is > provided on this platform.", __func__)); > + DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is > + provided on this platform.\n", __func__)); > return EFI_NOT_FOUND; > } >=20 > -- > 2.39.0