From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 370B9D804D6 for ; Mon, 4 Dec 2023 07:19:16 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xBtcHMVZTnEAz+Yrdy6J619mdr/MqJXrr70N5IEhZyw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701674355; v=1; b=Z5ZQmXjhGzzYy3s6oIfHr3tMYE5EPTjtpWV5yl2q6PriwKqSI0U20ZM0opt6VKqIRCu6hMq+ +X7Tf5tmMHIyAbUienzliblhyiQcbuFiCE4/ujYAxRIdz2646Izg3+9SATTNgl4D+pCimH/FN7I UCMVvXRuaD+CeoIvSLbBIhpE= X-Received: by 127.0.0.2 with SMTP id XO8yYY7687511x1wXwuYHhI7; Sun, 03 Dec 2023 23:19:15 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.57]) by mx.groups.io with SMTP id smtpd.web10.64291.1701674354519944174 for ; Sun, 03 Dec 2023 23:19:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PwUZA4dcj7X/LOT2zCHRhkXHmwZsLQM0y5BqKjZFu/ZdZTzerYGdqvH76weA9kM1lUgLVPmXU3Tbrk8EJ/W8yqGSrMpCEN9BylNtBJwjYUahNH7lJMGE9r3FNaPgW673H3rj1zlCvVwY+ha0asKVECBs+IhcSQ1T2DRWT84CirUh1Ro0y3i/drtbmWvVlBKxy4uYq0/KA1IHYaG9ic7nWFLtgXsDo3QW8DgCBsmJyElmfM9bSeeaMGy/WfeT7YwDggO/lvTT4VlG8U9TdJf9LOeZ7UkdCUgN8KFPwEq99noeeY+/KNUfnLox7Znp4BCuSOy+6OLucQxopeZTIS5fKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bwIRGObnktj1H3pFSYMY7KweVn/z67BC6g5ocamEXOI=; b=KAuutSRQCY9DGyP8SpPDZNkBRtszI9g+AwtPXNlgG8C+UrrFIjFbDK3skDFVcDJJeLbZTSU4kAI+/nmkbji7W3I784U0IGDaavwSq1UntZDj4eQBP1/yHThNsLVOmaRj8GPwwguFjYWZAGKbRs90PEHitk1snT5U/SRSptpUuBMOAOalxpiKo4xL2BM0BwO62pl6txVsmnYd5xKyLLdw8lBA4ADkGslzlEtyqtwAS9OPBdHoX6KF2tt1TwGMkWRp30c14f8Fv4dZWydiQ5ws7y6sx5qToOQ75aRS5oimcMen/k5NH3QGsX4Yb4aGyGY/AHRMIhT3ivhH3F3KoPFkrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by PH7PR12MB5688.namprd12.prod.outlook.com (2603:10b6:510:130::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.33; Mon, 4 Dec 2023 07:19:11 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4%3]) with mapi id 15.20.7046.033; Mon, 4 Dec 2023 07:19:11 +0000 From: "Nickle Wang via groups.io" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Mike Maslenkin Subject: Re: [edk2-devel] [PATCH V3 7/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect reference of MAC address pointer Thread-Topic: [PATCH V3 7/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect reference of MAC address pointer Thread-Index: AQHaIPMFbUTfHMoNi0CW5GXVB6jeQ7CYwnCA Date: Mon, 4 Dec 2023 07:19:11 +0000 Message-ID: References: <20231127053107.1686-1-abner.chang@amd.com> <20231127053107.1686-8-abner.chang@amd.com> In-Reply-To: <20231127053107.1686-8-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|PH7PR12MB5688:EE_ x-ms-office365-filtering-correlation-id: 28ca44ee-ac57-4697-a342-08dbf4995057 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: qU2Z4Pcey9YRjjjcFe8KEVpmMAX7I0g99IVLAjhnAYEc3lKlh3GDL1xyLLKtTFLTad1JEgQ5km0UY1oLH98DyREGDkMVYA1lpTeQVI/okvwZrF3C2fYxpX76I55C2xUNDN1aY4VHgLGk1O1HF98ndbNuYBjfWoNlhS30FrkIrLmOysfUAXsw2Ih6bixxy1KvBuB10KlWsRscme//bHULyhlEJlv2Fg9CRV+YFx6fN0ljaatT7u2fTtImSJoZFFnsRZ1eOppVPMywM2b7AxOhudE+mnj/203JUrx9BVon9PWGccqv+1lczAbp09gX4HpoIRZDfyt26frWGQKyYREeG43go0g+R/RaJ2SmvD8QHK2xVL/sUYjjLA44In+jQ/u+HXqCZQ0fxVB7SnC8qFxr7k4QbE4llykptzPNd7PirGNj0p6IszzHPnxXZHCOhhP1HJV+Z0XUGhBNzkzbs+BQaDzwXB7piHiZ9Ktx1ekHrIkDrTna05cufdX2b3LdqMQTIK7SpcO8QWjuYi+Hll1QeoY/OhzAGvra2QTESdksAetffaxOPHbwkgOb7phikIkUlWJ/qWM+eOoBVEjylWdcvivuGXSVaUSwRFepBa3QQI4lVCFnz1ZtzNYiF0jzWP5BemnGh5MqeTo8WDSkbHibNEsRYQqZ/4f1c4rCANpZTHYUxFO35SLY7nIcLY++KdIn x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z76CcxlYYLDICjgyGyoZJ0EIeTTsgtTo9eBNxA3zqxo2XQ8SquZuzYxPpFQ5?= =?us-ascii?Q?ia0z9euO0VhbVlGjjnudbcmrL6aMu+LZxhqo+kEgwgx56OV6/t8ZzUKxn+kJ?= =?us-ascii?Q?DdBr1ulJJswgFhnW7OxOxHj9sxp8t1Bc6CzXt2E1OXvkJZkBbXTkMxyL+VwL?= =?us-ascii?Q?PQLBLDr0moHPFblO7AKZefXCaR1B3Nxu2+ALurOIs2D1/e57W6HZN7dnV/n5?= =?us-ascii?Q?GFbvdYFrPT7keQxZ58veswcCHqeM6wP30ZpfPZWjNHGRXKjCtFOVilg9Js/E?= =?us-ascii?Q?CrQn4UuF0As5swC24Nf4284IUF7MmRh4vtFLUvfETtCMCtufj/1Djo/uaCGe?= =?us-ascii?Q?qAXUatVgpb2/35Q3RWWIoIZXoSHluG+qVKhmF5i92b8dfUJKxppP/rA08B2D?= =?us-ascii?Q?MosfMn8dnNZoxyYgewLXXqJ9iPEFxbWM4bRwtvnPInyUwazpA6lx0xaJdbpP?= =?us-ascii?Q?Rbu033t7VX5d5Xd3gzzMxyIuL3XAJpNIyZbdxhAT8tllt0SnL8HSxJQvMs0B?= =?us-ascii?Q?fqxqJhX9o8U0WQxVreapCmZORW08wA1bEMT/R7xlTi+wBTVzqd9E+e5n3VGg?= =?us-ascii?Q?8f4oysz/tfLvFfWHCb4TltJ7xBU/LozuL9SX1B9xcMdkuGIOKeHoLm3EjNmq?= =?us-ascii?Q?ho/SM8fZGo9kq++AzyTIoA3Qd58oYeWgDoayAUkPNX9Wy56ohuKj3NPW0BDm?= =?us-ascii?Q?uZT2JpU61ELThN9yvl8nujtuVUzDrChgS+vM9N73tnG1Ob8LaKAMfesfghul?= =?us-ascii?Q?Bcta2mdOcKo24+0AqqQ20zvvMxM6QGuyjno7oXxeGZQPhjY21P/bfni/+3a3?= =?us-ascii?Q?VWCZjUus2AvAE+lVC8oi3MqsUzaMKpBQGltPzw+NGcBG2srt6lnxlHFd9++B?= =?us-ascii?Q?b/bkBUwHf5mPfph3T/NO599EoLnndvbdnfnqQSTUKx24micMMfjUyjhJDyI5?= =?us-ascii?Q?cMqxrJucsUOxPLJcxU0leUS36/wgc0fKI6+7Y+enKOayHxo0p7NVtry0oM82?= =?us-ascii?Q?6BPG/B16LA19uGzBED4kZpUk6SmlIMuv0NCx+mFIKcXoIA3QrktWV/5W7Quy?= =?us-ascii?Q?yEVw6lwslXJ2yMfZpX/GNg4Iy/+yWIQJSO3VzmnOcMAHBekhG/U0/z5u7SW3?= =?us-ascii?Q?DJjI/8TpTFQRPKUyaj+F7/l0ios/KipsGq0JMxlESo9pgFZ5F/446a80XWeU?= =?us-ascii?Q?uAYZQa2Wrh2WdXuwdYm+ARXK8rw9Qq8HjxqM7CA3GI0+HjS/cGkhBsqpzrh3?= =?us-ascii?Q?RQaeNFX4tQQH9ZYQoOboZHyj/z1MSt8rZHx96B2EPWI5LwlKMQpqdXIVhL7P?= =?us-ascii?Q?LDVebxq7lPkODt991ibRE4MdEprWs5WG8NknnXySw5JihbXzBjtX7SlvTdBC?= =?us-ascii?Q?iZv5pol46rr/w1FckfXw6B/XVtga6Jxz0dXb5ujG9vcmP2/nSJjJs76EXTcd?= =?us-ascii?Q?1BMFH3yh337pPBdJM6BmCiDeGJeqozxsXOUOsTrECOmCzJAs/H0kPzEj0Bbx?= =?us-ascii?Q?bt4hU2sXiqZNzW+6pxuLxk0heUw3xlwsCcpbQ1KM4xJCon6B1HhjnhldKQWg?= =?us-ascii?Q?sjdPQbP+IBKtTejKlTVKLYMZ4a6hro4nfcwITsPvv4k7sMW0ryo+K7SoCTA2?= =?us-ascii?Q?LAdgpDU+uTm8He76jKddh1owogllAF5nmfpxWRtHbKZw?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28ca44ee-ac57-4697-a342-08dbf4995057 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2023 07:19:11.8034 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fSZWprkrb9NkOyn4aKsysA3ZmEWtv9SQoAxSJaVnteCBV+cSR+1O1eLynzOANF6GALS/5VXhYAtCQmu2HuDXVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5688 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YclLIBwpvuKB59SBAPIOlL28x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Z5ZQmXjh; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: abner.chang@amd.com > Sent: Monday, November 27, 2023 1:31 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy ; > Mike Maslenkin > Subject: [PATCH V3 7/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect > reference of MAC address pointer >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Abner Chang >=20 > MAC address reference is incorrect when it is copied to Host Interface > DeviceDescriptor. >=20 > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Mike Maslenkin > --- > .../PlatformHostInterfaceBmcUsbNicLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > index e5bf70cfd58..c4a71226e63 100644 > --- > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= ac > eBmcUsbNicLib.c > +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI > +++ nterfaceBmcUsbNicLib.c > @@ -120,7 +120,7 @@ RedfishPlatformHostInterfaceDeviceDescriptor ( > InterfaceData->DeviceDescriptor.UsbDeviceV2.SerialNumberStr =3D 0; > CopyMem ( > (VOID *)&InterfaceData->DeviceDescriptor.UsbDeviceV2.MacAddress, > - (VOID *)&ThisInstance->MacAddress, > + (VOID *)ThisInstance->MacAddress, > sizeof (InterfaceData->DeviceDescriptor.UsbDeviceV2.MacAddress) > ); > InterfaceData->DeviceDescriptor.UsbDeviceV2.Characteristics = |=3D > (UINT16)ThisInstance->CredentialBootstrapping; > -- > 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112014): https://edk2.groups.io/g/devel/message/112014 Mute This Topic: https://groups.io/mt/102824322/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-