From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.72]) by mx.groups.io with SMTP id smtpd.web11.6037.1684378316720331784 for ; Wed, 17 May 2023 19:51:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=p4mkfIJW; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.243.72, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fnDJTQmIBX9RIaHJyiSsfwqb5X/xV7gqMyxntvkJ+hVONoH6uepBK9bKqi9+ZdPQpapAi/sJkWo4XazxkTspo+6yt2niJUDpsyac9r74f6GDKfPPoKnoB3uNDHhP2qkSG2a4yu0YeY7RUYMrK0bH87XPUOJTTT+yNA6266gHdAX6HT/V2pzthSXVBlt8YLW+teFtjy4lxXrcQ7IZpOx54p9fNUj+irwDdNcTql0r3dP9bJgiawBNyqBDVjiH4tiBy6JROW457WWYDYo4cejvsSbgbY1SampPuk9uU+deVx9WRt3ZESdbzG0dKpvLy47Ls4giQWAFSj3Rr8hJh3kmtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BUH7vpdpoB9qHnUwKpIJqZozOCSOEco8BbPtOqvvOsk=; b=CWo/naGuiSIG2j7TZAU45qJ4dInYRRano9NQAW3dBz1X/t4Y2PDBtKQA4a1ZV7ykBzT0KoJxeAVe5qAP8L9EuKwc7MHk3YZEfnKaSA+Nj0IcwggyrWkDPHFq/804ixE5qZRQBpd8EIDEs38NMzwjyhPf9gr2zqyu+8erZ3QjfyFhJEqrD/7EVej3FanFaDHSgH2WuB3WlZtlUZc1Fc/+duwah27YuZXq3NbvbN53kN9oiCo4z8WC7Pb8/r2/jIS/A9gGqBCt7hxL+mlrfWy4CrNCh9vWLSR3JXnAfKtcydwpb+FS36V75TBXDUl7LyQi/AT9uQ5ibrtpEzchOvVFVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BUH7vpdpoB9qHnUwKpIJqZozOCSOEco8BbPtOqvvOsk=; b=p4mkfIJWCyp6W3toJ7rXgr0iL8as6XkAXR382+qRY6zoedL/JA69ZF9XqBaJXayzenCXVxCFBXyeHJhtXMka67FdZfvUBVfk95u89n86390ylzLtdIeiFefxLPsrpeZkoU+LMjcHE3xNC4ndkXxHTvGU0OtxzYGkYGudQgWw8/BrHnMngw0o1797zBmsaFMYoLRqk6qWQh/7Wn5/fldkzWPI6UiftnG6/2fPp0dbu0UE8krb0hJS/IXqy82TB17HKWg8H3RyldErvDeiPIPdRpl2VgEBy2BbqM6I/J7c8dWyhgda+c/TPUqREPqF47/t+yxvyXqtSZh8TsOJQxWDXg== Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by IA0PR12MB8746.namprd12.prod.outlook.com (2603:10b6:208:490::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Thu, 18 May 2023 02:51:54 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9df:b45b:2cc1:f017]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9df:b45b:2cc1:f017%5]) with mapi id 15.20.6387.023; Thu, 18 May 2023 02:51:53 +0000 From: "Nickle Wang" To: "devel@edk2.groups.io" , "Chang, Abner" CC: Isaac Oram , "Attar, AbdulLateef (Abdul Lateef)" Subject: Re: [edk2-devel] [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiFrb: Add to ManageabilityPkg Thread-Topic: [edk2-devel] [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiFrb: Add to ManageabilityPkg Thread-Index: AQHZiTOzqoDEJajFRkiEYToUhm0Sjg== Date: Thu, 18 May 2023 02:51:52 +0000 Message-ID: References: <20230513123327.1496-1-abner.chang@amd.com> <175EB402247F662E.30531@groups.io> In-Reply-To: <175EB402247F662E.30531@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|IA0PR12MB8746:EE_ x-ms-office365-filtering-correlation-id: 6d904c52-47b5-440e-9d45-08db574ad5db x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hhNcRCNqkejbV17+GLsWFVSb2dKGHvMXCK+jrFfYBc6CKnK+UK4PKaElxNp/XE5HVSTUoW/ZM2RYQFg6d9b3qmBYl6tktP9lSUATrYScFpkapfjCK5X1m1JRZrMDhH4JRdbk3J9jcftZkF3GOXBdNpykxFMwIb5lxIeW4T3UaudZ7DovTOvZ5J20xBV2HNLPzSExCr7vuNYGNdImK95xb4sPiiwZ/i5RoawmNiSEzI8eI0l2NdNFSO6B6wCejTojJyPaO6rOIhAfdj/CXiGkvC1q4BfQSbGTVR4+1IsrPNBLE1CKlcJgHtdXZFQXsDYQ2/870tYDa6jOdzTvjIDfXhWEmnFO2gWaPGfezcCtV0vP15Bxty96NyMqJPWuqK7FrTYbKhagINpp6Z2RvT7SGR/l/Aaixa3+WEsA0ad20GihXOi0sY2/URV+T8n2m95OopXWs7UQbnWfYWOx1wwAkWfYoia5YZNWsdA56f7Kd/Ic1SQ6yBtTNmpmHWAIlehhUiIovAAYlkanSHUVpG7cZW3AW1JwvotG9G9d/RdYl4rPeB/+zGbE6J4F+0ylMF92P2U1W10RyDMvqG/NpK/a18z3SLLuaz5fc8qkonyvkCA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR12MB7031.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(136003)(396003)(346002)(376002)(451199021)(478600001)(4326008)(316002)(2906002)(52536014)(8936002)(66899021)(64756008)(41300700001)(66476007)(66556008)(66946007)(76116006)(8676002)(54906003)(110136005)(5660300002)(71200400001)(66446008)(7696005)(966005)(53546011)(9686003)(6506007)(186003)(122000001)(55016003)(83380400001)(38070700005)(86362001)(33656002)(38100700002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dy51BgPbUgOR4yOhjgJAd8pBlGkD9ukYIJ/HebHTFk3erV6POoXJ4b0ONU8Q?= =?us-ascii?Q?MW0Sru7xTV2UTPectcA5JRPjHuOaZUNO1nr9WXurBzdWu8F8BGZBKQ5oLNtG?= =?us-ascii?Q?BDH0osOHuov+URo/bcfoivIT6l8HrUbphUgM7vHYK0LuTPvLs8PuWnx+gLh4?= =?us-ascii?Q?nr2pdYnj7KH689hEDa2fH0Dwk/6xOel3VGi1pV7ooYJLL3L3R22ZLBofQFYQ?= =?us-ascii?Q?lbK4FfBe/E94L88oFB0z4iKvW5KeB2zTeFf77TXq1b+x/g3xPR0cX1ic7PnG?= =?us-ascii?Q?UMZjpNZ6hpcZoG9AbW7Qys0d/VAI7Q8YYAI1D/L1k1rTH+Jt5jQIwxKIYlkv?= =?us-ascii?Q?RaG3B//XOkLylZyCIeeWXGwq3SIWPSp+DWco5HYtUOB4TFGO6fx6ite4Hxr5?= =?us-ascii?Q?cwFR9GDHkwKM98MkXSdAum0CVypae/DfrAFPHWnxR/4CL5++19yqInLyRlkl?= =?us-ascii?Q?0gP1IYB8ivOjpd9RFuB59VMLVlYT9cSLGIGyTxcJuuKjylrDSpe0ScO8BVeg?= =?us-ascii?Q?i2CI5Ygbj3pbUT/KXe6qMo7BU7SwRoombFUg3c/sjcQMkcHPltlE/Oa5PvHJ?= =?us-ascii?Q?SikG0KcyP7g3a97T4/Fn4/141qJubsPJiV8C345vNaQGjoAocORFAgRMnmwf?= =?us-ascii?Q?50UpV06zkUZyWUAyU3n1tMZe3PTO2VbAjA6qK4IZZD0BKHe4I8kGUbRPwMD+?= =?us-ascii?Q?qygZrx3dlI0Jw15SgZVYCTiGDCeD4uDK1mzJP6maj05D/fN9zZGCpen+3EwP?= =?us-ascii?Q?YlTRtHuQI7nvo7Qwv1DOTd712Gzzb58dgHetNAUqk3Wrk7n9ncCiu8Ca/3Pr?= =?us-ascii?Q?ABwTAF9SPOL/guvfXfBC5BETd20gPU9LsciAdAEqwvBkJDL8Q62GxQlzS9Ll?= =?us-ascii?Q?Uxgw5pz0HLfwkrY3tph1t8O/Y6qnwikaQCvkEg6YcrrlB744kQIOoNvRwSHK?= =?us-ascii?Q?S+AyzqgnI4mM7Du7Xj0gghQ6QjjUG6K4ECLMmncn6yyZAp4gur4elQPyrvN6?= =?us-ascii?Q?VzjAXEnv3tUhzBDJZdra7Syce0sI5lcYtTPQcvVWI80iDEOfNe4BPuX9V2Ru?= =?us-ascii?Q?3ytEbKJmJsI1z6OD4Hzpv4gEWJwzNPjWSTOHTSxIbcUvOFae3r0eL73iAmUs?= =?us-ascii?Q?6e323xZjyFhi9dRytHtVrByFDPoiD2BiCBoMk+uqm7GeBhkFsZr9RKP7LbsF?= =?us-ascii?Q?rXR/xBNNO9rGDCwZNPDBOWYA/78a6p5SKXaUNOGtOwyKHVdbaLBfqdNxDxuk?= =?us-ascii?Q?tvJBJIpNTMXkO7XXFO15fflJaQqMFT3UXytrPPs33FRhBmnP78UhLZtErG3U?= =?us-ascii?Q?yh9H0hIBRLeRVciegV4NJTPQXqW6TGaj9mD2Hcnv1TGO2Umhk70yr8ahKbaz?= =?us-ascii?Q?g9/tMIJMVwn/QipUla4osPNHa1XDjGCdiLeyfDEFbxcsXjL5Z29uPsecNzQD?= =?us-ascii?Q?zGBAXDn0+eSwvDIkVPQk2g1d/MQsfv7PEaURpAR/ARYYP8OQXezb2CCINAXe?= =?us-ascii?Q?ZeR6O5Gc1ktR49mcvO1A+QM58TeCFFbmM2vE9dZ5L4Zni8ntnueoSVczTuR9?= =?us-ascii?Q?SltYuIVZMf5pyLHh8439+ghy9cQMpOYYK8R7vCGrPWOlCcbNOoGJ3OKqkt2D?= =?us-ascii?Q?qVLSnIAHA9Y8oheQo9M+dZ8Rv3ZZ5UGDbDQJvXaidf66?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d904c52-47b5-440e-9d45-08db574ad5db X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2023 02:51:52.9961 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NceJvSci351plYUrE/GhDZb1lp1Us7sTlRl9SWg97PYa2KgwFTzIE23jHZqTBmsjNa91C3A9TKmjrr3rFGY9wA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8746 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, Abn= er > via groups.io > Sent: Saturday, May 13, 2023 8:33 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef= ) > ; Nickle Wang > Subject: [edk2-devel] [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiFr= b: > Add to ManageabilityPkg >=20 > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. >=20 >=20 > From: Abner Chang >=20 > Add IpmiFrb to ManageabilityPkg. >=20 > Signed-off-by: Abner Chang > Cc: Isaac Oram > Cc: Abdul Lateef Attar > Cc: Nickle Wang > --- > Features/ManageabilityPkg/ManageabilityPkg.dec | 2 ++ > Features/ManageabilityPkg/Include/Manageability.dsc | 8 ++++++++ > Features/ManageabilityPkg/ManageabilityPkg.dsc | 3 +++ > Features/ManageabilityPkg/Include/PostMemory.fdf | 4 ++++ > Features/ManageabilityPkg/Include/PreMemory.fdf | 4 ++++ > 5 files changed, 21 insertions(+) >=20 > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec > b/Features/ManageabilityPkg/ManageabilityPkg.dec > index b0ca01094a..3980931424 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dec > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec > @@ -79,6 +79,8 @@ >=20 > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable|FALSE|BO > OLEAN|0x10000004 >=20 > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable|FALSE|BO > OLEAN|0x10000005 >=20 > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEna > ble|FALSE|BOOLEAN|0x10000006 > + > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmFrb|FALSE|BOOLEA > + N|0x1000000B > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmFrb|FALSE|BOOLEA > + N|0x1000000C >=20 > [PcdsDynamic, PcdsDynamicEx] >=20 > gManageabilityPkgTokenSpaceGuid.PcdFRB2EnabledFlag|TRUE|BOOLEAN|0x20 > 000001 > diff --git a/Features/ManageabilityPkg/Include/Manageability.dsc > b/Features/ManageabilityPkg/Include/Manageability.dsc > index a432b0ff26..06fed828b2 100644 > --- a/Features/ManageabilityPkg/Include/Manageability.dsc > +++ b/Features/ManageabilityPkg/Include/Manageability.dsc > @@ -30,6 +30,10 @@ > ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf > !endif >=20 > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmFrb =3D=3D TRU= E > + ManageabilityPkg/Universal/IpmiFrb/FrbPei.inf > +!endif > + > [Components.X64, Components.AARCH64] > !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiEnable =3D=3D= TRUE > ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf > @@ -51,3 +55,7 @@ > !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable =3D=3D > TRUE > ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > !endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmFrb =3D=3D TRU= E > + ManageabilityPkg/Universal/IpmiFrb/FrbDxe.inf > +!endif > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc > b/Features/ManageabilityPkg/ManageabilityPkg.dsc > index e3baf27f2a..6fa3e3c6ae 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc > @@ -37,6 +37,8 @@ > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable > |TRUE > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable > |TRUE >=20 > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEna > ble|TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmFrb > |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmFrb > |TRUE >=20 > # > # Include common libraries > @@ -53,5 +55,6 @@ >=20 > [LibraryClasses] >=20 > ManageabilityTransportLib|ManageabilityPkg/Library/BaseManageabilityTrans= p > ortNullLib/BaseManageabilityTransportNull.inf > + IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf >=20 > !include Include/Manageability.dsc > diff --git a/Features/ManageabilityPkg/Include/PostMemory.fdf > b/Features/ManageabilityPkg/Include/PostMemory.fdf > index 9100cb2646..84e7ea978b 100644 > --- a/Features/ManageabilityPkg/Include/PostMemory.fdf > +++ b/Features/ManageabilityPkg/Include/PostMemory.fdf > @@ -26,3 +26,7 @@ > !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable =3D=3D > TRUE > INF ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > !endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmFrb =3D=3D TRU= E > + INF ManageabilityPkg/Universal/IpmiFrb/FrbDxe.inf > +!endif > diff --git a/Features/ManageabilityPkg/Include/PreMemory.fdf > b/Features/ManageabilityPkg/Include/PreMemory.fdf > index 16e079f494..add36e2095 100644 > --- a/Features/ManageabilityPkg/Include/PreMemory.fdf > +++ b/Features/ManageabilityPkg/Include/PreMemory.fdf > @@ -10,3 +10,7 @@ > !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiEnable =3D=3D= TRUE > INF ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf > !endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmFrb =3D=3D TRU= E > + INF ManageabilityPkg/Universal/IpmiFrb/FrbPei.inf > +!endif > -- > 2.37.1.windows.1 >=20 >=20 >=20 >=20 >=20