From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6F8E9D80D0B for ; Mon, 18 Sep 2023 13:17:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jYiaj+lFI2BZ06A302w6vnrTPctrhL6Bbv+mFmuc3z0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1695043039; v=1; b=DgDbEDi19hLEFlfVbcMBjLzEfoTnMI3MFnuEqH0rRSlpdLP1iEoG4R7eAAIstFPkYGGjAWWg aNvr1KLmKZN+jpzfKTau0UrAg8+jlFigFmpBKRWUwpaTtr/EdBw43tYhzxL3n33lIllgk8jl2O3 5RH0qwMJsh3AcYdPBrIhpxxE= X-Received: by 127.0.0.2 with SMTP id UaFFYY7687511xERTt7e20P8; Mon, 18 Sep 2023 06:17:18 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.67]) by mx.groups.io with SMTP id smtpd.web10.50751.1695043037527152212 for ; Mon, 18 Sep 2023 06:17:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RRN8VojXW29SlN13PLlj3iFqhy63Z8i0NWE/EdWl+iLQJA+jUnOaKWuxArss6qF/uaflwRHOqWv0jixqkpZwcf6xWuo36GMjXRdMMiYvyanmTY4T14UfeiWrkrMaM8GcyuI+ApuARiAFEPfyjHZlL2WWhPE5TvbqveEv4gESUBE6w2/iTzLmUiI+tFVuCAKWmZaGvfUaaF1x0NAXSEvmBFI4WNN40rmCQVBrWYq07EJZezDU13QQVVcngy/v0dnUJUlCmP5V8/JKmdO59LQhI4H2Iw4mirKi+qbPlf3MJ9W6MjZ9zq5f0AIbv5YmF5YiVQ9hSxZavWdbkjVyWMa7Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tLAGqlfkUT0Ky9ZtkoCCZJFWApLrzdspW9KEutbPkhU=; b=CCLHRIFZ28foWgdtFAoZ/dkf9SSyXnba+QIzwr+7iwQqOncCoJ2stTEGKB7gJFDfMTfkf0Wk/hDFlHeQTR1VqMIo68Nbq/vdIcR5GWHXkG6ikQV4IfOdLre/whS6x7GXcQXuiwAS0M0Oi3/kKwW+EfZElm1im5jv979QoDT8J6BvTPCAStW/e+4T0npDgSc91CKbX+zfumq/3kzBXG0DIr6rQ8UG1zNp8nPSTnK2pMKXpdX2r+nqe386ZZnz0vTqSaC4lkR1e6D8NPdMrgKItfkup+fjZvtEp5PLvw6kDkeKLxNHUyOEhHCUZw5du0SpbEfxOd60lU/yx+iMvmF9xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by SJ0PR12MB5437.namprd12.prod.outlook.com (2603:10b6:a03:302::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.26; Mon, 18 Sep 2023 13:17:14 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::1390:de0a:6b46:9837]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::1390:de0a:6b46:9837%7]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023 13:17:14 +0000 From: "Nickle Wang via groups.io" To: "devel@edk2.groups.io" , Nickle Wang , Abner Chang CC: Igor Kulchytskyy , Nick Ramirez , Mike Maslenkin Subject: Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller. Thread-Topic: [edk2-devel] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller. Thread-Index: AQHZ6jHywDgPBT0vKkm9IAZYAfS0RbAgj/gw Date: Mon, 18 Sep 2023 13:17:14 +0000 Message-ID: References: <1786007649F51CE2.9824@groups.io> In-Reply-To: <1786007649F51CE2.9824@groups.io> Accept-Language: en-US X-Mentions: abner.chang@amd.com X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|SJ0PR12MB5437:EE_ x-ms-office365-filtering-correlation-id: ab33c6f0-2e83-4ff9-d9a0-08dbb8499307 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: xnpAVsw60/pMGSsIGs/K6gSDp6TPCxbYmwiHYq7q+5kygmQ6K0hf3Oi5IIX1N632El+hq8bdb2nvBzH7repcTsXcx4wu+8m51HKqDmelRymLrhnmAdB6XGLhXT+FplbjhG9+Suw7afdYoXQyfAKAxcWrOH0sMJlaXlZ48OQ5Resvb5LcYlU8BqY3OGcb17KWYApljh7DCjeXBYe27FWTCWSY2O+fm9YKCuVD4g8MatH+BBQi7bLVE1Huf2hffqZTTu5v/5ICoYqdeRW6+k50UWRx+0ptQ1IFvLUyI4x8vV1Q7nKph3pOoQSAxtk+P/HLaskHIFesmPEQLrverEc6r3h8/V9NtVpJIHutnZ0/LUe87BDUFp7KV/B76Fn2t/oUMzim+gpJMHIgPfwMOxtN+GqkGzB4FEPfykoBP1JMlV4yF6RP8ll23TkpYTG0EsoN7CB2DNberHBlNpAxveB2/vQgXjNDvLK0ymhJP1vTavGi2WtSnLR882786YyxL5fe3Urupw7Hd+/Ef12+bFMnRZGoIWgOgvCx5v5vUPkntT8QHK/tmDtr2VSrBzXLyx1nvIlZYesZ/W4YXGQYVWZZh/3tJKf6elO+tY8aQkkGkl0= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rOkWWppTReo6GKIIhEYGzlpzF6BpMWeb7swC9Yt+bRO+bOnIbzh2iyKt9Qjg?= =?us-ascii?Q?A5LAtPCAYRlhI9EPyw7gl5IjouP4G1z+xPYjfheUjdr2jRkc0Kfds50yaNKY?= =?us-ascii?Q?iyS55hG+SiMoTguNJ8z1EvTIJs0XKp566TnRW+hhUGAg6UBOoxrVX3U2atp5?= =?us-ascii?Q?F9a4dUjC/ml1Qegy9gfa2YZdIxgscrAlK4THYiohRYnd+Am8JVcgxRZjiT91?= =?us-ascii?Q?TwALWY4IA3txvY8dU6DSgl9ZMPxwTHUA1OLU73SQ3c/CAtCttbGJcFp0nqja?= =?us-ascii?Q?bSr3zxK9fNuUFzvlxm2kfEXhGlvg2YmX7+PI67xxQqWxGHK1XzDOslWEFQs7?= =?us-ascii?Q?4G5k6zoyF3VK2GO2XLMxoN1k0Rbbh2xXKf4cJ+o98w0Ajf/AyxJvTiZv7Kk4?= =?us-ascii?Q?ITrgUvmA0aEaqR16itVQJRBwjTJd7a7vPhYLIZpf4iigs3DuHT456PGbM8VG?= =?us-ascii?Q?HdXYYSVJ+jZCJ/mkUQE8IdpuSMnV+FgFP5VaUBklUKlXekkLsuEgzOTdqaOe?= =?us-ascii?Q?FnR4G7ea+voApqeUGy73ONUJmM5vkLPuLp177erQ9fP6Q08hUSI5r9r3b6j3?= =?us-ascii?Q?XbCaBGUMajlK5cDjAel+h3gCSYavlWKd1yajgJLXGZrk1I5GTDNkWUkFMzZv?= =?us-ascii?Q?9Y8+qsrIa+7x6u248sxTCzDXe1yiFLrdzlKeJrvLA25A3hj0S6LMSAqNuCS8?= =?us-ascii?Q?PoXxZ0OOpxPjM5kV8zfXTu/UUbVci4cem2ae0Xmioi4PqGTuiak0YBICQ8dr?= =?us-ascii?Q?HU/xIdSs096UnGlPXYWSH1G/TvEeT9Rv9b3OC9+O9PimmTWEEpyH+eZbDJ6Z?= =?us-ascii?Q?aNh2VtI9YBKy7twAoN2XR1MwAnKZG1bCGAsaIGR96i7qPias8z7yFOqOXgRM?= =?us-ascii?Q?1f1RguqGtGnQtMk5bqZLvY0RP4d4YF3AqfIHvbDaaQ/ekplg5N/xhVunbBcw?= =?us-ascii?Q?eVI8Ft4jnOLQqgQEJa34emNFnP1xa8HJX+NmzHHXd5tMbtZ+Sf15RwV1M2e4?= =?us-ascii?Q?/d8LFZzqZ1Qwc9eh5YWxsKyKyeOjNjxDat3T/ykTlP3yfxjAXxwl4++iE3gs?= =?us-ascii?Q?6V6gcy/b53NFehvlWnDXZdDaT309AfmF3fmwO5prxmLDxVoFjD+AnZUVQI4P?= =?us-ascii?Q?TeJMGh5+NAzDXPplEOM8xczU54V3pcjr9iosg4HIKC6Voy1pft0/7lKCdALT?= =?us-ascii?Q?L4FfjG83dtnIOl/+IuxintGiHuqxtM8OVm2BDPgn5hLQpF5pHV56kvJbj0VI?= =?us-ascii?Q?fasPStY9apunZSvDk1maas5twTGgf+o1w7rA9CGrxlcoQ7rCXkkktkv9qXN1?= =?us-ascii?Q?KAs5kJKFlG8xHuVSEDkiguddYRBDfqqUUGhMDMsulQp7m8AtDQncNUUb30/2?= =?us-ascii?Q?K0ll0Tp/oEUhGiie2IKiN+O1OSak1UWb5UyFsqXJiABI6ZcVIqq+dGrtFLXH?= =?us-ascii?Q?UJ6XJHyZT8XjVb9ELM8JsBbAZ4mzzDwUHOFHHFe/eSJt0xwKfxv4WECSYvAR?= =?us-ascii?Q?ki95v57ykyJggbJMEHRyIJW+OYuF+uz9G21CLBdQ+jWnUYQSmrgK5NfwhsXw?= =?us-ascii?Q?vKZMDy7DN87knFIxM2E=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab33c6f0-2e83-4ff9-d9a0-08dbb8499307 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2023 13:17:14.1919 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AxSlY8LYT5ILl27TBKeZ17H8TyblcKZum7dv+Tp/KLH1N7vQ9MCMSizRnhdEYDyvOupjwrtx6q+rOMAPx3Ji7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5437 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lbg458xvLbgm1VFfYGcPW9Qlx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR12MB7031488D1402C696BCD72F96D9FBAMW4PR12MB7031namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=DgDbEDi1; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") --_000_MW4PR12MB7031488D1402C696BCD72F96D9FBAMW4PR12MB7031namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi @Abner Chang I update the function header of RedfishRestExSendReceive() in 2nd version a= nd I assume there is no need to update UEFI specification for this. Please = feel free to correct me if I am wrong. Thanks, Nickle > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Nickle Wan= g > via groups.io > Sent: Monday, September 18, 2023 9:13 PM > To: devel@edk2.groups.io > Cc: Abner Chang ; Igor Kulchytskyy ; > Nick Ramirez ; Mike Maslenkin > > Subject: [edk2-devel] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP > status code to caller. > > External email: Use caution opening links or attachments > > > Return unsupported HTTP status code to caller so caller can handle HTTP e= rror > status code. Current implementation only return EFI error to caller. With= out > knowing the HTTP status code, caller has trouble to handle HTTP request f= ailure. > > Signed-off-by: Nickle Wang = > > Cc: Abner Chang > > Cc: Igor Kulchytskyy > > Cc: Nick Ramirez > > Cc: Mike Maslenkin > > --- > MdePkg/Include/Protocol/RestEx.h | 3 ++- > .../RedfishRestExDxe/RedfishRestExProtocol.c | 27 ++++++++++--------- > 2 files changed, 16 insertions(+), 14 deletions(-) > > diff --git a/MdePkg/Include/Protocol/RestEx.h > b/MdePkg/Include/Protocol/RestEx.h > index e9bc7be94f2c..da9f1c3f87ef 100644 > --- a/MdePkg/Include/Protocol/RestEx.h > +++ b/MdePkg/Include/Protocol/RestEx.h > @@ -131,7 +131,8 @@ typedef struct { > response when the data is retrieved from the service. RequestMessage c= ontains > the HTTP > request to the REST resource identified by RequestMessage.Request.Url.= The > ResponseMessage is the returned HTTP response for that request, includ= ing any > HTTP > - status. > + status. It's caller's responsibility to free this ResponseMessage usin= g FreePool(). > + RestConfigFreeHttpMessage() in RedfishLib is an example to release > ResponseMessage structure. > > @param[in] This Pointer to EFI_REST_EX_PROTOCOL instan= ce for a > particular > REST service. > diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c > b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c > index 90973619f2bc..5bcdade4b18c 100644 > --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c > +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c > @@ -29,7 +29,8 @@ EFI_REST_EX_PROTOCOL mRedfishRestExProtocol =3D { > response when the data is retrieved from the service. RequestMessage c= ontains > the HTTP > request to the REST resource identified by RequestMessage.Request.Url.= The > ResponseMessage is the returned HTTP response for that request, includ= ing any > HTTP > - status. > + status. It's caller's responsibility to free this ResponseMessage usin= g FreePool(). > + RestConfigFreeHttpMessage() in RedfishLib is an example to release > ResponseMessage structure. > > @param[in] This Pointer to EFI_REST_EX_PROTOCOL instan= ce for a > particular > REST service. > @@ -320,6 +321,18 @@ ReSendRequest:; > DEBUG ((DEBUG_ERROR, "This HTTP Status is not handled!\n")); > DumpHttpStatusCode (DEBUG_REDFISH_NETWORK, ResponseData- > >Response.StatusCode); > Status =3D EFI_UNSUPPORTED; > + > + // > + // Deliver status code back to caller so caller can handle it. > + // > + ResponseMessage->Data.Response =3D AllocateZeroPool (sizeof > (EFI_HTTP_RESPONSE_DATA)); > + if (ResponseMessage->Data.Response =3D=3D NULL) { > + Status =3D EFI_OUT_OF_RESOURCES; > + goto ON_EXIT; > + } > + > + ResponseMessage->Data.Response->StatusCode =3D > + ResponseData->Response.StatusCode; > + > goto ON_EXIT; > } > > @@ -443,18 +456,6 @@ ON_EXIT: > FreePool (ResponseData); > } > > - if (EFI_ERROR (Status)) { > - if (ResponseMessage->Data.Response !=3D NULL) { > - FreePool (ResponseMessage->Data.Response); > - ResponseMessage->Data.Response =3D NULL; > - } > - > - if (ResponseMessage->Body !=3D NULL) { > - FreePool (ResponseMessage->Body); > - ResponseMessage->Body =3D NULL; > - } > - } > - > return Status; > } > > -- > 2.17.1 > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108780): https://edk2.groups.io/g/devel/message/108780 Mute This Topic: https://groups.io/mt/101432753/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MW4PR12MB7031488D1402C696BCD72F96D9FBAMW4PR12MB7031namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi @Abner Chang

 

I update the function header of RedfishRestExSend= Receive() in 2nd version and I assume there is no need to update UEFI speci= fication for this. Please feel free to correct me if I am wrong.=

 

Thanks,

Nickle

 

> -----Original Message-----

> From: devel@edk2.groups.io <devel@edk2.gr= oups.io> On Behalf Of Nickle Wang

> via groups.io

> Sent: Monday, September 18, 2023 9:13 PM

> To: devel@edk2.groups.io

> Cc: Abner Chang <abner.chang@amd.com>;= Igor Kulchytskyy <igork@ami.com>;

> Nick Ramirez <nramirez@nvidia.com>; Mi= ke Maslenkin

> <mike.maslenkin@gmail.com>

> Subject: [edk2-devel] [PATCH v2] RedfishPkg/= RedfishRestExDxe: return HTTP

> status code to caller.

>

> External email: Use caution opening links or= attachments

>

>

> Return unsupported HTTP status code to calle= r so caller can handle HTTP error

> status code. Current implementation only ret= urn EFI error to caller. Without

> knowing the HTTP status code, caller has tro= uble to handle HTTP request failure.

>

> Signed-off-by: Nickle Wang <nicklew@nvidia.com>

> Cc: Abner Chang <abner.= chang@amd.com>

> Cc: Igor Kulchytskyy <igork@a= mi.com>

> Cc: Nick Ramirez <nrami= rez@nvidia.com>

> Cc: Mike Maslenkin <mike.maslenkin@gmail.com>

> ---

>  MdePkg/Include/Protocol/RestEx.h =              |&= nbsp; 3 ++-

>  .../RedfishRestExDxe/RedfishRestExProt= ocol.c  | 27 ++++++++++---------

>  2 files changed, 16 insertions(+), 14 = deletions(-)

>

> diff --git a/MdePkg/Include/Protocol/RestEx.= h

> b/MdePkg/Include/Protocol/RestEx.h

> index e9bc7be94f2c..da9f1c3f87ef 100644

> --- a/MdePkg/Include/Protocol/RestEx.h

> +++ b/MdePkg/Include/Protocol/RestEx.h

> @@ -131,7 +131,8 @@ typedef struct {

>    response when the data is = retrieved from the service. RequestMessage contains

> the HTTP

>    request to the REST resour= ce identified by RequestMessage.Request.Url. The

>    ResponseMessage is the ret= urned HTTP response for that request, including any

> HTTP

> -  status.

> +  status. It's caller's responsibility= to free this ResponseMessage using FreePool().

> +  RestConfigFreeHttpMessage() in Redfi= shLib is an example to release

> ResponseMessage structure.

>

>    @param[in]  This = ;            &n= bsp;  Pointer to EFI_REST_EX_PROTOCOL instance for a

> particular

>        &n= bsp;            = ;            &n= bsp;  REST service.

> diff --git a/RedfishPkg/RedfishRestExDxe/Red= fishRestExProtocol.c

> b/RedfishPkg/RedfishRestExDxe/RedfishRestExP= rotocol.c

> index 90973619f2bc..5bcdade4b18c 100644

> --- a/RedfishPkg/RedfishRestExDxe/RedfishRes= tExProtocol.c

> +++ b/RedfishPkg/RedfishRestExDxe/RedfishRes= tExProtocol.c

> @@ -29,7 +29,8 @@ EFI_REST_EX_PROTOCOL = mRedfishRestExProtocol =3D {

>    response when the data is = retrieved from the service. RequestMessage contains

> the HTTP

>    request to the REST resour= ce identified by RequestMessage.Request.Url. The

>    ResponseMessage is the ret= urned HTTP response for that request, including any

> HTTP

> -  status.

> +  status. It's caller's responsibility= to free this ResponseMessage using FreePool().

> +  RestConfigFreeHttpMessage() in Redfi= shLib is an example to release

> ResponseMessage structure.

>

>    @param[in]  This = ;            &n= bsp;  Pointer to EFI_REST_EX_PROTOCOL instance for a

> particular

>        &n= bsp;            = ;            &n= bsp;  REST service.

> @@ -320,6 +321,18 @@ ReSendRequest:;

>      DEBUG ((DEBUG_= ERROR, "This HTTP Status is not handled!\n"));

>      DumpHttpStatus= Code (DEBUG_REDFISH_NETWORK, ResponseData-

> >Response.StatusCode);

>      Status =3D EFI= _UNSUPPORTED;

> +

> +    //

> +    // Deliver status code b= ack to caller so caller can handle it.

> +    //

> +    ResponseMessage->Data= .Response =3D AllocateZeroPool (sizeof

> (EFI_HTTP_RESPONSE_DATA));

> +    if (ResponseMessage->= Data.Response =3D=3D NULL) {

> +      Status =3D E= FI_OUT_OF_RESOURCES;

> +      goto ON_EXIT= ;

> +    }

> +

> +    ResponseMessage->Data= .Response->StatusCode =3D

> + ResponseData->Response.StatusCode;

> +

>      goto ON_EXIT;<= /p>

>    }

>

> @@ -443,18 +456,6 @@ ON_EXIT:

>      FreePool (Resp= onseData);

>    }

>

> -  if (EFI_ERROR (Status)) {

> -    if (ResponseMessage->= Data.Response !=3D NULL) {

> -      FreePool (Re= sponseMessage->Data.Response);

> -      ResponseMess= age->Data.Response =3D NULL;

> -    }

> -

> -    if (ResponseMessage->= Body !=3D NULL) {

> -      FreePool (Re= sponseMessage->Body);

> -      ResponseMess= age->Body =3D NULL;

> -    }

> -  }

> -

>    return Status;

>  }

>

> --

> 2.17.1

>

>

>

>

>

 

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#108780) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MW4PR12MB7031488D1402C696BCD72F96D9FBAMW4PR12MB7031namp_--