From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 962D4941995 for ; Thu, 26 Oct 2023 12:58:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NTGeJtdYPgi5MoMKxhrWgMf48xf2HW4A0xXDdajmx7w=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698325109; v=1; b=w40yBh5emaAKZXg+eWru2dYghCd5WGgiFCNQZJIqjrkMDRnlFAaFJZiBqLg0tL990v9UUZ2W xQpO+XTM3XyPlBO1hToeRIQ3XjnEUqv6tHPQHlcs1JdIcgrVTi566EA3EeC1MtsdNsPnNUOxxlE BipgWB3cxjpfg74JOhrJBx+k= X-Received: by 127.0.0.2 with SMTP id CbKgYY7687511xXWgvgGDtVb; Thu, 26 Oct 2023 05:58:29 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web10.199358.1698325108568202167 for ; Thu, 26 Oct 2023 05:58:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZB2+SmjNDhZYt40zn3Ld9mZkmVv6EuEbgJz5rSU4kibrE7x2/fxS4FeLyvz8+tAWnlpV0hI5aS0NirfsOOsvxoH1FIrLKKRap6xbawyChxIljCBfFgNQZE1tGxt30uqoQgdgI7AaSC5F4I70cEfoJKFhiJlcUMoAfGIZkuJjR1rdWLRjunl0918+z9VOH/4m0qebIT2Q99AQxr2okPF2vLWjKqVXf7rZxtKOK1oTZq3cpF8cGWtGZiKLZb2GvCVo5RctzSvejv7MdJlRbSokeBsYXBFvr2Mhe6+hzUDCDGxdjo8RNy5OJgOx1lj82p6uFVwNjoPgA2wf18yQDWVypQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0BY7O2BoQWhzaW+/Z0AXEVbA8hVEPAmcLjkeHIPynSU=; b=bTzww4i/11Ug83VAaXTrkx58vVEtychYG4reBc8Re3aLltEc0nC0lHgysfWjE22GolxtP2SQjwNAo3e7VGPO9B4gwbzfx4I8Ob0htqtScZoNRF8Zw1JylJVvZG9jS9z3pZgRWFUGFQVspDxS5vBtfCPf5P1iidAK3vKeyKgWvvkET5sXy9sZXIfEYcNG6sDsuTDIJnrLgZ8FmxVntsZ6DorLWgI/WXpX8LOEWZSL7sCAsCTtco3FSlfNzIIl8gVkJ/4ImKpCQBo20IFT3XEaNtMPl5TyE69bYOw7gqECYb3XcEnJWmdgeVPlsm1iokobhRFkHTGB0xABtdzC2wY2Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by DM4PR12MB5181.namprd12.prod.outlook.com (2603:10b6:5:394::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Thu, 26 Oct 2023 12:58:25 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9e7:5f16:2a5a:7be]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::d9e7:5f16:2a5a:7be%4]) with mapi id 15.20.6907.032; Thu, 26 Oct 2023 12:58:25 +0000 From: "Nickle Wang via groups.io" To: Igor Kulchytskyy , "Chang, Abner" , "devel@edk2.groups.io" CC: Nick Ramirez Subject: Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller Thread-Topic: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller Thread-Index: AQHaBlWyEJtthRqT+UuBsO9C4/wzpLBbmWhQgABvrYCAAACmIA== Date: Thu, 26 Oct 2023 12:58:25 +0000 Message-ID: References: <20231024083944.16275-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=cfbc3f75-dde8-4c77-a5a6-b619356f2f83;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-26T06:09:54Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|DM4PR12MB5181:EE_ x-ms-office365-filtering-correlation-id: b374b042-89e0-4975-5729-08dbd6233e0e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: isWdxBUMEZgAqit2EG62laIizhVI4d2U6Ea675gOzhoQ1sLvJUjNf7XtlIT7ONOPvtiViekNcz+2k5Yico+e8XZkJbqrCsdFp8ImGMlDpBWo2clbXeMo/XNBM3krvK92SsCShVDSF56JzlNapNdLYqsiM+Y0FvGeH1Lj+sfwTzjWNvU/o2egTWJE4h0JlEpW9hG17GW1m6kEESOk8e5rCdgL9kaXt18LkbMSm9NrSFagJfAGrLtglcFo5wKRIzmkPkA0bX/9BH3vgsxQ1i1hkzaXYadwRZSn2ykGvQ4LMSRziE0TmU8fqoAwfds0AzL/8T/m2HTYdLkDJLAP4CuL0dTc9GouOKwEkv1UyXq0PQf9KbS7gL34If5E61J0ysQPtH50ApvbjDuLD4lu0ZNCnAshFseDNxL600+aJVTPXHQCyiSarncZDi+m+Nm+dptvsCPY4PaIaSGFGD1C2vID8z6XUb1V6VdXqYtBpXcDysNj4iq0kYuAQ+N2LSEFa4m3AYIoQ6YKl1WV5zJPu3li0MS/QtclgLn38Oxk7jW+VMHnC2mAzarsaNZw9eaOJqBA67fGOdmx8jH8zQwgdle3cL0TbS42547hboffsv70i2yL+YHvXclJIjeJiOYCsQ/N x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SbeZMyaiDVvxnqCcMNXQGwiIT4IMW7hkkeIGJpicxLxQ+lJKTsQMqO81FMV7?= =?us-ascii?Q?bo5sIBxfOf24AS5rTxUkKbkfJcl2SeJTSul95LBvXZQILVfl9oqOc/xSUOre?= =?us-ascii?Q?lzJIcMg6dUDitel+N1+vYw3qIhvUKh9A0jnv5iA4BQW7U5k6GKBtSuAU1TPL?= =?us-ascii?Q?g1brOpP/ZA0IEvD4daUadpPIToyj5jZtm2PVKx0H0KeJkwyC1Dq50A5+HWbF?= =?us-ascii?Q?SOAL/tpP5F37sDCsNYImuXgW9NTO7hWvTOBAvecC4kRsMBjk2EHmtmlMUoLd?= =?us-ascii?Q?U9FDjC5tpRxverP+03+jjX8+OIuNxUV6o/u7uyfo5kGhVfN80Qn/tkhogOfE?= =?us-ascii?Q?FniqX82+ldX9DdFyW6CnqhrTxfYYiCAQzvIiLDk8nk0BH4Qr5trdBBQhQ0BE?= =?us-ascii?Q?MDhZpEtpYea7biod59drx9/PKE2+7k6xW+Twj30fxmiXhzGEpXL5ciAzfSQp?= =?us-ascii?Q?eDdJxRvlqv04t0zOMytEb8pUFfr5umQF2Q1f3X/vSB/3A4e08kTNwD8SedVe?= =?us-ascii?Q?VOzJ7CvmwOnTwbm+7+bafIKhL+inZHbwUN/UK9Nq+0t88zN2PegLlFttk6LA?= =?us-ascii?Q?nKZge4UxjJigZlQ+E1ipYkFgs9lkHgsZR93b2nEnhc8IuwcSUWi2ss/U9JmL?= =?us-ascii?Q?+XITrgfcKYyOZf5TCigC6NVxKiZaZb6TZ5wX0u1VvhBkkME0IjgceQ53Q2Lu?= =?us-ascii?Q?SRHnP0vKuQctQzzgYvRrAUZNDCbF7v1flFg/jH6xJu50phgqjka3CF+jsLdV?= =?us-ascii?Q?lv/lE+Rt/Z+0DptdN1g+8/7R+VbYuLrBlLmbS599Jwi2EhXyw/5VIum4h6mT?= =?us-ascii?Q?p9lwEKC3LIBae3Ddt/RYHC3BF7wuquI/C2kVI3XCvl1lN761tz1nb5+Pbyjc?= =?us-ascii?Q?RcdnT3Pj8HM01XEzpPA30hC53iWr7kHomal+t8IBIWzQLS+kW+yKVrWUWMm9?= =?us-ascii?Q?2ewyn6d1G1/75fTPj6PjWoLf5dHZMoOImAUJxk10dFSzR7tFLIUU90TvkgLa?= =?us-ascii?Q?2X7ckEs6qXo1abSTy0tV6tZVocI0rEK+wvm6c8hM7uhg6CjLnjd6K31WsJtp?= =?us-ascii?Q?IYKz1J3LSr/Oe1nN52XOkkYKc5hwB6nCn5DpoKSidwIxk6+eDQhFi0Pw7q76?= =?us-ascii?Q?BuDn/JWmYogqeA/4Nh0XucbUeL8POa3bEouWMvIv0Zw+sG366WF4m/U58fso?= =?us-ascii?Q?s06MUka2tIAbZcEH8A1bjigieXuErVvBKZmERNdaw195l5b+KDP6jecsWUKt?= =?us-ascii?Q?y/jtRj/Wk0X6o+KAzAuo4xCjBIriyDyfuurcVNqtnclCmvu8UrOHfDgS6LrY?= =?us-ascii?Q?xDH0njwe62BDYuK0Yv1g/qi7/8vt9LMHxmdV5QJsKqEQBl8clTb8UERgY68t?= =?us-ascii?Q?RPYTvcAFmIR7rPaQAWpTm/nFvKRHFf9nopd0hi3bnnd4Qf6618g7+r67FYhz?= =?us-ascii?Q?AjDxzFmNcIvfgRLb9SJZjy0uzOzyHTBso3a1FwUNp5ZFQqipYVxHcoSMrHyB?= =?us-ascii?Q?J3iZVMFkufqQNCznyHW09dWdmiW7QpEj3ZaVTqvzddO7IxM/l3t3gmZN5MNn?= =?us-ascii?Q?c7yrj8ATu2yV/Jka414=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b374b042-89e0-4975-5729-08dbd6233e0e X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2023 12:58:25.5787 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uSrQEzDILOHKxQ4BVGEqAsaU4Wv/lSguZWxpK1vdDKxnr0TJIwYt4DE8/MaeJA1LwNvCxZMXePeWC7ZF3k1HDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5181 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: u7qKyeYQABgJV8f2WmrE7yVjx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=w40yBh5e; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Igor, If the DELETE request to BMC is handled by Redfish task, we need to return = HTTP header to caller so caller can get Task URI. But from BIOS Redfish per= spective, I don't see this use case yet. Thanks, Nickle > -----Original Message----- > From: Igor Kulchytskyy > Sent: Thursday, October 26, 2023 8:50 PM > To: Chang, Abner ; Nickle Wang > ; devel@edk2.groups.io > Cc: Nick Ramirez > Subject: RE: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTT= P > headers to caller >=20 > External email: Use caution opening links or attachments >=20 >=20 > Hi Nickle, > Just one quick question. > Is there any sense to return the headers for DELETE request? > Thank you, > Igor >=20 > -----Original Message----- > From: Chang, Abner > Sent: Thursday, October 26, 2023 2:10 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP > headers to caller >=20 >=20 > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance= .** >=20 > [AMD Official Use Only - General] >=20 > Reviewed-by: Abner Chang >=20 > > -----Original Message----- > > From: Nickle Wang > > Sent: Tuesday, October 24, 2023 4:40 PM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; Igor Kulchytskyy > > ; Nick Ramirez > > Subject: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to > > caller > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Call Ex interface to get HTTP headers and return to caller. > > > > Signed-off-by: Nickle Wang > > Cc: Abner Chang > > Cc: Igor Kulchytskyy > > Cc: Nick Ramirez > > --- > > RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > index f4045044829a..5e06d516ba84 100644 > > --- a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > +++ b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > @@ -356,7 +356,7 @@ RedfishGetByUri ( > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > - JsonValue =3D getUriFromService (RedfishService, Uri, &Re= dResponse- > > >StatusCode); > > + JsonValue =3D getUriFromServiceEx (RedfishService, Uri, &= RedResponse- > > >Headers, &RedResponse->HeaderCount, &RedResponse->StatusCode); > > RedResponse->Payload =3D createRedfishPayload (JsonValue, > > RedfishService); > > > > // > > @@ -498,10 +498,12 @@ RedfishPatchToUri ( > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > - JsonValue =3D (EDKII_JSON_VALUE)patchUriFromService ( > > + JsonValue =3D (EDKII_JSON_VALUE)patchUriFromServiceEx ( > > RedfishService, > > Uri, > > Content, > > + &(RedResponse->Headers), > > + &(RedResponse->HeaderCount), > > &(RedResponse->StatusCode) > > ); > > > > @@ -661,12 +663,14 @@ RedfishPostToUri ( > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > - JsonValue =3D (EDKII_JSON_VALUE)postUriFromService ( > > + JsonValue =3D (EDKII_JSON_VALUE)postUriFromServiceEx ( > > RedfishService, > > Uri, > > Content, > > ContentSize, > > ContentType, > > + &(RedResponse->Headers), > > + &(RedResponse->HeaderCount), > > &(RedResponse->StatusCode) > > ); > > > > -- > > 2.17.1 >=20 > -The information contained in this message may be confidential and propri= etary > to American Megatrends (AMI). This communication is intended to be read o= nly by > the individual or entity to whom it is addressed or by their designee. If= the reader > of this message is not the intended recipient, you are on notice that any > distribution of this message, in any form, is strictly prohibited. Please= promptly > notify the sender by reply e-mail or by telephone at 770-246-8600, and th= en > delete or destroy all copies of the transmission. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110096): https://edk2.groups.io/g/devel/message/110096 Mute This Topic: https://groups.io/mt/102154017/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-