Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol

["Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>]

Hi Laszlo,

Thanks for your reminder. I enable sendemail.thread now.

Regards,
Nickle

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Thursday, February 29, 2024 5:04 PM
> To: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP
> protocol
> 
> External email: Use caution opening links or attachments
> 
> 
> Hi Nickle,
> 
> On 2/29/24 09:52, Nickle Wang via groups.io wrote:
> > Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
> > RedfishClientPkg to use RedfishHttpLib. And remove the use of
> > RedfishHttpCacheLib.
> >
> > I also replace several functions from RedfishLib with the function
> > provided in RedfishHttpLib. In this way, there is no dependency on
> > RedfishLib in RedfishClientPkg.
> >
> > I noticed that there is false alarm in uncrustify check. When there
> > are deleted files, uncrustiry cannot check them and trigger uncrustify
> > failure.
> >
> > Pull request is created here for testing CI:
> > https://github.com/tianocore/edk2-redfish-client/pull/79
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> >
> > Nickle Wang (13):
> >   RedfishClientPkg/.github: do not run uncrustify to deleted file.
> >   RedfishClientPkg: remove RedfishHttpCacheLib
> >   RedfishClientPkg: ues RedfishHttpLib
> >   RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib
> >   RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib
> >   RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib
> >   RedfishClientPkg/BiosDxe: ues RedfishHttpLib
> >   RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib
> >   RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
> >   RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib
> >   RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib
> >   RedfishClientPkg/MemoryDxe: ues RedfishHttpLib
> >   RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib
> 
> can you please enable (shallow) threading in your git config?
> 
> $ git config sendemail.thread true
> 
> Thanks!
> Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116155): https://edk2.groups.io/g/devel/message/116155
Mute This Topic: https://groups.io/mt/104640214/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-