From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6E74BD811A7 for ; Tue, 9 Jan 2024 11:14:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3do82+27NXY6HyESHr+4XCwOPOZcSGsMzsSc9Gg/DNw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1704798896; v=1; b=lwkLxfZgqSsNSCdIgCYI29dbleaQXDFHv08rbDjYHXOEFGZwGBS2k9dvPKpHarwFWTXQG56l rptNbIGwPGsmlgiTNkedkTgu+OLgGiCSWyPaxqOSZAzU3eXcfCDyBUGG7Y5hTamRK2RB+xZ518U ZsLFWiA5VZ1sYvW5eCPkU6gs= X-Received: by 127.0.0.2 with SMTP id yEQtYY7687511xAGRowmtIAK; Tue, 09 Jan 2024 03:14:56 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.45]) by mx.groups.io with SMTP id smtpd.web11.14229.1704798895322662227 for ; Tue, 09 Jan 2024 03:14:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lickN7KglraP3BGERdkAJz6JZSZQcnEE+qgEHbYOSic1bV1B4LVIySmy7KuOWFMDPk/mMxKMpDPNC8MS4y5AqWLYR1iyNJbmS2paOGKsjcp658KT0Q5p3XkgVAgF6CpyO/ysX1IdgCDPLaxSJ4HJ0EcWHDlOnxXOeM6epdn5BB4rzh2Eg+pW0Kbkj3x+g/vnpd2J43ywnmWOKYbBcsuf0CvvxSW7JVXwBGMFy+4ebIhbW5EpYbtAb8nF5fwR0zwQzDF97/+8p0IK+tGJrsQjoX/cT/2JDQptYDOelB5u/a7DgEU3jdA6NfPXjbu+6oU925a6AztjRFCCbV36X/j04A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N46oyEPAKQJem0eog2938oT/uPf/4x9kLGrPl7dKDfg=; b=nuQnIXDZFdznTNg6KLTIwOiNEaj79MsKO1S9OKPd3RaTA/vrFguPiuX4XZ10vWfNi4pKpb6wIhD6FkrP4E3hN0MXHGd89JRnbyPPImONED2wKacUBUJuQ5ps55MyDcqPRWkFwB1iZ9t3NPhkf1cHwvC2cSEOqmqjJfox+l1acpxBsTR/7DGF900eGDwJR/n65FJtLEURyP5JZkTGy5xWYZO3FV4TEJXokt23XQ4xz1YU9dyTvYaiVIlGNGHXSA/LbGhm9Yxt5i/E3XDD0vT4QJ2ImNU6iMBpwsRO5UrreemPYUKF3xtLYYvTaLNmoEWcPckhkazYCYZGXkaV3p65AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by CH0PR12MB5186.namprd12.prod.outlook.com (2603:10b6:610:b9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Tue, 9 Jan 2024 11:14:52 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4%3]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024 11:14:52 +0000 From: "Nickle Wang via groups.io" To: "Chang, Abner" , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDebugLib: add function to print buffer. Thread-Topic: [PATCH] RedfishPkg/RedfishDebugLib: add function to print buffer. Thread-Index: AQHaQsuIgC3vEycfh069dT3ZWb/2mrDRGxNwgAA5V5A= Date: Tue, 9 Jan 2024 11:14:52 +0000 Message-ID: References: <20240109071432.32648-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US X-Mentions: Abner.Chang@amd.com X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=c67af31a-2a92-4ca0-8a0f-cf7211cf6521;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-01-09T07:49:11Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|CH0PR12MB5186:EE_ x-ms-office365-filtering-correlation-id: 65f78894-8f59-4fbc-abc7-08dc1104336e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: k6ChlpV0I+h+syVAQgyHt6jMOPhuKOv9Wa3OP5m27Xs7zXdKvrJDRZpQEutzLuW/WDwcVVa8vbXly9uo1k6Ety+L2AfuFkgCDgug1GLLnPiM7lK+0L8YzuEoglnM9rMWj2g/cXM1cebStw7AexwD74aaJS3YNqQINu5dTzi7iz3181hr2yQXZNFvmegap8mmMslquqMvUYRHnRsraZjn+F15R0svsJb4NdL7q9w9pE6dlMyr910mUF9P209ta3ENSsiaUZq9ZLE9iCpUekHpP7eeC8EZALFpJIubL/MKgQc0SCVhTNu+X95j8o3PyR7NYZqpi6b7NIwbbjwUVnLJCNBprgbLzsX5BWrsPlJ4da61nVk1i9CJlrP28T1yYxysWr3mwzlLHy2DLKF2ilSrtOxrR3U5rsxkWXaGpd0sVCE2iPPP+Zy1sivY0zEVIpHC4i0Cz3sEepCRt88CYNBq/nrNghCZ7jALkVYoYNWCSccu+IpPbp0wmn5OwgITiobtPWSgRizOCIbecMiMe1w2nHldif8ZSKWOdaH9CkJPdEE0q/uoxAJ4dxJmsXBAKsicOPaAUnKM/aWemI5OQ+M2Skm9+nCLbJCKG5oh2doYHcp9LySW/rGtr2sdKSHDCdx9UQHkRGd8/xAkJ1B10Bo/NA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3PLzk5Jf3DJOYGnF6HFoo22lgsoj30iYGEXQD9gQstxyeevAhfZRMo+qAznV?= =?us-ascii?Q?YOC+7AbJLW9Ia78CRRfEdCOMIvqYwUEoPreHLGxEVRSez8ueLHt9EmvVzM/N?= =?us-ascii?Q?+1mFlsCxzwAolmYB+TTjS/PISvrjmHr4sIb7TPNwz3TjBKcbaYKvM1J0BTtj?= =?us-ascii?Q?X3xZavLu4u7s5rv0OMGf9VxYZ5aK73xd0WNm+si7TWsOkc98vLggEn6My0YO?= =?us-ascii?Q?1/A8CBgVBKX/ikSFtDPsHyLVcY/BwYt6nkWk2jEWUXwCPGwKTCTbLbHm2Uqf?= =?us-ascii?Q?nAbGx2g+kjZSAMUJ6d7t8CHQwiHoUNM9ybH+XWsXGspuPdwcxbtdxg7v3Vxb?= =?us-ascii?Q?8RjGGSRDs/uuGrKKEFQaj7eZ08+Fax+m2jAPsQQHTO3VhzlEFiLKhLD4+Ckj?= =?us-ascii?Q?ag5yxeOWNvseTgOAUw3sDKbdLIJF0iEzgsZNsmKhE5zPlehmKJWTfRRsToTY?= =?us-ascii?Q?gvT+xJa5VvtDPA77Nw3hgqVXRHJF3hPyW/GuLPECID8GNE6TET0RNh5HELRi?= =?us-ascii?Q?ldk2hvwkey6FP7n7iQU0m8MIqQ+dy6Af0N+xQ1ZEO8kdTRng3lKjeCo4s5xG?= =?us-ascii?Q?afEvM6R1aLeKwfzEBsF9qXZjgmDr4IPgXqGR300+WETMQeplAtXIPRl7tFDt?= =?us-ascii?Q?OFpunk0Shl42qoAPOTQp8GIbXSIH5lCJkUPtDqTqWYDmYdm8iKDXTdtsqJrn?= =?us-ascii?Q?bMW3XVXAiBN7oUwBRtHynvS/JwFdYIF0ft6An7POqXPndzeXbzjEat6xkQcz?= =?us-ascii?Q?v3QABrzzeiNQ67eIM2sKI0RtClewnNT2APOQb6at90MGFmwn/llZBSGFUdd7?= =?us-ascii?Q?viTp7M2Ym5pXXzalXJYXtjEOvWZFatHpiLl3hTky+ULk21cF5TdIJpXR4bGO?= =?us-ascii?Q?FDzT+Y3jz5xEo/+Gw1vBnYfo7l1LZZizha1A350YApx+Gkzm3QFYhMcxWhGN?= =?us-ascii?Q?b0s1xU9XSXzDicB4bY6ueE64ajXLkHRK38x8OC7yMphnPhlQV8ltQH0t+fqr?= =?us-ascii?Q?KW7x945wrlYnIYEjAg8c/ZrgC1wyTuh6bIGUgJp7Y0BH8fE7lQg7RprKYfnP?= =?us-ascii?Q?XbiYrdCPeGC1KEch/r97skIpA4cIynzpTCtDcYpXAaDfnHDB+Cto2ZIb1j9F?= =?us-ascii?Q?7VOOfen/ySCqNVatRyko5eYQ76enWBYRDIBZZ/jeSbLmuoRtlQujeSF3uUaE?= =?us-ascii?Q?ABRpPRY92ajowDW4QE+LYXFAhWn0icUiGPHbm/ZSAPjhEuu5exZcciOPQyVU?= =?us-ascii?Q?7IjH6a+zE+5I3iHfNHxdIrlI3PPBwEjN+TOTsKZmj7zqGUydYzcX08my8FUa?= =?us-ascii?Q?svcY5mQJKa6XcTzGDKMz3Fn6zl8TTZBpUZxwplO+CU3OjQcCt2OqDyPtweNS?= =?us-ascii?Q?jHV4V92Gt0YgPlC6ATf+Nn2cLSCrehb+VTUFrWqgaeSSCYc6y4uDd8j1Q2DK?= =?us-ascii?Q?eTslk0tVK8vRz9cx3eY+bTwGTRj5SOd90pt4Y4jvrctsIHZVtYc4e4stPjre?= =?us-ascii?Q?WU2EKmiRyRcSI2feedo2nG7wIW93c/Fmm9Nhc5W+Pg846vbjq1bnFXr+h6K/?= =?us-ascii?Q?HtFNoZN626CBURtjYLBLzNcmGqoQB4auAjwBhFdj?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65f78894-8f59-4fbc-abc7-08dc1104336e X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2024 11:14:52.0182 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ji0rZqlfWOKi4nyuMNhBjN96qAsQLFKZJqe0PubLTBgDkRBxRnHAdvUw2dqC+wRaIh6yNuxY/hSo0eeL855vBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5186 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7wCzqUL399u8lngLvqcmGQv5x7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR12MB70315861AF23CE0C04019195D96A2MW4PR12MB7031namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=lwkLxfZg; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") --_000_MW4PR12MB70315861AF23CE0C04019195D96A2MW4PR12MB7031namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for your review, @Chang, Abner! Version= 2 patch is sent for review here: https://edk2.groups.io/g/devel/message/11= 3439 Regards, Nickle > -----Original Message----- > From: Chang, Abner > Sent: Tuesday, January 9, 2024 4:00 PM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: RE: [PATCH] RedfishPkg/RedfishDebugLib: add function to print bu= ffer. > > External email: Use caution opening links or attachments > > > [AMD Official Use Only - General] > > > -----Original Message----- > > From: Nickle Wang > > > Sent: Tuesday, January 9, 2024 3:15 PM > > To: devel@edk2.groups.io > > Cc: Chang, Abner >; Igo= r Kulchytskyy > > >; Nick Ramirez > > > Subject: [PATCH] RedfishPkg/RedfishDebugLib: add function to print buff= er. > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Introduce DumpBuffer function to print the buffer content. This helps > > developer to debug Redfish issue. > > > > Signed-off-by: Nickle Wang > > > Cc: Abner Chang > > > Cc: Igor Kulchytskyy > > > Cc: Nick Ramirez > > > --- > > RedfishPkg/Include/Library/RedfishDebugLib.h | 20 ++++++++- > > .../Library/RedfishDebugLib/RedfishDebugLib.c | 41 ++++++++++++++++++- > > 2 files changed, 59 insertions(+), 2 deletions(-) > > > > diff --git a/RedfishPkg/Include/Library/RedfishDebugLib.h > > b/RedfishPkg/Include/Library/RedfishDebugLib.h > > index 5f75bad12a..3430cf1d14 100644 > > --- a/RedfishPkg/Include/Library/RedfishDebugLib.h > > +++ b/RedfishPkg/Include/Library/RedfishDebugLib.h > > @@ -1,7 +1,7 @@ > > /** @file > > This file defines the Redfish debug library interface. > > > > - Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights rese= rved. > > + Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES. All > > + rights > > reserved. > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -138,4 +138,22 @@ DumpIpv4Address ( > > IN EFI_IPv4_ADDRESS *Ipv4Address > > ); > > > > +/** > > + Debug output raw data buffer. > > + > > + @param[in] ErrorLevel DEBUG macro error level > > + @param[in] Buffer Debug output data buffer. > > + @param[in] BufferSize The size of Buffer in byte. > > + > > + @retval EFI_SUCCESS Debug dump finished. > > + @retval EFI_INVALID_PARAMETER Buffer is NULL. > > + > > +**/ > > +EFI_STATUS > > +DumpBuffer ( > > + IN UINTN ErrorLevel, > > + IN UINT8 *Buffer, > > + IN UINTN BufferSize > > + ); > > + > > #endif > > diff --git a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c > > b/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c > > index efa9a5ca13..5fd40ad955 100644 > > --- a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c > > +++ b/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c > > @@ -1,7 +1,7 @@ > > /** @file > > Redfish debug library to debug Redfish application. > > > > - Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights rese= rved. > > + Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES. All > > + rights > > reserved. > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -21,6 +21,7 @@ > > > > #define REDFISH_JSON_STRING_LENGTH 200 #define > > REDFISH_JSON_OUTPUT_FORMAT (EDKII_JSON_COMPACT | > > EDKII_JSON_INDENT(2)) > > +#define REDFISH_SIZE_PER_ROW 16 > > How about name this as REDFISH_PRINT_BUFFER_BYTES_PER_ROW, looks more > clear. > > Abner > > > > > /** > > Debug print the value of StatementValue. > > @@ -366,3 +367,41 @@ DumpIpv4Address ( > > > > return EFI_SUCCESS; > > } > > + > > +/** > > + Debug output raw data buffer. > > + > > + @param[in] ErrorLevel DEBUG macro error level > > + @param[in] Buffer Debug output data buffer. > > + @param[in] BufferSize The size of Buffer in byte. > > + > > + @retval EFI_SUCCESS Debug dump finished. > > + @retval EFI_INVALID_PARAMETER Buffer is NULL. > > + > > +**/ > > +EFI_STATUS > > +DumpBuffer ( > > + IN UINTN ErrorLevel, > > + IN UINT8 *Buffer, > > + IN UINTN BufferSize > > + ) > > +{ > > + UINTN Index; > > + > > + if (Buffer =3D=3D NULL) { > > + return EFI_INVALID_PARAMETER; > > + } > > + > > + DEBUG ((ErrorLevel, "Address: 0x%p size: %d\n", Buffer, > > + BufferSize)); for (Index =3D 0; Index < BufferSize; Index++) { > > + if (Index % REDFISH_SIZE_PER_ROW =3D=3D 0) { > > + DEBUG ((ErrorLevel, "\n%04X: ", Index)); > > + } > > + > > + DEBUG ((ErrorLevel, "%02X ", Buffer[Index])); } > > + > > + DEBUG ((ErrorLevel, "\n")); > > + > > + return EFI_SUCCESS; > > +} > > -- > > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113440): https://edk2.groups.io/g/devel/message/113440 Mute This Topic: https://groups.io/mt/103616099/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MW4PR12MB70315861AF23CE0C04019195D96A2MW4PR12MB7031namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Thanks for your review, @Chang, Abner!  Version 2 patch is sent for review her= e: https://edk2.grou= ps.io/g/devel/message/113439

 

Regards,

Nickle

 

> -----Original Message-----

> From: Chang, Abner <Abner.Chang@amd.com&g= t;

> Sent: Tuesday, January 9, 2024 4:00 PM

> To: Nickle Wang <nicklew@nvidia.com>; = devel@edk2.groups.io

> Cc: Igor Kulchytskyy <igork@ami.com>; = Nick Ramirez <nramirez@nvidia.com>

> Subject: RE: [PATCH] RedfishPkg/RedfishDebug= Lib: add function to print buffer.

>

> External email: Use caution opening links or= attachments

>

>

> [AMD Official Use Only - General]

>

> > -----Original Message-----

> > From: Nickle Wang <= nicklew@nvidia.com>

> > Sent: Tuesday, January 9, 2024 3:15 PM<= /p>

> > To: devel@edk2.group= s.io

> > Cc: Chang, Abner <= Abner.Chang@amd.com>; Igor Kulchytskyy

> > <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com&g= t;

> > Subject: [PATCH] RedfishPkg/RedfishDebu= gLib: add function to print buffer.

> >

> > Caution: This message originated from a= n External Source. Use proper

> > caution when opening attachments, click= ing links, or responding.

> >

> >

> > Introduce DumpBuffer function to print = the buffer content. This helps

> > developer to debug Redfish issue.

> >

> > Signed-off-by: Nickle Wang <nicklew@nvidia.com>

> > Cc: Abner Chang <a= bner.chang@amd.com>

> > Cc: Igor Kulchytskyy <ig= ork@ami.com>

> > Cc: Nick Ramirez <= nramirez@nvidia.com>

> > ---

> >  RedfishPkg/Include/Library/Redfis= hDebugLib.h  | 20 ++++++++-

> > .../Library/RedfishDebugLib/RedfishDebu= gLib.c | 41 ++++++++++++++++++-

> >  2 files changed, 59 insertions(+)= , 2 deletions(-)

> >

> > diff --git a/RedfishPkg/Include/Library= /RedfishDebugLib.h

> > b/RedfishPkg/Include/Library/RedfishDeb= ugLib.h

> > index 5f75bad12a..3430cf1d14 100644

> > --- a/RedfishPkg/Include/Library/Redfis= hDebugLib.h

> > +++ b/RedfishPkg/Include/Library/Redfis= hDebugLib.h

> > @@ -1,7 +1,7 @@

> >  /** @file

> >    This file defines the= Redfish debug library interface.

> >

> > -  Copyright (c) 2023, NVIDIA CORP= ORATION & AFFILIATES. All rights reserved.

> > +  Copyright (c) 2023-2024, NVIDIA= CORPORATION & AFFILIATES. All

> > + rights

> > reserved.

> >

> >    SPDX-License-Identifi= er: BSD-2-Clause-Patent

> >

> > @@ -138,4 +138,22 @@ DumpIpv4Address (<= /p>

> >    IN EFI_IPv4_ADDRESS&n= bsp; *Ipv4Address

> >    );

> >

> > +/**

> > +  Debug output raw data buffer.

> > +

> > +  @param[in]    Er= rorLevel  DEBUG macro error level

> > +  @param[in]    Bu= ffer      Debug output data buffer.

> > +  @param[in]    Bu= fferSize  The size of Buffer in byte.

> > +

> > +  @retval EFI_SUCCESS  =            Debug dump fin= ished.

> > +  @retval EFI_INVALID_PARAMETER&n= bsp;  Buffer is NULL.

> > +

> > +**/

> > +EFI_STATUS

> > +DumpBuffer (

> > +  IN  UINTN  ErrorLevel= ,

> > +  IN  UINT8  *Buffer,

> > +  IN  UINTN  BufferSize=

> > +  );

> > +

> >  #endif

> > diff --git a/RedfishPkg/Library/Redfish= DebugLib/RedfishDebugLib.c

> > b/RedfishPkg/Library/RedfishDebugLib/Re= dfishDebugLib.c

> > index efa9a5ca13..5fd40ad955 100644

> > --- a/RedfishPkg/Library/RedfishDebugLi= b/RedfishDebugLib.c

> > +++ b/RedfishPkg/Library/RedfishDebugLi= b/RedfishDebugLib.c

> > @@ -1,7 +1,7 @@

> >  /** @file

> >    Redfish debug library= to debug Redfish application.

> >

> > -  Copyright (c) 2023, NVIDIA CORP= ORATION & AFFILIATES. All rights reserved.

> > +  Copyright (c) 2023-2024, NVIDIA= CORPORATION & AFFILIATES. All

> > + rights

> > reserved.

> >

> >    SPDX-License-Identifi= er: BSD-2-Clause-Patent

> >

> > @@ -21,6 +21,7 @@

> >

> >  #define REDFISH_JSON_STRING_LENGT= H  200  #define

> > REDFISH_JSON_OUTPUT_FORMAT  (EDKII= _JSON_COMPACT |

> > EDKII_JSON_INDENT(2))

> > +#define REDFISH_SIZE_PER_ROW &nbs= p;      16

>

> How about name this as REDFISH_PRINT_BUFFER_= BYTES_PER_ROW, looks more

> clear.

>

> Abner

>

> >

> >  /**

> >    Debug print the value= of StatementValue.

> > @@ -366,3 +367,41 @@ DumpIpv4Address (<= /p>

> >

> >    return EFI_SUCCESS;

> >  }

> > +

> > +/**

> > +  Debug output raw data buffer.

> > +

> > +  @param[in]    Er= rorLevel  DEBUG macro error level

> > +  @param[in]    Bu= ffer      Debug output data buffer.

> > +  @param[in]    Bu= fferSize  The size of Buffer in byte.

> > +

> > +  @retval EFI_SUCCESS  =            Debug dump fin= ished.

> > +  @retval EFI_INVALID_PARAMETER&n= bsp;  Buffer is NULL.

> > +

> > +**/

> > +EFI_STATUS

> > +DumpBuffer (

> > +  IN  UINTN  ErrorLevel= ,

> > +  IN  UINT8  *Buffer,

> > +  IN  UINTN  BufferSize=

> > +  )

> > +{

> > +  UINTN  Index;

> > +

> > +  if (Buffer =3D=3D NULL) {

> > +    return EFI_INVALID_= PARAMETER;

> > +  }

> > +

> > +  DEBUG ((ErrorLevel, "Addre= ss: 0x%p size: %d\n", Buffer,

> > + BufferSize));  for (Index =3D 0;= Index < BufferSize; Index++) {

> > +    if (Index % REDFISH= _SIZE_PER_ROW =3D=3D 0) {

> > +      DEBUG (= (ErrorLevel, "\n%04X: ", Index));

> > +    }

> > +

> > +    DEBUG ((ErrorLevel,= "%02X ", Buffer[Index]));  }

> > +

> > +  DEBUG ((ErrorLevel, "\n&qu= ot;));

> > +

> > +  return EFI_SUCCESS;

> > +}

> > --

> > 2.34.1

 

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#113440) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MW4PR12MB70315861AF23CE0C04019195D96A2MW4PR12MB7031namp_--