public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nickle Wang" <nicklew@nvidia.com>
To: "rfc@edk2.groups.io" <rfc@edk2.groups.io>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Simon Wang (SW-GPU)" <simowang@nvidia.com>,
	"Chang, Abner" <abner.chang@amd.com>,
	Nick Ramirez <nramirez@nvidia.com>
Subject: [RFC] Introduce new status code for ManageabilityPkg and Redfish*Pkg
Date: Thu, 1 Jun 2023 04:23:12 +0000	[thread overview]
Message-ID: <MW4PR12MB703159565E882ED78436FBC5D9499@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2200 bytes --]

Hi edk2 community,

I like to introduce EFI_COMPUTING_UNIT_MANAGEABILITY status code to PiStatusCode.h. EFI_COMPUTING_UNIT_MANAGEABILITY will be used in edk2 RedfishPkg and edk2-redfish-client RedfishClientPkg to report Redfish operation errors. It will also be used to report errors in edk2-platforms ManageabilityPkg.

EFI_COMPUTING_UNIT_MANAGEABILITY is created as one of the subclasses in computing unit class.

#define EFI_COMPUTING_UNIT_CACHE               (EFI_COMPUTING_UNIT | 0x00040000)
#define EFI_COMPUTING_UNIT_MEMORY              (EFI_COMPUTING_UNIT | 0x00050000)
#define EFI_COMPUTING_UNIT_CHIPSET             (EFI_COMPUTING_UNIT | 0x00060000)
+ #define EFI_COMPUTING_UNIT_MANAGEABILITY       (EFI_COMPUTING_UNIT | 0x00070000)

Below operation values are defined to report failure in manageability related operations. I only provide the definitions for Redfish functions but the failure case like in MCTP, IPMI and KCS can be created in the future.

+///
+/// Computing Unit Manageability Subclass Error Code definitions.
+/// The detail information is reported by REPORT_STATUS_CODE_WITH_EXTENDED_DATA
+//  with ASCII string in EFI_STATUS_CODE_STRING_DATA.
+///@{
+#define EFI_MANAGEABILITY_EC_REDFISH_COMMUNICATION_ERROR        (EFI_SUBCLASS_SPECIFIC | 0x00000000)
+#define EFI_MANAGEABILITY_EC_REDFISH_HOST_INTERFACE_ERROR       (EFI_SUBCLASS_SPECIFIC | 0x00000001)
+#define EFI_MANAGEABILITY_EC_REDFISH_BOOTSTRAP_CREDENTIAL_ERROR (EFI_SUBCLASS_SPECIFIC | 0x00000002)

* EFI_MANAGEABILITY_EC_REDFISH_COMMUNICATION_ERROR will be used to report communication failure between host and Redfish service providers (or BMC).
* EFI_MANAGEABILITY_EC_REDFISH_HOST_INTERFACE_ERROR is reported when host system can not create Redfish host interface due to some errors.
* EFI_MANAGEABILITY_EC_REDFISH_BOOTSTRAP_CREDENTIAL_ERROR is reported when host system cannot get bootstrap credentials by following the Host Interface standard.

Detail reason will be provided in ASCII string by calling REPORT_STATUS_CODE_WITH_EXTENDED_DATA().

The pull request is here for reference: https://github.com/nicklela/edk2/pull/4/files  Any feedback is welcome.

Thanks,
Nickle


[-- Attachment #2: Type: text/html, Size: 7599 bytes --]

             reply	other threads:[~2023-06-01  4:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01  4:23 Nickle Wang [this message]
2023-06-01 17:33 ` [RFC] Introduce new status code for ManageabilityPkg and Redfish*Pkg Isaac Oram
2023-06-06 15:26   ` [edk2-rfc] " Zimmer, Vincent
2023-06-07  3:22     ` Nickle Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR12MB703159565E882ED78436FBC5D9499@MW4PR12MB7031.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox