From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9B6DCD8018D for ; Wed, 30 Aug 2023 01:47:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=z6IWtlBisXqnEHU9BSRO+U3nKmZUqd5UUbNXzLVajHk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1693360066; v=1; b=eoDC7pz+0fqOSwo6cLYuhopPZHo2BYB+8hPO9fqMbdYGLIW302U56IE2+ST5NuujvL41gCa6 hlaRNN46g07GiyF0Gl/itOny4DdBxOvYp5du74Bpz6TfeUbxByQV2jVREPnIb47NBuebAf0pfBc tw8A3qKOy3Bh/NkabiytF5ko= X-Received: by 127.0.0.2 with SMTP id SqtNYY7687511xgq08507RrA; Tue, 29 Aug 2023 18:47:46 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.49]) by mx.groups.io with SMTP id smtpd.web10.4759.1693360065191924392 for ; Tue, 29 Aug 2023 18:47:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xf6sNjEgZJnbWKWnVEgTVu+dhdtsZqLgt9tX5ChFG2HaPZmgEHRwd47GXxeaA+lDGjnAi5hFD9q1c+/6hotu4Y6VCXjapmPIKfWCdXZG3iJgW80gW2fZ80TmgxAoj0/k8t6Ku/4+Jy1lEiQbHMt0K1DRzh2PKCo2NR4CxtQFJ+F16pIA5zc2My7YqL74K56rZmgISOGFky1COWLjo6Vm39ne/XtHTAUtjyggAjX+plbSXkVJmOoTPCUZ6ZjuiExye6eJYDkCOZ5E49Sx65KjcIJHnqGWr0pW+aFTy+trrB3dqljEQlJgfZTPT63SoyNIEwjTDuq5oaMB+sjhJEkD6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lTcRybaV9B7dWTBNU6wc8D5Ldwyv+JTlP/o4K1NfnK4=; b=PQzxajx0o5UMzAVcQzENkzMdCyVW5uHxRxs34u+q0uCuLuc3WU3vvTK/UNzYCbKuWkReY30jV/fIpl2SenC9D2STbX7a8t13r/BEaAw7bHgJjeUcBs1lrrAyzzrlCvRtGykBwSBJEORbXLfBnJMMPsNevrIzJwY41fwZYgxSO7kUrcLO/muEBJ9799LIYjJETQJ6fHuh4qXkZF2zIrgYkvP343w+N19W/2OAka7vvmNG306rzCvCUuR6Z5fusUbBGjUT1Uffb6H1Mz0fzBc+NswCeqKsFNOhBy2pQvj2bDxrSX73N2NgWoNB+oYfW/oKA8+Rgst8JCuakFtfMJGAuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by PH7PR12MB8426.namprd12.prod.outlook.com (2603:10b6:510:241::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.35; Wed, 30 Aug 2023 01:47:41 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::1390:de0a:6b46:9837]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::1390:de0a:6b46:9837%7]) with mapi id 15.20.6699.035; Wed, 30 Aug 2023 01:47:40 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" , "abner.chang@amd.com" CC: "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uninialized list variable. Thread-Topic: [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uninialized list variable. Thread-Index: AQHZ2k8BBetSpHzumkypZqTmLfwL/7ACEsOQ Date: Wed, 30 Aug 2023 01:47:40 +0000 Message-ID: References: <20230829080112.12748-1-mike.maslenkin@gmail.com> <20230829080112.12748-2-mike.maslenkin@gmail.com> In-Reply-To: <20230829080112.12748-2-mike.maslenkin@gmail.com> Accept-Language: en-US X-Mentions: abner.chang@amd.com X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|PH7PR12MB8426:EE_ x-ms-office365-filtering-correlation-id: c0a2f99e-4a2b-497e-637a-08dba8fb18ad x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 2Hd0w6k7nnnw4rD9JjwSYVjhYJf9qh6RpltE2bAJl6gpMNOQy3P0apTzIIujScRECd3c8z8maS6IuDE8193D75o+kffhpe5L34bfcSntK74Z8ZOcpisLqg2DclmAvX6RngwPL4haeBzev0TPQXjZm1JPIOoGE9wXVGXKSpTS5IrSeGPA/8SD/BcCXptIPpp2mpIAa/rwUdv9kzvtuJ+7xrUf+lMpVBga9b+GJNXDSNF2JrT39KLMihvslRcXZbYjp4mSz6VTnBNRUbgyDib2k2EsShV/98wIShhGpjGfZI1DCQSl1MrTGkjT6qmnWIXnUv8UcrXcvTX8KeezY+o4s8rcLFuoTlfHlCLY/708PMYzT+lDgwjno1Lfrv49uvrHYZwvTlrGvzOS8NDdiO3ftYnxzhGbrk4je3lefS3RHjN5Z3YD41pJDIv4yM6/8OLXIELMP0w48fzy3U61ZgowaumyKEo1DT5fUukyKQQWjZ5+8YpL7DppAyrBwwopEGQkK0RGFkzo9ZxfnTWTeU0Ah19sHhQEvQGo/nuUTpy7c4wUGiBiJ43QOLlhjhRzgTO4u+I1DElxO7eyVfqtv2KNS96Fbtq2edJo4d+a0LeSBtuAHKXluvUSezRfD2wZCc1+ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NIjdMHnFSQBo1IFwdXSu5nRSoWBe2m6qqNxFlfirXl6wzl/Z7Js4Z2DEfVQA?= =?us-ascii?Q?d6tdN8ZQ9sfUM0ZRMAOGj2ZhREz1X8eCKQaGXYY8udwWjpmL1d9ff8a0l897?= =?us-ascii?Q?X0yLuIzsT4fyyqkSGOz8oL4hPMUf3qxgN0IkKU8BosA0YkE5xWHXhiuUgvqB?= =?us-ascii?Q?77GpfF2h+JWKa6c8UnWR8m97ZG9iNXgi1xvmSyFmvbtY1sSbiL5Aq95c4pYS?= =?us-ascii?Q?G6aHmhzaPDaGXc3rfT3dDGNhCyEOWvSb5XnroDCuClBslLtlxA519/VfJtVl?= =?us-ascii?Q?rkKLMLIfPOv1kF0wKKCqK9WX+p7rr4vLzvYzsjEX09MGjs/Wma//kfX/H6m2?= =?us-ascii?Q?TPu4uTFeLEptcEIM1DigUgyNU+vW++iUEXj3qNWVd/Q+uWmy6V9SJoVMoIl2?= =?us-ascii?Q?ry3Sn6Q55dsa9QkOnI8lIM7sUnps5gHdDiKntQDBFCAPXZJMrF1I6qUmQJgI?= =?us-ascii?Q?xJdtaAvVGAcWtJJZO7++qYDWkKgQpdAOcUuiDBAimLc81TaMqmTZxaLdk3oR?= =?us-ascii?Q?JsbY5K7oWv96HsWg3PfE99Fi2eM+S0UcO21bPKVZmCrEXhZRmPax4gLUpuzq?= =?us-ascii?Q?x6+M+XD+S6ezcoO17uEKpfZQOl52VOc1aD85U4A2EMHIZmV1aecQ28TXgLah?= =?us-ascii?Q?09J7/4FUspk852qdz/a0zb0w0Mnv5HfNG+Vb2fX9rzJXLS8vFb5vnxqGrLCq?= =?us-ascii?Q?fSPMsvb8abMaP9bJQt6XBTuimiJx1IB5oNPneiAimbVNwnwW5PeOvTcryYSA?= =?us-ascii?Q?CDScpeznCp+QLAFfGiXUauoC6B1rgbdooJVuTFo3eGd+R9aw/vhufN338NVy?= =?us-ascii?Q?AingcBKO1tULRu8dx0QxtcVYRx8069Jke522LcGYJULMgvexJazA8dWf2z61?= =?us-ascii?Q?/hrvrwSvCk6++CAUrCFI7Jms1L0TAHpCFK2I8hg2RrF3sutUUphF+YVGfPnx?= =?us-ascii?Q?xR96Elo9rEFCxH5tcOEdDsMfURKLh60oI8qbqWWy/xbnx/ORlbjszj5CqqqH?= =?us-ascii?Q?otlc5lsyBOALUpWsGVyzYGkgYgtXmth3UObQ2Vr3K690mFMCxt2jTCem0RK/?= =?us-ascii?Q?PptsHAXA5HlLtFlQtuwBi98y1FE9JGWaBcHCf9rszaINl5QOiOlKBBqodCFY?= =?us-ascii?Q?Y3rS3RuE+53OzyCuNcFadDzWCMYxzI+bmTgLRLFS+ZyIpBO4Ply8VYFP8dTC?= =?us-ascii?Q?XdfczZSDly6vauqTKLXA8Bha+CQS1y6cNk9pWtU06b4MGFKy7Xo/MLp9Nqbl?= =?us-ascii?Q?FiP9xAQMDVp7UuNSEvZIQN3QdbjUP4NnDNfjWib9gHsiba8nrCf8D2cU7miN?= =?us-ascii?Q?do7w9eCAzGpblRQZD++vsOHDgBYsI+XCQJZvFmP477lzCwkMAnxWNn97cwyx?= =?us-ascii?Q?jwEiWzuGw7rnJ/axrviuxUgDQU2ascGldw07av2fuSzD4EvupwXAa84tVzyv?= =?us-ascii?Q?S5/K9eg1+t38AksVsyhML4AmFVJQ/pAMG2PIHGP/Tauh+qm+fzJO1iMSLqbn?= =?us-ascii?Q?rEeAiC4WpYM8y3xzCGNbAyBrUHnix9cl5evaftRRrcH68P/dM5faMC2EKYNH?= =?us-ascii?Q?2wixdWeLKlrmARoIdpA=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0a2f99e-4a2b-497e-637a-08dba8fb18ad X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2023 01:47:40.7310 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QifCZAxydKqgf5V/1iwwKeVx7K5/bQG/4snfXTCbH/HH2ea6Nec3d5gvrUmSBYhGWO5TJhsuZg9ip20hI1fR8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8426 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: iZhg87KFxLbiUd1EThQKvNImx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR12MB70315CB1F46BDA1A27393C6BD9E6AMW4PR12MB7031namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=eoDC7pz+; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") --_000_MW4PR12MB70315CB1F46BDA1A27393C6BD9E6AMW4PR12MB7031namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang @abner.chang@amd.com, I am thinking that we may= need to provide allocation function for CS structure so caller does not ne= ed to handle linked-list initialization like this one, or other stuff requi= es understanding to CS structure implementation. Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.chang@amd.com; Nickle Wang ; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uniniali= zed list > variable. > > External email: Use caution opening links or attachments > > > Signed-off-by: Mike Maslenkin > > --- > RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > index b9c799e07684..a1738de46fdf 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > @@ -97,6 +97,8 @@ RedfishConsumeResourceCommon ( > if (BiosCs->Attributes =3D=3D NULL) { > > BiosCs->Attributes =3D AllocateZeroPool (sizeof > (RedfishBios_V1_0_9_Attributes_CS)); > > ASSERT (BiosCs->Attributes !=3D NULL); > > + // initialize list > > + BiosCs->Attributes->Prop.ForwardLink =3D &BiosCs->Attributes->Prop; > > } > > > > // > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108105): https://edk2.groups.io/g/devel/message/108105 Mute This Topic: https://groups.io/mt/101027003/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MW4PR12MB70315CB1F46BDA1A27393C6BD9E6AMW4PR12MB7031namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Nickle Wang <nicklew@nvidia.com&g= t;

 

@abner.chang@amd.com, I = am thinking that we may need to provide allocation function for CS structure so caller does not need to handle linked-list in= itialization like this one, or other stuff requies understanding to CS stru= cture implementation.

 

Regards,

Nickle

 

> -----Original Message-----

> From: Mike Maslenkin <mike.maslenkin@gmai= l.com>

> Sent: Tuesday, August 29, 2023 4:01 PM

> To: devel@edk2.groups.io

> Cc: abner.chang@amd.com; Nickle Wang <nic= klew@nvidia.com>;

> igork@ami.com; Mike Maslenkin <mike.masle= nkin@gmail.com>

> Subject: [PATCH v2 1/6] RedfishClientPkg: fi= x crash on access to uninialized list

> variable.

>

> External email: Use caution opening links or= attachments

>

>

> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>

> ---

>  RedfishClientPkg/Features/Bios/v1_0_9/= Common/BiosCommon.c | 2 ++

>  1 file changed, 2 insertions(+)

>

> diff --git a/RedfishClientPkg/Features/Bios/= v1_0_9/Common/BiosCommon.c

> b/RedfishClientPkg/Features/Bios/v1_0_9/Comm= on/BiosCommon.c

> index b9c799e07684..a1738de46fdf 100644

> --- a/RedfishClientPkg/Features/Bios/v1_0_9/= Common/BiosCommon.c

> +++ b/RedfishClientPkg/Features/Bios/v1_0_9/= Common/BiosCommon.c

> @@ -97,6 +97,8 @@ RedfishConsumeResourceComm= on (

>    if (BiosCs->Attributes = =3D=3D NULL) {

>

>      BiosCs->Att= ributes =3D AllocateZeroPool (sizeof

> (RedfishBios_V1_0_9_Attributes_CS));

>

>      ASSERT (BiosCs= ->Attributes !=3D NULL);

>

> +    // initialize list

>

> +    BiosCs->Attributes-&g= t;Prop.ForwardLink =3D &BiosCs->Attributes->Prop;

>

>    }

>

>

>

>    //

>

> --

> 2.32.0 (Apple Git-132)

 

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#108105) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MW4PR12MB70315CB1F46BDA1A27393C6BD9E6AMW4PR12MB7031namp_--