From: "Nickle Wang" <nicklew@nvidia.com>
To: "abner.chang@amd.com" <abner.chang@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Isaac Oram <isaac.w.oram@intel.com>,
Abdul Lateef Attar <abdattar@amd.com>,
Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
Subject: Re: [edk2-platforms][PATCH 2/2] ManageabilityPkg: Use DEBUG_MANAGEABILITY
Date: Tue, 30 May 2023 06:52:38 +0000 [thread overview]
Message-ID: <MW4PR12MB70315E1904C36F8CE541002FD94B9@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230530063316.46-2-abner.chang@amd.com>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
Regards,
Nickle
> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Tuesday, May 30, 2023 2:33 PM
> To: devel@edk2.groups.io
> Cc: Isaac Oram <isaac.w.oram@intel.com>; Abdul Lateef Attar
> <abdattar@amd.com>; Nickle Wang <nicklew@nvidia.com>; Tinh Nguyen
> <tinhnguyen@os.amperecomputing.com>
> Subject: [edk2-platforms][PATCH 2/2] ManageabilityPkg: Use
> DEBUG_MANAGEABILITY
>
> External email: Use caution opening links or attachments
>
>
> From: Abner Chang <abner.chang@amd.com>
>
> Use debug print level DEBUG_MANAGEABILITY in
> ManageabilityPkg.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Abdul Lateef Attar <abdattar@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> ---
> .../Library/ManageabilityTransportHelperLib.h | 2 +-
> .../BaseManageabilityTransportHelper.c | 2 +-
> .../Universal/IpmiBmcAcpi/BmcAcpi.c | 6 ++++--
> .../Universal/IpmiBmcElog/BmcElog.c | 4 +++-
> .../ManageabilityPkg/Universal/IpmiFrb/FrbDxe.c | 8 +++++---
> .../PldmSmbiosTransferDxe/PldmSmbiosTransferDxe.c | 14 +++++++-------
> 6 files changed, 21 insertions(+), 15 deletions(-)
>
> diff --git
> a/Features/ManageabilityPkg/Include/Library/ManageabilityTransportHelperLib.
> h
> b/Features/ManageabilityPkg/Include/Library/ManageabilityTransportHelperLib.
> h
> index 11a1bd0521..dfe32189ad 100644
> ---
> a/Features/ManageabilityPkg/Include/Library/ManageabilityTransportHelperLib.
> h
> +++
> b/Features/ManageabilityPkg/Include/Library/ManageabilityTransportHelperLib.
> h
> @@ -11,7 +11,7 @@
>
> #include <Library/ManageabilityTransportLib.h>
>
> -#define DEBUG_MANAGEABILITY_INFO DEBUG_INFO
> +#define DEBUG_MANAGEABILITY_INFO DEBUG_MANAGEABILITY
>
> typedef struct _MANAGEABILITY_PROTOCOL_NAME
> MANAGEABILITY_PROTOCOL_NAME;
>
> diff --git
> a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/Bas
> eManageabilityTransportHelper.c
> b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/Bas
> eManageabilityTransportHelper.c
> index f72957ea7f..27bc5eaddf 100644
> ---
> a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/Bas
> eManageabilityTransportHelper.c
> +++
> b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/Bas
> eManageabilityTransportHelper.c
> @@ -163,7 +163,7 @@ HelperAcquireManageabilityTransport (
> CHAR16 *ManageabilityProtocolName;
> CHAR16 *ManageabilityTransportName;
>
> - DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__));
> + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Entry\n", __func__));
> if ((TransportToken == NULL) || (ManageabilityProtocolSpec == NULL)) {
> DEBUG ((DEBUG_ERROR, "%a: One of the required input parameters is
> NULL.\n", __func__));
> return EFI_INVALID_PARAMETER;
> diff --git a/Features/ManageabilityPkg/Universal/IpmiBmcAcpi/BmcAcpi.c
> b/Features/ManageabilityPkg/Universal/IpmiBmcAcpi/BmcAcpi.c
> index cf066dd095..d04623ecad 100644
> --- a/Features/ManageabilityPkg/Universal/IpmiBmcAcpi/BmcAcpi.c
> +++ b/Features/ManageabilityPkg/Universal/IpmiBmcAcpi/BmcAcpi.c
> @@ -24,6 +24,8 @@
> #include <Library/BaseMemoryLib.h>
> #include <Library/UefiLib.h>
>
> +#include <Library/ManageabilityTransportHelperLib.h>
> +
> #ifndef EFI_ACPI_CREATOR_ID
> #define EFI_ACPI_CREATOR_ID SIGNATURE_32 ('M', 'S', 'F', 'T')
> #endif
> @@ -140,7 +142,7 @@ UpdateDeviceSsdtTable (
> //
> // Update IO(Decode16, 0xCA2, 0xCA2, 0, 2)
> //
> - DEBUG ((DEBUG_INFO, "UpdateDeviceSsdtTable - IPMI\n"));
> + DEBUG ((DEBUG_MANAGEABILITY_INFO, "UpdateDeviceSsdtTable - IPMI\n"));
> for (DataPtr = (UINT8 *)(Table + 1);
> DataPtr < (UINT8 *)((UINT8 *)Table + Table->Length - 4);
> DataPtr++)
> @@ -158,7 +160,7 @@ UpdateDeviceSsdtTable (
> ASSERT (IoRsc->Header.Bits.Type == ACPI_SMALL_ITEM_FLAG);
> ASSERT (IoRsc->Header.Bits.Name ==
> ACPI_SMALL_IO_PORT_DESCRIPTOR_NAME);
> ASSERT (IoRsc->Header.Bits.Length == sizeof
> (EFI_ACPI_IO_PORT_DESCRIPTOR) - sizeof (ACPI_SMALL_RESOURCE_HEADER));
> - DEBUG ((DEBUG_INFO, "IPMI IO Base in ASL update - 0x%04x <= 0x%04x\n",
> IoRsc->BaseAddressMin, PcdGet16 (PcdIpmiKcsIoBaseAddress)));
> + DEBUG ((DEBUG_MANAGEABILITY_INFO, "IPMI IO Base in ASL update -
> 0x%04x <= 0x%04x\n", IoRsc->BaseAddressMin, PcdGet16
> (PcdIpmiKcsIoBaseAddress)));
> IoRsc->BaseAddressMin = PcdGet16 (PcdIpmiKcsIoBaseAddress);
> IoRsc->BaseAddressMax = PcdGet16 (PcdIpmiKcsIoBaseAddress);
> }
> diff --git a/Features/ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.c
> b/Features/ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.c
> index 02873fc4c6..8b34b2d2d5 100644
> --- a/Features/ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.c
> +++ b/Features/ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.c
> @@ -15,6 +15,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #include <Library/UefiRuntimeServicesTableLib.h>
> #include <Library/IpmiCommandLib.h>
>
> +#include <Library/ManageabilityTransportHelperLib.h>
> +
> EFI_STATUS
> EFIAPI
> CheckIfSelIsFull (
> @@ -186,7 +188,7 @@ CheckIfSelIsFull (
> // Check the Bit7 of the OperationByte if SEL is OverFlow.
> //
> SelIsFull = (SelInfo.OperationSupport & 0x80);
> - DEBUG ((DEBUG_INFO, "SelIsFull - 0x%x\n", SelIsFull));
> + DEBUG ((DEBUG_MANAGEABILITY_INFO, "SelIsFull - 0x%x\n", SelIsFull));
>
> return EFI_SUCCESS;
> }
> diff --git a/Features/ManageabilityPkg/Universal/IpmiFrb/FrbDxe.c
> b/Features/ManageabilityPkg/Universal/IpmiFrb/FrbDxe.c
> index 46f741eed1..40ae0c3ecc 100644
> --- a/Features/ManageabilityPkg/Universal/IpmiFrb/FrbDxe.c
> +++ b/Features/ManageabilityPkg/Universal/IpmiFrb/FrbDxe.c
> @@ -16,6 +16,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #include <Library/IpmiCommandLib.h>
> #include <IndustryStandard/Ipmi.h>
>
> +#include <Library/ManageabilityTransportHelperLib.h>
> +
> /**
> This routine disables the specified FRB timer.
>
> @@ -159,7 +161,7 @@ ReportFrb2Status (
> //
> Status = IpmiGetWatchdogTimer (&GetWatchdogTimer);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_INFO, "Failed to get Watchdog Timer info from BMC.\n"));
> + DEBUG ((DEBUG_ERROR, "Failed to get Watchdog Timer info from BMC.\n"));
> return Status;
> }
>
> @@ -167,9 +169,9 @@ ReportFrb2Status (
> // Check if timer is running, report status to DEBUG_MODE output.
> //
> if (GetWatchdogTimer.TimerUse.Bits.TimerRunning == 1) {
> - DEBUG ((DEBUG_INFO, "FRB2 Timer is running.\n"));
> + DEBUG ((DEBUG_MANAGEABILITY_INFO, "FRB2 Timer is running.\n"));
> } else {
> - DEBUG ((DEBUG_INFO, "FRB2 Timer is not running.\n"));
> + DEBUG ((DEBUG_MANAGEABILITY_INFO, "FRB2 Timer is not running.\n"));
> }
>
> return EFI_SUCCESS;
> diff --git
> a/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosTra
> nsferDxe.c
> b/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosTra
> nsferDxe.c
> index f897162bb5..fdf033f0b1 100644
> ---
> a/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosTra
> nsferDxe.c
> +++
> b/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosTra
> nsferDxe.c
> @@ -147,7 +147,7 @@ GetSmbiosStructureTableMetaData (
> EFI_STATUS Status;
> UINT32 ResponseSize;
>
> - DEBUG ((DEBUG_INFO, "%a: Set SMBIOS structure table metafile.\n",
> __func__));
> + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Set SMBIOS structure table
> metafile.\n", __func__));
>
> ResponseSize = sizeof (PLDM_SMBIOS_STRUCTURE_TABLE_METADATA);
> Status = PldmSubmitCommand (
> @@ -194,7 +194,7 @@ SetSmbiosStructureTableMetaData (
> UINT32 ResponseSize;
> UINT32 RequestSize;
>
> - DEBUG ((DEBUG_INFO, "%a: Get SMBIOS structure table metafile.\n",
> __func__));
> + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Get SMBIOS structure table
> metafile.\n", __func__));
>
> RequestSize = sizeof (PLDM_SMBIOS_STRUCTURE_TABLE_METADATA);
> ResponseSize = 0;
> @@ -236,7 +236,7 @@ GetSmbiosStructureTable (
> OUT UINT32 *BufferSize
> )
> {
> - DEBUG ((DEBUG_INFO, "%a: Unsupported.\n", __func__));
> + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Unsupported.\n", __func__));
> // Only support PLDM SMBIOS Transfer push mode.
> return EFI_UNSUPPORTED;
> }
> @@ -272,7 +272,7 @@ SetSmbiosStructureTable (
> EFI_SMBIOS_TABLE_HEADER *Record;
> PLDM_SET_SMBIOS_STRUCTURE_TABLE_REQUEST
> *PldmSetSmbiosStructureTable;
>
> - DEBUG ((DEBUG_INFO, "%a: Set SMBIOS structure table.\n", __func__));
> + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Set SMBIOS structure table.\n",
> __func__));
>
> Status = gBS->LocateProtocol (
> &gEfiSmbiosProtocolGuid,
> @@ -422,7 +422,7 @@ GetSmbiosStructureByType (
> OUT UINT32 *BufferSize
> )
> {
> - DEBUG ((DEBUG_INFO, "%a: Unsupported.\n", __func__));
> + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Unsupported.\n", __func__));
> // Only support PLDM SMBIOS Transfer push mode.
> return EFI_UNSUPPORTED;
> }
> @@ -451,7 +451,7 @@ GetSmbiosStructureByHandle (
> OUT UINT32 *BufferSize
> )
> {
> - DEBUG ((DEBUG_INFO, "%a: Unsupported.\n", __func__));
> + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Unsupported.\n", __func__));
> // Only support PLDM SMBIOS Transfer push mode.
> return EFI_UNSUPPORTED;
> }
> @@ -486,7 +486,7 @@ DxePldmSmbiosTransferEntry (
> EFI_HANDLE Handle;
> EFI_STATUS Status;
>
> - DEBUG ((DEBUG_INFO, "%a: Entry.\n", __func__));
> + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Entry.\n", __func__));
>
> SetSmbiosStructureTableHandle = 0;
>
> --
> 2.37.1.windows.1
next prev parent reply other threads:[~2023-05-30 6:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 6:33 [edk2-platforms][PATCH 1/2] ManageabilityPkg: Replace __FUNCTION__ with __func__ Chang, Abner
2023-05-30 6:33 ` [edk2-platforms][PATCH 2/2] ManageabilityPkg: Use DEBUG_MANAGEABILITY Chang, Abner
2023-05-30 6:52 ` Nickle Wang [this message]
2023-05-30 8:48 ` Attar, AbdulLateef (Abdul Lateef)
2023-05-31 8:07 ` Chang, Abner
2023-05-30 6:51 ` [edk2-platforms][PATCH 1/2] ManageabilityPkg: Replace __FUNCTION__ with __func__ Nickle Wang
2023-05-30 8:47 ` Attar, AbdulLateef (Abdul Lateef)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR12MB70315E1904C36F8CE541002FD94B9@MW4PR12MB7031.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox