From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.71]) by mx.groups.io with SMTP id smtpd.web11.96470.1679649559241170886 for ; Fri, 24 Mar 2023 02:19:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=uELU3ulr; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.220.71, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I0utr7Y1rSHC13ehx3gs6Vgkgdd7jJvjlLPj0xXecOvZ+Yo09WpO4mBbLDFwp9gIcAc7w1YrlqDCAkG4RjTVdFUHzBMKxiqpZGEGmKJV/VWsy3Amj8Pnl2eocsmiw87QrV2wjUfNPQZa4Gt+LeyaRCWjEbD3jr0LH8GM4Yo+YUcSs7odbSoMrTIEwfyGd7FgcM0ruUDZRA+M/JJag66zQsy1dwUZuY82BQkdUWfEOpL9KoBBXAFn5yiQA+3NFYe8UFqDRAfAOqz8QhoDMGtJ0VIzeeYWYIyMS60tVIA2MDBjqDoQd1ZtfL/8wFfo7U5hxijppWWfokLf3u92jsSx2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h8ydcAxg+vlgi5ZwmkPalHsyyR5Wp7a+U4ab0q3Iu5M=; b=iGKhWKS8R5C1HIuOpTqIBiV/PU7qFGeSA1Qcc2EwdFIWqOkN5771EFlRei5LY++9EmjCAgi7R3NDKF1zIoqxmBNTz1+f3CRIqHRuT6l5QJ92PiK9uGQ2CYL/W9cbjhG7oXYMbXGzdOh62hP6Mw7d6BW36MhfXNXDtHnZdlphjWP8puXCpjQaqpC8mrlgZ7dc7inD2SIIIX6BGAlzgtaE1gYVmdZ4bDtg+ZS2DP+LF601PB+4vUx2xQh3EcxUeFk1IKhPDs7oLZKd+eBHa2fRZYwURjCSdiCRn97KQWSId4Wc/qAqo/MFRJ/X5Ow1RbtJyvgxW7Tg7CqhqDNHuUZGpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h8ydcAxg+vlgi5ZwmkPalHsyyR5Wp7a+U4ab0q3Iu5M=; b=uELU3ulr9LnxQSrpKRr86WEW3K71798I5iums8kLiW/PUDcu9XteV8eO5oZhWmsIR5JpFe7q5XI/GTAuLDBLYfQv2sC78r7CGeQ7nGwftMkGk/MAZYssdh4g06KjFoHV/kYZ4qJOeNcEKOLpYiC/HweEvmypi8fCS/u16yCW8D63HaAKZNle3gSrao7DWDfn4q6UdRGaZysSkHOa2wTbUOU1/x+3lC/Ktppt9iQ49YGbxoohwFgX1Vi0Z91cnuujw96pqegBFaidcH7LdPbsNXMTPi1E0N4azThIqeCxlbK+c6/xhQXTTK49prgB6FzR2uSOOJygNqk2bbRfDYtnDQ== Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by MN2PR12MB4334.namprd12.prod.outlook.com (2603:10b6:208:1d1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 09:19:16 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::c27a:fa4b:66ea:d266]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::c27a:fa4b:66ea:d266%5]) with mapi id 15.20.6178.037; Fri, 24 Mar 2023 09:19:16 +0000 From: "Nickle Wang" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Liming Gao , Isaac Oram , Nate DeSimone , Igor Kulchytskyy , Abdul Lateef Attar Subject: Re: [PATCH v4 4/9] ManageabilityPkg: Add NULL ManageabilityTransportLib Thread-Topic: [PATCH v4 4/9] ManageabilityPkg: Add NULL ManageabilityTransportLib Thread-Index: AQHZXGjmgIOf9//TyU6qgp1TIS083K8JqmrQ Date: Fri, 24 Mar 2023 09:19:16 +0000 Message-ID: References: <20230322024840.1629-1-abner.chang@amd.com> <20230322024840.1629-4-abner.chang@amd.com> In-Reply-To: <20230322024840.1629-4-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|MN2PR12MB4334:EE_ x-ms-office365-filtering-correlation-id: dcb6874c-b497-4fb3-fb51-08db2c48d737 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Z9I8BYdY0ctZWuU/kEQ+d198ZzO/vKjpp76E8vv21FEoIGmgsj0qPcqsemvCGtdqqbRQR49RFwfTu6Dfvsc1Gduns8kCco/kqKe0/Z/f+sh+JmFK3mHR+lFgGADTXvfD8ukCrMEGxLePueQ4/MoZocejvGaHeJ4m2F2MnmLTOCsPkYl1PyeS/EZYUvwN80xTisGqmQTRKcPoNC/2UIHDuQhw7yToqm7qILhZkA42ve7ZLFKUxY8F68ACw+3c9dHmsIpDW5A/O26zrhJqdVBIl+qLiJrzkEhjZFESVTsll7jNfQBB+iGF6hkImZeVfiMlu6cvPKghJ7LyTl3qTH4raZLCW42m4Unl2IprbpuARaS/MApqyIGeu/5VWppGFbN6zg7GS4K2HSSAEei9cGSC9nkk0w4e3cg0sPPzsIwdQQ8Zd9Xy7unP4KcWD2IfqJas9DwmRf/u7W1lwAkd0YmZ3MsSWJV7GyPa6EuiUNdCsgZBJ+FszHBqdKscNi7Lg+GC1iOxwWMZOckRz90dnlqE/gfsJi8ErfoyT0/D46f38LkU3IKuOPF1MKSmX+FHyOsd7uUvLyYDJG3Pzn7oogQ3U7mP3pERC+bVZRTWsJehisHhGEu7NKJiGsZsq2wraZn2CFUZe8tZNvF9Dl9VMjLxAM/DqEzyb+C6mmXFYOostvHpr//x52/7UvzvNOhMsWiZWN3QSZSqcnEj0beoSfnW/A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR12MB7031.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(396003)(346002)(136003)(376002)(39860400002)(451199018)(2906002)(5660300002)(41300700001)(55016003)(33656002)(8936002)(76116006)(66446008)(64756008)(66476007)(66946007)(66556008)(52536014)(8676002)(4326008)(316002)(110136005)(54906003)(71200400001)(7696005)(478600001)(53546011)(9686003)(186003)(6506007)(86362001)(83380400001)(38100700002)(26005)(38070700005)(122000001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/bF83873R+acrd8VMBQR2hjuBHDDQmdAjw8etAr5OwTEWA3NqqobPoEEp3mg?= =?us-ascii?Q?7XeuZLi1zMp2aBubh8GfLqTfkpxCHMJjGZJyriSnANr0qThkPg1yTvtMsr8a?= =?us-ascii?Q?NwFZj999nyzIQpEl20CNiot2b2qlK8evewYMiu4z8vbUMqAy6hK8X6Mc/CoX?= =?us-ascii?Q?lcoqMJky6eTKPp1knCsTfN2yGIP4SAyA/u8Ypy8snovofLF1EjuoWjCoC/jz?= =?us-ascii?Q?LO5J9eLnr6BUX1U2Ny7dEfuH5mQO55gb1TD61lYTi64fJ/JRDl78wdmTRPQe?= =?us-ascii?Q?ZqNXF40+xXmpKQ21m8Z5w1kNKBTimtWv2hkT/E2lgxF6xBfBQzMV+1AeBFG5?= =?us-ascii?Q?itwr1sS3VCXtOjmTPjSNUjYuottE6MMYn5zeP4ikwn+qaTQQ1iUHNjty/OhP?= =?us-ascii?Q?bpmUdm52DgaoNNKyliM8cl/hX3spBStaMYMOXLbCZwZiuRu5kbcQp/RoxRj+?= =?us-ascii?Q?ALv/HXKleUJf78ICdLhS3ucrsJwASS/wmqryz4+BVH356joUdTyJ1yv7HlG5?= =?us-ascii?Q?31uWxFhtH4EwouLc9AQJXorwFCaACup6B7vTpWmsUzIcK1u21mxfNT9Xpfd/?= =?us-ascii?Q?CDzWRRsfDUrpf/NGgxHjc13hTPG9Q6WUCclnl6EaiifMA3hkg9JUqRRguv5N?= =?us-ascii?Q?xThSXzlFYbnIJxZLUwa+q/GiqI3HVHqN/KDm6P2Kyu0d1ZMihpahEnnNU5vs?= =?us-ascii?Q?u8Fl2yc7w9/whYA6eR8kKUjE6CqKtNGsDOl2w877Pur3JmijWWMUhgFyn5jC?= =?us-ascii?Q?T9sfnGoY3OF4AT/6oCm+6hPkIJkLlinQtEobK6neqr1kiZwkRvBiOsl802KW?= =?us-ascii?Q?+N/mOl1rUsZW3k1HnshNFiRnk9tiiKrYHZLaLRY2hmVpg7l2G/ceDlsDCeqK?= =?us-ascii?Q?b719uUXwRbFle5D2ByNDpvpRL8yttqAKX78ISyVSaNjjhEOnrsB+ejendSxU?= =?us-ascii?Q?dJqDvrTTRUK2XlfhnKCYjn34cJpooqQ3hZHzgrFpVyyIjvgDLsiBF+Xku9CJ?= =?us-ascii?Q?4huT01DE5ilh1KYQroHOIdZrQuVQmIT4PPe8af6DhLS+GQFYwQc4Hl0/Tv5d?= =?us-ascii?Q?NEjOkEV/1D5Rsu6hzZb/OJjW+gXtsNn+Xl2UyZY3QAcR91I3QSPC2DGuxT5N?= =?us-ascii?Q?2jmzsJYrDEla4yDMZPq+hl2w8Ic5FMqTascJCLbEmj1PzEWDr86GKfPPkdFd?= =?us-ascii?Q?0Cx3P9YnzJ4Z1nXhnqcfECN2BCBXvt79eacH9Fnr7dah38WXH09H5JGwXs4v?= =?us-ascii?Q?hdtrvL6XvG1s78tEkWLE6dx4Ah/qqJzLoXBfi4CaMXjI7UoQ6Lt8+grhnqoz?= =?us-ascii?Q?u3OjrDhn1IdSEP4zGA6zaCIVRyzfF5D3NxFQax/OflqsLw9O3UuJ3R/td0u6?= =?us-ascii?Q?f92jKByVrl9Jc5l1Q3R6DUOqlQiNUf94PZ5ulgN/rP2mqMCOjTBb9Na4DiYj?= =?us-ascii?Q?MGqBPDLagJcy26xWQmJ6HLI+fCRucKHFiQuFgHs3FCG2FfDzGDSjKRm9jy/T?= =?us-ascii?Q?s7Ejn4xwE0fc7+HY0YeAcqeDJRrzpNohgRx3FSJo16pHWtbF0ZlK4f+DfIQH?= =?us-ascii?Q?kSj4TPnqOodCmyN1W70=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcb6874c-b497-4fb3-fb51-08db2c48d737 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2023 09:19:16.2782 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XT5CLUF7TeCNzmwCGdeAEBwKBYJlclPTwcwuP7yn/N1erHbVCZNmzBapOvJwCbKX+3ACyB6UV3ss9eLdZk3FgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4334 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: abner.chang@amd.com > Sent: Wednesday, March 22, 2023 10:49 AM > To: devel@edk2.groups.io > Cc: Liming Gao ; Isaac Oram > ; Nate DeSimone ; > Nickle Wang ; Igor Kulchytskyy ; Abdul > Lateef Attar > Subject: [PATCH v4 4/9] ManageabilityPkg: Add NULL ManageabilityTransport= Lib >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Abner Chang >=20 > The NULL instance of ManageabilityTransportLib > library. >=20 > Signed-off-by: Abner Chang > Cc: Liming Gao > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Abdul Lateef Attar > --- > .../ManageabilityPkg/ManageabilityPkg.dsc | 4 +- > .../BaseManageabilityTransportNull.inf | 28 ++++++++ > .../BaseManageabilityTransportNull.c | 64 +++++++++++++++++++ > .../BaseManageabilityTransportNull.uni | 13 ++++ > 4 files changed, 108 insertions(+), 1 deletion(-) > create mode 100644 > Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/BaseM > anageabilityTransportNull.inf > create mode 100644 > Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/BaseM > anageabilityTransportNull.c > create mode 100644 > Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/BaseM > anageabilityTransportNull.uni >=20 > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc > b/Features/ManageabilityPkg/ManageabilityPkg.dsc > index b3586afa07..f5b8c550e8 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc > @@ -35,5 +35,7 @@ > !include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > !include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc >=20 > -!include Include/Dsc/Manageability.dsc > +[LibraryClasses] > + > ManageabilityTransportLib|ManageabilityPkg/Library/BaseManageabilityTrans= p > ortNullLib/BaseManageabilityTransportNull.inf >=20 > +!include Include/Dsc/Manageability.dsc > diff --git > a/Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/Bas= e > ManageabilityTransportNull.inf > b/Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/Bas= e > ManageabilityTransportNull.inf > new file mode 100644 > index 0000000000..3cb97afb8b > --- /dev/null > +++ > b/Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/Bas= e > ManageabilityTransportNull.inf > @@ -0,0 +1,28 @@ > +## @file > +# Null instance of Manageability Transport Library > +# > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + INF_VERSION =3D 0x0001001B > + BASE_NAME =3D BaseManageabilityTransportNull > + MODULE_UNI_FILE =3D BaseManageabilityTransportNull.uni > + FILE_GUID =3D B63DC070-FB44-44F3-8E9A-DA6CC712EF4= F > + MODULE_TYPE =3D BASE > + VERSION_STRING =3D 1.0 > + LIBRARY_CLASS =3D ManageabilityTransportLib > + > +# > +# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 > +# > + > +[Sources] > + BaseManageabilityTransportNull.c > + > +[Packages] > + ManageabilityPkg/ManageabilityPkg.dec > + MdePkg/MdePkg.dec > + > diff --git > a/Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/Bas= e > ManageabilityTransportNull.c > b/Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/Bas= e > ManageabilityTransportNull.c > new file mode 100644 > index 0000000000..49fc8c0f71 > --- /dev/null > +++ > b/Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/Bas= e > ManageabilityTransportNull.c > @@ -0,0 +1,64 @@ > +/** @file > + Null instance of Manageability Transport Library > + > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#include > +#include > + > +/** > + This function acquires to create a transport session to transmit manag= eability > + packet. A transport token is returned to caller for the follow up oper= ations. > + > + @param [in] ManageabilityProtocolSpec The protocol spec the transpo= rt > interface is acquired. > + @param [out] TransportToken The pointer to receive the tr= ansport > token created by > + the target transport interfac= e library. > + @retval EFI_SUCCESS Token is created successfully= . > + @retval EFI_OUT_OF_RESOURCES Out of resource to create a n= ew > transport session. > + @retval EFI_UNSUPPORTED Protocol is not supported on = this > transport interface. > + @retval Otherwise Other errors. > + > +**/ > +EFI_STATUS > +AcquireTransportSession ( > + IN EFI_GUID *ManageabilityProtocolSpec, > + OUT MANAGEABILITY_TRANSPORT_TOKEN **TransportToken > + ) > +{ > + return EFI_UNSUPPORTED; > +} > + > +/** > + This function returns the transport capabilities. > + > + @param [out] TransportFeature Pointer to receive transport cap= abilities. > + See the definitions of > + MANAGEABILITY_TRANSPORT_CAPABILI= TY. > + > +**/ > +VOID > +GetTransportCapability ( > + OUT MANAGEABILITY_TRANSPORT_CAPABILITY *TransportCapability > + ) > +{ > + *TransportCapability =3D 0; > +} > + > +/** > + This function releases the manageability session. > + > + @param [in] TransportToken The transport token acquired through > + AcquireTransportSession. > + @retval EFI_SUCCESS Token is released successfully. > + Otherwise Other errors. > + > +**/ > +EFI_STATUS > +ReleaseTransportSession ( > + IN MANAGEABILITY_TRANSPORT_TOKEN *TransportToken > + ) > +{ > + return EFI_SUCCESS; > +} > diff --git > a/Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/Bas= e > ManageabilityTransportNull.uni > b/Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/Bas= e > ManageabilityTransportNull.uni > new file mode 100644 > index 0000000000..2211037072 > --- /dev/null > +++ > b/Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/Bas= e > ManageabilityTransportNull.uni > @@ -0,0 +1,13 @@ > +// /** @file > +// Null instance of Manageability Transport Library > +// > +// Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<= BR> > +// > +// SPDX-License-Identifier: BSD-2-Clause-Patent > +// > +// **/ > + > +#string STR_MODULE_ABSTRACT #language en-US "Null instance o= f > Manageability Transport Library" > + > +#string STR_MODULE_DESCRIPTION #language en-US "Manageability > Transport library implementation for build ManageabilityPkg only." > + > -- > 2.37.1.windows.1