From: "Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>
To: Mike Maslenkin <mike.maslenkin@gmail.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "abner.chang@amd.com" <abner.chang@amd.com>,
"igork@ami.com" <igork@ami.com>
Subject: Re: [edk2-devel] [PATCH 1/3] RedfishClientPkg: fix misleading texts in debug traces.
Date: Mon, 4 Dec 2023 07:03:38 +0000 [thread overview]
Message-ID: <MW4PR12MB70316681DF38E17FA7B10617D986A@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231130231844.22397-2-mike.maslenkin@gmail.com>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
Regards,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Friday, December 1, 2023 7:19 AM
> To: devel@edk2.groups.io
> Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> igork@ami.com
> Subject: [PATCH 1/3] RedfishClientPkg: fix misleading texts in debug traces.
>
> External email: Use caution opening links or attachments
>
>
> Update debug traces with the correct function names.
>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
> RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 4 ++--
> .../ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c | 4 ++--
> RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c | 4
> ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> index ea2740184160..a26a1083cd74 100644
> --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> @@ -553,7 +553,7 @@ RedfishCheckResourceCommon (
>
> Status = RedfishPlatformConfigGetConfigureLang (RESOURCE_SCHEMA,
> RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigureLangList,
> &Count);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex
> failed: %r\n", __func__, Status));
> + DEBUG ((DEBUG_ERROR, "%a, RedfishPlatformConfigGetConfigureLang
> failed: %r\n", __func__, Status));
> return Status;
> }
>
> @@ -720,7 +720,7 @@ RedfishIdentifyResourceCommon (
> if (Supported) {
> Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang
> (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION,
> REDPATH_ARRAY_PATTERN, &ConfigLangList);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex
> failed: %r\n", __func__, Status));
> + DEBUG ((DEBUG_ERROR, "%a,
> RedfishFeatureGetUnifiedArrayTypeConfigureLang failed: %r\n", __func__,
> Status));
> return Status;
> }
>
> diff --git
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste
> mCommon.c
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste
> mCommon.c
> index 78beb5cb32b3..979d49f79234 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste
> mCommon.c
> +++
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste
> mCommon.c
> @@ -1457,7 +1457,7 @@ RedfishCheckResourceCommon (
>
> Status = RedfishPlatformConfigGetConfigureLang (RESOURCE_SCHEMA,
> RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigureLangList,
> &Count);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex
> failed: %r\n", __func__, Status));
> + DEBUG ((DEBUG_ERROR, "%a, RedfishPlatformConfigGetConfigureLang
> failed: %r\n", __func__, Status));
> return Status;
> }
>
> @@ -1591,7 +1591,7 @@ RedfishIdentifyResourceCommon (
> if (Supported) {
> Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang
> (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION,
> REDPATH_ARRAY_PATTERN, &ConfigLangList);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex
> failed: %r\n", __func__, Status));
> + DEBUG ((DEBUG_ERROR, "%a,
> RedfishFeatureGetUnifiedArrayTypeConfigureLang failed: %r\n", __func__,
> Status));
> return Status;
> }
>
> diff --git
> a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> index 44325ddb21c4..14c263011c2a 100644
> --- a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> @@ -2373,7 +2373,7 @@ RedfishCheckResourceCommon (
>
> Status = RedfishPlatformConfigGetConfigureLang (RESOURCE_SCHEMA,
> RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigureLangList,
> &Count);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex
> failed: %r\n", __func__, Status));
> + DEBUG ((DEBUG_ERROR, "%a, RedfishPlatformConfigGetConfigureLang
> failed: %r\n", __func__, Status));
> return Status;
> }
>
> @@ -2507,7 +2507,7 @@ RedfishIdentifyResourceCommon (
> if (Supported) {
> Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang
> (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION,
> REDPATH_ARRAY_PATTERN, &ConfigLangList);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex
> failed: %r\n", __func__, Status));
> + DEBUG ((DEBUG_ERROR, "%a,
> RedfishFeatureGetUnifiedArrayTypeConfigureLang failed: %r\n", __func__,
> Status));
> return Status;
> }
>
> --
> 2.32.0 (Apple Git-132)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112004): https://edk2.groups.io/g/devel/message/112004
Mute This Topic: https://groups.io/mt/102905309/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-12-04 7:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 23:18 [edk2-devel] [edk2-redfish-client][PATCH 0/3] RedfishClientPkg: fix traces Mike Maslenkin
2023-11-30 23:18 ` [edk2-devel] [PATCH 1/3] RedfishClientPkg: fix misleading texts in debug traces Mike Maslenkin
2023-12-04 7:03 ` Nickle Wang via groups.io [this message]
2023-11-30 23:18 ` [edk2-devel] [PATCH 2/3] RedfishClientPkg: fix format specifier in DEBUG macro Mike Maslenkin
2023-12-04 7:03 ` Nickle Wang via groups.io
2023-11-30 23:18 ` [edk2-devel] [PATCH 3/3] RedfishClientPkg: warn user about reboot if allowed Mike Maslenkin
2023-12-04 7:05 ` Nickle Wang via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR12MB70316681DF38E17FA7B10617D986A@MW4PR12MB7031.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox