From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D9772780091 for ; Mon, 4 Dec 2023 07:03:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4TAjodwkjq5myxL6fzvXoIQfD4oLj4N9eTb2U9eF+5Q=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701673423; v=1; b=lM4kKi2J19daqBN9irSxRUzRkr5Xfj2qmVKDGY05ZFeQpbhfBhuXEMhZOOW9v8GWytdblYeM I5uZUMDhPbsvZKTcotgKA2al498r+rpxxCD8mnbnQGyACxSAxSKxuNTZo86p02+XBX6BvW0CRks vqMWqsN2ina7+78n6wll4orc= X-Received: by 127.0.0.2 with SMTP id hyczYY7687511xDovnNaKLfI; Sun, 03 Dec 2023 23:03:43 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.75]) by mx.groups.io with SMTP id smtpd.web10.64092.1701673422454921827 for ; Sun, 03 Dec 2023 23:03:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cYGLs9ZIZU0UDVV2Rl+9LXnvdCAUQPKRaei34CJ2dHXpNnoGVtPF74xJO5VO+qqqQbp5sTVxDKdeHqGEeBTH6Xei7ukgPtuiuSlq/uNGpWfivHWruz5gv2QMJM2Rbj8EoplBK6/dV6pKoDZvO5yIvyRcsJY5PndXWf5tYTuU3psHrZpu786a3PS5bBQFPADWtuxHW8YoCiQIooUnLZZvI8nI3LQfE408a9Lk/qwlt+3CG1JPAoqWjYTyGpv2Yv11ZQn9apXSaP/m3hEvXvJ0J0aJ3viXwTkv/j5CxIIEKzf92qlJnF75i9T83dR9xzr8bKswGIiiKX51S3ApEy4GtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pfHf8+ZAIdeIdsXQPyglDA1Y62cQAn30yaR/UmHMKIs=; b=j4cNrbYSexArkPPaBdipom91kItE35g/0eoog8y63QqukfwvYQpgq8C8Sojg698RsJgS9P9eNtbqAbJZdLRsF85utjMPdQx0SXPNNkKVR9lLHDEhZrUBvBwSk2eNuHU90unk0TPYXszdDWx2tILo/bQkrvbnpIxJeNlEkjL/NznK6LJwv93ZA+VLOJBxQFy750dQScFlYkZ1IU37BkxpIga4qP8qXGKOdHmvy+oCH/SVCKbK+lYafggXrqs/1NOnGocRMfgmHzhGE3wQHFCGntyIQlgQLggrH9gMB2QsMhfj1g9+sZQwkzVCPZ4MsCpIzR8qsuVt7YNwTohQAxqOUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by SA3PR12MB7877.namprd12.prod.outlook.com (2603:10b6:806:31b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.33; Mon, 4 Dec 2023 07:03:38 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::a78e:602e:415c:4cb4%3]) with mapi id 15.20.7046.033; Mon, 4 Dec 2023 07:03:38 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "abner.chang@amd.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH 1/3] RedfishClientPkg: fix misleading texts in debug traces. Thread-Topic: [PATCH 1/3] RedfishClientPkg: fix misleading texts in debug traces. Thread-Index: AQHaI+OY4U57P+pIdECtdX+Pjle1gbCYuCqg Date: Mon, 4 Dec 2023 07:03:38 +0000 Message-ID: References: <20231130231844.22397-1-mike.maslenkin@gmail.com> <20231130231844.22397-2-mike.maslenkin@gmail.com> In-Reply-To: <20231130231844.22397-2-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|SA3PR12MB7877:EE_ x-ms-office365-filtering-correlation-id: 01bd8c47-ada8-4aae-fb82-08dbf4972400 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: AoErs+n+rID7FTyX1FghQazTPu10h5BSak2bQiPNZKfCVY+zRB7h3Ifie9TuzNhfgHo0qfPuPlXHncwFZo9DJR3Dg22l13TM8Mjrr05XQKHyZZtWTFvNqV7C1hHYhkBxPVYMrtmaMmAx+u2fUDorrOZCknhMNiIX5XosmXUoKI3djjaAu/Apw241ETYWr8Dw52yMN8Tih5Ezhij8aFO8RDjADOh/PK8o51aUH7BIvF83v4jd5ynEMMR1qF9o8NqVQ11BcwRBBKiRq4voXiYc+XywlPLqe9+ZTiqhaGb8GRxZiy2uldhiCjONplm5YrkmX8PN7al2zMFu9LrV34/u8QnOHU8JCFx4AtDjiNxtgzj/uNsfvYoAKRsup4vMr359WGq3IXyH5y0niZbYN+UJcPGaTUhLqtH+6NMAPZqOJ3RC0zQlo99tdtCO3tyYKVNrlDGTIj2iV/cThYg3gOh5qdObt1wZMn+Pqye2UUzsmEuW5zdtzhZr8Of3M6GBIsuplnv4y9Fk99O6rhRXMd7YJHb2UrRk3Dwjb4nehadACql3+bKAC6s3d/wlmnE8szmPHMMOk3yO0MuRr4cNzxZik7wgsvEjs+sis66f0AFdPZY+7Jaf3p9Cze4u985R96wIJwJ++tBFfWWJBUatbWdavNv6JPHo+jKF9tCryZP+fpA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CXXPUpKgKxyzr4asaj3oXdBg0npVfNMHrqgT0HxihIrW/lQ227H0LpBohFFH?= =?us-ascii?Q?uKCy9sh8hOMsBmQo3a/485158vSaXpX2Gh3ygpPjcO5zhNzlB6jjrl9+/8y3?= =?us-ascii?Q?yyoBn8XBkRElBB0F1X5B4jn8qOIJXKsLHCieTqhZYVcpI3tiGCya8nft7phN?= =?us-ascii?Q?NddTMbX3ziOcq9QEHNFHZXPnoiBA5ndv9v7IBGHILJSVvJh3I+kc1YpmAGCv?= =?us-ascii?Q?vFw62w1nZf/RYouiZLFDh84kTJXd1xV+1/+DhL0uavdSXXprWr5euiYrfxLL?= =?us-ascii?Q?2ZpHuWeudU5MTZvn7n2alaOAr3Yull1OGSdx505OUZ7dGefQRmj5KAAjTM7I?= =?us-ascii?Q?QPxsOu5VIxqe1pIzdOluoQNyjbgXnelp5d5q1rHD5qxTn93vwWgBslQV0U7Y?= =?us-ascii?Q?s4Z1AhQR/pqOB770343EGP6M1JOgiaMxODVTui2qNjykrVQzyilKIPoHKT0o?= =?us-ascii?Q?I3is2iaa5Jv4wNzO2OXk/HD3fPE8GCow7AWI+sKx2bK3GYXj5nqSXQkrn90l?= =?us-ascii?Q?KwAzgM+tZ8r00rZAsX8dBk657nvk2YJAh4dC7UqdNJPpx2utILfEw1N+LyB5?= =?us-ascii?Q?JstPj3x4nPy4/+JXb1XH/zjg5QhZtLcKANGgLKnwlliu70LSjHOHRtdesbQw?= =?us-ascii?Q?hfckByHW+A//VUm9+yAOVAv5S7B4gc08tfmkAl9pLAJGoZPjtb0R0UjrCA0F?= =?us-ascii?Q?yagEEjWw+YIjhRn4MHgFMjD5SmFKmXWmOBLTW9nqrVIXMOHJxhO+uYbApm/g?= =?us-ascii?Q?H1NIMI9Ku7qIFFS4PNaiivI/2NEMhBKVElhD56YBC0xdYMDEItRLfxWOJp0B?= =?us-ascii?Q?0GKSJmxo/fUJtGwVfYX31MAcxSjHad53JfSvIyhaFx2pMC4d0omQzVf0IN3W?= =?us-ascii?Q?74m8LesB94e9aOiiFGrjEu0mbkydJlAnusiLpl62GKumEDDcKLp1C3IXFJZA?= =?us-ascii?Q?yAMOFLQ92nJgEA0DimXNvm/SecGKBa8CqPt7kjW68e03JOkNLMOKbftT1Q4y?= =?us-ascii?Q?CjRhMohMsYCaxN2LBp1S2k1mYxJSsgBgy7y8sM0JwGCOLIc52VVpwJ5kjQRc?= =?us-ascii?Q?m+Pa6xTbbngS/zseaWyFkGNh1suPYMnpwCm98oo2xuAT5JsCCs1JSA9aQ30i?= =?us-ascii?Q?ECSscoXQNn2iKMRKdnDgznBzCmxn/B8xwC8L76ZcoVmCq8tJk3khCHaiAIkL?= =?us-ascii?Q?WEvBs8HIVyvvO7Kg9IPNVqCiWNNP4BLuV7b6jPya78LQZo8zrqPMX/DA7s4d?= =?us-ascii?Q?YTi1p90ndDM5vaRin3muJSAaTUp8yYiOK3mGE1yuy1xkdEj7VmzsSW33KPbq?= =?us-ascii?Q?beVDMAiwcuLxLBdmzvIZ5vhblJnFZv0mOal0T4ly9YxaWHLwlhz3H8NvX6gN?= =?us-ascii?Q?Z93AEcUltE1ibdRJAUn+O38hBRxA8KqRwQYIWc3KagEVCVgiWIECixZe8IJF?= =?us-ascii?Q?PRHFB6ONU8R+Ko8XNJkz8sM7FTssCUEQxJQSmZ0wAosibcTZX4hru4rrm9d1?= =?us-ascii?Q?73lPNKaMxHv9BJ1GmM+NmW2VBaYRAoIObdBfpwlzMxmH3Qi6m9JLM5c1fvNO?= =?us-ascii?Q?wbfR3L+8jKL8WTo5KFCYKuXGjOqTNdw0xo2nPzTQ55h6tCFBLMW3ehVWYZNY?= =?us-ascii?Q?S6MFpvxdnlzJa+/rp0Biq4c4GOiAatRFBgzJZ2K5tRLa?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01bd8c47-ada8-4aae-fb82-08dbf4972400 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2023 07:03:38.3821 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NhtwfLPhcU1j6CjqfJyklVZpEnQwk2tLsWEsyePa3d26SXyo9SXAwjCgBNLskxCvglkOHV5aQFMn83HeJ6w5gQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7877 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xDsX3oLwLKKxzQpDteZ2QAP3x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=lM4kKi2J; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Friday, December 1, 2023 7:19 AM > To: devel@edk2.groups.io > Cc: abner.chang@amd.com; Nickle Wang ; > igork@ami.com > Subject: [PATCH 1/3] RedfishClientPkg: fix misleading texts in debug trac= es. >=20 > External email: Use caution opening links or attachments >=20 >=20 > Update debug traces with the correct function names. >=20 > Signed-off-by: Mike Maslenkin > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > --- > RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 4 ++-- > .../ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c | 4 ++-- > RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c | 4 > ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > index ea2740184160..a26a1083cd74 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > @@ -553,7 +553,7 @@ RedfishCheckResourceCommon ( >=20 > Status =3D RedfishPlatformConfigGetConfigureLang (RESOURCE_SCHEMA, > RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigureLangList, > &Count); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex > failed: %r\n", __func__, Status)); > + DEBUG ((DEBUG_ERROR, "%a, RedfishPlatformConfigGetConfigureLang > failed: %r\n", __func__, Status)); > return Status; > } >=20 > @@ -720,7 +720,7 @@ RedfishIdentifyResourceCommon ( > if (Supported) { > Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex > failed: %r\n", __func__, Status)); > + DEBUG ((DEBUG_ERROR, "%a, > RedfishFeatureGetUnifiedArrayTypeConfigureLang failed: %r\n", __func__, > Status)); > return Status; > } >=20 > diff --git > a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste > mCommon.c > b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste > mCommon.c > index 78beb5cb32b3..979d49f79234 100644 > --- > a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste > mCommon.c > +++ > b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste > mCommon.c > @@ -1457,7 +1457,7 @@ RedfishCheckResourceCommon ( >=20 > Status =3D RedfishPlatformConfigGetConfigureLang (RESOURCE_SCHEMA, > RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigureLangList, > &Count); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex > failed: %r\n", __func__, Status)); > + DEBUG ((DEBUG_ERROR, "%a, RedfishPlatformConfigGetConfigureLang > failed: %r\n", __func__, Status)); > return Status; > } >=20 > @@ -1591,7 +1591,7 @@ RedfishIdentifyResourceCommon ( > if (Supported) { > Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex > failed: %r\n", __func__, Status)); > + DEBUG ((DEBUG_ERROR, "%a, > RedfishFeatureGetUnifiedArrayTypeConfigureLang failed: %r\n", __func__, > Status)); > return Status; > } >=20 > diff --git > a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > index 44325ddb21c4..14c263011c2a 100644 > --- a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > @@ -2373,7 +2373,7 @@ RedfishCheckResourceCommon ( >=20 > Status =3D RedfishPlatformConfigGetConfigureLang (RESOURCE_SCHEMA, > RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigureLangList, > &Count); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex > failed: %r\n", __func__, Status)); > + DEBUG ((DEBUG_ERROR, "%a, RedfishPlatformConfigGetConfigureLang > failed: %r\n", __func__, Status)); > return Status; > } >=20 > @@ -2507,7 +2507,7 @@ RedfishIdentifyResourceCommon ( > if (Supported) { > Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang > (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, > REDPATH_ARRAY_PATTERN, &ConfigLangList); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex > failed: %r\n", __func__, Status)); > + DEBUG ((DEBUG_ERROR, "%a, > RedfishFeatureGetUnifiedArrayTypeConfigureLang failed: %r\n", __func__, > Status)); > return Status; > } >=20 > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112004): https://edk2.groups.io/g/devel/message/112004 Mute This Topic: https://groups.io/mt/102905309/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-