From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.66]) by mx.groups.io with SMTP id smtpd.web10.1264.1680845957768760720 for ; Thu, 06 Apr 2023 22:39:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=OROmvoNd; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.243.66, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cNEUnaYBpSTI7ybU+ImHEFixcjTe8EDb6GfYt/Ivdhn0GPFDLjVMlNgdFCc4/jl31H/s7jhY2nrlSqOubz/LXyUnc7oVxDYb44dGORmROIr/rBPoPcgm2hPIcWHwCPQww/Dry1d/CckcM0dD6OYfFNjZVDzXDlnRgQ7Af2Elt12zOeBdKn7WYChtkcILSAXt+jFZFf/sVHCKaWzKMCPfwVHQ8mDE4K7X91zfo+m2DcqWzKjOXTlb36yABZgPKwmNciva748DpsABxc5V2wr7SfJzDC0SA0850JOxDHHZUNERkztOWAu9rpGk7Hu0ecWcuxkZdwjyS6Y9lNKKymtryA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tV6ijupslxJDhqU5E23tFRBw/cuMfwkFDAbMOrtusl0=; b=B5c7g7W+/WBghsfgWZN4DbSzWlKYYywxOOsQ+RW/5uZtSnmvQHLq2MEyLwmO+i/OVNyjneKLs7c1qxZ818wJ+P2dWYI734AyQDIv+mcVxY0iM0N19SCRRtzi3YZabrUU9kZqF95HnOaWqJjHOAvn+f0VUKuY8HZhnqrsNB+vW4Ve1M+AkTFWUbKBC/vnIedCm5WKdrPXqQbVICIwnl6Gme1ZU4Y4y/yw5jgHtA2ciKzQa54hqctgAFlN44Yhq0EDdjT8nWvBVlqfE9mr/SHfmSezUltbZZO4eLeNUz1AAUKf7faeKwI9gCOgNKYKvk2q/pCxZI3xcNNJNP7KctFbAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tV6ijupslxJDhqU5E23tFRBw/cuMfwkFDAbMOrtusl0=; b=OROmvoNd77RMkH9ReTdJ7p4rpK8oB2AQ9AaTP6VVhGooHAIcChLD1Cn3s7c7ycTKdlIFVq0qLY8dsBGSJCqXOwv+1q7q8m/JZEv6YvX9vOpQmTF2Ti8Xdi31PDHHrYqc6yTlhw6IqtsT3bBZwMoeF8ZZiLksVo94r3Lgof5NLfHrjplEb576VWVDvN4GLxU0+T1nTLZSXYJiKP8C+7w4gohhzlNoemlc83lUxWijLuew7thUfYf1GV/fitA5EB0R9lprMczqq3EX4gWyoqaS5zL5FSL8pKyHFYt9UrBa5dE9PrZkoh/cfXm40yYxVhYyeZhTMK+fc4n4mERohTtGgQ== Received: from IA1PR12MB7517.namprd12.prod.outlook.com (2603:10b6:208:41a::19) by SJ1PR12MB6026.namprd12.prod.outlook.com (2603:10b6:a03:48b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Fri, 7 Apr 2023 05:39:14 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by IA1PR12MB7517.namprd12.prod.outlook.com (2603:10b6:208:41a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Fri, 7 Apr 2023 05:39:06 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::deb:4184:674f:c674]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::deb:4184:674f:c674%4]) with mapi id 15.20.6277.034; Fri, 7 Apr 2023 05:39:05 +0000 From: "Nickle Wang" To: Rebecca Cran , "devel@edk2.groups.io" , Liming Gao , Michael D Kinney , Guomin Jiang , Wei6 Xu , Guo Dong , Ray Ni , Sean Rhodes , James Lu , Gua Guo , Andrew Fish , Hao A Wu , Maciej Rabeda , Siyuan Fu , Jiewen Yao , Jian J Wang , Xiaoyu Lu , Ard Biesheuvel , Sami Mujawar , Supreeth Venkatesh , Michael Kubacki , Nate DeSimone , Sean Brogan CC: Leif Lindholm , Abner Chang , Igor Kulchytskyy , Daniel Schaefer , Min Xu , Jordan Justen , Gerd Hoffmann , Peter Grehan , Erdem Aktas , James Bottomley , Tom Lendacky , Michael Roth , Sunil V L , Andrei Warkentin Subject: Re: [PATCH 08/18] RedfishPkg: Update code to be more C11 compliant by using __func__ Thread-Topic: [PATCH 08/18] RedfishPkg: Update code to be more C11 compliant by using __func__ Thread-Index: AQHZaNaDZWNE+yy3u0+ALLox4sEWo68fVLLw Date: Fri, 7 Apr 2023 05:39:05 +0000 Message-ID: References: <20230406222319.2281263-1-rebecca@bsdio.com> <20230406222319.2281263-9-rebecca@bsdio.com> In-Reply-To: <20230406222319.2281263-9-rebecca@bsdio.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|IA1PR12MB7517:EE_|SJ1PR12MB6026:EE_ x-ms-office365-filtering-correlation-id: 4f57c01d-d38f-4b46-854f-08db372a6697 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2Q+jqYlaHWCVm3MjcuDDZC7vSRzaeVkkCQ3HJgTMLa1v+8OBg+lJ1LkAuCTHlEfKqC+cMtQsbasA+Py6kUuEUFfyugQZJkNGrGbLhLuYSGipGYfWMSIWzTdPXErQN/S3HaYS8AcqQiNIyrzuyAiJ2VPUYWFRqJOLpautfVfv5tMNhiQUpqH7n5rIOr4jORsAL6ioit8njmzit8yf9nxARuVY4KJwFs/6PCY5oIgzMzkgHiu87DacoiHRDch+l1fq0tbjrFSy6H894BMU6Q3XcMd2bhmvOo+Kv9nIyEbR8z3XKV0+5R7iQbpBMyrEuwgpgjB37KTQzDdKGvLQP8tMlwlB8w2Xj+Uz5w4EZzHrv91m7ZfB/xwkM3/+gf5Xkc/VU+/4Si+0Pu4f+Y8c53tj2NfjIP/pVJYgNg73g6lOJpew59K+6rRWcJUCKXq8uBORarISphW0gV5GYQ+vmQr1sBQXbTT2bBr7hWz8ZkDpGorBSLzALreHxNx+RFCqUb8G+iDj1x46XBk7NXAgaER0KrdR0sRRPAhKGNMVkHOIhC7WnlQlVrZ5FT2SjXGsSXRi5d7p+PAaZ/F1zQNSiB131OiTe+xUmlN4bVpHe2jGb4r+H1EaY8HqwP07+mnQNEbzPt2VZRoEC9FVERO0NM587Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR12MB7517.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(366004)(376002)(136003)(39860400002)(396003)(451199021)(30864003)(38070700005)(66556008)(122000001)(53546011)(921005)(55016003)(9686003)(186003)(38100700002)(83380400001)(8936002)(5660300002)(26005)(52536014)(2906002)(7406005)(7416002)(33656002)(478600001)(7696005)(66476007)(15650500001)(71200400001)(76116006)(64756008)(66446008)(66946007)(8676002)(110136005)(54906003)(41300700001)(6506007)(4326008)(19627235002)(86362001)(316002)(559001)(579004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KY/4RcMdRd4o4/2LjXRGsaEV93HkGOUDkRrfoX47qM2N1HHSIJ9+SRvxqG+3?= =?us-ascii?Q?PjncYwDTcsRsdav59Tbkz/xZo7A+fXyyBE8jZtuaZKMl117oT/hhaS9HRCgb?= =?us-ascii?Q?j+CVAa4o7vNscneRW0JSIozxzcGislsV/rTdhxhk7c+G/osZv80ibNbRPnAB?= =?us-ascii?Q?SG758ZelgJ0cVnGCvoHlL7LhG+SugHqIpIQXx2ZPfol8Ez06PElGwUfD61nC?= =?us-ascii?Q?iJUlJLEDxXSi3rPirjvDCABprEU3EkEd+CJ5vBvmVVwKL8kkyJyzZt41rqUW?= =?us-ascii?Q?t3bw6QW9jzt3jW6oEXcOlpoIfiK9GV/+d3II9TR+qd6pB6QyQgZ5FzGtw03w?= =?us-ascii?Q?bThCNsbGZqel5yeA9bFOCeI2sBmhaCk+naxsMjFg2QO/bFZ3IXNZOcizo3w1?= =?us-ascii?Q?wV+YqVlfexE3Od1nFvKxFgTZH37ijDFCXDBI2GzcoKUzdPrXV+5YWBg1cmVY?= =?us-ascii?Q?mZdcP2VzcJ0791e2vQ07l4vkiifGxmgho+ocGArT8Acao6XZ/bI2hG25SQd0?= =?us-ascii?Q?5u05ZGKA3k8e+411iqJi4L/GqrrkQpdQSQAsuWtBmJVt09YxFmu9Xrposjur?= =?us-ascii?Q?8llPoFWt6HmYhJdw3u/HYra/60ig9FwXuL5Rs5zuXHDWhAEFAFqVNfDuVCcK?= =?us-ascii?Q?NBAFMb03iJn6z2wKu/y/nqBaqyWY/WFC7eShHBFadZUr9yTqlpgGC80Jpd0+?= =?us-ascii?Q?yQb7jjpbU+gUWr/RCBWTGCceqqQ3bfwa9mV8UCc4612ZfMDiBHHljK9L9JBW?= =?us-ascii?Q?jlCw0F85p8LwcQMildm9v184/Ik6CCjBdxG6oVRA2G1TZqKUn4evx5GD6+aG?= =?us-ascii?Q?C3kxAe448mtQ1kXzgDlY/++p40kUqHPx4pat4y8QT34AHfjKIcqgBwwpbWpD?= =?us-ascii?Q?mECy+DR+dGluGIYN9tdz6yNjKxvB1AOl3s5DMS3mTWu/NEkQ33QEY87ku+qV?= =?us-ascii?Q?r5MM15QROyEoH4qraBk9g5jLUzgqZIj9czD0trkVFp6WRgvB3PQNlmXLoeee?= =?us-ascii?Q?uFV8t+4nBHrRfCLkglGcTSV3Pfv+7GvOS+F/MxZov2uPDiK86hl6T8NYjFNE?= =?us-ascii?Q?g0CfvWrP5ck672n1HM54zoKcWfIfgu8FvYRzpw5rKrxgqHmhiJBXxXra57Tx?= =?us-ascii?Q?q3uUl7qd3gs0978+xwTJGP7QNMEqCBMmeO9XDsRok7dNGBIZHbN4teEvw8f2?= =?us-ascii?Q?lSETH1iWVD7mQcszO/3VL+74NPf3ewzOuGB6b0tDczp9pxqimkMk2xsGw267?= =?us-ascii?Q?vmuOPlt7N+jyKSAz/klUNaWXXEYI+J987mUkGp8X0Nl9KB6FhRegPS3Cm3UT?= =?us-ascii?Q?B/Fp3Cwi8TLGdLRS/0RD3fCnroSyQVlh3mMnzcjOWu7P6eTFosiHbIp2fqRS?= =?us-ascii?Q?XsluoGyTOjn9PiAAXQBRkUdLB6CVVSmjfbGwWBdWHwLLyKOZvpqV+9nA5ayI?= =?us-ascii?Q?qv9tosbzlVVwdOLRaaKFtwLGX7mDn0H8GvDiTkUtM3EXT0+/7QxiktSuuI5y?= =?us-ascii?Q?SkBzoWfoOoeM0Mpr2zWkzpgx/fiV8cPf97CuwKDZ4ycqGduLIw6t4x5V9bD7?= =?us-ascii?Q?+lWmG8K/4Hb1/mArIUk=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f57c01d-d38f-4b46-854f-08db372a6697 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2023 05:39:05.2329 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VzZh6r3S/i4eU9j+flo+Q3epRqQc0293J2qLD+xB0ajvjU6+Ajz6W9y0sM+GhJUft2kHZrGJTn0gXL+qxOMvZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6026 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Rebecca Cran > Sent: Friday, April 7, 2023 6:23 AM > To: devel@edk2.groups.io; Liming Gao ; Michael > D Kinney ; Guomin Jiang > ; Wei6 Xu ; Guo Dong > ; Ray Ni ; Sean Rhodes > ; James Lu ; Gua Guo > ; Andrew Fish ; Hao A Wu > ; Maciej Rabeda ; > Siyuan Fu ; Jiewen Yao ; Jian = J > Wang ; Xiaoyu Lu ; Ard > Biesheuvel ; Sami Mujawar > ; Supreeth Venkatesh > ; Michael Kubacki > ; Nate DeSimone > ; Sean Brogan > > Cc: Rebecca Cran ; Leif Lindholm > ; Abner Chang ; Nickle > Wang ; Igor Kulchytskyy ; Daniel > Schaefer ; Min Xu ; Jordan > Justen ; Gerd Hoffmann ; > Peter Grehan ; Erdem Aktas ; > James Bottomley ; Tom Lendacky > ; Michael Roth ; Sunil > V L ; Andrei Warkentin > > Subject: [PATCH 08/18] RedfishPkg: Update code to be more C11 compliant b= y > using __func__ >=20 > External email: Use caution opening links or attachments >=20 >=20 > __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among > others support, while __func__ was standardized in C99. >=20 > Since it's more standard, replace __FUNCTION__ with __func__ throughout > RedfishPkg. >=20 > Visual Studio versions before VS 2015 don't support __func__ and so > will fail to compile. A workaround is to define __func__ as > __FUNCTION__ : >=20 > #define __func__ __FUNCTION__ >=20 > Signed-off-by: Rebecca Cran > --- >=20 > RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac= e > BmcUsbNicLib.c | 36 ++++++------ >=20 > RedfishPkg/Library/RedfishPlatformCredentialIpmiLib/RedfishPlatformCreden= tia > lIpmiLib.c | 28 ++++----- > RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c = | 2 +- > RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c = | > 4 +- > RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c > | 6 +- > RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c > | 20 +++---- > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c = | 62 > ++++++++++---------- > RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > | 14 ++--- > RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c = | 14 > ++--- > 9 files changed, 93 insertions(+), 93 deletions(-) >=20 > diff --git > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= a > ceBmcUsbNicLib.c > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= a > ceBmcUsbNicLib.c > index 122473dbe446..4bd01850af93 100644 > --- > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= a > ceBmcUsbNicLib.c > +++ > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterf= a > ceBmcUsbNicLib.c > @@ -37,7 +37,7 @@ ProbeRedfishCredentialBootstrap ( > UINT32 ResponseSize; > BOOLEAN ReturnBool; >=20 > - DEBUG ((DEBUG_INFO, "%a: Entry\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); >=20 > // > // IPMI callout to NetFn 2C, command 02 > @@ -65,10 +65,10 @@ ProbeRedfishCredentialBootstrap ( > (ResponseData.CompletionCode =3D=3D > REDFISH_IPMI_COMP_CODE_BOOTSTRAP_CREDENTIAL_DISABLED) > )) > { > - DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Redfish Credentail > Bootstrapping is supported\n", __FUNCTION__)); > + DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Redfish Credentail > Bootstrapping is supported\n", __func__)); > ReturnBool =3D TRUE; > } else { > - DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Redfish Credentail > Bootstrapping is not supported\n", __FUNCTION__)); > + DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Redfish Credentail > Bootstrapping is not supported\n", __func__)); > ReturnBool =3D FALSE; > } >=20 > @@ -94,7 +94,7 @@ RedfishPlatformHostInterfaceDeviceDescriptor ( > HOST_INTERFACE_BMC_USB_NIC_INFO *ThisInstance; > REDFISH_INTERFACE_DATA *InterfaceData; >=20 > - DEBUG ((DEBUG_INFO, "%a: Entry\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); >=20 > if (IsListEmpty (&mBmcUsbNic)) { > return EFI_NOT_FOUND; > @@ -166,7 +166,7 @@ RedfishPlatformHostInterfaceProtocolData ( > UINT8 HostNameLength; > CHAR8 *HostNameString; >=20 > - DEBUG ((DEBUG_INFO, "%a: Entry\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); >=20 > if (IsListEmpty (&mBmcUsbNic) || (IndexOfProtocolData > 0)) { > return EFI_NOT_FOUND; > @@ -300,7 +300,7 @@ RetrievedBmcUsbNicInfo ( > IPMI_LAN_VLAN_ID *LanVlanId; > EFI_USB_DEVICE_DESCRIPTOR UsbDeviceDescriptor; >=20 > - DEBUG ((DEBUG_INFO, "%a: Entry\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); >=20 > if (IsListEmpty (&mBmcUsbNic)) { > return EFI_NOT_FOUND; > @@ -605,7 +605,7 @@ HostInterfaceIpmiCheckMacAddress ( > EFI_MAC_ADDRESS IpmiLanChannelMacAddre= ss; > BOOLEAN AlreadyCached; >=20 > - DEBUG ((DEBUG_INFO, "%a: Entry.\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Entry.\n", __func__)); >=20 > GetLanConfigReps =3D NULL; > AlreadyCached =3D FALSE; > @@ -823,7 +823,7 @@ UsbNicSearchUsbIo ( > EFI_DEVICE_PATH_PROTOCOL *ThisUsbDevicePath; > EFI_DEVICE_PATH_PROTOCOL *ThisUsbDevicePathEnd; >=20 > - DEBUG ((DEBUG_INFO, "%a: Entry.\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Entry.\n", __func__)); > DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "Device path on the EFI handle > which has UsbIo and SNP instaleld on it.\n")); > DevicePathStr =3D ConvertDevicePathToText (UsbDevicePath, FALSE, FALSE= ); > if (DevicePathStr !=3D NULL) { > @@ -987,7 +987,7 @@ IdentifyUsbNicBmcChannel ( > EFI_USB_IO_PROTOCOL *UsbIo; > HOST_INTERFACE_BMC_USB_NIC_INFO *BmcUsbNic; >=20 > - DEBUG ((DEBUG_INFO, "%a: Entry.\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Entry.\n", __func__)); > Status =3D gBS->HandleProtocol ( > Handle, > &gEfiSimpleNetworkProtocolGuid, > @@ -1074,7 +1074,7 @@ CheckBmcUsbNicOnHandles ( > return EFI_INVALID_PARAMETER; > } >=20 > - DEBUG ((DEBUG_INFO, "%a: Entry, #%d SNP handle\n", __FUNCTION__, > HandleNumer)); > + DEBUG ((DEBUG_INFO, "%a: Entry, #%d SNP handle\n", __func__, > HandleNumer)); >=20 > GotOneUsbNIc =3D FALSE; > for (Index =3D 0; Index < HandleNumer; Index++) { > @@ -1084,7 +1084,7 @@ CheckBmcUsbNicOnHandles ( > (VOID **)&DevicePath > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, " Failed to locate SNP on %d handle.\n", > __FUNCTION__, Index)); > + DEBUG ((DEBUG_ERROR, " Failed to locate SNP on %d handle.\n", > __func__, Index)); > continue; > } >=20 > @@ -1137,7 +1137,7 @@ CheckBmcUsbNic ( > UINTN BufferSize; > EFI_HANDLE *HandleBuffer; >=20 > - DEBUG ((DEBUG_INFO, "%a: Entry, the registration key - 0x%08x.\n", > __FUNCTION__, Registration)); > + DEBUG ((DEBUG_INFO, "%a: Entry, the registration key - 0x%08x.\n", > __func__, Registration)); >=20 > Handle =3D NULL; > Status =3D EFI_SUCCESS; > @@ -1213,7 +1213,7 @@ PlatformHostInterfaceSnpCallback ( > IN VOID *Context > ) > { > - DEBUG ((DEBUG_INFO, "%a: Entry.\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Entry.\n", __func__)); >=20 > CheckBmcUsbNic (mPlatformHostInterfaceSnpRegistration); > return; > @@ -1241,7 +1241,7 @@ RedfishPlatformHostInterfaceNotification ( > { > EFI_STATUS Status; >=20 > - DEBUG ((DEBUG_INFO, "%a: Entry\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); >=20 > *InformationReadinessGuid =3D NULL; > InitializeListHead (&mBmcUsbNic); > @@ -1257,7 +1257,7 @@ RedfishPlatformHostInterfaceNotification ( > } >=20 > if (Status =3D=3D EFI_NOT_FOUND) { > - DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "%a: BMC USB NIC is not > found. Register the notification.\n", __FUNCTION__)); > + DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "%a: BMC USB NIC is not > found. Register the notification.\n", __func__)); >=20 > // Register the notification of SNP installation. > Status =3D gBS->CreateEvent ( > @@ -1268,7 +1268,7 @@ RedfishPlatformHostInterfaceNotification ( > &mPlatformHostInterfaceSnpEvent > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Fail to create event for the installatio= n of > SNP protocol.", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Fail to create event for the installatio= n of > SNP protocol.", __func__)); > return Status; > } >=20 > @@ -1278,7 +1278,7 @@ RedfishPlatformHostInterfaceNotification ( > &mPlatformHostInterfaceSnpRegistration > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Fail to register event for the installat= ion of > SNP protocol.", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Fail to register event for the installat= ion of > SNP protocol.", __func__)); > return Status; > } >=20 > @@ -1286,6 +1286,6 @@ RedfishPlatformHostInterfaceNotification ( > return EFI_SUCCESS; > } >=20 > - DEBUG ((DEBUG_ERROR, "%a: Something wrong when look for BMC USB > NIC.\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Something wrong when look for BMC USB > NIC.\n", __func__)); > return Status; > } > diff --git > a/RedfishPkg/Library/RedfishPlatformCredentialIpmiLib/RedfishPlatformCred= en > tialIpmiLib.c > b/RedfishPkg/Library/RedfishPlatformCredentialIpmiLib/RedfishPlatformCred= en > tialIpmiLib.c > index dacb09bb2399..3b34dafbaf60 100644 > --- > a/RedfishPkg/Library/RedfishPlatformCredentialIpmiLib/RedfishPlatformCred= en > tialIpmiLib.c > +++ > b/RedfishPkg/Library/RedfishPlatformCredentialIpmiLib/RedfishPlatformCred= en > tialIpmiLib.c > @@ -63,10 +63,10 @@ LibStopRedfishService ( > // > Status =3D SetBootstrapAccountCredentialsToVariable (NULL, NULL, TRUE)= ; > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: fail to remove bootstrap credential: %r\n"= , > __FUNCTION__, Status)); > + DEBUG ((DEBUG_ERROR, "%a: fail to remove bootstrap credential: %r\n"= , > __func__, Status)); > } >=20 > - DEBUG ((DEBUG_INFO, "%a: bootstrap credential service stopped\n", > __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: bootstrap credential service stopped\n", > __func__)); >=20 > return EFI_SUCCESS; > } > @@ -153,7 +153,7 @@ GetBootstrapAccountCredentials ( > return EFI_INVALID_PARAMETER; > } >=20 > - DEBUG ((DEBUG_VERBOSE, "%a: Disable bootstrap control: 0x%x\n", > __FUNCTION__, DisableBootstrapControl)); > + DEBUG ((DEBUG_VERBOSE, "%a: Disable bootstrap control: 0x%x\n", > __func__, DisableBootstrapControl)); >=20 > // > // IPMI callout to NetFn 2C, command 02 > @@ -183,19 +183,19 @@ GetBootstrapAccountCredentials ( > ); >=20 > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: IPMI transaction failure. Returning\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: IPMI transaction failure. Returning\n", > __func__)); > return Status; > } else { > if (ResponseData.CompletionCode !=3D IPMI_COMP_CODE_NORMAL) { > if (ResponseData.CompletionCode =3D=3D > REDFISH_IPMI_COMP_CODE_BOOTSTRAP_CREDENTIAL_DISABLED) { > - DEBUG ((DEBUG_ERROR, "%a: bootstrap credential support was > disabled\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: bootstrap credential support was > disabled\n", __func__)); > return EFI_ACCESS_DENIED; > } >=20 > - DEBUG ((DEBUG_ERROR, "%a: Completion code =3D 0x%x. Returning\n", > __FUNCTION__, ResponseData.CompletionCode)); > + DEBUG ((DEBUG_ERROR, "%a: Completion code =3D 0x%x. Returning\n", > __func__, ResponseData.CompletionCode)); > return EFI_PROTOCOL_ERROR; > } else if (ResponseData.GroupExtensionId !=3D > REDFISH_IPMI_GROUP_EXTENSION) { > - DEBUG ((DEBUG_ERROR, "%a: Group Extension Response =3D 0x%x. > Returning\n", __FUNCTION__, ResponseData.GroupExtensionId)); > + DEBUG ((DEBUG_ERROR, "%a: Group Extension Response =3D 0x%x. > Returning\n", __func__, ResponseData.GroupExtensionId)); > return EFI_DEVICE_ERROR; > } else { > if (BootstrapUsername !=3D NULL) { > @@ -216,7 +216,7 @@ GetBootstrapAccountCredentials ( > } > } >=20 > - DEBUG ((DEBUG_INFO, "%a: get bootstrap credential via IPMI: %r\n", > __FUNCTION__, Status)); > + DEBUG ((DEBUG_INFO, "%a: get bootstrap credential via IPMI: %r\n", > __func__, Status)); >=20 > return Status; > } > @@ -269,7 +269,7 @@ GetBootstrapAccountCredentialsFromVariable ( > } >=20 > if (DataSize !=3D sizeof (BOOTSTRAP_CREDENTIALS_VARIABLE)) { > - DEBUG ((DEBUG_ERROR, "%a: data corruption. returned size: %d !=3D st= ructure > size: %d\n", __FUNCTION__, DataSize, sizeof > (BOOTSTRAP_CREDENTIALS_VARIABLE))); > + DEBUG ((DEBUG_ERROR, "%a: data corruption. returned size: %d !=3D > structure size: %d\n", __func__, DataSize, sizeof > (BOOTSTRAP_CREDENTIALS_VARIABLE))); > FreePool (Data); > return EFI_NOT_FOUND; > } > @@ -284,7 +284,7 @@ GetBootstrapAccountCredentialsFromVariable ( >=20 > FreePool (Data); >=20 > - DEBUG ((DEBUG_INFO, "%a: get bootstrap credential from variable\n", > __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: get bootstrap credential from variable\n", > __func__)); >=20 > return EFI_SUCCESS; > } > @@ -412,7 +412,7 @@ LibCredentialGetAuthInfo ( > DisableCredentialService =3D PcdGetBool > (PcdRedfishDisableBootstrapCredentialService); >=20 > if (mRedfishServiceStopped) { > - DEBUG ((DEBUG_ERROR, "%a: credential service is stopped due to secur= ity > reason\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: credential service is stopped due to secur= ity > reason\n", __func__)); > return EFI_ACCESS_DENIED; > } >=20 > @@ -441,17 +441,17 @@ LibCredentialGetAuthInfo ( > // > Status =3D GetBootstrapAccountCredentials (DisableCredentialService, *= UserId, > USERNAME_MAX_SIZE, *Password, PASSWORD_MAX_SIZE); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: fail to get bootstrap credential: %r\n", > __FUNCTION__, Status)); > + DEBUG ((DEBUG_ERROR, "%a: fail to get bootstrap credential: %r\n", > __func__, Status)); > return Status; > } >=20 > if (DisableCredentialService) { > - DEBUG ((DEBUG_INFO, "%a: credential bootstrapping control disabled\n= ", > __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: credential bootstrapping control disabled\n= ", > __func__)); > } >=20 > Status =3D SetBootstrapAccountCredentialsToVariable (*UserId, *Passwor= d, > FALSE); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: fail to cache bootstrap credential: %r\n", > __FUNCTION__, Status)); > + DEBUG ((DEBUG_ERROR, "%a: fail to cache bootstrap credential: %r\n", > __func__, Status)); > } >=20 > return EFI_SUCCESS; > diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > index 51a85a73360d..0a0a4e645872 100644 > --- a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > +++ b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > @@ -1101,7 +1101,7 @@ RedfishIsValidOdataType ( > } > } >=20 > - DEBUG ((DEBUG_INFO, "%a: This Odata type is not in the list.\n", > __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: This Odata type is not in the list.\n", __fun= c__)); > return FALSE; > } >=20 > diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/serv= ice.c > b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c > index cbd4330a0ed0..206094d87d0f 100644 > --- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c > +++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c > @@ -521,7 +521,7 @@ getUriFromService ( > // > Status =3D DecodeResponseContent (ContentEncodedHeader->FieldValue= , > &ResponseMsg.Body, &ResponseMsg.BodyLength); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Failed to decompress the response cont= ent > %r\n.", __FUNCTION__, Status)); > + DEBUG ((DEBUG_ERROR, "%a: Failed to decompress the response cont= ent > %r\n.", __func__, Status)); > ret =3D NULL; > goto ON_EXIT; > } > @@ -656,7 +656,7 @@ patchUriFromService ( > // > Status =3D EncodeRequestContent ((CHAR8 *)HTTP_CONTENT_ENCODING_GZIP, > (CHAR8 *)content, (VOID **)&EncodedContent, &EncodedContentLen); > if (Status =3D=3D EFI_INVALID_PARAMETER) { > - DEBUG ((DEBUG_ERROR, "%a: Error to encode content.\n", __FUNCTION__)= ); > + DEBUG ((DEBUG_ERROR, "%a: Error to encode content.\n", __func__)); > ret =3D NULL; > goto ON_EXIT; > } else if (Status =3D=3D EFI_UNSUPPORTED) { > diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c > b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c > index 96aac125ee22..b51b558a487d 100644 > --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c > +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c > @@ -122,7 +122,7 @@ RedfishConfigCommonInit ( > // > Status =3D gBS->LocateProtocol (&gEdkIIRedfishCredentialProtocolGuid, = NULL, > (VOID **)&gCredential); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_INFO, "%a: No Redfish Credential Protocol is installed= on > system.", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: No Redfish Credential Protocol is installed= on > system.", __func__)); > return Status; > } >=20 > @@ -138,7 +138,7 @@ RedfishConfigCommonInit ( > &gEndOfDxeEvent > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Fail to register End Of DXE event.", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Fail to register End Of DXE event.", __fun= c__)); > return Status; > } >=20 > @@ -156,7 +156,7 @@ RedfishConfigCommonInit ( > if (EFI_ERROR (Status)) { > gBS->CloseEvent (gEndOfDxeEvent); > gEndOfDxeEvent =3D NULL; > - DEBUG ((DEBUG_ERROR, "%a: Fail to register Exit Boot Service event."= , > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Fail to register Exit Boot Service event."= , > __func__)); > return Status; > } >=20 > diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c > b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c > index 96ac70f418c8..993ad338b6eb 100644 > --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c > +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c > @@ -372,7 +372,7 @@ RedfishDiscoverProtocolInstalled ( > EFI_REDFISH_DISCOVER_NETWORK_INTERFACE *ThisNetworkInterface; > EFI_REDFISH_DISCOVERED_TOKEN *ThisRedfishDiscoveredToken; >=20 > - DEBUG ((DEBUG_INFO, "%a: New network interface is installed on system = by > EFI Redfish discover driver.\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: New network interface is installed on system = by > EFI Redfish discover driver.\n", __func__)); >=20 > BufferSize =3D sizeof (EFI_HANDLE); > Status =3D gBS->LocateHandle ( > @@ -383,7 +383,7 @@ RedfishDiscoverProtocolInstalled ( > &HandleBuffer > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Can't locate handle with > EFI_REDFISH_DISCOVER_PROTOCOL installed.\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Can't locate handle with > EFI_REDFISH_DISCOVER_PROTOCOL installed.\n", __func__)); > } >=20 > gRedfishDiscoverActivated =3D TRUE; > @@ -403,7 +403,7 @@ RedfishDiscoverProtocolInstalled ( > if (EFI_ERROR (Status)) { > gEfiRedfishDiscoverProtocol =3D NULL; > gRedfishDiscoverActivated =3D FALSE; > - DEBUG ((DEBUG_ERROR, "%a: Can't locate > EFI_REDFISH_DISCOVER_PROTOCOL.\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Can't locate > EFI_REDFISH_DISCOVER_PROTOCOL.\n", __func__)); > return; > } > } > @@ -422,13 +422,13 @@ RedfishDiscoverProtocolInstalled ( > &gNetworkInterfaceInstances > ); > if (EFI_ERROR (Status) || (gNumberOfNetworkInterfaces =3D=3D 0)) { > - DEBUG ((DEBUG_ERROR, "%a: No network interfaces found on the > handle.\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: No network interfaces found on the > handle.\n", __func__)); > return; > } >=20 > gRedfishDiscoveredToken =3D AllocateZeroPool (gNumberOfNetworkInterfac= es > * sizeof (EFI_REDFISH_DISCOVERED_TOKEN)); > if (gRedfishDiscoveredToken =3D=3D NULL) { > - DEBUG ((DEBUG_ERROR, "%a: Not enough memory for > EFI_REDFISH_DISCOVERED_TOKEN.\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Not enough memory for > EFI_REDFISH_DISCOVERED_TOKEN.\n", __func__)); > return; > } >=20 > @@ -449,7 +449,7 @@ RedfishDiscoverProtocolInstalled ( > &ThisRedfishDiscoveredToken->Event > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Failed to create event for Redfish disco= vered > token.\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Failed to create event for Redfish disco= vered > token.\n", __func__)); > goto ErrorReturn; > } >=20 > @@ -472,7 +472,7 @@ RedfishDiscoverProtocolInstalled ( > } >=20 > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Acquire Redfish service fail.\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Acquire Redfish service fail.\n", __func__= )); > goto ErrorReturn; > } >=20 > @@ -556,7 +556,7 @@ RedfishConfigHandlerDriverEntryPoint ( > &gEfiRedfishDiscoverProtocolEvent > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Fail to create event for the installation = of > EFI_REDFISH_DISCOVER_PROTOCOL.", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Fail to create event for the installation = of > EFI_REDFISH_DISCOVER_PROTOCOL.", __func__)); > return Status; > } >=20 > @@ -566,7 +566,7 @@ RedfishConfigHandlerDriverEntryPoint ( > &gEfiRedfishDiscoverRegistration > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Fail to register event for the installatio= n of > EFI_REDFISH_DISCOVER_PROTOCOL.", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Fail to register event for the installatio= n of > EFI_REDFISH_DISCOVER_PROTOCOL.", __func__)); > return Status; > } >=20 > @@ -593,7 +593,7 @@ RedfishConfigHandlerDriverEntryPoint ( > gExitBootServiceEvent =3D NULL; > gBS->CloseEvent (gEfiRedfishDiscoverProtocolEvent); > gEfiRedfishDiscoverProtocolEvent =3D NULL; > - DEBUG ((DEBUG_ERROR, "%a: Fail to install EFI Binding Protocol of EF= I > Redfish Config driver.", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Fail to install EFI Binding Protocol of EF= I > Redfish Config driver.", __func__)); > return Status; > } >=20 > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index f64c79088f63..583c6f78e19c 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -196,13 +196,13 @@ Tcp4GetSubnetInfo ( > Tcp4Option.EnableNagle =3D TRUE; > Status =3D Tcp4->Configure (Tcp4, &Tcp4CfgData); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Can't get subnet information\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Can't get subnet information\n", __func__)= ); > return Status; > } >=20 > Status =3D Tcp4->GetModeData (Tcp4, NULL, NULL, &IpModedata, NULL, NUL= L); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", > __func__)); > return Status; > } >=20 > @@ -265,12 +265,12 @@ Tcp6GetSubnetInfo ( > ZeroMem ((VOID *)&IpModedata, sizeof (EFI_IP6_MODE_DATA)); > Status =3D Tcp6->GetModeData (Tcp6, NULL, NULL, &IpModedata, NULL, NUL= L); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", > __func__)); > return Status; > } >=20 > if (IpModedata.AddressCount =3D=3D 0) { > - DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n", > __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n", __func__)); > Instance->SubnetAddrInfoIPv6Number =3D 0; > return EFI_SUCCESS; > } > @@ -282,7 +282,7 @@ Tcp6GetSubnetInfo ( >=20 > Instance->SubnetAddrInfoIPv6 =3D AllocateZeroPool (IpModedata.AddressC= ount > * sizeof (EFI_IP6_ADDRESS_INFO)); > if (Instance->SubnetAddrInfoIPv6 =3D=3D NULL) { > - DEBUG ((DEBUG_ERROR, "%a: Failed to allocate memory for IPv6 subnet > address information\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Failed to allocate memory for IPv6 subnet > address information\n", __func__)); > return EFI_OUT_OF_RESOURCES; > } >=20 > @@ -529,7 +529,7 @@ DiscoverRedfishHostInterface ( > IP4_COPY_ADDRESS ((VOID *)&Instance->HostSubnetMask.v4, (VOID > *)Data->HostIpMask); >=20 > if (EFI_IP4_EQUAL (&Instance->HostIpAddress.v4, &mZeroIp4Addr)) { > - DEBUG ((DEBUG_ERROR, "%a: invalid host IP address: zero address\= n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: invalid host IP address: zero address\= n", > __func__)); > // > // Invalid IP address detected. Change address format to Unknown= and use > system default address. > // > @@ -537,7 +537,7 @@ DiscoverRedfishHostInterface ( > } >=20 > if (!IP4_IS_VALID_NETMASK (EFI_IP4 (Instance->HostSubnetMask.v4)))= { > - DEBUG ((DEBUG_ERROR, "%a: invalid subnet mask address\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: invalid subnet mask address\n", __func= __)); > // > // Invalid subnet mast address detected. Change address format t= o > Unknown and use system default address. > // > @@ -551,14 +551,14 @@ DiscoverRedfishHostInterface ( > IP4_COPY_ADDRESS ((VOID *)&Instance->TargetIpAddress.v4, (VOID *)D= ata- > >RedfishServiceIpAddress); >=20 > if (EFI_IP4_EQUAL (&Instance->TargetIpAddress.v4, &mZeroIp4Addr)) = { > - DEBUG ((DEBUG_ERROR, "%a: invalid service IP address: zero addre= ss\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: invalid service IP address: zero addre= ss\n", > __func__)); > } > } else { > IP6_COPY_ADDRESS ((VOID *)&Instance->TargetIpAddress.v6, (VOID *)D= ata- > >RedfishServiceIpAddress); > } >=20 > if (Instance->HostIntfValidation) { > - DEBUG ((DEBUG_ERROR, "%a:Send UPnP unicast SSDP to validate this > Redfish Host Interface is not supported.\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a:Send UPnP unicast SSDP to validate this > Redfish Host Interface is not supported.\n", __func__)); > Status =3D EFI_UNSUPPORTED; > } else { > // > @@ -682,7 +682,7 @@ AddAndSignalNewRedfishService ( > RestExOpened =3D FALSE; > DeleteRestEx =3D FALSE; >=20 > - DEBUG ((DEBUG_INFO, "%a:Add this instance to Redfish instance list.\n"= , > __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a:Add this instance to Redfish instance list.\n"= , > __func__)); >=20 > if (Uuid !=3D NULL) { > Char16Uuid =3D (CHAR16 *)AllocateZeroPool (AsciiStrSize ((const CHAR= 8 *)Uuid) > * sizeof (CHAR16)); > @@ -846,7 +846,7 @@ AddAndSignalNewRedfishService ( > if (!InfoRefresh) { > Status =3D CreateRestExInstance (Instance, Instance->DiscoverToken= ); // > Create REST EX child. > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a:Can't create REST EX child instance.\n"= , > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a:Can't create REST EX child instance.\n"= , > __func__)); > goto ON_EXIT; > } >=20 > @@ -906,7 +906,7 @@ AddAndSignalNewRedfishService ( > (EFI_REST_EX_CONFIG_DATA)(UINT8 *)RestExHttpCon= figData > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a:REST EX configured..\n", __FUNCTION__))= ; > + DEBUG ((DEBUG_ERROR, "%a:REST EX configured..\n", __func__)); > DeleteRestEx =3D TRUE; > goto EXIT_FREE_ALL; > } > @@ -927,7 +927,7 @@ AddAndSignalNewRedfishService ( >=20 > Status =3D gBS->SignalEvent (Instance->DiscoverToken->Event); > if (!EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__)); > } > } >=20 > @@ -997,13 +997,13 @@ NetworkInterfaceGetSubnetInfo ( > Instance > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a:Failed to get Subnet infomation.\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a:Failed to get Subnet infomation.\n", > __func__)); > return Status; > } else { > - DEBUG ((DEBUG_INFO, "%a:MAC address: %s\n", __FUNCTION__, Instance= - > >StrMacAddr)); > + DEBUG ((DEBUG_INFO, "%a:MAC address: %s\n", __func__, Instance- > >StrMacAddr)); > if (CheckIsIpVersion6 (Instance)) { > if (Instance->SubnetAddrInfoIPv6Number =3D=3D 0) { > - DEBUG ((DEBUG_ERROR, "%a: There is no Subnet infomation for IP= v6 > network interface.\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: There is no Subnet infomation for IP= v6 > network interface.\n", __func__)); > return EFI_NOT_FOUND; > } >=20 > @@ -1184,13 +1184,13 @@ RedfishServiceAcquireService ( > UINTN NetworkInterfacesInde= x; > EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INTERNAL > *TargetNetworkInterfaceInternal; >=20 > - DEBUG ((DEBUG_INFO, "%a:Entry.\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a:Entry.\n", __func__)); >=20 > // > // Validate parameters. > // > if ((ImageHandle =3D=3D NULL) || (Token =3D=3D NULL) || ((Flags & > ~EFI_REDFISH_DISCOVER_VALIDATION) =3D=3D 0)) { > - DEBUG ((DEBUG_ERROR, "%a:Invalid parameters.\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a:Invalid parameters.\n", __func__)); > return EFI_INVALID_PARAMETER; > } >=20 > @@ -1208,7 +1208,7 @@ RedfishServiceAcquireService ( > TargetNetworkInterfaceInternal =3D > (EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INTERNAL *)GetFirstNode > (&mEfiRedfishDiscoverNetworkInterface); > NumNetworkInterfaces =3D NumberOfNetworkInterface (); > if (NumNetworkInterfaces =3D=3D 0) { > - DEBUG ((DEBUG_ERROR, "%a:No network interface on platform.\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a:No network interface on platform.\n", > __func__)); > return EFI_UNSUPPORTED; > } > } > @@ -1219,10 +1219,10 @@ RedfishServiceAcquireService ( > NewInstance =3D FALSE; > Instance =3D GetInstanceByOwner (ImageHandle, > TargetNetworkInterfaceInternal, Flags & > ~EFI_REDFISH_DISCOVER_VALIDATION); // Check if we can re-use previous > instance. > if (Instance =3D=3D NULL) { > - DEBUG ((DEBUG_INFO, "%a:Create new > EFI_REDFISH_DISCOVERED_INTERNAL_INSTANCE.\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a:Create new > EFI_REDFISH_DISCOVERED_INTERNAL_INSTANCE.\n", __func__)); > Instance =3D (EFI_REDFISH_DISCOVERED_INTERNAL_INSTANCE > *)AllocateZeroPool (sizeof (EFI_REDFISH_DISCOVERED_INTERNAL_INSTANCE)); > if (Instance =3D=3D NULL) { > - DEBUG ((DEBUG_ERROR, "%a:Memory allocation fail.\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a:Memory allocation fail.\n", __func__)); > } >=20 > InitializeListHead (&Instance->Entry); > @@ -1238,14 +1238,14 @@ RedfishServiceAcquireService ( > } >=20 > if (TargetNetworkInterfaceInternal->StrMacAddr !=3D NULL) { > - DEBUG ((DEBUG_INFO, "%a:Acquire Redfish service on network interfa= ce > MAC address:%s.\n", __FUNCTION__, TargetNetworkInterfaceInternal- > >StrMacAddr)); > + DEBUG ((DEBUG_INFO, "%a:Acquire Redfish service on network interfa= ce > MAC address:%s.\n", __func__, TargetNetworkInterfaceInternal->StrMacAddr)= ); > } else { > - DEBUG ((DEBUG_INFO, "%a:WARNING: No MAC address on this network > interface.\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a:WARNING: No MAC address on this network > interface.\n", __func__)); > } >=20 > Instance->DiscoverToken =3D Token; // Always use the latest Token pa= ssed by > caller. > if ((Flags & EFI_REDFISH_DISCOVER_HOST_INTERFACE) !=3D 0) { > - DEBUG ((DEBUG_INFO, "%a:Redfish HOST interface discovery.\n", > __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a:Redfish HOST interface discovery.\n", > __func__)); > Instance->HostIntfValidation =3D FALSE; > if ((Flags & EFI_REDFISH_DISCOVER_VALIDATION) !=3D 0) { > Instance->HostIntfValidation =3D TRUE; > @@ -1255,12 +1255,12 @@ RedfishServiceAcquireService ( > } >=20 > if ((Flags & EFI_REDFISH_DISCOVER_SSDP) !=3D 0) { > - DEBUG ((DEBUG_ERROR, "%a:Redfish service discovery through SSDP is= not > supported\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a:Redfish service discovery through SSDP is= not > supported\n", __func__)); > return EFI_UNSUPPORTED; > } else { > if (EFI_ERROR (Status1) && EFI_ERROR (Status2)) { > FreePool ((VOID *)Instance); > - DEBUG ((DEBUG_ERROR, "%a:Something wrong on Redfish service > discovery Status1=3D%x, Status2=3D%x.\n", __FUNCTION__, Status1, Status2)= ); > + DEBUG ((DEBUG_ERROR, "%a:Something wrong on Redfish service > discovery Status1=3D%x, Status2=3D%x.\n", __func__, Status1, Status2)); > } else { > if (NewInstance) { > InsertTailList (&mRedfishDiscoverList, &Instance->Entry); > @@ -1326,7 +1326,7 @@ RedfishServiceReleaseService ( > EFI_REDFISH_DISCOVERED_INTERNAL_LIST *DiscoveredRedfishInstance; >=20 > if (IsListEmpty (&mRedfishInstanceList)) { > - DEBUG ((DEBUG_ERROR, "%a:No any discovered Redfish service.\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a:No any discovered Redfish service.\n", > __func__)); > return EFI_NOT_FOUND; > } >=20 > @@ -1535,7 +1535,7 @@ TestForRequiredProtocols ( > ); > if (EFI_ERROR (Status)) { > if (Index =3D=3D ListCount - 1) { > - DEBUG ((DEBUG_ERROR, "%a: all required protocols are found on = this > controller handle: %p.\n", __FUNCTION__, ControllerHandle)); > + DEBUG ((DEBUG_ERROR, "%a: all required protocols are found on = this > controller handle: %p.\n", __func__, ControllerHandle)); > return EFI_SUCCESS; > } > } > @@ -1706,7 +1706,7 @@ BuildupNetworkInterface ( > if (!NewNetworkInterfaceInstalled) { > NetworkInterface =3D GetTargetNetworkInterfaceInternalByCont= roller > (ControllerHandle); > if (NetworkInterface =3D=3D NULL) { > - DEBUG ((DEBUG_ERROR, "%a: Can't find network interface by > ControllerHandle\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Can't find network interface by > ControllerHandle\n", __func__)); > return Status; > } > } > @@ -1720,10 +1720,10 @@ BuildupNetworkInterface ( > (V= OID *)&mRedfishDiscover > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Fail to install > EFI_REDFISH_DISCOVER_PROTOCOL\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Fail to install > EFI_REDFISH_DISCOVER_PROTOCOL\n", __func__)); > } > } else { > - DEBUG ((DEBUG_INFO, "%a: Not REST EX, continue with next\n", > __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Not REST EX, continue with next\n", > __func__)); > Index++; > if (Index =3D=3D (sizeof (gRequiredProtocol) / sizeof > (REDFISH_DISCOVER_REQUIRED_PROTOCOL))) { > break; > diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > index 872cf3ae0609..45fc6e2182bc 100644 > --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > @@ -59,11 +59,11 @@ RedfishCreateSmbiosTable42 ( > Status =3D RedfishPlatformHostInterfaceDeviceDescriptor (&DeviceType, > &DeviceDescriptor); > if (EFI_ERROR (Status)) { > if (Status =3D=3D EFI_NOT_FOUND) { > - DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is > provided on this platform.", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is > provided on this platform.", __func__)); > return EFI_NOT_FOUND; > } >=20 > - DEBUG ((DEBUG_ERROR, "%a: Fail to get device descriptor, %r.", > __FUNCTION__, Status)); > + DEBUG ((DEBUG_ERROR, "%a: Fail to get device descriptor, %r.", __fun= c__, > Status)); > return Status; > } >=20 > @@ -71,7 +71,7 @@ RedfishCreateSmbiosTable42 ( > (DeviceType !=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) > ) > { > - DEBUG ((DEBUG_ERROR, "%a: Only support either protocol type 04h or 0= 5h > as Redfish host interface.", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Only support either protocol type 04h or 0= 5h > as Redfish host interface.", __func__)); > return EFI_UNSUPPORTED; > } >=20 > @@ -98,7 +98,7 @@ RedfishCreateSmbiosTable42 ( > } >=20 > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Fail to get Redfish host interafce proto= col > type data.", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Fail to get Redfish host interafce proto= col > type data.", __func__)); > if (ProtocolRecords !=3D NULL) { > FreePool (ProtocolRecords); > } > @@ -124,7 +124,7 @@ RedfishCreateSmbiosTable42 ( > } else { > NewProtocolRecords =3D ReallocatePool (CurrentProtocolsDataLength, > NewProtocolsDataLength, (VOID *)ProtocolRecords); > if (NewProtocolRecords =3D=3D NULL) { > - DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for Redfish ho= st > interface protocol data.", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for Redfish ho= st > interface protocol data.", __func__)); > FreePool (ProtocolRecords); > FreePool (ProtocolRecord); > return EFI_OUT_OF_RESOURCES; > @@ -258,7 +258,7 @@ PlatformHostInterfaceInformationReady ( > IN VOID *Context > ) > { > - DEBUG ((DEBUG_INFO, "%a: Platform Redfish Host Interface informtion is > ready\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Platform Redfish Host Interface informtion is > ready\n", __func__)); >=20 > RedfishCreateSmbiosTable42 (); >=20 > @@ -290,7 +290,7 @@ RedfishHostInterfaceDxeEntryPoint ( > EFI_STATUS Status; > EFI_GUID *ReadyGuid; >=20 > - DEBUG ((DEBUG_INFO, "%a: Entry\n.", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: Entry\n.", __func__)); >=20 > // > // Check if the Redfish Host Interface depends on > diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c > b/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c > index 75b3f1fab8fc..41f2b29c83be 100644 > --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c > +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c > @@ -28,17 +28,17 @@ ResetHttpTslSession ( > { > EFI_STATUS Status; >=20 > - DEBUG ((DEBUG_INFO, "%a: TCP connection is finished. Could be TSL sess= ion > closure, reset HTTP instance for the new TLS session.\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a: TCP connection is finished. Could be TSL sess= ion > closure, reset HTTP instance for the new TLS session.\n", __func__)); >=20 > Status =3D Instance->HttpIo.Http->Configure (Instance->HttpIo.Http, NU= LL); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Error to reset HTTP instance.\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Error to reset HTTP instance.\n", __func__= )); > return Status; > } >=20 > Status =3D Instance->HttpIo.Http->Configure (Instance->HttpIo.Http, > &((EFI_REST_EX_HTTP_CONFIG_DATA *)Instance->ConfigData)- > >HttpConfigData); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Error to re-initiate HTTP instance.\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Error to re-initiate HTTP instance.\n", > __func__)); > } >=20 > return Status; > @@ -70,7 +70,7 @@ RedfishCheckHttpReceiveStatus ( > ReturnStatus =3D EFI_SUCCESS; > } else if (HttpIoReceiveStatus !=3D EFI_CONNECTION_FIN) { > if ((Instance->Flags & RESTEX_INSTANCE_FLAGS_TCP_ERROR_RETRY) =3D=3D= 0) { > - DEBUG ((DEBUG_ERROR, "%a: TCP error, reset HTTP session.\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: TCP error, reset HTTP session.\n", > __func__)); > Instance->Flags |=3D RESTEX_INSTANCE_FLAGS_TCP_ERROR_RETRY; > gBS->Stall (500); > Status =3D ResetHttpTslSession (Instance); > @@ -78,20 +78,20 @@ RedfishCheckHttpReceiveStatus ( > return EFI_NOT_READY; > } >=20 > - DEBUG ((DEBUG_ERROR, "%a: Reset HTTP instance fail.\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Reset HTTP instance fail.\n", __func__))= ; > } >=20 > ReturnStatus =3D EFI_DEVICE_ERROR; > } else { > if ((Instance->Flags & RESTEX_INSTANCE_FLAGS_TLS_RETRY) !=3D 0) { > - DEBUG ((DEBUG_ERROR, "%a: REST_EX Send and receive fail even with = a > new TLS session.\n", __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: REST_EX Send and receive fail even with = a > new TLS session.\n", __func__)); > ReturnStatus =3D EFI_DEVICE_ERROR; > } >=20 > Instance->Flags |=3D RESTEX_INSTANCE_FLAGS_TLS_RETRY; > Status =3D ResetHttpTslSession (Instance); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Reset HTTP instance fail.\n", > __FUNCTION__)); > + DEBUG ((DEBUG_ERROR, "%a: Reset HTTP instance fail.\n", __func__))= ; > ReturnStatus =3D EFI_DEVICE_ERROR; > } >=20 > -- > 2.34.1