From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.55]) by mx.groups.io with SMTP id smtpd.web11.176618.1672208908330780723 for ; Tue, 27 Dec 2022 22:28:28 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=hg9ELB1g; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.212.55, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZjABTteFSn2Ckf0Y/7W/hq1jtlNUWm8OSkvrtfpSczPxxko75MWRn/fECs5a57luFZL8CKvC4qNm4bFppLDpHBhBtich4GgNkq+Jl/l2A70TWtPWAofRrBEtytEj4FL3aIi+F4i5Vz5ntQBWWh/Ii0mu893aL0i9u10vXuu5yE3RhC0JmyBQkguj1+F9ALQMlUh3itEDwDoZKT5hcWKpHhQA6oyv3E75qaQApQseTbSg59fucngpp8NRg0UnyG/l09Jfl6m1mz+iMccXV382HCuQF2Hi6XedFOs+w0FECuTBtAsGqCurc2IV8/7vOeV97N2jlEwh0W2OH7U0bxr6jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rC0SE9bKMEd9DAPnuzWbeefQ1h//fQz7ce1tbvDMO7Y=; b=IH0aHoyxZLRGeETMkAo0sQnrzo6re1g7vR/yikd1+KtsA1VGU/Ie2XTM5VidX8XS+xQKw8esqFr8U9ffxiBkSU5uINkWqpW2xNuOGX/DkMdZKt4fmaNS8so0pERi3X7yOfHMk9H40+/8DzIlI67nVJ6xp5zMSkWX4U4ESe9Q5qrqmxJUiM4LRvVgUqx8QW8AYdl0sGhn0jHa2m6+ld3Kkd29PQ2/3D3nkgTMg2d7gDOHhRiK8vfSg/ir9lJw3un6cvvsij4+qgC823CFCoc96HStL3nONNmjIZVIUjQWhdJQCEQb0rgdkvn/t9VdXaYoIxhfEUpb8RNmjihC+MPHkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rC0SE9bKMEd9DAPnuzWbeefQ1h//fQz7ce1tbvDMO7Y=; b=hg9ELB1gwikDgC4BKTmKnYjqcPa5WDfKSiXwamCxKNzo8Of1bNVo+vrpHf2Iwd/gWctOEzeOeKG7KF5XXf1pkjWN/ohDbFULFgYIxk0STazEzZjxHQsNXqIbeQUBF0chgv+R9E6n2UJw56mSglVEyGP1M8ptVGjyzbIFWUX8aP39NEqLZ+FiYFeyWTPeH7cU4JagVXyW/i5qaiuVXd7EVy7RsLhbzx7EB2XHtRZggTZNXO4Q3MiwA3BP25n4EdkZzgSXaG/LP8fGGg2YOmWhuehUbrv47JZnzBRlutMOXEZcT30SJr45Eb4lvz88aZXTCwKzeiS0urYXg3k7kyB4rg== Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by MN0PR12MB5786.namprd12.prod.outlook.com (2603:10b6:208:375::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Wed, 28 Dec 2022 06:28:25 +0000 Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::6b34:f6ce:b778:4075]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::6b34:f6ce:b778:4075%7]) with mapi id 15.20.5944.016; Wed, 28 Dec 2022 06:28:25 +0000 From: "Nickle Wang" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Interface V2 update Thread-Topic: [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Interface V2 update Thread-Index: AQHZGntHFSBV17BAc0+2xT4/HAFgra6C1iCA Date: Wed, 28 Dec 2022 06:28:25 +0000 Message-ID: References: <20221228051336.1769-1-abner.chang@amd.com> <20221228051336.1769-4-abner.chang@amd.com> In-Reply-To: <20221228051336.1769-4-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|MN0PR12MB5786:EE_ x-ms-office365-filtering-correlation-id: dfb44d59-8844-4125-4309-08dae89cb9b0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OaYwsWHA+ikrRABaRqA51BTJK6tbbQ8dB38nIz2WzQaPW2IHJMceh37h1ycb4Ax4JFw8416t6qWXXY0oBUkRDlyvnux4kLBPR8OO0wSbxNedERQMZOIO0M6C+7WbcgH4crhJ75qoJC45/0ZDa6/okDwj262DKINWe/NDRUCnQUrbS/X5aDlOBpN4V+VqupjrzX9QFKBBvqEDfD9FHddyBnEViQGC2WGX/1Lqh576y+SqjqCWSKbx5Fne2EepmBEMPSxvJWGMrOo3vboQknaOarNuvLMD3PXALzKw/SVtYMjT5bRmL7q9dO6Q172QmmZ6Mds8jy2Ppj7bka+bFSNtjNtPtPPwDPn/ZUMglsV/YnIZGqxVZyc47PmEGWSwXfXz6STKMvpGbVQsmIFOybGck+JnDaRoNzkEHMUVeIr1CyLGZf/LM70WJxEDnoykeYr08T3cs8tq6R8Hqy9Q4AhK2539/9jn9EMkkvpo51AVSTjZRSz9sjqAzYGpKhPi1uDQY0OJk4jx8gp2ZOfrYrU6RRsoejEF152SUpilq1Ed6UIssRgKepMs2iOrHEe5ZJlU+Sb72aSqE73cjVOBg6CqmN3By4+GlCEHol3m2hfeYIhEhB3SufEZV/Kg+91ZLZghfSm+V0dXb37ylKEJHn10dpScxuJlbRZQ0GVR3EkUZwBe/V3cBL3Gk6ZzqDAVtvjinAbuMef2yb4lYbLibF95wQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR12MB7031.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(366004)(39860400002)(136003)(451199015)(76116006)(66556008)(66446008)(66946007)(66476007)(5660300002)(52536014)(8936002)(8676002)(64756008)(15650500001)(41300700001)(71200400001)(110136005)(478600001)(4326008)(33656002)(2906002)(316002)(6506007)(186003)(9686003)(7696005)(26005)(86362001)(55016003)(53546011)(83380400001)(38100700002)(122000001)(38070700005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G28LQiLhY//a6eGIjJXCX2gapOfGZZ8MwQHVzWDKLam3C25vi8BFuKJHF1oy?= =?us-ascii?Q?FDBOL5ZczxcW+76gx7jLV9YvZm8w77mZDgGW10temArBETCQ1lN0JLWT1fpy?= =?us-ascii?Q?N9r7n12oMVwJi8/oc4vNokL+QwwQADQZa1jERPQRpUOG+iJ5Qzri3REH6y/i?= =?us-ascii?Q?tePEBoBqufs01Zdyhg/pBjCtOla7YWUrSict8bqnJ/54q9KWzO8HejW/Q7o+?= =?us-ascii?Q?awKMd6FK6EL3LEj94rhYl4Mc5uqW+grkBMiy+W/nqKn8DXaSBvWKYqoEWy6q?= =?us-ascii?Q?4mlB8ifGZHFvqpsOWQUe2ltZABjtBfKBLkpBLMx40wXJigZjaoNu9PoW8mp0?= =?us-ascii?Q?p3r8063Bk5bDBs3vnKJQp2aQy6nXqFbj5LsYu963I6HaS89sN2vsqGtnGFdY?= =?us-ascii?Q?12264W6Nbc30kx8aCrl+m5ZgH4xVq+16Udo1iw88OKHO3uRMCp3zhdHgXLEN?= =?us-ascii?Q?+5wRhaKGgVRwiFPvZvCgg+VbfjALJ9rVBP4FIX/95tP64kGpIFt4mUJL8vzA?= =?us-ascii?Q?6tLZsggvml4Qbmb0oxeuaVchYKskVsgg9aoA9p2lljqTo+tcVe38MvLDA7Kc?= =?us-ascii?Q?7eNnINyWs79UGrcBoYzSsoCNrLh4qjSxuQJOtLHB0sINaFfuJgMKBjyZmuNt?= =?us-ascii?Q?06duprsgbHRFQkRpUvXZxNr3rSX+ka2ChPNhd3ntIyuiASGu+nWijOeF4Hio?= =?us-ascii?Q?jF2c17IzIByD8a6fc4Q36uPaAeYWXP2ddJGbo8Uf8GH1XBXa/uQ2uyXKFXQc?= =?us-ascii?Q?GRqcY9dZAZ9zMBtfsrfpPk59jrOclfDtHCZB5iIbL0KVBn9zv15XD/Ebd6ZV?= =?us-ascii?Q?eXWEqei9qqs2uSeKQeicHJhNuHoWaUs/uEWRDCoaKWieLbhpjQSi3+vvQCie?= =?us-ascii?Q?QMT5BZZwjfGjSSlo9g2a9yow01+X/8z8KQN6GZnfgGsgcZdjB4xVry0iDd8t?= =?us-ascii?Q?THcpB5fzRjpZPKV5N1nz3kcbTM44YU2wacbvwOQDfkAHnLnZZB7FserajXoa?= =?us-ascii?Q?C0wRHY+lcnNIrE80Jb9y1ieLkzxkZcVICQeVzdUF4JgeVrcdI6/kArbbNH/K?= =?us-ascii?Q?Fjs9U+cn2Qat7tRXxFEwAaq96izHsdMkrcQOVVAS42r1an5Wtt+Ngrf6IGcr?= =?us-ascii?Q?bRRkS3tJBW6DylcF8elnJ/hxzV4gRdBpsTBnO9de2GWu/OHkX4WJpxZ/X6DZ?= =?us-ascii?Q?VR7GGwg55twkPeZxcAc0pP7RVQ93dHKtnjLoWjDf/6+WVBfathhvtPkqG6z8?= =?us-ascii?Q?t0c9wEMTs/gnZ3LioENX8K/wQI1/jOd0WdzzQ5kOM0xAKJgwN+IHRmnrJftq?= =?us-ascii?Q?uSGhGaPPk/5DebbuaBy+ctjzD1o/vyn2cAgYOoyUSLdXW5BB8RIVwv50npIC?= =?us-ascii?Q?wRrTYSfIPh4DVQp2wccI+IQ370hy3LrprGGDYcfB/l35zCkOxFSOcwRdI60o?= =?us-ascii?Q?xHIqUFSDc9BAqpOGRGKzvkfxtTjMOecl5B6ElQ2wLCFx+DKrddUxeiktSWcJ?= =?us-ascii?Q?FOGe6TPsOeGNzG5KBglAXqCKx6fiMtEBDjeW3m9O8so0zMqw+jfC7ChzfWra?= =?us-ascii?Q?K1mnh1jR0NtxO2AgZtk=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfb44d59-8844-4125-4309-08dae89cb9b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2022 06:28:25.4068 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XGxWBb8+81Pu4trMulxBkEFaIAzfQD/PardX1MR2+ekTv6bMVqs+Mnh5hBRtimxEXvlVo4EfystxYmRhyLkmAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5786 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nickle Wang Regards, Nickle -----Original Message----- From: abner.chang@amd.com =20 Sent: Wednesday, December 28, 2022 1:14 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Interface V2 update External email: Use caution opening links or attachments From: Abner Chang Support USB_INTERFACE_DEVICE_DESCRIPTOR_V2 which is updated in Redfish Host= Interface spec v1.3. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../IndustryStandard/RedfishHostInterface.h | 25 ++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h b/R= edfishPkg/Include/IndustryStandard/RedfishHostInterface.h index 49b3ceee39c..022bd1f36ef 100644 --- a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h +++ b/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h @@ -3,6 +3,7 @@ Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (C) 2022 Advanced Micro Devices, Inc. All rights=20 + reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -29,6 +30,18 @@ #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP4 0x01 #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP6 0x02 +/// +/// Definitions for IP assignment tyeps. +/// +typedef enum { + RedfishHostIpAssignmentUnknown, + RedfishHostIpAssignmentStatic, + RedfishHostIpAssignmentDhcp, + RedfishHostIpAssignmentAutoConfigure, + RedfishHostIpAssignmentHostSelected, + RedfishHostIpAssignmentReserved +} REDFISH_HOST_IP_ASSIGNMENT; + #pragma pack(1) /// /// Structure definitions of Host Interface device type 04h (USB Network I= nterface V2) @@ -40,12 +53,18 @@ typedef struct { ///< idVendor field of the USB = descriptor. UINT16 IdProduct; ///< The Product ID of the devi= ce, as read from the ///< idProduct field of the USB= descriptor. - UINT8 SecialNumberStr; ///< The string number for the = Serial Number of the + UINT8 SerialNumberStr; ///< The string number for the = Serial Number of the ///< device. The string data is= read from the ///< iSerialNumber.bDescriptorT= ype field of the USB ///< descriptor, and is convert= ed from Unicode to ASCII ///< and is NULL terminated. UINT8 MacAddress[6]; ///< The MAC address of the PCI= /PCIe network device. + + /// + /// Below is defined in Redfish Host Interface spec v1.3 /// + UINT16 Characteristics; ///< Additional device characte= ristics. + UINT16 CredentialBootstrappingHandle; ///< Credential bootstrapping h= andle. } USB_INTERFACE_DEVICE_DESCRIPTOR_V2; // @@ -74,6 +93,10 @@ typedef struct { /// /// Define union for the Host Interface Device Descriptor /// +#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_3 0x11 ///< Leng= th USB interface device v2 defined in + ///< Redf= ish host interface spec v1.3 +#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_2 0x0d ///< Leng= th USB interface device v2 defined in + ///<=20 +Redfish host interface spec v1.2 typedef union { USB_INTERFACE_DEVICE_DESCRIPTOR_V2 UsbDeviceV2; ///< Devi= ce type USB V2 device discriptor. PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2 PciPcieDeviceV2; ///< Devi= ce type PCI/PCIe V2 device discriptor. -- 2.37.1.windows.1