From: "Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>
To: Mike Maslenkin <mike.maslenkin@gmail.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>, Nick Ramirez <nramirez@nvidia.com>
Subject: Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.
Date: Wed, 1 Nov 2023 00:52:38 +0000 [thread overview]
Message-ID: <MW4PR12MB703173CE46507A481B1FFA1DD9A7A@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAL77WPDQseVWLzzu89chFjUPfAdQmMq6Qp0WpAzTcC7uL3ngPA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 5025 bytes --]
> Ack.
> Looks good to me.
Thanks for your review, Mike! @Abner Chang<mailto:abner.chang@amd.com>, could you please provide reviewed-by to version 3 if this looks good to you?
Regards,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Tuesday, October 31, 2023 11:14 PM
> To: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>; Igor Kulchytskyy <igork@ami.com>;
> Nick Ramirez <nramirez@nvidia.com>
> Subject: Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple
> definitions.
>
> External email: Use caution opening links or attachments
>
>
> On Tue, Oct 31, 2023 at 3:56 PM Nickle Wang via groups.io
> <nicklew=nvidia.com@groups.io<mailto:nicklew=nvidia.com@groups.io>> wrote:
> >
> > There are two definitions for below functions in RedfishCrtLib.h.
> > Create this change to remote duplicated functions.
> > Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(),
> > strlen(), strchr(), strcasecmp(), strstr(), memcmp(), memset(),
> > memcpy(), memchr(), memcmp() and memmove().
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> > Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> > Cc: Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> > Cc: Nick Ramirez <nramirez@nvidia.com<mailto:nramirez@nvidia.com>>
> > Cc: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>
> > Reviewed-by: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> > ---
> > RedfishPkg/Include/Library/RedfishCrtLib.h | 105
> > ---------------------
> > 1 file changed, 105 deletions(-)
> >
> > diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h
> > b/RedfishPkg/Include/Library/RedfishCrtLib.h
> > index 23c6acfca33e..ac6c5162ad6a 100644
> > --- a/RedfishPkg/Include/Library/RedfishCrtLib.h
> > +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
> > @@ -172,20 +172,6 @@ free (
> > void *
> > );
> >
> > -void *
> > -memset (
> > - void *,
> > - int,
> > - size_t
> > - );
> > -
> > -int
> > -memcmp (
> > - const void *,
> > - const void *,
> > - size_t
> > - );
> > -
> > int
> > isdigit (
> > int
> > @@ -216,47 +202,6 @@ isalnum (
> > int
> > );
> >
> > -void *
> > -memcpy (
> > - void *,
> > - const void *,
> > - size_t
> > - );
> > -
> > -void *
> > -memset (
> > - void *,
> > - int,
> > - size_t
> > - );
> > -
> > -void *
> > -memchr (
> > - const void *,
> > - int,
> > - size_t
> > - );
> > -
> > -int
> > -memcmp (
> > - const void *,
> > - const void *,
> > - size_t
> > - );
> > -
> > -void *
> > -memmove (
> > - void *,
> > - const void *,
> > - size_t
> > - );
> > -
> > -int
> > -strcmp (
> > - const char *,
> > - const char *
> > - );
> > -
> > int
> > strncmp (
> > const char *,
> > @@ -264,35 +209,6 @@ strncmp (
> > size_t
> > );
> >
> > -char *
> > -strcpy (
> > - char *,
> > - const char *
> > - );
> > -
> > -size_t
> > -strlen (
> > - const char *
> > - );
> > -
> > -char *
> > -strcat (
> > - char *,
> > - const char *
> > - );
> > -
> > -char *
> > -strchr (
> > - const char *,
> > - int
> > - );
> > -
> > -int
> > -strcasecmp (
> > - const char *,
> > - const char *
> > - );
> > -
> > int
> > strncasecmp (
> > const char *,
> > @@ -300,21 +216,6 @@ strncasecmp (
> > size_t
> > );
> >
> > -char *
> > -strncpy (
> > - char *,
> > - size_t,
> > - const char *,
> > - size_t
> > - );
> > -
> > -int
> > -strncmp (
> > - const char *,
> > - const char *,
> > - size_t
> > - );
> > -
> > char *
> > strrchr (
> > const char *,
> > @@ -328,12 +229,6 @@ strtoul (
> > int
> > );
> >
> > -char *
> > -strstr (
> > - const char *s1,
> > - const char *s2
> > - );
> > -
> > long
> > strtol (
> > const char *,
> > --
> > 2.17.1
>
> Ack.
> Looks good to me.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110457): https://edk2.groups.io/g/devel/message/110457
Mute This Topic: https://groups.io/mt/102296237/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 15358 bytes --]
next prev parent reply other threads:[~2023-11-01 0:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 12:56 [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions Nickle Wang via groups.io
2023-10-31 15:13 ` Mike Maslenkin
2023-11-01 0:52 ` Nickle Wang via groups.io [this message]
2023-11-01 2:04 ` Chang, Abner via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR12MB703173CE46507A481B1FFA1DD9A7A@MW4PR12MB7031.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox