* [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.
@ 2023-10-31 12:56 Nickle Wang via groups.io
2023-10-31 15:13 ` Mike Maslenkin
0 siblings, 1 reply; 4+ messages in thread
From: Nickle Wang via groups.io @ 2023-10-31 12:56 UTC (permalink / raw)
To: devel; +Cc: Abner Chang, Igor Kulchytskyy, Nick Ramirez, Mike Maslenkin
There are two definitions for below functions in RedfishCrtLib.h. Create
this change to remote duplicated functions.
Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(),
strlen(), strchr(), strcasecmp(), strstr(), memcmp(), memset(),
memcpy(), memchr(), memcmp() and memmove().
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
---
RedfishPkg/Include/Library/RedfishCrtLib.h | 105 ---------------------
1 file changed, 105 deletions(-)
diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h b/RedfishPkg/Include/Library/RedfishCrtLib.h
index 23c6acfca33e..ac6c5162ad6a 100644
--- a/RedfishPkg/Include/Library/RedfishCrtLib.h
+++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
@@ -172,20 +172,6 @@ free (
void *
);
-void *
-memset (
- void *,
- int,
- size_t
- );
-
-int
-memcmp (
- const void *,
- const void *,
- size_t
- );
-
int
isdigit (
int
@@ -216,47 +202,6 @@ isalnum (
int
);
-void *
-memcpy (
- void *,
- const void *,
- size_t
- );
-
-void *
-memset (
- void *,
- int,
- size_t
- );
-
-void *
-memchr (
- const void *,
- int,
- size_t
- );
-
-int
-memcmp (
- const void *,
- const void *,
- size_t
- );
-
-void *
-memmove (
- void *,
- const void *,
- size_t
- );
-
-int
-strcmp (
- const char *,
- const char *
- );
-
int
strncmp (
const char *,
@@ -264,35 +209,6 @@ strncmp (
size_t
);
-char *
-strcpy (
- char *,
- const char *
- );
-
-size_t
-strlen (
- const char *
- );
-
-char *
-strcat (
- char *,
- const char *
- );
-
-char *
-strchr (
- const char *,
- int
- );
-
-int
-strcasecmp (
- const char *,
- const char *
- );
-
int
strncasecmp (
const char *,
@@ -300,21 +216,6 @@ strncasecmp (
size_t
);
-char *
-strncpy (
- char *,
- size_t,
- const char *,
- size_t
- );
-
-int
-strncmp (
- const char *,
- const char *,
- size_t
- );
-
char *
strrchr (
const char *,
@@ -328,12 +229,6 @@ strtoul (
int
);
-char *
-strstr (
- const char *s1,
- const char *s2
- );
-
long
strtol (
const char *,
--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110408): https://edk2.groups.io/g/devel/message/110408
Mute This Topic: https://groups.io/mt/102296237/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.
2023-10-31 12:56 [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions Nickle Wang via groups.io
@ 2023-10-31 15:13 ` Mike Maslenkin
2023-11-01 0:52 ` Nickle Wang via groups.io
0 siblings, 1 reply; 4+ messages in thread
From: Mike Maslenkin @ 2023-10-31 15:13 UTC (permalink / raw)
To: devel, nicklew; +Cc: Abner Chang, Igor Kulchytskyy, Nick Ramirez
On Tue, Oct 31, 2023 at 3:56 PM Nickle Wang via groups.io
<nicklew=nvidia.com@groups.io> wrote:
>
> There are two definitions for below functions in RedfishCrtLib.h. Create
> this change to remote duplicated functions.
> Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(),
> strlen(), strchr(), strcasecmp(), strstr(), memcmp(), memset(),
> memcpy(), memchr(), memcmp() and memmove().
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
> Reviewed-by: Abner Chang <abner.chang@amd.com>
> ---
> RedfishPkg/Include/Library/RedfishCrtLib.h | 105 ---------------------
> 1 file changed, 105 deletions(-)
>
> diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h b/RedfishPkg/Include/Library/RedfishCrtLib.h
> index 23c6acfca33e..ac6c5162ad6a 100644
> --- a/RedfishPkg/Include/Library/RedfishCrtLib.h
> +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
> @@ -172,20 +172,6 @@ free (
> void *
> );
>
> -void *
> -memset (
> - void *,
> - int,
> - size_t
> - );
> -
> -int
> -memcmp (
> - const void *,
> - const void *,
> - size_t
> - );
> -
> int
> isdigit (
> int
> @@ -216,47 +202,6 @@ isalnum (
> int
> );
>
> -void *
> -memcpy (
> - void *,
> - const void *,
> - size_t
> - );
> -
> -void *
> -memset (
> - void *,
> - int,
> - size_t
> - );
> -
> -void *
> -memchr (
> - const void *,
> - int,
> - size_t
> - );
> -
> -int
> -memcmp (
> - const void *,
> - const void *,
> - size_t
> - );
> -
> -void *
> -memmove (
> - void *,
> - const void *,
> - size_t
> - );
> -
> -int
> -strcmp (
> - const char *,
> - const char *
> - );
> -
> int
> strncmp (
> const char *,
> @@ -264,35 +209,6 @@ strncmp (
> size_t
> );
>
> -char *
> -strcpy (
> - char *,
> - const char *
> - );
> -
> -size_t
> -strlen (
> - const char *
> - );
> -
> -char *
> -strcat (
> - char *,
> - const char *
> - );
> -
> -char *
> -strchr (
> - const char *,
> - int
> - );
> -
> -int
> -strcasecmp (
> - const char *,
> - const char *
> - );
> -
> int
> strncasecmp (
> const char *,
> @@ -300,21 +216,6 @@ strncasecmp (
> size_t
> );
>
> -char *
> -strncpy (
> - char *,
> - size_t,
> - const char *,
> - size_t
> - );
> -
> -int
> -strncmp (
> - const char *,
> - const char *,
> - size_t
> - );
> -
> char *
> strrchr (
> const char *,
> @@ -328,12 +229,6 @@ strtoul (
> int
> );
>
> -char *
> -strstr (
> - const char *s1,
> - const char *s2
> - );
> -
> long
> strtol (
> const char *,
> --
> 2.17.1
Ack.
Looks good to me.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110419): https://edk2.groups.io/g/devel/message/110419
Mute This Topic: https://groups.io/mt/102296237/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.
2023-10-31 15:13 ` Mike Maslenkin
@ 2023-11-01 0:52 ` Nickle Wang via groups.io
2023-11-01 2:04 ` Chang, Abner via groups.io
0 siblings, 1 reply; 4+ messages in thread
From: Nickle Wang via groups.io @ 2023-11-01 0:52 UTC (permalink / raw)
To: Mike Maslenkin, devel@edk2.groups.io, Abner Chang
Cc: Igor Kulchytskyy, Nick Ramirez
[-- Attachment #1: Type: text/plain, Size: 5025 bytes --]
> Ack.
> Looks good to me.
Thanks for your review, Mike! @Abner Chang<mailto:abner.chang@amd.com>, could you please provide reviewed-by to version 3 if this looks good to you?
Regards,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Tuesday, October 31, 2023 11:14 PM
> To: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>; Igor Kulchytskyy <igork@ami.com>;
> Nick Ramirez <nramirez@nvidia.com>
> Subject: Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple
> definitions.
>
> External email: Use caution opening links or attachments
>
>
> On Tue, Oct 31, 2023 at 3:56 PM Nickle Wang via groups.io
> <nicklew=nvidia.com@groups.io<mailto:nicklew=nvidia.com@groups.io>> wrote:
> >
> > There are two definitions for below functions in RedfishCrtLib.h.
> > Create this change to remote duplicated functions.
> > Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(),
> > strlen(), strchr(), strcasecmp(), strstr(), memcmp(), memset(),
> > memcpy(), memchr(), memcmp() and memmove().
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> > Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> > Cc: Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> > Cc: Nick Ramirez <nramirez@nvidia.com<mailto:nramirez@nvidia.com>>
> > Cc: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>
> > Reviewed-by: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> > ---
> > RedfishPkg/Include/Library/RedfishCrtLib.h | 105
> > ---------------------
> > 1 file changed, 105 deletions(-)
> >
> > diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h
> > b/RedfishPkg/Include/Library/RedfishCrtLib.h
> > index 23c6acfca33e..ac6c5162ad6a 100644
> > --- a/RedfishPkg/Include/Library/RedfishCrtLib.h
> > +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
> > @@ -172,20 +172,6 @@ free (
> > void *
> > );
> >
> > -void *
> > -memset (
> > - void *,
> > - int,
> > - size_t
> > - );
> > -
> > -int
> > -memcmp (
> > - const void *,
> > - const void *,
> > - size_t
> > - );
> > -
> > int
> > isdigit (
> > int
> > @@ -216,47 +202,6 @@ isalnum (
> > int
> > );
> >
> > -void *
> > -memcpy (
> > - void *,
> > - const void *,
> > - size_t
> > - );
> > -
> > -void *
> > -memset (
> > - void *,
> > - int,
> > - size_t
> > - );
> > -
> > -void *
> > -memchr (
> > - const void *,
> > - int,
> > - size_t
> > - );
> > -
> > -int
> > -memcmp (
> > - const void *,
> > - const void *,
> > - size_t
> > - );
> > -
> > -void *
> > -memmove (
> > - void *,
> > - const void *,
> > - size_t
> > - );
> > -
> > -int
> > -strcmp (
> > - const char *,
> > - const char *
> > - );
> > -
> > int
> > strncmp (
> > const char *,
> > @@ -264,35 +209,6 @@ strncmp (
> > size_t
> > );
> >
> > -char *
> > -strcpy (
> > - char *,
> > - const char *
> > - );
> > -
> > -size_t
> > -strlen (
> > - const char *
> > - );
> > -
> > -char *
> > -strcat (
> > - char *,
> > - const char *
> > - );
> > -
> > -char *
> > -strchr (
> > - const char *,
> > - int
> > - );
> > -
> > -int
> > -strcasecmp (
> > - const char *,
> > - const char *
> > - );
> > -
> > int
> > strncasecmp (
> > const char *,
> > @@ -300,21 +216,6 @@ strncasecmp (
> > size_t
> > );
> >
> > -char *
> > -strncpy (
> > - char *,
> > - size_t,
> > - const char *,
> > - size_t
> > - );
> > -
> > -int
> > -strncmp (
> > - const char *,
> > - const char *,
> > - size_t
> > - );
> > -
> > char *
> > strrchr (
> > const char *,
> > @@ -328,12 +229,6 @@ strtoul (
> > int
> > );
> >
> > -char *
> > -strstr (
> > - const char *s1,
> > - const char *s2
> > - );
> > -
> > long
> > strtol (
> > const char *,
> > --
> > 2.17.1
>
> Ack.
> Looks good to me.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110457): https://edk2.groups.io/g/devel/message/110457
Mute This Topic: https://groups.io/mt/102296237/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 15358 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.
2023-11-01 0:52 ` Nickle Wang via groups.io
@ 2023-11-01 2:04 ` Chang, Abner via groups.io
0 siblings, 0 replies; 4+ messages in thread
From: Chang, Abner via groups.io @ 2023-11-01 2:04 UTC (permalink / raw)
To: Nickle Wang, Mike Maslenkin, devel@edk2.groups.io
Cc: Igor Kulchytskyy, Nick Ramirez
[-- Attachment #1: Type: text/plain, Size: 5836 bytes --]
[AMD Official Use Only - General]
Sure, thanks for this change.
Reviewed-by: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
From: Nickle Wang <nicklew@nvidia.com>
Sent: Wednesday, November 1, 2023 8:53 AM
To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
Subject: RE: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> Ack.
> Looks good to me.
Thanks for your review, Mike! @Abner Chang<mailto:abner.chang@amd.com>, could you please provide reviewed-by to version 3 if this looks good to you?
Regards,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>
> Sent: Tuesday, October 31, 2023 11:14 PM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>; Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>;
> Nick Ramirez <nramirez@nvidia.com<mailto:nramirez@nvidia.com>>
> Subject: Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple
> definitions.
>
> External email: Use caution opening links or attachments
>
>
> On Tue, Oct 31, 2023 at 3:56 PM Nickle Wang via groups.io
> <nicklew=nvidia.com@groups.io<mailto:nicklew=nvidia.com@groups.io>> wrote:
> >
> > There are two definitions for below functions in RedfishCrtLib.h.
> > Create this change to remote duplicated functions.
> > Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(),
> > strlen(), strchr(), strcasecmp(), strstr(), memcmp(), memset(),
> > memcpy(), memchr(), memcmp() and memmove().
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> > Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> > Cc: Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> > Cc: Nick Ramirez <nramirez@nvidia.com<mailto:nramirez@nvidia.com>>
> > Cc: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>
> > Reviewed-by: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> > ---
> > RedfishPkg/Include/Library/RedfishCrtLib.h | 105
> > ---------------------
> > 1 file changed, 105 deletions(-)
> >
> > diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h
> > b/RedfishPkg/Include/Library/RedfishCrtLib.h
> > index 23c6acfca33e..ac6c5162ad6a 100644
> > --- a/RedfishPkg/Include/Library/RedfishCrtLib.h
> > +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
> > @@ -172,20 +172,6 @@ free (
> > void *
> > );
> >
> > -void *
> > -memset (
> > - void *,
> > - int,
> > - size_t
> > - );
> > -
> > -int
> > -memcmp (
> > - const void *,
> > - const void *,
> > - size_t
> > - );
> > -
> > int
> > isdigit (
> > int
> > @@ -216,47 +202,6 @@ isalnum (
> > int
> > );
> >
> > -void *
> > -memcpy (
> > - void *,
> > - const void *,
> > - size_t
> > - );
> > -
> > -void *
> > -memset (
> > - void *,
> > - int,
> > - size_t
> > - );
> > -
> > -void *
> > -memchr (
> > - const void *,
> > - int,
> > - size_t
> > - );
> > -
> > -int
> > -memcmp (
> > - const void *,
> > - const void *,
> > - size_t
> > - );
> > -
> > -void *
> > -memmove (
> > - void *,
> > - const void *,
> > - size_t
> > - );
> > -
> > -int
> > -strcmp (
> > - const char *,
> > - const char *
> > - );
> > -
> > int
> > strncmp (
> > const char *,
> > @@ -264,35 +209,6 @@ strncmp (
> > size_t
> > );
> >
> > -char *
> > -strcpy (
> > - char *,
> > - const char *
> > - );
> > -
> > -size_t
> > -strlen (
> > - const char *
> > - );
> > -
> > -char *
> > -strcat (
> > - char *,
> > - const char *
> > - );
> > -
> > -char *
> > -strchr (
> > - const char *,
> > - int
> > - );
> > -
> > -int
> > -strcasecmp (
> > - const char *,
> > - const char *
> > - );
> > -
> > int
> > strncasecmp (
> > const char *,
> > @@ -300,21 +216,6 @@ strncasecmp (
> > size_t
> > );
> >
> > -char *
> > -strncpy (
> > - char *,
> > - size_t,
> > - const char *,
> > - size_t
> > - );
> > -
> > -int
> > -strncmp (
> > - const char *,
> > - const char *,
> > - size_t
> > - );
> > -
> > char *
> > strrchr (
> > const char *,
> > @@ -328,12 +229,6 @@ strtoul (
> > int
> > );
> >
> > -char *
> > -strstr (
> > - const char *s1,
> > - const char *s2
> > - );
> > -
> > long
> > strtol (
> > const char *,
> > --
> > 2.17.1
>
> Ack.
> Looks good to me.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110461): https://edk2.groups.io/g/devel/message/110461
Mute This Topic: https://groups.io/mt/102296237/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 20187 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-01 2:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-31 12:56 [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions Nickle Wang via groups.io
2023-10-31 15:13 ` Mike Maslenkin
2023-11-01 0:52 ` Nickle Wang via groups.io
2023-11-01 2:04 ` Chang, Abner via groups.io
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox