From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0950C940E78 for ; Wed, 30 Aug 2023 01:49:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nRNesQ5AILPw4UMPx7iu4Zpe2I5k+xd+igeYuikn25Y=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693360196; v=1; b=dUc1pJ5TGJavUuQuaaVkg1nCFVTKnf84IMFGUHOwF7Jdohlqjh/DFRh3go0z3Z0NC0Dkd69k Kwe5eF6kbwci1AUOb7Hr4M9C2AKnXiFz8GKEf2BAwDMJLIWvuJCdM9WM3B+ZGTcptnm88nUIoVg v7AwJwm1C/VPFjQ+nVuaIpBE= X-Received: by 127.0.0.2 with SMTP id UghLYY7687511xLG2basp7Zc; Tue, 29 Aug 2023 18:49:56 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.67]) by mx.groups.io with SMTP id smtpd.web11.4772.1693360196036041794 for ; Tue, 29 Aug 2023 18:49:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i9gxPOWrzVQybxop2EzXrQy81ttVIFSzSiXrtfQHEBamJY2hhgIXOZR34z5kAl9gaf1x7+nPszOaB8pbjPYXqWtJ6jN1V8ph0gIN4jq+XtPhC8vEbZxlVv64y6EZFvRpS1J4uedvzGqPpgiC3VbRwpqDqZdzZUV+EkO8zLj2REtEkcHTZVvABXbhrih715wWoKIH7bkJn7OdFCyjX+aMdsPWqMX4YEQm38zns00JoL6bKSzRE1qmEyMF4jHybtYNIkY6bYJOatyTsgi6d3R0KuspefUXGH8lJaCEdi5FJs49TqtyBwkOAbw4+zkkAx98iCEhlouIrVUKKIakxiS3Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MAXGeoo+yEYrrXs5QRH1nK3sfqJ6cLNJ6UGOa3Y4XSQ=; b=CU9/Va9RFsRGuyuM9ZkIurvUpbhx2DZtHDI4I101rr169WJE2XrqZx8+z3w2PSvTekBZP8m5mJFWoTK6heTBphgzCK8HxvBMOKedkDMSZTA5iGQDuxhZerg84yhAZFxnGQTwj4UyuYescWebXh/6Vs65yG7MXW3g384hhPksWvLyZc+xDsnDtS0QTllT5usi+qlxYY/zwUZSDumGZXqPelGpoXTZ2dCXm8ECKZdmkseVS4hgG2deE8Q1kSctPm1IwpBtFtaHEbLVGbQoaj2BYNdKcf5hYc9PiQ6Tx9ybjjYlx+W/tuoTDEpYtgzel5opfaKU78pSJV6cf4WlE2LiLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by PH7PR12MB8426.namprd12.prod.outlook.com (2603:10b6:510:241::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.35; Wed, 30 Aug 2023 01:49:53 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::1390:de0a:6b46:9837]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::1390:de0a:6b46:9837%7]) with mapi id 15.20.6699.035; Wed, 30 Aug 2023 01:49:53 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "abner.chang@amd.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 4/6] RedfishClientPkg: fix memory leak during EFI variables write. Thread-Topic: [PATCH v2 4/6] RedfishClientPkg: fix memory leak during EFI variables write. Thread-Index: AQHZ2k8ByCRDzAG3CEuGGRiw7YSfSbACE9nQ Date: Wed, 30 Aug 2023 01:49:53 +0000 Message-ID: References: <20230829080112.12748-1-mike.maslenkin@gmail.com> <20230829080112.12748-5-mike.maslenkin@gmail.com> In-Reply-To: <20230829080112.12748-5-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|PH7PR12MB8426:EE_ x-ms-office365-filtering-correlation-id: d0e321b8-5976-4a8b-5b2e-08dba8fb67d3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: WsfosjZGfDzenyR/C/CKhr2L6tk7RgMXuNQhq4i9NXzX9k9/VrVtQ9eJ62iWjc2p2p3c1e7Ukh5RjchXrNuPBc/1nsqfxLgMWqrxi02cJQHi/dC2jqy8odXR1XTCkJ4DTFpJPRtYzaRLdlyZ03aGVtaH/QGPx4cXq3dwAp/MnwwpYQii0EHUwxCu3hcR0rHvjgIjAbEVgqabnKN9MHaufeRapwvc4Lnsr7PaHVIJLz9wfokbsT3RGezr+THuYnuXws9q4xaPAtwFwOHEvypPcgJmSyvhdjvHCRxojLNTPtEaaU4LZKDpgY/vcucoaopAxxVA7veWIiyKM28L/FnOthu9v85XERVHWJc3Y7zJPE3jDRqbssN477aG7OI/xiipl+aT1kuKM75vnq96GUrQjv8pVvqlUkS1dQFtFG6nD9wNCXCFMOzHVCtH9wLpjFDgtGdaKkBek7TBKQtzJcXjWiJvSwPg9udb7TkceTWqqUSw2udjuJ7MhlBL5HRxvgE7dN5VI91ns64xNCVkhAi4fe4WCLT+F85NToLt2jXcG6CZvL0+9mQ79NoY879Vo6EUDppEKBw58Tk5QjKOnqf4C0dtvf72SQAZfx12qokHpH3pMZqzkGnE0bOiuFzDQdyg x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IdG6jA95FgJ7h3BBO2LITTCV2EPuAY6xjz2TZnGBu0IXu8f/4Wp4kZaU3GrD?= =?us-ascii?Q?nTIgPXd2Py+tQv1M0VNR/uQZnBoTz6zijcks3dPAi89Cf4mvKn8v0/xhUkUd?= =?us-ascii?Q?uVZCGPMHj0OaJG5fa58KkRWBybMcHAwjYrAyL4ZuOtLk6dg8DxhMzOL00vo8?= =?us-ascii?Q?Y2MFNRCFRB2dMLTQ6kXt0HF7R6kz22xoPAWlkAZn4s2fcIYl79YVWWz8w5b5?= =?us-ascii?Q?uFZYE0j0y2wN+Z8umkv38bJvk6m4UCSo/hqaWXttD4X2Ip/d9+x7LCCftRSm?= =?us-ascii?Q?VEcfcEira1XFVZfrLi89+qYkQdEOv2SesFj/RrDfVbwgiFWtD4905wEKKGoc?= =?us-ascii?Q?7oCn83bRctwU5pQtn/HpjWtV1ZJG0tVSvT3EnUpVEfB/HMJ9Hz2/wwNEyNwe?= =?us-ascii?Q?K52jDpXeDstHKUtpA5i+6z8byJ9tKGgbXwE0gsodxHW+oXqytaQAmQtSNZb3?= =?us-ascii?Q?GYkJS/Pjcq4EJ1wNYlXYmA0nDNcYiBTTbETCzgAuJUl24fg8Qm+usoZdZ7ZM?= =?us-ascii?Q?yAIry4SVeGPybzEikfnFSMQVQwzLeozH4KwVDz+3qp7hcX8XoEgNVjedR/vq?= =?us-ascii?Q?S4wwrYyAWmwhA+KCLwAt4PzuxEFnEC6F49JTEOeyuoxmmRSUZYWYbVBx3G+U?= =?us-ascii?Q?J2eaa4QoDoqVuYAaGcJWCWf6Jfa1C2eU8m4GvqQ2thl7BovYp3BmvOee0Dnn?= =?us-ascii?Q?DyMhqJ8IsQeApp7/a6HVGuDN0RoddS8XCJCaEO8BHwB0BXDjtrzkBXDoyGNm?= =?us-ascii?Q?18N3A7NTkIfxOCWOWeAdM0RuY7GgGcuqfJuky9Iviwg6GWYkGrRFUHjIWuEb?= =?us-ascii?Q?pApYDR19KqRHd+uZJxPn0Nt7FU7PUj8cYNKFJDjdCOtCTqufrQ3JkLe6XjJo?= =?us-ascii?Q?evroaFp5H75gLyjju12qqqv3RvSWNLSVj90NZ4aJeWoybsmJrDijywCnlynA?= =?us-ascii?Q?xSIbliBAu9UcCwSpE2kowMfSPvWl9iG+zfMzZy7aAoIdSgTdqP6ssJXXC1Gd?= =?us-ascii?Q?i9alIpzk2sXkZZhA1m8VsEJ1R5GsAIuGBXNN+sbgVjCDmBw7cN1ZAnjUdeJ4?= =?us-ascii?Q?oMr/mDXOPkG1R0KrudCtaPwK0axfxXC3L06TVXotBcVhRdSO2ooZDNMM3t5n?= =?us-ascii?Q?45l+j+k0jRlwmNSPQz/4+WpS/QeUZbctWvcBmT3dZRk/qLBcUDBY8WFXO9Rx?= =?us-ascii?Q?yBgfMc1pQG1zck69MrBSqky+esIDziEtJf6JinmZ6UQkMf19l2sBbnQFacVK?= =?us-ascii?Q?eiy8rS4KPDtzQcaYBsBAqcn0zijE3h0cTEPExJvrlGhl7TvaZoV14mYUDXjO?= =?us-ascii?Q?jdZ7YcKLYmvDiBGdVac2pmWKv85HVP8Ej5k6x/z77+CdHX+wxUolBGKCOT2p?= =?us-ascii?Q?CdYL4KkKcG8TFV/ByUj0bBo3iUQ3x9sEhI9RoVE+uoB68rFBjJEK8GgoUixe?= =?us-ascii?Q?KL7jqlIWU718w10VOeOgoioOtdBlNPfy1Fq2MMO/4OHMpd7MfrTCwWRJgwKj?= =?us-ascii?Q?YO9AKHG6pvefJF73J4LChVAJCEZlBIzkaIY/u16N9IGq2EMEmFyTxuP0QVK+?= =?us-ascii?Q?8AjqACSE3tcUTXxzj7Y=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0e321b8-5976-4a8b-5b2e-08dba8fb67d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2023 01:49:53.4612 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3OlLamk0HmqmNob84GiDB6b3OuB96I/V2H+YSRRNyjnoZcKLaN4AWn1+aGbmnWHv2/LZCq4e2JccgScQWQd3TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8426 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: m7Vz2KaDBqQtuQePFY56pGEhx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=dUc1pJ5T; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.chang@amd.com; Nickle Wang ; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v2 4/6] RedfishClientPkg: fix memory leak during EFI vari= ables > write. >=20 > External email: Use caution opening links or attachments >=20 >=20 > Signed-off-by: Mike Maslenkin > --- > .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c | 6 +++++- > RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 6 +++++- > 2 files changed, 10 insertions(+), 2 deletions(-) >=20 > diff --git > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > index 86684cc72e1e..6a72afed8715 100644 > --- a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > +++ b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > @@ -424,7 +424,11 @@ SaveConfigLangMapList ( > gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid, > VARIABLE_ATTRIBUTE_NV_BS, 0, NULL); >=20 > } >=20 >=20 >=20 > - return gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid, > VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); >=20 > + Status =3D gRT->SetVariable (VariableName, &gEfiRedfishClientVariableG= uid, > VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); >=20 > + >=20 > + FreePool (VarData); >=20 > + >=20 > + return Status; >=20 > } >=20 >=20 >=20 > /** >=20 > diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > index 7ac6e885dea6..a892ced984c8 100644 > --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > @@ -411,7 +411,11 @@ SaveETagList ( > gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid, > VARIABLE_ATTRIBUTE_NV_BS, 0, NULL); >=20 > } >=20 >=20 >=20 > - return gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid, > VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); >=20 > + Status =3D gRT->SetVariable (VariableName, &gEfiRedfishClientVariableG= uid, > VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); >=20 > + >=20 > + FreePool (VarData); >=20 > + >=20 > + return Status; >=20 > } >=20 >=20 >=20 > /** >=20 > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108108): https://edk2.groups.io/g/devel/message/108108 Mute This Topic: https://groups.io/mt/101027006/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-