From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 829B9740038 for ; Mon, 11 Mar 2024 13:18:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gBxqr1OFokL4+XL6PLh2s/hFlx+VklVDp3bS+Fntsp4=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710163128; v=1; b=QlxlEOnLvGQlWmkY588oJYJ8ROYICZ3JRUmq8AZ+2Ft4Cc3xrlYa5qrLCLxmocMttKCVd2IS Wd/cU1TkYQe82bbzLJPmB9TpolDQc2vZAdWobCaxdyU7PpS1ZNUnNjjygtiP94nf8kqsSwfB+dY rwIWE9Ndpd56QONT7m33ucXXFQg1jRGwWSZ9vAIOhQGFEdIFrbMwyribYtC0OQj55C+ZkeHTyOz IapPqtu9qgGbMH10sKaba6ossN1j36Zp4I0hR7KM+Al58wttG3vbDnNpGySVH45Hi28/BtOh6SO L4YfGxpQT3jpIy2UutZ+fKEo7aFKPaR0YsBzAhVD3JsEA== X-Received: by 127.0.0.2 with SMTP id l5GpYY7687511xCsLGa8kEEe; Mon, 11 Mar 2024 06:18:48 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web11.62683.1710163127435816997 for ; Mon, 11 Mar 2024 06:18:47 -0700 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by CYYPR12MB8750.namprd12.prod.outlook.com (2603:10b6:930:be::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.34; Mon, 11 Mar 2024 13:18:39 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::fef9:2c9c:21b5:6f50%2]) with mapi id 15.20.7362.035; Mon, 11 Mar 2024 13:18:39 +0000 From: "Nickle Wang via groups.io" To: "devel@edk2.groups.io" , "mike.maslenkin@gmail.com" CC: Abner Chang , Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH 2/4][edk2-redfish-client] RedfishClientPkg: fix leak in provisioning properties functions Thread-Topic: [edk2-devel] [PATCH 2/4][edk2-redfish-client] RedfishClientPkg: fix leak in provisioning properties functions Thread-Index: AQHacteVKdYfO38dmU+lDtsLAZfgdrEyh5LA Date: Mon, 11 Mar 2024 06:18:47 -0700 Message-ID: References: <20240310104151.41355-1-mike.maslenkin@gmail.com> <20240310104151.41355-3-mike.maslenkin@gmail.com> In-Reply-To: <20240310104151.41355-3-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|CYYPR12MB8750:EE_ x-ms-office365-filtering-correlation-id: ddf9c926-7249-47b5-7d21-08dc41cdc440 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: LX4FuyZsx4pMSFJesEOgQ+bz5JpyWi47zQzrKKT2Ms1YyKmxjzGJmNGbcoe5iI4fkBfj4f6EIXJ52wAzBzvGiU5lg15iBf6AMnQ7L/LBcKOyzym+1uALKn6ljMz7hePko1mEwl7Q4pR1Zec9TzRALc5IM4mIBAjROi/X1QgO7eMn6KAANrKJfBC617QUdeyxc5ALRuJkgOBrIRwPl6pVsrPYOyvZhPJl4EWqQmrXflLwlWyJ3F5RSlkTGkapgMIkKKSw97ARRBW5sFY4ig9PNBdYtiE1g0JzUg4kgrZZwLFFrDRlBSDh4743lXNSotJwWWnhf7TlU2F9DLUVGYS6pNWU5qmYCFH/yD69YuxYQds1FnlHcIIO9iKNPt24F+YNm9ym+bqxnzdcFTgj7RhJyy5+AxJps9qf2LPCQfiB6RMNUAhq75rec8rAaUn101YkNoeYuwJ5HbFFAJ2FuZ1CHu3W36ple86NSbOqOLB5yDGl+HugX9BsA9JjVSjrTNhENzyKCY6IdJvNoXCK90CkfHqzNo9b6tge7+/UjbuhnWKxCx2fash1qLcY4DLw/DShERqIkYE0oQAyEd0HbEBoUyoPs0aXl5DDkpVswEXY/jTT/fDBTLbTcOU5SSEGmdCynq5ScKbB2Q/6Df+ZEAv0U55oERp9IAiaRTo/8eXYmZw= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DTmjvend4f7RWb2elw4eygtmr2BUOaxJlLybpjUEiCref7XcfV6wBu5xxGdl?= =?us-ascii?Q?4cuI9Mt9XfzfdlNlAjGWqVn8W8VryxOo1ZbLPaOPMhQlS/uych6p0XUE/A5L?= =?us-ascii?Q?EOJdTW7+D3DpW9KSK8SVGq6HsnWUwjqVtEzxGpismfqH6RcBscJggUBqV1FH?= =?us-ascii?Q?w9bH2ZvBLbNmCeCuPaDjdVV4AWmVhSD8SxuzxBTZ8HD3va9uVX+m3XF2TpLx?= =?us-ascii?Q?OMjPk35OmLZ+QIrp7HLe/WxggwlWmLB9Y+dEtkjHwP7FLhFEogzBUjJee42x?= =?us-ascii?Q?9rmEJJF1bNYrsT/HBZtPsaH4iCXyxCMC6MOWw+G5Y4aae7TuQMj/Kqffry6Q?= =?us-ascii?Q?uS6llm635n1N/Y1pRikxO/hQlKa2BMStW4AL265hPTYDfTwLVTwPhdzhnQ1F?= =?us-ascii?Q?hHS+zJkFhd7n/FcSPw4bSyt+9gi41Hh4WAV3hpu9ojx7cZdSvbP7YemPeAbz?= =?us-ascii?Q?xGExDNPSJqJxrVDjFNVKY5Cc8l4kr5LwIjsA7F3NMxHWxS0g8qFcX2qPpIyk?= =?us-ascii?Q?3hKdq1YKTlshoBv4dGiSuV45iM27bWGtp6M+Elydii4CA/djNUHVVn1Trnhi?= =?us-ascii?Q?5patb97voLzGce8pNaQA2fKw/ysclhZxvqOgUcfnQuKfZXmcDwDlEyTam8qh?= =?us-ascii?Q?wMlE250UtiDZfogadPcjbJIgFdeBblGU1PQTxeoIjloXThRMRZnOJxbo1J3B?= =?us-ascii?Q?LrG8leKAYVA3hlpKtAtZ4SC1N2rHqmyUKvFdkr5Nyd6ZiX2Bss1iJ7q4y8h1?= =?us-ascii?Q?NWCPRf4DXfni60ZrCPfaTMJcv10QPpWUhcLqfD0MikP8Ir0Vwv/itgMB9lwA?= =?us-ascii?Q?0S0jyBw7KSZhSALHoS7pdrQwmcImy0yCY0VWLn136Vn2nHG7S2NdKY9Far62?= =?us-ascii?Q?6jhE73IIcnHfFZOp5c/EeNhiE0zBx6h396pz2F+kiOoGqcGpsAUFbk2KhQz6?= =?us-ascii?Q?nq3K2gmUCTcP7nWpNCNy1AR9cWMXqDiP/bIph1HJtOgUZBhb6OWTSLaYqHe2?= =?us-ascii?Q?jx5Q6GDpr5kQFomvDGgaMgZz/y4DcIhfRgSPHWfN70E0UfjeCihzF1L69F0S?= =?us-ascii?Q?2yZfvAkLOojPltYQyz5c5+P9QvLg9RcWhuyyrb58HAyc+fHdTlJy0JjkVjfU?= =?us-ascii?Q?+GTJYL/IphMbrcZPRlLtXvxGAr0PdArq86cui6dGUQItuZXWm4lzcfxqKF2+?= =?us-ascii?Q?jHATUicn1hDfyGMGOIYfNAS727PIVafq411Gy6Fgc7q5iyud54Y4Ge3lqtV9?= =?us-ascii?Q?bDtWp/OonaiRIWDUKS8VCQCLeUJfhgC9uHT4R+WDhpzL1MTTDdOwcrvRgkEm?= =?us-ascii?Q?TR+I89oQVxfATX2WKermg/HNsicYfk6RtH/lgtnCDfPLQ8sOfCY5R05gY2jo?= =?us-ascii?Q?9ZA7tpMcaBVBHAqRmLHHnFgFJtcESi3yqPvQEDFi5WkMBxAJczQGa81oZqqW?= =?us-ascii?Q?UYBzR5bAhIAbN4CyYxMbGdhP1TqentxFIGCAMWgJf872guZvclWvbvjtF8AW?= =?us-ascii?Q?qI2y1XfZb0YGnMw40vl/qQf+XVi2B0YugkEhWz+2R4BYHTWFBjK+rMkNNfkN?= =?us-ascii?Q?nI4fw/6d5UFNueyqN3KUsyAXBbm3aCBug9Imx6qx?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddf9c926-7249-47b5-7d21-08dc41cdc440 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2024 13:18:39.6309 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RnOeNrg50cm+HP88JHM0d0t/jmS4EkXXeAxNz1qSAXO/ZPmtqCKsImUeaucAbDwWXZ2wjtVrndb8KF3ABAWc/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8750 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8er68iPa2IfCw3n1bmUgYilrx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=QlxlEOnL; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Mike > Maslenkin via groups.io > Sent: Sunday, March 10, 2024 6:42 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > > Subject: [edk2-devel] [PATCH 2/4][edk2-redfish-client] RedfishClientPkg: = fix leak > in provisioning properties functions >=20 > External email: Use caution opening links or attachments >=20 >=20 > The structure instance retunred by ToStructure() must be deallocated prop= erly. >=20 > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nickle Wang > Signed-off-by: Mike Maslenkin > --- > RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 5 ++++- > .../Features/BootOption/v1_0_4/Common/BootOptionCommon.c | 5 ++++- > .../Features/Memory/V1_7_1/Common/MemoryCommon.c | 5 ++++- > 3 files changed, 12 insertions(+), 3 deletions(-) >=20 > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > index 1eb269a84222..f40fe215afeb 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > @@ -247,7 +247,6 @@ ProvisioningBiosProperties ( > ); >=20 > if (EFI_ERROR (Status)) { >=20 > DEBUG ((DEBUG_ERROR, "%a, ToJson() failed: %r\n", __func__, Status))= ; >=20 > - return Status; >=20 > } >=20 >=20 >=20 > // >=20 > @@ -258,6 +257,10 @@ ProvisioningBiosProperties ( > (EFI_REST_JSON_STRUCTURE_HEADER *)Bios >=20 > ); >=20 >=20 >=20 > + if (EFI_ERROR (Status)) { >=20 > + return Status; >=20 > + } >=20 > + >=20 > return (PropertyChanged ? EFI_SUCCESS : EFI_NOT_FOUND); >=20 > } >=20 >=20 >=20 > diff --git > a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommon. > c > b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommon. > c > index 339c8ba04103..358b32253973 100644 > --- > a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommon. > c > +++ > b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommo > +++ n.c > @@ -334,7 +334,6 @@ ON_RELEASE: > ); >=20 > if (EFI_ERROR (Status)) { >=20 > DEBUG ((DEBUG_ERROR, "%a: ToJson() failed: %r\n", __func__, Status))= ; >=20 > - return Status; >=20 > } >=20 >=20 >=20 > // >=20 > @@ -345,6 +344,10 @@ ON_RELEASE: > (EFI_REST_JSON_STRUCTURE_HEADER *)BootOption >=20 > ); >=20 >=20 >=20 > + if (EFI_ERROR (Status)) { >=20 > + return Status; >=20 > + } >=20 > + >=20 > return (PropertyChanged ? EFI_SUCCESS : EFI_NOT_FOUND); >=20 > } >=20 >=20 >=20 > diff --git > a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > index e873f05ca040..39ec7ec0c34b 100644 > --- a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c > @@ -2133,7 +2133,6 @@ ProvisioningMemoryProperties ( > ); >=20 > if (EFI_ERROR (Status)) { >=20 > DEBUG ((DEBUG_ERROR, "%a, ToJson() failed: %r\n", __func__, Status))= ; >=20 > - return Status; >=20 > } >=20 >=20 >=20 > // >=20 > @@ -2144,6 +2143,10 @@ ProvisioningMemoryProperties ( > (EFI_REST_JSON_STRUCTURE_HEADER *)Memory >=20 > ); >=20 >=20 >=20 > + if (EFI_ERROR (Status)) { >=20 > + return Status; >=20 > + } >=20 > + >=20 > return (PropertyChanged ? EFI_SUCCESS : EFI_NOT_FOUND); >=20 > } >=20 >=20 >=20 > -- > 2.32.0 (Apple Git-132) >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#116566): https://edk2.groups.io/g/devel/message/11656= 6 > Mute This Topic: https://groups.io/mt/104841893/7129762 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [nicklew@nvidia.com] -= =3D-=3D- > =3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116625): https://edk2.groups.io/g/devel/message/116625 Mute This Topic: https://groups.io/mt/104841893/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-