From: "Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>
To: Mike Maslenkin <mike.maslenkin@gmail.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "abner.chang@amd.com" <abner.chang@amd.com>,
"igork@ami.com" <igork@ami.com>
Subject: Re: [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script
Date: Tue, 3 Oct 2023 12:49:38 +0000 [thread overview]
Message-ID: <MW4PR12MB703179F62B2160399A452B95D9C4A@MW4PR12MB7031.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230929222414.47115-1-mike.maslenkin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3158 bytes --]
Patch set Reviewed-by: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
Hi @Mike Maslenkin<mailto:mike.maslenkin@gmail.com>, could you please add Abner and my Reviewed-by to two commit messages in this PR? https://github.com/tianocore/edk2-redfish-client/pull/53 And then I will merge this pull request.
This is an example:
Original "HEAD~$NO_COMMITS" returns a diff agains current repo state
including not stashed changes. As the purpose of uncrustify is to
check commits, let's get changes against HEAD itself and ignore
local modifications.
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>
Reviewed-by: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
Reviewed-by: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
Thanks,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Saturday, September 30, 2023 6:24 AM
> To: devel@edk2.groups.io
> Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script
>
> External email: Use caution opening links or attachments
>
>
> Please, look at these changes. I've had some troubles when tried to run uncrustify
> checks locally on macOS and those fixes helped me.
> Also I tried this set on Linux and it worked.
>
> Here is a link to PR:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co<https://github.com/tianocore/edk2-redfish-client/pull/53>
> m%2Ftianocore%2Fedk2-redfish-<https://github.com/tianocore/edk2-redfish-client/pull/53>
> client%2Fpull%2F53&data=05%7C01%7Cnicklew%40nvidia.com%7Cb0010e3e1b<https://github.com/tianocore/edk2-redfish-client/pull/53>
> 704e77ebf308dbc13ad2d3%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0<https://github.com/tianocore/edk2-redfish-client/pull/53>
> %7C638316230613811494%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw<https://github.com/tianocore/edk2-redfish-client/pull/53>
> MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C<https://github.com/tianocore/edk2-redfish-client/pull/53>
> &sdata=Edar%2Fg4kjvKcj9v6DFz6PBu7zGrIUNt2pU%2FYwyMz6JE%3D&reserved<https://github.com/tianocore/edk2-redfish-client/pull/53>
> =0<https://github.com/tianocore/edk2-redfish-client/pull/53>
>
> Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> Cc: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> Cc: Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109282): https://edk2.groups.io/g/devel/message/109282
Mute This Topic: https://groups.io/mt/101667892/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 8246 bytes --]
prev parent reply other threads:[~2023-10-03 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 22:24 [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script Mike Maslenkin
2023-09-29 22:24 ` [edk2-devel] [PATCH 1/2] RedfishClientPkg/.github: tune file list for uncrustify check Mike Maslenkin
2023-09-29 22:24 ` [edk2-devel] [PATCH 2/2] RedfishClientPkg/.github: fix " Mike Maslenkin
2023-10-02 3:25 ` [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script Chang, Abner via groups.io
2023-10-03 12:49 ` Nickle Wang via groups.io [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR12MB703179F62B2160399A452B95D9C4A@MW4PR12MB7031.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox