Patch set Reviewed-by: Nickle Wang <nicklew@nvidia.com>
Hi
@Mike Maslenkin, could you please add Abner and my Reviewed-by to two commit messages in this PR?
https://github.com/tianocore/edk2-redfish-client/pull/53 And then I will merge this pull request.
This is an example:
Original "HEAD~$NO_COMMITS" returns a diff agains current repo state
including not stashed changes. As the purpose of uncrustify is to
check commits, let's get changes against HEAD itself and ignore
local modifications.
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
Thanks,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Saturday, September 30, 2023 6:24 AM
> To: devel@edk2.groups.io
> Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script
>
> External email: Use caution opening links or attachments
>
>
> Please, look at these changes. I've had some troubles when tried to run uncrustify
> checks locally on macOS and those fixes helped me.
> Also I tried this set on Linux and it worked.
>
> Here is a link to PR:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co
> m%2Ftianocore%2Fedk2-redfish-
> client%2Fpull%2F53&data=05%7C01%7Cnicklew%40nvidia.com%7Cb0010e3e1b
> 704e77ebf308dbc13ad2d3%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0
> %7C638316230613811494%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw
> MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C
> &sdata=Edar%2Fg4kjvKcj9v6DFz6PBu7zGrIUNt2pU%2FYwyMz6JE%3D&reserved
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>