From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 196B9AC1877 for ; Tue, 3 Oct 2023 12:49:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dmpNjLCLc3gjpbx377nePi5DihnS0rbWsL29y2WoZew=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1696337381; v=1; b=jndYr0Zln/kDNdh1/otPzRCEnSeaswgUd5BYkIP2C+tmg9SsokriqShC8JB2MC87vc1GxuaW Q5ay1mnyxO9xnhqlfCDes+m8XB7FcTfQ/0eLKdepDzRwr2/2M16n54EoaIPx79cmosl/r7PV96y WUMWMbJFE6r5bh9GQwGPtdfI= X-Received: by 127.0.0.2 with SMTP id Do2TYY7687511xGgG9L7kWbc; Tue, 03 Oct 2023 05:49:41 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.64]) by mx.groups.io with SMTP id smtpd.web11.106989.1696337380831929270 for ; Tue, 03 Oct 2023 05:49:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QP7q/jtZKpqL+ve2RdC1PfKmz3QwTzbaTpgV4UsUbccW6RAhBX/X6Ddg703DCF8VdCzNnqHpsb05qWNyPOR7vuiHcEIURC9gdYni4YRl/o4YUuaDTPAwXjGuEzhve1/rujwStph9VmEtwvaNMiYWfzujjaWfd4atfgr3iVow0BT+hkEMT100N8CZRrEVI/wfttcbsBmXGoJ8/OhZ6d81QKlvAN565Sk+cq8JrUX9wnnTYqxdZjm2zQVBsfbc/TwAtcR1wiIzwlNYmmMc5RfJelUabTrWsGihClOoBv83pq73wuIG/191E/wFPhkIRUNFBwWv0i8BUzTGYkTKA0ksNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lav/s6jlP1vy0FxGYENSG3/E7kn9AwZm3itibjVH/6Y=; b=f+UpszhQQrremrnKlPZ4cGK1lNlQMnb+KJzncCVA6uBcy3nuGvO1FYwJ+pMEGjrWv362HKLxAi2ETQ0k05y+2OnlQ0GTAX76Q2cfZlorEgXQRH0IRIN17JFhB37WdKcoX+RHskSHN8dDttIJ4SqT/2HHlHytAEymS4gNianQ52ZiwmZ9YZ96r5T4lqoOcAkuCB/RQuaVI8vWme/vy/qzzRuGybD5WO/vcUjbVbVumNHeEM0cGWLfKMiZuvz1HWsIV8UrvLE4uZn438eoIxI6sLgEUcO4HqPUyDk5K4Vsmr0gCzymPofieLCM3gLRaLZjekruJVqst2FYbD/7lSzJsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by SN7PR12MB8791.namprd12.prod.outlook.com (2603:10b6:806:32a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.29; Tue, 3 Oct 2023 12:49:38 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::f345:babc:2bc5:bfae]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::f345:babc:2bc5:bfae%4]) with mapi id 15.20.6838.029; Tue, 3 Oct 2023 12:49:38 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "abner.chang@amd.com" , "igork@ami.com" Subject: Re: [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script Thread-Topic: [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script Thread-Index: AQHZ8yOxwBKp0poplEWk2Z4fktzfubA4CJxg Date: Tue, 3 Oct 2023 12:49:38 +0000 Message-ID: References: <20230929222414.47115-1-mike.maslenkin@gmail.com> In-Reply-To: <20230929222414.47115-1-mike.maslenkin@gmail.com> Accept-Language: en-US X-Mentions: mike.maslenkin@gmail.com X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|SN7PR12MB8791:EE_ x-ms-office365-filtering-correlation-id: 81be6cb7-a9ea-443f-0af3-08dbc40f342b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: XLFzJmA8wtbh/isZzBEzVvXpkRLiNLdfUxtDy2KS+AOwpRw5l9gLX+gcXfl/1QomdRPU69Qu09oA326R8i+Bjrsw/klGGUPM4LXyZNohH4vdcuflmcKlBwunl/k2SOT3iEnw9u/IoboH86mkHVRiB7x2pxY+efjvzVCqreUIrAIeF879EMoXFwgvvBCrWR2XSynRsQJ1lad85172vMD9plY3LJb8OMaWKY3SJ4P4QTnB6MtTFyv9XA8mORX5T2kH45jrAQef3apEZUkF/M7iWwz76biIpSsc28ELDXd5M6ULiqQ5c1g9FzthB0GXDo+1cZ76eknDqVNZH9c/ZvF5Kbn7kY+DeO81dTZpKOTB3O6utfVeXwviu2mRmcTXGg7w20rN67kLYz14WY9X8raAiuD2wxvOfkZMw2IP7IdCw6tMwAOcwWPMq6kspXB4wByyhA3VeU6rwp4k6frSpO1goeCw/8sTHcdyYDGlR9vEZ5kRsiDWDHHlnlzMirFCRrdEIjzt9VBgjXTMyY3nwdA1Dv3SisrzZZZQv3Ru6VXuZ+M+QyAuYYYcjilbnrV65KHQZOudcKTYM4QwaHRoTSMA55eeZXxTmuCntIC4RUip6bE= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dVJSVrq8sSN/A28YmYSNW5wCbSQvMtVxiUBctqgdJFzkqgxXkTqGpOXm+eNv?= =?us-ascii?Q?0I9qhKF7j6CIiYU03/xF87GpQu30Zt84VhDhGiSbIHSbwSSktTFQlhVk+5bo?= =?us-ascii?Q?9l5e4Jq7DKxEfFuvHUqjidh+dS+B98Vttt1mfUrQUzCmDt8HESaXv3hIxlzK?= =?us-ascii?Q?Qy0QdSLLYIwMr+4hs9SQkEn5pFhBvfYZKbqG4illZN1efkN+iXmIjLSVpbQ6?= =?us-ascii?Q?Vm0F+QjH22eAdFv7cpMNeIBJRULU1cpFJox+rdTDbf7NJHNcrlkWsU6HsGoz?= =?us-ascii?Q?UWxPAV3n2tIzKLVWE3zLsnmTlf+GLKq+S09gPBC1+jq2N8BT/e87uKu5kSvC?= =?us-ascii?Q?3X7cZgMSHJiba17SvPGLzpWW1gb9OuejkyR4QSgftdhSng44ZUp/i8HIVinE?= =?us-ascii?Q?x/SUOjtMHpuooIxLtS2rOtfCtI5Xt8N6JrJJELeTVlMrgMWNWuK7hPQbc9vc?= =?us-ascii?Q?RDZkFWYr0xCg0/8H8vgxMrfiiYpt5Qub+xrB3uipnlHhpyTpu73pt98mzC9M?= =?us-ascii?Q?a9wc9MdSPxS6gmMscGO66rGnc9RZhNVzS23gwnyixvw64u6no3Q/uqLVHIoa?= =?us-ascii?Q?LPSoVrQ9uFzKVPtH4H2doyds8muAbTp2ovkuMEVmIsC6+lj1vhWyWUJwrtxw?= =?us-ascii?Q?q5+73ofoDT/gNT3AYGttQCKRWpbjADTsOY+5PE487ZRQd2LOzLxNz40HdZvo?= =?us-ascii?Q?v5TE5kVwpdn122d6kPmNjoC54BCOQMdgoOpntgcchQMXZ8LqoGcXNL3r6W5i?= =?us-ascii?Q?lRtRxDR8PrKDJ7aSzry0F4wCOSn68zM7QcnfcSqy404xfmZSRSCk8L1iphzH?= =?us-ascii?Q?2a4MVzh/aTUO6ea3aIH6n+RHs/NGmi5lnEHTK8DiQdKZIylEngN9EisNnSAm?= =?us-ascii?Q?W35xY3BpauJ1XGtFYmdjY9bfkeLmshfaGZTQvicqvC70zWZtnLU8dv0xuw/y?= =?us-ascii?Q?M9mNqpS/hlW4xajclE3edpqZM6RkwvJI94l7akI1UNpXkzOD8sZOqUOkxVKJ?= =?us-ascii?Q?ZMwijVSO9W9z3q3fU2EtIybRZb07931/6CuTi3repZgwGuRQeC3ak8ke9vHO?= =?us-ascii?Q?Hvu75P1LxXOtihyTsDKywb/eMAIkqkprYHZOg4CutBV2eJUmsY6BQaFwyaAI?= =?us-ascii?Q?oRdR2vGdEvgDm1fBgJpn7hD8cnBmMbZe7wWr1Tj0qRMSpaFJQA4niU/NjZP8?= =?us-ascii?Q?dtC+2DadOJ60dyPli8ZnRH6roWOlX9PwjTXMKi3hu7wYMMjzluNGkShmG2LZ?= =?us-ascii?Q?NGQk62iAaKa3RQV/S86P9cmhAwuvzPauZZNu3PdPzS4il+60bd9oQlPi235/?= =?us-ascii?Q?9AVS4GnFhmlaIZhRkKEHQOVRIfO6LCs8CvE/RDwBrqONT6jDnPYu8Lp/bcHQ?= =?us-ascii?Q?sqz+b5632ckR0RhvAzgrfUAmb7sg4L7ojaB9PWtvRw6wuJrSTvnobmQPn6Vs?= =?us-ascii?Q?yqjd89uaaXDlTLHkrqrtj/9wRyOzMi5zt4Y8x7eekZikwqaj5BhnJfRjBpAG?= =?us-ascii?Q?Rau8gQCDWoGqGZZ30KrBLBFYMvn6sZ72qe1UIpZT/1lbC4G26zDrr0hcXd04?= =?us-ascii?Q?ZPZ4uupHRa+ZYnn5oNo=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81be6cb7-a9ea-443f-0af3-08dbc40f342b X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2023 12:49:38.1456 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DNhr+6r+bLE+xcFrMlWjjwKISra+Xy27STk18N6IX8k8S+9DBmPB+p3CgRHtPect0wlOqTLUi0a2XXW0SRMqwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8791 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: aUEkdEJR8IqhOYxXjakSP4Fmx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR12MB703179F62B2160399A452B95D9C4AMW4PR12MB7031namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jndYr0Zl; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MW4PR12MB703179F62B2160399A452B95D9C4AMW4PR12MB7031namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch set Reviewed-by: Nickle Wang > Hi @Mike Maslenkin, could you please add A= bner and my Reviewed-by to two commit messages in this PR? https://github.c= om/tianocore/edk2-redfish-client/pull/53 And then I will merge this pull re= quest. This is an example: Original "HEAD~$NO_COMMITS" returns a diff agains current repo state including not stashed changes. As the purpose of uncrustify is to check commits, let's get changes against HEAD itself and ignore local modifications. Signed-off-by: Mike Maslenkin > Reviewed-by: Abner Chang > Reviewed-by: Nickle Wang > Thanks, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Saturday, September 30, 2023 6:24 AM > To: devel@edk2.groups.io > Cc: abner.chang@amd.com; Nickle Wang ; > igork@ami.com; Mike Maslenkin > Subject: [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script > > External email: Use caution opening links or attachments > > > Please, look at these changes. I've had some troubles when tried to run u= ncrustify > checks locally on macOS and those fixes helped me. > Also I tried this set on Linux and it worked. > > Here is a link to PR: > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu= b.co > m%2Ftianocore%2Fedk2-redfish- > client%2Fpull%2F53&data=3D05%7C01%7Cnicklew%40nvidia.com%7Cb0010e3e1b > 704e77ebf308dbc13ad2d3%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0 > %7C638316230613811494%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C > &sdata=3DEdar%2Fg4kjvKcj9v6DFz6PBu7zGrIUNt2pU%2FYwyMz6JE%3D&reserved > =3D0 > > Cc: Abner Chang > > Cc: Nickle Wang > > Cc: Igor Kulchytskyy > > Signed-off-by: Mike Maslenkin > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109282): https://edk2.groups.io/g/devel/message/109282 Mute This Topic: https://groups.io/mt/101667892/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MW4PR12MB703179F62B2160399A452B95D9C4AMW4PR12MB7031namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

 

Patch set  Reviewed-by: Nickle Wang <nicklew@nvidia.com>

 

Hi @Mike Maslenkin, could you please add Abner and my Reviewed= -by to two commit messages in this PR? https:= //github.com/tianocore/edk2-redfish-client/pull/53 And then I will merg= e this pull request.

 

This is an example:

 

Original "HEAD~$NO_COMMITS" returns a d= iff agains current repo state

including not stashed changes. As the purpose of = uncrustify is to

check commits, let's get changes against HEAD its= elf and ignore

local modifications.

 

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>

Reviewed-by: Abner Chang <abner.chang@amd.com>

Reviewed-by: Nickle Wang <nicklew@nvidia.com>

 

Thanks,

Nickle

 

> -----Original Message-----

> From: Mike Maslenkin <mike.maslenkin@gmai= l.com>

> Sent: Saturday, September 30, 2023 6:24 AM

> To: devel@edk2.groups.io

> Cc: abner.chang@amd.com; Nickle Wang <nic= klew@nvidia.com>;

> igork@ami.com; Mike Maslenkin <mike.masle= nkin@gmail.com>

> Subject: [RFC][PATCH 0/2][edk2-redfish-clien= t]: tune uncrustify script

>

> External email: Use caution opening links or= attachments

>

>

> Please, look at these changes. I've had some= troubles when tried to run uncrustify

> checks locally on macOS and those fixes help= ed me.

> Also I tried this set on Linux and it worked= .

>

> Here is a link to PR:

> https://nam11.safelin= ks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.co

&= gt; m%2Ftianocore%2Fedk2-redfish-

&= gt; client%2Fpull%2F53&data=3D05%7C01%7Cnicklew%40nvidia.com%7Cb0010e3e= 1b

&= gt; 704e77ebf308dbc13ad2d3%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0

&= gt; %7C638316230613811494%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw

&= gt; MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C

&= gt; &sdata=3DEdar%2Fg4kjvKcj9v6DFz6PBu7zGrIUNt2pU%2FYwyMz6JE%3D&res= erved

&= gt; =3D0

>

> Cc: Abner Chang <abner.= chang@amd.com>

> Cc: Nickle Wang <nicklew= @nvidia.com>

> Cc: Igor Kulchytskyy <igork@a= mi.com>

> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>

 

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#109282) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MW4PR12MB703179F62B2160399A452B95D9C4AMW4PR12MB7031namp_--