Re: [edk2-devel] [PATCH V3 5/9] RedfishPkg/RedfishDiscovery: Add more debug message

["Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>]

Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Monday, November 27, 2023 1:31 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>;
> Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH V3 5/9] RedfishPkg/RedfishDiscovery: Add more debug message
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
>  .../RedfishDiscoverDxe/RedfishDiscoverDxe.c   | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> index 28ba2d3a9fc..833ae2b969f 100644
> --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> @@ -603,6 +603,27 @@ DiscoverRedfishHostInterface (
>      }
> 
>      if (MacCompareStatus != 0) {
> +      DEBUG ((DEBUG_ERROR, "%a: MAC address is not matched.\n", __func__));
> +      DEBUG ((
> +        DEBUG_ERROR,
> +        "    NetworkInterface: %02x %02x %02x %02x %02x %02x.\n",
> +        Instance->NetworkInterface->MacAddress.Addr[0],
> +        Instance->NetworkInterface->MacAddress.Addr[1],
> +        Instance->NetworkInterface->MacAddress.Addr[2],
> +        Instance->NetworkInterface->MacAddress.Addr[3],
> +        Instance->NetworkInterface->MacAddress.Addr[4],
> +        Instance->NetworkInterface->MacAddress.Addr[5]
> +        ));
> +      DEBUG ((
> +        DEBUG_ERROR,
> +        "    Redfish Host interface: %02x %02x %02x %02x %02x %02x.\n",
> +        DeviceDescriptor->DeviceDescriptor.UsbDeviceV2.MacAddress[0],
> +        DeviceDescriptor->DeviceDescriptor.UsbDeviceV2.MacAddress[1],
> +        DeviceDescriptor->DeviceDescriptor.UsbDeviceV2.MacAddress[2],
> +        DeviceDescriptor->DeviceDescriptor.UsbDeviceV2.MacAddress[3],
> +        DeviceDescriptor->DeviceDescriptor.UsbDeviceV2.MacAddress[4],
> +        DeviceDescriptor->DeviceDescriptor.UsbDeviceV2.MacAddress[5]
> +        ));
>        return EFI_UNSUPPORTED;
>      }
> 
> @@ -716,6 +737,8 @@ DiscoverRedfishHostInterface (
>                   IsHttps
>                   );
>      }
> +  } else {
> +    DEBUG ((DEBUG_ERROR, "%a: RedfishGetHostInterfaceProtocolData is
> failed.\n", __func__));
>    }
> 
>    return Status;
> --
> 2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112011): https://edk2.groups.io/g/devel/message/112011
Mute This Topic: https://groups.io/mt/102824320/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-