Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

["Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>]

Thanks for addressing my comment.


Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Thursday, February 22, 2024 4:06 AM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin <mike.maslenkin@gmail.com>; Nickle Wang
> <nicklew@nvidia.com>; Abner Chang <abner.chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>
> Subject: [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine
> RedfishExternalResourceResourceFeatureCallback
> 
> External email: Use caution opening links or attachments
> 
> 
> Use local variable for BiosUri passed to HandleResource() to avoid problems in
> case of Private->Uri is overriden down the call stack.
> 
> Suggested-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
>  RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> index f40f2d85af80..db77ed3dfccb 100644
> --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> @@ -670,6 +670,7 @@ RedfishExternalResourceResourceFeatureCallback (
>    REDFISH_SERVICE                  RedfishService;
> 
>    REDFISH_RESOURCE_COMMON_PRIVATE  *Private;
> 
>    EFI_STRING                       ResourceUri;
> 
> +  EFI_STRING                       BiosUri;
> 
> 
> 
>    if (FeatureAction != CallbackActionStartOperation) {
> 
>      return EFI_UNSUPPORTED;
> 
> @@ -707,19 +708,19 @@ RedfishExternalResourceResourceFeatureCallback (
>    //
> 
>    // Initialize collection path
> 
>    //
> 
> -  Private->Uri = RedfishGetUri (ResourceUri);
> 
> -  if (Private->Uri == NULL) {
> 
> +  BiosUri = RedfishGetUri (ResourceUri);
> 
> +  if (BiosUri == NULL) {
> 
>      ASSERT (FALSE);
> 
>      FreePool (ResourceUri);
> 
>      return EFI_OUT_OF_RESOURCES;
> 
>    }
> 
> 
> 
> -  Status = HandleResource (Private, Private->Uri);
> 
> +  Status = HandleResource (Private, BiosUri);
> 
>    if (EFI_ERROR (Status)) {
> 
> -    DEBUG ((DEBUG_ERROR, "%a, process external resource: %a failed: %r\n",
> __func__, Private->Uri, Status));
> 
> +    DEBUG ((DEBUG_ERROR, "%a, process external resource: %s failed:
> + %r\n", __func__, BiosUri, Status));
> 
>    }
> 
> 
> 
> -  FreePool (Private->Uri);
> 
> +  FreePool (BiosUri);
> 
>    FreePool (ResourceUri);
> 
>    return Status;
> 
>  }
> 
> --
> 2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115771): https://edk2.groups.io/g/devel/message/115771
Mute This Topic: https://groups.io/mt/104495956/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-