From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 358DB7803CD for ; Thu, 22 Feb 2024 02:14:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PbE2W7n8GTXYlk/S30V05s4zDnFvY0Y+LgCsQsRKqCo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708568048; v=1; b=rp1J0nMihtQqzM15Sj3996oMHTECGcMg6VTGSvvKW4M8ts+zp+sZfvrfwqDQM/+NePG2ylrR tjWGMMG6+auQknnBp7StPUkIKD9KJRC0mEMxb1wtiIk87r3NoMM2CRe0HWSuJ8AHCvyYRpaQHyo uSgMGy/IkCp44qvfka/LdbI0= X-Received: by 127.0.0.2 with SMTP id BWt7YY7687511xJba3qAr08I; Wed, 21 Feb 2024 18:14:08 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.46]) by mx.groups.io with SMTP id smtpd.web11.4293.1708568048027891172 for ; Wed, 21 Feb 2024 18:14:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hNPC1bnMfIWUQiLfmYmC7zbWZslvmnzQY8yqbiouDThciMWZ5WjJc1YGYG2eS7LorKiPCSu7MzEjA11KF3F3THBKKZEDLBIfSPCcju4BG+Wvd3v1Z3R2xusbHcn66/RWOQVPVKs/p2sQ0blhNSQtz0PQlqB/9UmhGBFgxTLCwjOeZQIdQN484tr0s5HA/CKNZEg5tA7LqlJXrYJCjU64doLv20Je7IwWgu5C9HBrakb3panpmH9HBXxIhV/SDfHo0yzIIoVvvWT9KJ6lf5LRR7A9faUPpbPq03JEZ2ASijpvzKAZOkOGbsnj1urigMmR2bon7EXlAJ20X2zJ3nU9ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YVwQWiolBGOgPixKCrDwV7u9mxjdsa2f9CAZQUdVhFc=; b=l9JTcOOUxQYzdcMZYUQrrhHIQjI+tgjepTByQvRLBqsrujAfgJh6Nk4uMMSGmjB2KMV4LxXDOIKbhMkkbAjuLd62anPX5dHpkhOrAFjxUgljfNGOCXogC0roThvZ1XpjUeJtngei3wCHKYncbr8j9kkA32j5YJYantxoN3fx0xwXXmc0HoyEydznKilJc4aNBnNMk0zNeVPY8An+La8Cl1csxoKH44xCJKxSB+70HKIaf3Xapau5FpfctQlGEJMVXvLPkHmtkM9rNXENa8d2dofFQtvfAR38nPN6MiF28QVGSHb6pQoGIvJCnGyin9tfh7A4CROK/wzgdeQp+oJoUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) by MN2PR12MB4094.namprd12.prod.outlook.com (2603:10b6:208:15f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.24; Thu, 22 Feb 2024 02:14:03 +0000 X-Received: from MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::aa79:3ab0:fbcd:d61b]) by MW4PR12MB7031.namprd12.prod.outlook.com ([fe80::aa79:3ab0:fbcd:d61b%5]) with mapi id 15.20.7316.018; Thu, 22 Feb 2024 02:14:03 +0000 From: "Nickle Wang via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: Abner Chang , Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback Thread-Topic: [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback Thread-Index: AQHaZQF7sLGBuss+uUC86C7mSphhCbEVn4CA Date: Thu, 22 Feb 2024 02:14:03 +0000 Message-ID: References: <20240221200628.74174-1-mike.maslenkin@gmail.com> <20240221200628.74174-3-mike.maslenkin@gmail.com> In-Reply-To: <20240221200628.74174-3-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR12MB7031:EE_|MN2PR12MB4094:EE_ x-ms-office365-filtering-correlation-id: c8660850-64a2-4e40-5b73-08dc334bf0ca x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: aq+UlLeg+viGUtSHY0i9LeRoabC6B6Q+U8mggImKplqJQnjG+Fcu5+5ONxFcNdYdyfG8bAmZ95klwS6p2vDKfn5CRBaTcdG8VClxQPm/xIEhfgsI6CnYxjIRn8EUXhmssf5aoUoXte8U2JtseTqFnsqv1YowoI8V/6mIxnWR7+jBRMj5muE72gPgH+038gY9CO8eBb7vpNwNM7fmkCDW9O0Y6Jbo162pNFOOpKkQZI0oAt/q9PX3mwB7jt/KK3YjU221pA+O/a11Mpq3E4nVbMiFbfXPZciEy4Ra0oA3lOOk1dX+gKCHerDvQ38UxYG9Eulbp8zeWGIE7WLZ6worWCdkFwPpwRGFyzgo4lt8FLhONgnZp20xOC0ZkXWZeKcvQSMwgG3gF78bK5rDPSPQ1E9XYDojWzry7DrsQ7PBbk5YCEEiUCWpq1V+4q2YUY6NUo+rEtyX0unqknhg2gSsFwc+1XUENvNkKFAYPlQdnackcpuwfmMo5Mw2I/EA/EF8pgLKs7ReOc8MYleuee2WIk5K9R4ty3tgQE6pq3C+4pRbl2P84sBO7w9mfIn7ke5DpFP8UZAhT8TJNEk3AVfHK5rAB0YCd25TMK4S7z0V3zGFS5Eg2LeW1C68F8HMwDMg x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LmhBxjeGapJ7iimebi+5q2TFGMMVECOSPxi2NkgDf91tDIytiFRxmz5xtl/5?= =?us-ascii?Q?z0ce31IG+A4IW7eoZM6HCuZ1sl352WrgOXVjaVevLGeKxPccaH7UVGp3aH2h?= =?us-ascii?Q?MBJjS4hL69Snp5fCwsf86gYCSYPVtpksFeKlAAhKWEPq/gAZqdbRohE48AcD?= =?us-ascii?Q?pvVQUbSp/DxTBVXHacno22+SYMVo2zZoAY3u/yEWJfsxVMMhUx8jp9l2s4Og?= =?us-ascii?Q?lgf+X8ZYw7pVrkFjJjKKhiV0juv/OyaebzlQ1NuR2b5BnHv6pMJp8QJ5AB9x?= =?us-ascii?Q?ae0Km4m1D2Rv3YgAHxuRUCrWQzbhbf3qPfDGADvLe3GoySUl+Zyqzz45fBN9?= =?us-ascii?Q?ie1D4EoLP0MOQMhz40MWpPXf6PxBuVDiTa67u+dzpmOwz6qbFAfVcpKhuYf0?= =?us-ascii?Q?OIW2R20pz15b4UQPtkMO0YGjJgwJSZOOcNZuYamDRnw/5A/P05LF2kY8Xalt?= =?us-ascii?Q?ZrNh/jC7qXOWgrnKfHdItGqZNAapEzYpJ0VYXD+0nFhpCQtco5DTA/B4lqo1?= =?us-ascii?Q?mjNNss8NfDU20Ef9HU1nrHEKWssInAARpyx8Tgtfu1P/VOsJF/+lVHtF1L03?= =?us-ascii?Q?ts6+yHAjH8e2XN7zHB60y/HzbPkpAmvCHv6mSorVG+7a0e3Ew+IvzNqKfuuo?= =?us-ascii?Q?MpLyJTTaiVBXG0Vg8YVV5VUtIEoB+KfTnn/ND3Ez9KnDkTl8TNDlOLnukDCB?= =?us-ascii?Q?yAYpu8W96dWlOUaSYjOgIKd1G7oEOKSG6O+Ii0LLfitSKz321ORM3AYWsqCg?= =?us-ascii?Q?C25F5vb1MpClOEiQvyTSxLRBVBuVphyJAIjkQrkdjHpKQHS0uOYh4NsEWQjr?= =?us-ascii?Q?H26+fcRog4+WRG9kcP4ppsjH8mnIC+IdTcIsRIv8LPeilnVtRuouCQv3otWT?= =?us-ascii?Q?D5DR+atzSnZ7367fqwLknqm36BVkK0Q6vM7S5QYxnnqSM1C3cPcgLNq7ez2Y?= =?us-ascii?Q?TBmu8uSmTT2d/ZeNphy5iiq7n2Ty8rkzjdFOoQp41THIIYRnnhP0JNtiz82j?= =?us-ascii?Q?Ly1OgCAJVV2dmEg35R8nbV1gz6mGzHQxrZSSTrMEcVnoJwvhn5dCDFiG221A?= =?us-ascii?Q?lybxuc7GxK/ANcagqh/cphkEmnF1mfw7KqA9lulUpkQI62dyxhOaYRR+mUEg?= =?us-ascii?Q?xP7k21ZCeOA5bYXxKk2yTwUQ+k1dF5a480nkSTBO+xZ0TLq4A9XQfQDuAP5K?= =?us-ascii?Q?No5wiZwesWM3XlUmScZ5Fm11GLUJM/FLSEK2wR5Ltz8SG28O+oiNuLr1VeXB?= =?us-ascii?Q?de7smA2KhmX+gWK2u4Pj77RCVd/FKXce1C5PJHCZB319q8ou22PG2E4tKys1?= =?us-ascii?Q?OBYvEbeYbmMVqugRvS0A75ILL1ndl0kinC65WgniHEwqGNywQLQDLG/cxYim?= =?us-ascii?Q?La6KxkXcCB8nUxZWS27JB2ENUAPqEhXapur6DjmV/5VB+lfManBY4FbAqAPb?= =?us-ascii?Q?0HgiNYu0SIEhQjZKvc5+Fcd1Ud39WFtFjeT6JSm6I/4+wHY2IkBE84/0kjXQ?= =?us-ascii?Q?sIzZzeFGnT3NOrphipHfgyeFJP5GEwmexfy8ZY1wNhCnTbjqijxoE5dU30cS?= =?us-ascii?Q?5uVK1Ko3yXRVdRT9WOx6fDnAaPnnOaraBQ/qIKFqYyY1pL0W+L6Zh228DhM/?= =?us-ascii?Q?2sUdphQLrvyAu31esnQjtHxytoMfaIn4zzOV7mZ7KtB5?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7031.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8660850-64a2-4e40-5b73-08dc334bf0ca X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2024 02:14:03.5045 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dUGXZNPfnq3XKeb0CynyEj8wAn8At5mor+6feJ44SVuUDMxZehhsLe9c4smX4aOSYf4KgMVJBTkrhfY15Q7ixA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4094 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: va9PHsnZIeaqtpAd5SwhY1anx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=rp1J0nMi; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks for addressing my comment. Reviewed-by: Nickle Wang Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > Sent: Thursday, February 22, 2024 4:06 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Nickle Wang > ; Abner Chang ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine > RedfishExternalResourceResourceFeatureCallback >=20 > External email: Use caution opening links or attachments >=20 >=20 > Use local variable for BiosUri passed to HandleResource() to avoid proble= ms in > case of Private->Uri is overriden down the call stack. >=20 > Suggested-by: Nickle Wang > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) >=20 > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > index f40f2d85af80..db77ed3dfccb 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > @@ -670,6 +670,7 @@ RedfishExternalResourceResourceFeatureCallback ( > REDFISH_SERVICE RedfishService; >=20 > REDFISH_RESOURCE_COMMON_PRIVATE *Private; >=20 > EFI_STRING ResourceUri; >=20 > + EFI_STRING BiosUri; >=20 >=20 >=20 > if (FeatureAction !=3D CallbackActionStartOperation) { >=20 > return EFI_UNSUPPORTED; >=20 > @@ -707,19 +708,19 @@ RedfishExternalResourceResourceFeatureCallback ( > // >=20 > // Initialize collection path >=20 > // >=20 > - Private->Uri =3D RedfishGetUri (ResourceUri); >=20 > - if (Private->Uri =3D=3D NULL) { >=20 > + BiosUri =3D RedfishGetUri (ResourceUri); >=20 > + if (BiosUri =3D=3D NULL) { >=20 > ASSERT (FALSE); >=20 > FreePool (ResourceUri); >=20 > return EFI_OUT_OF_RESOURCES; >=20 > } >=20 >=20 >=20 > - Status =3D HandleResource (Private, Private->Uri); >=20 > + Status =3D HandleResource (Private, BiosUri); >=20 > if (EFI_ERROR (Status)) { >=20 > - DEBUG ((DEBUG_ERROR, "%a, process external resource: %a failed: %r\n= ", > __func__, Private->Uri, Status)); >=20 > + DEBUG ((DEBUG_ERROR, "%a, process external resource: %s failed: > + %r\n", __func__, BiosUri, Status)); >=20 > } >=20 >=20 >=20 > - FreePool (Private->Uri); >=20 > + FreePool (BiosUri); >=20 > FreePool (ResourceUri); >=20 > return Status; >=20 > } >=20 > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115771): https://edk2.groups.io/g/devel/message/115771 Mute This Topic: https://groups.io/mt/104495956/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-