Hi Mike,
> May I know why didn't you remove
> RedfishClientPkg/PrivateLibrary/RedfishLib completely?
Yes, Abner and I had discussed this before. RedfishLib brings some difficulty to maintain because it is private library in two separated repositories.
Before we go and remove it, we like to make sure that no one is using it.
@Igor Kulchytskyy, if my memory serves me well, you mentioned that AMI is using RedfishLib. Is it ok for
us to remove RedfishLib in RedfishCientPkg (not RedfishPkg)?
Thanks,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Friday, March 1, 2024 8:08 AM
> To: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP
> protocol
>
> External email: Use caution opening links or attachments
>
>
> Good work, Nickle!
>
> On Thu, Feb 29, 2024 at 11:53 AM Nickle Wang via groups.io
> <nicklew=nvidia.com@groups.io> wrote:
> >
> > Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
> > RedfishClientPkg to use RedfishHttpLib. And remove the use of
> > RedfishHttpCacheLib.
> >
> > I also replace several functions from RedfishLib with the function
> > provided in RedfishHttpLib. In this way, there is no dependency on
> > RedfishLib in RedfishClientPkg.
>
> May I know why didn't you remove
> RedfishClientPkg/PrivateLibrary/RedfishLib completely?
> I've been looking at this library for a long time and started improving it with this
> set.
> Eventually I realized that the improved functions are not used in RedfishClientPkg.
> Then I just deleted RedfishClientPkg/PrivateLibrary and
> RedfishClientPkg/PrivateInclude/Library/RedfishLib.h,
> tuned the dec and dsc files, and I successfully built the package.
> Removing this library is a big improvement since it duplicates RedfishLib from
> RedfishPkg.
> and their headers no longer conflict.
>
> Regards,
> Mike.
>
>
> >
> > I noticed that there is false alarm in uncrustify check. When there
> > are deleted files, uncrustiry cannot check them and trigger uncrustify
> > failure.
> >
> > Pull request is created here for testing CI:
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> > ub.com%2Ftianocore%2Fedk2-redfish-
> client%2Fpull%2F79&data=05%7C02%7Cni
> >
> cklew%40nvidia.com%7C44d7d139b40b4acff94508dc3983b3df%7C43083d1572
> 7340
> >
> c1b7db39efd9ccc17a%7C0%7C0%7C638448485034820142%7CUnknown%7CTW
> FpbGZsb3
> >
> d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
> %7
> >
> C0%7C%7C%7C&sdata=ocqaIR0%2BtKvx8ETphWlWFX2uZIQbQvDKWkn7D36c2z
> 0%3D&res
> > erved=0
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> >
> > Nickle Wang (13):
> > RedfishClientPkg/.github: do not run uncrustify to deleted file.
> > RedfishClientPkg: remove RedfishHttpCacheLib
> > RedfishClientPkg: ues RedfishHttpLib
> > RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib
> > RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib
> > RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib
> > RedfishClientPkg/BiosDxe: ues RedfishHttpLib
> > RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib
> > RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
> > RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib
> > RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib
> > RedfishClientPkg/MemoryDxe: ues RedfishHttpLib
> > RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib
> >
> > RedfishClientPkg/RedfishClientPkg.dec | 1 -
> > RedfishClientPkg/RedfishClientLibs.dsc.inc | 2 +-
> > RedfishClientPkg/RedfishClientPkg.dsc | 1 -
> > .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +-
> > .../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +-
> > .../BootOptionCollectionDxe.inf | 5 +-
> > .../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +-
> > .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +-
> > .../ComputerSystemCollectionDxe.inf | 3 +-
> > .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +-
> > .../MemoryCollectionDxe.inf | 3 +-
> > .../EdkIIRedfishResourceConfigLib.inf | 2 +-
> > .../RedfishFeatureUtilityLib.inf | 3 +-
> > .../RedfishHttpCacheLib.inf | 48 --
> > .../RedfishVersionLib/RedfishVersionLib.inf | 3 +-
> > .../Library/EdkIIRedfishResourceConfigLib.h | 4 +-
> > .../Library/RedfishFeatureUtilityLib.h | 46 +-
> > .../Include/Library/RedfishHttpCacheLib.h | 59 --
> > .../Include/RedfishCollectionCommon.h | 3 +-
> > .../Include/RedfishResourceCommon.h | 3 +-
> > .../RedfishFeatureUtilityInternal.h | 3 +-
> > .../RedfishHttpCacheLibInternal.h | 63 --
> > .../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +--
> > .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 113 +--
> > .../v1_0_4/Common/BootOptionCommon.c | 45 +-
> > .../BootOption/v1_0_4/Dxe/BootOptionDxe.c | 86 +-
> > .../BootOptionCollectionDxe.c | 26 +-
> > .../v1_13_0/Common/ComputerSystemCommon.c | 68 +-
> > .../v1_13_0/Dxe/ComputerSystemDxe.c | 85 +-
> > .../v1_5_0/Common/ComputerSystemCommon.c | 68 +-
> > .../v1_5_0/Dxe/ComputerSystemDxe.c | 84 +-
> > .../ComputerSystemCollectionDxe.c | 15 +-
> > .../Memory/V1_7_1/Common/MemoryCommon.c | 86 +-
> > .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 111 +--
> > .../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 +-
> > .../EdkIIRedfishResourceConfigLib.c | 6 +-
> > .../RedfishFeatureUtilityLib.c | 182 +---
> > .../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ------------------
> > .../RedfishVersionLib/RedfishVersionLib.c | 24 +-
> > .github/workflows/uncrustify-check.sh | 17 +-
> > 40 files changed, 328 insertions(+), 1838 deletions(-) delete mode
> > 100644
> > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.inf
> > delete mode 100644
> > RedfishClientPkg/Include/Library/RedfishHttpCacheLib.h
> > delete mode 100644
> > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLibIntern
> > al.h delete mode 100644
> > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.c
> >
> > --
> > 2.34.1
> >
> >
> >
> >
> >
> >