* [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
@ 2024-02-29 8:52 Nickle Wang via groups.io
2024-02-29 9:04 ` Laszlo Ersek
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Nickle Wang via groups.io @ 2024-02-29 8:52 UTC (permalink / raw)
To: devel; +Cc: Abner Chang, Igor Kulchytskyy
Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
RedfishClientPkg to use RedfishHttpLib. And remove the use of
RedfishHttpCacheLib.
I also replace several functions from RedfishLib with the function
provided in RedfishHttpLib. In this way, there is no dependency on
RedfishLib in RedfishClientPkg.
I noticed that there is false alarm in uncrustify check. When there
are deleted files, uncrustiry cannot check them and trigger uncrustify
failure.
Pull request is created here for testing CI:
https://github.com/tianocore/edk2-redfish-client/pull/79
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Nickle Wang (13):
RedfishClientPkg/.github: do not run uncrustify to deleted file.
RedfishClientPkg: remove RedfishHttpCacheLib
RedfishClientPkg: ues RedfishHttpLib
RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib
RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib
RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib
RedfishClientPkg/BiosDxe: ues RedfishHttpLib
RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib
RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib
RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib
RedfishClientPkg/MemoryDxe: ues RedfishHttpLib
RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib
RedfishClientPkg/RedfishClientPkg.dec | 1 -
RedfishClientPkg/RedfishClientLibs.dsc.inc | 2 +-
RedfishClientPkg/RedfishClientPkg.dsc | 1 -
.../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +-
.../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +-
.../BootOptionCollectionDxe.inf | 5 +-
.../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +-
.../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +-
.../ComputerSystemCollectionDxe.inf | 3 +-
.../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +-
.../MemoryCollectionDxe.inf | 3 +-
.../EdkIIRedfishResourceConfigLib.inf | 2 +-
.../RedfishFeatureUtilityLib.inf | 3 +-
.../RedfishHttpCacheLib.inf | 48 --
.../RedfishVersionLib/RedfishVersionLib.inf | 3 +-
.../Library/EdkIIRedfishResourceConfigLib.h | 4 +-
.../Library/RedfishFeatureUtilityLib.h | 46 +-
.../Include/Library/RedfishHttpCacheLib.h | 59 --
.../Include/RedfishCollectionCommon.h | 3 +-
.../Include/RedfishResourceCommon.h | 3 +-
.../RedfishFeatureUtilityInternal.h | 3 +-
.../RedfishHttpCacheLibInternal.h | 63 --
.../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +--
.../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 113 +--
.../v1_0_4/Common/BootOptionCommon.c | 45 +-
.../BootOption/v1_0_4/Dxe/BootOptionDxe.c | 86 +-
.../BootOptionCollectionDxe.c | 26 +-
.../v1_13_0/Common/ComputerSystemCommon.c | 68 +-
.../v1_13_0/Dxe/ComputerSystemDxe.c | 85 +-
.../v1_5_0/Common/ComputerSystemCommon.c | 68 +-
.../v1_5_0/Dxe/ComputerSystemDxe.c | 84 +-
.../ComputerSystemCollectionDxe.c | 15 +-
.../Memory/V1_7_1/Common/MemoryCommon.c | 86 +-
.../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 111 +--
.../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 +-
.../EdkIIRedfishResourceConfigLib.c | 6 +-
.../RedfishFeatureUtilityLib.c | 182 +---
.../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ------------------
.../RedfishVersionLib/RedfishVersionLib.c | 24 +-
.github/workflows/uncrustify-check.sh | 17 +-
40 files changed, 328 insertions(+), 1838 deletions(-)
delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.inf
delete mode 100644 RedfishClientPkg/Include/Library/RedfishHttpCacheLib.h
delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLibInternal.h
delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.c
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116140): https://edk2.groups.io/g/devel/message/116140
Mute This Topic: https://groups.io/mt/104640214/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
2024-02-29 8:52 [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol Nickle Wang via groups.io
@ 2024-02-29 9:04 ` Laszlo Ersek
2024-02-29 9:08 ` Nickle Wang via groups.io
2024-03-01 0:07 ` Mike Maslenkin
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Laszlo Ersek @ 2024-02-29 9:04 UTC (permalink / raw)
To: devel, nicklew; +Cc: Abner Chang, Igor Kulchytskyy
Hi Nickle,
On 2/29/24 09:52, Nickle Wang via groups.io wrote:
> Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
> RedfishClientPkg to use RedfishHttpLib. And remove the use of
> RedfishHttpCacheLib.
>
> I also replace several functions from RedfishLib with the function
> provided in RedfishHttpLib. In this way, there is no dependency on
> RedfishLib in RedfishClientPkg.
>
> I noticed that there is false alarm in uncrustify check. When there
> are deleted files, uncrustiry cannot check them and trigger uncrustify
> failure.
>
> Pull request is created here for testing CI:
> https://github.com/tianocore/edk2-redfish-client/pull/79
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
>
> Nickle Wang (13):
> RedfishClientPkg/.github: do not run uncrustify to deleted file.
> RedfishClientPkg: remove RedfishHttpCacheLib
> RedfishClientPkg: ues RedfishHttpLib
> RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib
> RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib
> RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib
> RedfishClientPkg/BiosDxe: ues RedfishHttpLib
> RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib
> RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
> RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib
> RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib
> RedfishClientPkg/MemoryDxe: ues RedfishHttpLib
> RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib
can you please enable (shallow) threading in your git config?
$ git config sendemail.thread true
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116154): https://edk2.groups.io/g/devel/message/116154
Mute This Topic: https://groups.io/mt/104640214/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
2024-02-29 9:04 ` Laszlo Ersek
@ 2024-02-29 9:08 ` Nickle Wang via groups.io
0 siblings, 0 replies; 9+ messages in thread
From: Nickle Wang via groups.io @ 2024-02-29 9:08 UTC (permalink / raw)
To: Laszlo Ersek, devel@edk2.groups.io; +Cc: Abner Chang, Igor Kulchytskyy
Hi Laszlo,
Thanks for your reminder. I enable sendemail.thread now.
Regards,
Nickle
> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Thursday, February 29, 2024 5:04 PM
> To: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP
> protocol
>
> External email: Use caution opening links or attachments
>
>
> Hi Nickle,
>
> On 2/29/24 09:52, Nickle Wang via groups.io wrote:
> > Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
> > RedfishClientPkg to use RedfishHttpLib. And remove the use of
> > RedfishHttpCacheLib.
> >
> > I also replace several functions from RedfishLib with the function
> > provided in RedfishHttpLib. In this way, there is no dependency on
> > RedfishLib in RedfishClientPkg.
> >
> > I noticed that there is false alarm in uncrustify check. When there
> > are deleted files, uncrustiry cannot check them and trigger uncrustify
> > failure.
> >
> > Pull request is created here for testing CI:
> > https://github.com/tianocore/edk2-redfish-client/pull/79
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> >
> > Nickle Wang (13):
> > RedfishClientPkg/.github: do not run uncrustify to deleted file.
> > RedfishClientPkg: remove RedfishHttpCacheLib
> > RedfishClientPkg: ues RedfishHttpLib
> > RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib
> > RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib
> > RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib
> > RedfishClientPkg/BiosDxe: ues RedfishHttpLib
> > RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib
> > RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
> > RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib
> > RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib
> > RedfishClientPkg/MemoryDxe: ues RedfishHttpLib
> > RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib
>
> can you please enable (shallow) threading in your git config?
>
> $ git config sendemail.thread true
>
> Thanks!
> Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116155): https://edk2.groups.io/g/devel/message/116155
Mute This Topic: https://groups.io/mt/104640214/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
2024-02-29 8:52 [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol Nickle Wang via groups.io
2024-02-29 9:04 ` Laszlo Ersek
@ 2024-03-01 0:07 ` Mike Maslenkin
2024-03-01 1:24 ` Nickle Wang via groups.io
2024-03-04 2:03 ` Chang, Abner via groups.io
2024-03-05 18:14 ` Igor Kulchytskyy via groups.io
3 siblings, 1 reply; 9+ messages in thread
From: Mike Maslenkin @ 2024-03-01 0:07 UTC (permalink / raw)
To: devel, nicklew; +Cc: Abner Chang, Igor Kulchytskyy
Good work, Nickle!
On Thu, Feb 29, 2024 at 11:53 AM Nickle Wang via groups.io
<nicklew=nvidia.com@groups.io> wrote:
>
> Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
> RedfishClientPkg to use RedfishHttpLib. And remove the use of
> RedfishHttpCacheLib.
>
> I also replace several functions from RedfishLib with the function
> provided in RedfishHttpLib. In this way, there is no dependency on
> RedfishLib in RedfishClientPkg.
May I know why didn't you remove
RedfishClientPkg/PrivateLibrary/RedfishLib completely?
I've been looking at this library for a long time and started
improving it with this set.
Eventually I realized that the improved functions are not used in
RedfishClientPkg.
Then I just deleted RedfishClientPkg/PrivateLibrary and
RedfishClientPkg/PrivateInclude/Library/RedfishLib.h,
tuned the dec and dsc files, and I successfully built the package.
Removing this library is a big improvement since it duplicates
RedfishLib from RedfishPkg.
and their headers no longer conflict.
Regards,
Mike.
>
> I noticed that there is false alarm in uncrustify check. When there
> are deleted files, uncrustiry cannot check them and trigger uncrustify
> failure.
>
> Pull request is created here for testing CI:
> https://github.com/tianocore/edk2-redfish-client/pull/79
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
>
> Nickle Wang (13):
> RedfishClientPkg/.github: do not run uncrustify to deleted file.
> RedfishClientPkg: remove RedfishHttpCacheLib
> RedfishClientPkg: ues RedfishHttpLib
> RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib
> RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib
> RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib
> RedfishClientPkg/BiosDxe: ues RedfishHttpLib
> RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib
> RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
> RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib
> RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib
> RedfishClientPkg/MemoryDxe: ues RedfishHttpLib
> RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib
>
> RedfishClientPkg/RedfishClientPkg.dec | 1 -
> RedfishClientPkg/RedfishClientLibs.dsc.inc | 2 +-
> RedfishClientPkg/RedfishClientPkg.dsc | 1 -
> .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +-
> .../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +-
> .../BootOptionCollectionDxe.inf | 5 +-
> .../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +-
> .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +-
> .../ComputerSystemCollectionDxe.inf | 3 +-
> .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +-
> .../MemoryCollectionDxe.inf | 3 +-
> .../EdkIIRedfishResourceConfigLib.inf | 2 +-
> .../RedfishFeatureUtilityLib.inf | 3 +-
> .../RedfishHttpCacheLib.inf | 48 --
> .../RedfishVersionLib/RedfishVersionLib.inf | 3 +-
> .../Library/EdkIIRedfishResourceConfigLib.h | 4 +-
> .../Library/RedfishFeatureUtilityLib.h | 46 +-
> .../Include/Library/RedfishHttpCacheLib.h | 59 --
> .../Include/RedfishCollectionCommon.h | 3 +-
> .../Include/RedfishResourceCommon.h | 3 +-
> .../RedfishFeatureUtilityInternal.h | 3 +-
> .../RedfishHttpCacheLibInternal.h | 63 --
> .../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +--
> .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 113 +--
> .../v1_0_4/Common/BootOptionCommon.c | 45 +-
> .../BootOption/v1_0_4/Dxe/BootOptionDxe.c | 86 +-
> .../BootOptionCollectionDxe.c | 26 +-
> .../v1_13_0/Common/ComputerSystemCommon.c | 68 +-
> .../v1_13_0/Dxe/ComputerSystemDxe.c | 85 +-
> .../v1_5_0/Common/ComputerSystemCommon.c | 68 +-
> .../v1_5_0/Dxe/ComputerSystemDxe.c | 84 +-
> .../ComputerSystemCollectionDxe.c | 15 +-
> .../Memory/V1_7_1/Common/MemoryCommon.c | 86 +-
> .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 111 +--
> .../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 +-
> .../EdkIIRedfishResourceConfigLib.c | 6 +-
> .../RedfishFeatureUtilityLib.c | 182 +---
> .../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ------------------
> .../RedfishVersionLib/RedfishVersionLib.c | 24 +-
> .github/workflows/uncrustify-check.sh | 17 +-
> 40 files changed, 328 insertions(+), 1838 deletions(-)
> delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.inf
> delete mode 100644 RedfishClientPkg/Include/Library/RedfishHttpCacheLib.h
> delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLibInternal.h
> delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.c
>
> --
> 2.34.1
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116191): https://edk2.groups.io/g/devel/message/116191
Mute This Topic: https://groups.io/mt/104640214/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
2024-03-01 0:07 ` Mike Maslenkin
@ 2024-03-01 1:24 ` Nickle Wang via groups.io
2024-03-05 17:50 ` Igor Kulchytskyy via groups.io
0 siblings, 1 reply; 9+ messages in thread
From: Nickle Wang via groups.io @ 2024-03-01 1:24 UTC (permalink / raw)
To: Mike Maslenkin, devel@edk2.groups.io, Igor Kulchytskyy; +Cc: Abner Chang
[-- Attachment #1: Type: text/plain, Size: 7515 bytes --]
Hi Mike,
> May I know why didn't you remove
> RedfishClientPkg/PrivateLibrary/RedfishLib completely?
Yes, Abner and I had discussed this before. RedfishLib brings some difficulty to maintain because it is private library in two separated repositories.
Before we go and remove it, we like to make sure that no one is using it. @Igor Kulchytskyy<mailto:igork@ami.com>, if my memory serves me well, you mentioned that AMI is using RedfishLib. Is it ok for us to remove RedfishLib in RedfishCientPkg (not RedfishPkg)?
Thanks,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Friday, March 1, 2024 8:08 AM
> To: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP
> protocol
>
> External email: Use caution opening links or attachments
>
>
> Good work, Nickle!
>
> On Thu, Feb 29, 2024 at 11:53 AM Nickle Wang via groups.io
> <nicklew=nvidia.com@groups.io<mailto:nicklew=nvidia.com@groups.io>> wrote:
> >
> > Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
> > RedfishClientPkg to use RedfishHttpLib. And remove the use of
> > RedfishHttpCacheLib.
> >
> > I also replace several functions from RedfishLib with the function
> > provided in RedfishHttpLib. In this way, there is no dependency on
> > RedfishLib in RedfishClientPkg.
>
> May I know why didn't you remove
> RedfishClientPkg/PrivateLibrary/RedfishLib completely?
> I've been looking at this library for a long time and started improving it with this
> set.
> Eventually I realized that the improved functions are not used in RedfishClientPkg.
> Then I just deleted RedfishClientPkg/PrivateLibrary and
> RedfishClientPkg/PrivateInclude/Library/RedfishLib.h,
> tuned the dec and dsc files, and I successfully built the package.
> Removing this library is a big improvement since it duplicates RedfishLib from
> RedfishPkg.
> and their headers no longer conflict.
>
> Regards,
> Mike.
>
>
> >
> > I noticed that there is false alarm in uncrustify check. When there
> > are deleted files, uncrustiry cannot check them and trigger uncrustify
> > failure.
> >
> > Pull request is created here for testing CI:
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> > ub.com%2Ftianocore%2Fedk2-redfish-
> client%2Fpull%2F79&data=05%7C02%7Cni
> >
> cklew%40nvidia.com%7C44d7d139b40b4acff94508dc3983b3df%7C43083d1572
> 7340
> >
> c1b7db39efd9ccc17a%7C0%7C0%7C638448485034820142%7CUnknown%7CTW
> FpbGZsb3
> >
> d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
> %7
> >
> C0%7C%7C%7C&sdata=ocqaIR0%2BtKvx8ETphWlWFX2uZIQbQvDKWkn7D36c2z
> 0%3D&res
> > erved=0
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> > Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> > Cc: Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> >
> > Nickle Wang (13):
> > RedfishClientPkg/.github: do not run uncrustify to deleted file.
> > RedfishClientPkg: remove RedfishHttpCacheLib
> > RedfishClientPkg: ues RedfishHttpLib
> > RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib
> > RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib
> > RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib
> > RedfishClientPkg/BiosDxe: ues RedfishHttpLib
> > RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib
> > RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
> > RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib
> > RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib
> > RedfishClientPkg/MemoryDxe: ues RedfishHttpLib
> > RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib
> >
> > RedfishClientPkg/RedfishClientPkg.dec | 1 -
> > RedfishClientPkg/RedfishClientLibs.dsc.inc | 2 +-
> > RedfishClientPkg/RedfishClientPkg.dsc | 1 -
> > .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +-
> > .../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +-
> > .../BootOptionCollectionDxe.inf | 5 +-
> > .../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +-
> > .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +-
> > .../ComputerSystemCollectionDxe.inf | 3 +-
> > .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +-
> > .../MemoryCollectionDxe.inf | 3 +-
> > .../EdkIIRedfishResourceConfigLib.inf | 2 +-
> > .../RedfishFeatureUtilityLib.inf | 3 +-
> > .../RedfishHttpCacheLib.inf | 48 --
> > .../RedfishVersionLib/RedfishVersionLib.inf | 3 +-
> > .../Library/EdkIIRedfishResourceConfigLib.h | 4 +-
> > .../Library/RedfishFeatureUtilityLib.h | 46 +-
> > .../Include/Library/RedfishHttpCacheLib.h | 59 --
> > .../Include/RedfishCollectionCommon.h | 3 +-
> > .../Include/RedfishResourceCommon.h | 3 +-
> > .../RedfishFeatureUtilityInternal.h | 3 +-
> > .../RedfishHttpCacheLibInternal.h | 63 --
> > .../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +--
> > .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 113 +--
> > .../v1_0_4/Common/BootOptionCommon.c | 45 +-
> > .../BootOption/v1_0_4/Dxe/BootOptionDxe.c | 86 +-
> > .../BootOptionCollectionDxe.c | 26 +-
> > .../v1_13_0/Common/ComputerSystemCommon.c | 68 +-
> > .../v1_13_0/Dxe/ComputerSystemDxe.c | 85 +-
> > .../v1_5_0/Common/ComputerSystemCommon.c | 68 +-
> > .../v1_5_0/Dxe/ComputerSystemDxe.c | 84 +-
> > .../ComputerSystemCollectionDxe.c | 15 +-
> > .../Memory/V1_7_1/Common/MemoryCommon.c | 86 +-
> > .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 111 +--
> > .../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 +-
> > .../EdkIIRedfishResourceConfigLib.c | 6 +-
> > .../RedfishFeatureUtilityLib.c | 182 +---
> > .../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ------------------
> > .../RedfishVersionLib/RedfishVersionLib.c | 24 +-
> > .github/workflows/uncrustify-check.sh | 17 +-
> > 40 files changed, 328 insertions(+), 1838 deletions(-) delete mode
> > 100644
> > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.inf
> > delete mode 100644
> > RedfishClientPkg/Include/Library/RedfishHttpCacheLib.h
> > delete mode 100644
> > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLibIntern
> > al.h delete mode 100644
> > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.c
> >
> > --
> > 2.34.1
> >
> >
> >
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116194): https://edk2.groups.io/g/devel/message/116194
Mute This Topic: https://groups.io/mt/104640214/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 17093 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
2024-02-29 8:52 [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol Nickle Wang via groups.io
2024-02-29 9:04 ` Laszlo Ersek
2024-03-01 0:07 ` Mike Maslenkin
@ 2024-03-04 2:03 ` Chang, Abner via groups.io
2024-03-05 18:14 ` Igor Kulchytskyy via groups.io
3 siblings, 0 replies; 9+ messages in thread
From: Chang, Abner via groups.io @ 2024-03-04 2:03 UTC (permalink / raw)
To: Nickle Wang, devel@edk2.groups.io; +Cc: Igor Kulchytskyy
[AMD Official Use Only - General]
Went through each patch, no problem with entire series.
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Thursday, February 29, 2024 4:53 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>
> Subject: [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
> RedfishClientPkg to use RedfishHttpLib. And remove the use of
> RedfishHttpCacheLib.
>
> I also replace several functions from RedfishLib with the function
> provided in RedfishHttpLib. In this way, there is no dependency on
> RedfishLib in RedfishClientPkg.
>
> I noticed that there is false alarm in uncrustify check. When there
> are deleted files, uncrustiry cannot check them and trigger uncrustify
> failure.
>
> Pull request is created here for testing CI:
> https://github.com/tianocore/edk2-redfish-client/pull/79
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
>
> Nickle Wang (13):
> RedfishClientPkg/.github: do not run uncrustify to deleted file.
> RedfishClientPkg: remove RedfishHttpCacheLib
> RedfishClientPkg: ues RedfishHttpLib
> RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib
> RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib
> RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib
> RedfishClientPkg/BiosDxe: ues RedfishHttpLib
> RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib
> RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
> RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib
> RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib
> RedfishClientPkg/MemoryDxe: ues RedfishHttpLib
> RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib
>
> RedfishClientPkg/RedfishClientPkg.dec | 1 -
> RedfishClientPkg/RedfishClientLibs.dsc.inc | 2 +-
> RedfishClientPkg/RedfishClientPkg.dsc | 1 -
> .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +-
> .../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +-
> .../BootOptionCollectionDxe.inf | 5 +-
> .../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +-
> .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +-
> .../ComputerSystemCollectionDxe.inf | 3 +-
> .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +-
> .../MemoryCollectionDxe.inf | 3 +-
> .../EdkIIRedfishResourceConfigLib.inf | 2 +-
> .../RedfishFeatureUtilityLib.inf | 3 +-
> .../RedfishHttpCacheLib.inf | 48 --
> .../RedfishVersionLib/RedfishVersionLib.inf | 3 +-
> .../Library/EdkIIRedfishResourceConfigLib.h | 4 +-
> .../Library/RedfishFeatureUtilityLib.h | 46 +-
> .../Include/Library/RedfishHttpCacheLib.h | 59 --
> .../Include/RedfishCollectionCommon.h | 3 +-
> .../Include/RedfishResourceCommon.h | 3 +-
> .../RedfishFeatureUtilityInternal.h | 3 +-
> .../RedfishHttpCacheLibInternal.h | 63 --
> .../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +--
> .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 113 +--
> .../v1_0_4/Common/BootOptionCommon.c | 45 +-
> .../BootOption/v1_0_4/Dxe/BootOptionDxe.c | 86 +-
> .../BootOptionCollectionDxe.c | 26 +-
> .../v1_13_0/Common/ComputerSystemCommon.c | 68 +-
> .../v1_13_0/Dxe/ComputerSystemDxe.c | 85 +-
> .../v1_5_0/Common/ComputerSystemCommon.c | 68 +-
> .../v1_5_0/Dxe/ComputerSystemDxe.c | 84 +-
> .../ComputerSystemCollectionDxe.c | 15 +-
> .../Memory/V1_7_1/Common/MemoryCommon.c | 86 +-
> .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 111 +--
> .../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 +-
> .../EdkIIRedfishResourceConfigLib.c | 6 +-
> .../RedfishFeatureUtilityLib.c | 182 +---
> .../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ------------------
> .../RedfishVersionLib/RedfishVersionLib.c | 24 +-
> .github/workflows/uncrustify-check.sh | 17 +-
> 40 files changed, 328 insertions(+), 1838 deletions(-)
> delete mode 100644
> RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.inf
> delete mode 100644
> RedfishClientPkg/Include/Library/RedfishHttpCacheLib.h
> delete mode 100644
> RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLibInternal.h
> delete mode 100644
> RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.c
>
> --
> 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116301): https://edk2.groups.io/g/devel/message/116301
Mute This Topic: https://groups.io/mt/104640214/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
2024-03-01 1:24 ` Nickle Wang via groups.io
@ 2024-03-05 17:50 ` Igor Kulchytskyy via groups.io
2024-03-06 6:40 ` Nickle Wang via groups.io
0 siblings, 1 reply; 9+ messages in thread
From: Igor Kulchytskyy via groups.io @ 2024-03-05 17:50 UTC (permalink / raw)
To: Nickle Wang, Mike Maslenkin, devel@edk2.groups.io; +Cc: Abner Chang
[-- Attachment #1: Type: text/plain, Size: 9188 bytes --]
Hi Nickle,
Sorry, for late response.
AMI does not use RedfishLib in RedfishClientPkg, but library in RedfishPkg used.
Thank you,
Igor
From: Nickle Wang <nicklew@nvidia.com>
Sent: Thursday, February 29, 2024 8:24 PM
To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com>
Cc: Abner Chang <abner.chang@amd.com>
Subject: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**
Hi Mike,
> May I know why didn't you remove
> RedfishClientPkg/PrivateLibrary/RedfishLib completely?
Yes, Abner and I had discussed this before. RedfishLib brings some difficulty to maintain because it is private library in two separated repositories.
Before we go and remove it, we like to make sure that no one is using it. @Igor Kulchytskyy<mailto:igork@ami.com>, if my memory serves me well, you mentioned that AMI is using RedfishLib. Is it ok for us to remove RedfishLib in RedfishCientPkg (not RedfishPkg)?
Thanks,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>
> Sent: Friday, March 1, 2024 8:08 AM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>; Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP
> protocol
>
> External email: Use caution opening links or attachments
>
>
> Good work, Nickle!
>
> On Thu, Feb 29, 2024 at 11:53 AM Nickle Wang via groups.io
> <nicklew=nvidia.com@groups.io<mailto:nicklew=nvidia.com@groups.io>> wrote:
> >
> > Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
> > RedfishClientPkg to use RedfishHttpLib. And remove the use of
> > RedfishHttpCacheLib.
> >
> > I also replace several functions from RedfishLib with the function
> > provided in RedfishHttpLib. In this way, there is no dependency on
> > RedfishLib in RedfishClientPkg.
>
> May I know why didn't you remove
> RedfishClientPkg/PrivateLibrary/RedfishLib completely?
> I've been looking at this library for a long time and started improving it with this
> set.
> Eventually I realized that the improved functions are not used in RedfishClientPkg.
> Then I just deleted RedfishClientPkg/PrivateLibrary and
> RedfishClientPkg/PrivateInclude/Library/RedfishLib.h,
> tuned the dec and dsc files, and I successfully built the package.
> Removing this library is a big improvement since it duplicates RedfishLib from
> RedfishPkg.
> and their headers no longer conflict.
>
> Regards,
> Mike.
>
>
> >
> > I noticed that there is false alarm in uncrustify check. When there
> > are deleted files, uncrustiry cannot check them and trigger uncrustify
> > failure.
> >
> > Pull request is created here for testing CI:
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith%2F&data=05%7C02%7Cigork%40ami.com%7Ceb1640aa25424af7c29908dc398e5836%7C27e97857e15f486cb58e86c2b3040f93%7C1%7C0%7C638448530742155955%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=LNYQJT7%2FM8rxev%2BI48n%2FeBi1FCla%2F1JlhvJ7koCpNno%3D&reserved=0>
> > ub.com%2Ftianocore%2Fedk2-redfish-
> client%2Fpull%2F79&data=05%7C02%7Cni
> >
> cklew%40nvidia.com%7C44d7d139b40b4acff94508dc3983b3df%7C43083d1572
> 7340
> >
> c1b7db39efd9ccc17a%7C0%7C0%7C638448485034820142%7CUnknown%7CTW
> FpbGZsb3
> >
> d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
> %7
> >
> C0%7C%7C%7C&sdata=ocqaIR0%2BtKvx8ETphWlWFX2uZIQbQvDKWkn7D36c2z
> 0%3D&res
> > erved=0
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> > Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> > Cc: Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> >
> > Nickle Wang (13):
> > RedfishClientPkg/.github: do not run uncrustify to deleted file.
> > RedfishClientPkg: remove RedfishHttpCacheLib
> > RedfishClientPkg: ues RedfishHttpLib
> > RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib
> > RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib
> > RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib
> > RedfishClientPkg/BiosDxe: ues RedfishHttpLib
> > RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib
> > RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
> > RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib
> > RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib
> > RedfishClientPkg/MemoryDxe: ues RedfishHttpLib
> > RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib
> >
> > RedfishClientPkg/RedfishClientPkg.dec | 1 -
> > RedfishClientPkg/RedfishClientLibs.dsc.inc | 2 +-
> > RedfishClientPkg/RedfishClientPkg.dsc | 1 -
> > .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +-
> > .../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +-
> > .../BootOptionCollectionDxe.inf | 5 +-
> > .../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +-
> > .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +-
> > .../ComputerSystemCollectionDxe.inf | 3 +-
> > .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +-
> > .../MemoryCollectionDxe.inf | 3 +-
> > .../EdkIIRedfishResourceConfigLib.inf | 2 +-
> > .../RedfishFeatureUtilityLib.inf | 3 +-
> > .../RedfishHttpCacheLib.inf | 48 --
> > .../RedfishVersionLib/RedfishVersionLib.inf | 3 +-
> > .../Library/EdkIIRedfishResourceConfigLib.h | 4 +-
> > .../Library/RedfishFeatureUtilityLib.h | 46 +-
> > .../Include/Library/RedfishHttpCacheLib.h | 59 --
> > .../Include/RedfishCollectionCommon.h | 3 +-
> > .../Include/RedfishResourceCommon.h | 3 +-
> > .../RedfishFeatureUtilityInternal.h | 3 +-
> > .../RedfishHttpCacheLibInternal.h | 63 --
> > .../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +--
> > .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 113 +--
> > .../v1_0_4/Common/BootOptionCommon.c | 45 +-
> > .../BootOption/v1_0_4/Dxe/BootOptionDxe.c | 86 +-
> > .../BootOptionCollectionDxe.c | 26 +-
> > .../v1_13_0/Common/ComputerSystemCommon.c | 68 +-
> > .../v1_13_0/Dxe/ComputerSystemDxe.c | 85 +-
> > .../v1_5_0/Common/ComputerSystemCommon.c | 68 +-
> > .../v1_5_0/Dxe/ComputerSystemDxe.c | 84 +-
> > .../ComputerSystemCollectionDxe.c | 15 +-
> > .../Memory/V1_7_1/Common/MemoryCommon.c | 86 +-
> > .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 111 +--
> > .../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 +-
> > .../EdkIIRedfishResourceConfigLib.c | 6 +-
> > .../RedfishFeatureUtilityLib.c | 182 +---
> > .../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ------------------
> > .../RedfishVersionLib/RedfishVersionLib.c | 24 +-
> > .github/workflows/uncrustify-check.sh | 17 +-
> > 40 files changed, 328 insertions(+), 1838 deletions(-) delete mode
> > 100644
> > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.inf
> > delete mode 100644
> > RedfishClientPkg/Include/Library/RedfishHttpCacheLib.h
> > delete mode 100644
> > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLibIntern
> > al.h delete mode 100644
> > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.c
> >
> > --
> > 2.34.1
> >
> >
> >
> >
> >
> >
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116404): https://edk2.groups.io/g/devel/message/116404
Mute This Topic: https://groups.io/mt/104640214/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 59041 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
2024-02-29 8:52 [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol Nickle Wang via groups.io
` (2 preceding siblings ...)
2024-03-04 2:03 ` Chang, Abner via groups.io
@ 2024-03-05 18:14 ` Igor Kulchytskyy via groups.io
3 siblings, 0 replies; 9+ messages in thread
From: Igor Kulchytskyy via groups.io @ 2024-03-05 18:14 UTC (permalink / raw)
To: Nickle Wang, devel@edk2.groups.io; +Cc: Abner Chang
Reviewed-by: Igor Kulchytskyy <igork@ami.com>
Whole patch reviewed
Regards,
Igor
-----Original Message-----
From: Nickle Wang <nicklew@nvidia.com>
Sent: Thursday, February 29, 2024 3:53 AM
To: devel@edk2.groups.io
Cc: Abner Chang <abner.chang@amd.com>; Igor Kulchytskyy <igork@ami.com>
Subject: [EXTERNAL] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**
Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
RedfishClientPkg to use RedfishHttpLib. And remove the use of
RedfishHttpCacheLib.
I also replace several functions from RedfishLib with the function
provided in RedfishHttpLib. In this way, there is no dependency on
RedfishLib in RedfishClientPkg.
I noticed that there is false alarm in uncrustify check. When there
are deleted files, uncrustiry cannot check them and trigger uncrustify
failure.
Pull request is created here for testing CI:
https://github.com/tianocore/edk2-redfish-client/pull/79
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Nickle Wang (13):
RedfishClientPkg/.github: do not run uncrustify to deleted file.
RedfishClientPkg: remove RedfishHttpCacheLib
RedfishClientPkg: ues RedfishHttpLib
RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib
RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib
RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib
RedfishClientPkg/BiosDxe: ues RedfishHttpLib
RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib
RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib
RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib
RedfishClientPkg/MemoryDxe: ues RedfishHttpLib
RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib
RedfishClientPkg/RedfishClientPkg.dec | 1 -
RedfishClientPkg/RedfishClientLibs.dsc.inc | 2 +-
RedfishClientPkg/RedfishClientPkg.dsc | 1 -
.../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +-
.../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +-
.../BootOptionCollectionDxe.inf | 5 +-
.../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +-
.../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +-
.../ComputerSystemCollectionDxe.inf | 3 +-
.../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +-
.../MemoryCollectionDxe.inf | 3 +-
.../EdkIIRedfishResourceConfigLib.inf | 2 +-
.../RedfishFeatureUtilityLib.inf | 3 +-
.../RedfishHttpCacheLib.inf | 48 --
.../RedfishVersionLib/RedfishVersionLib.inf | 3 +-
.../Library/EdkIIRedfishResourceConfigLib.h | 4 +-
.../Library/RedfishFeatureUtilityLib.h | 46 +-
.../Include/Library/RedfishHttpCacheLib.h | 59 --
.../Include/RedfishCollectionCommon.h | 3 +-
.../Include/RedfishResourceCommon.h | 3 +-
.../RedfishFeatureUtilityInternal.h | 3 +-
.../RedfishHttpCacheLibInternal.h | 63 --
.../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +--
.../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 113 +--
.../v1_0_4/Common/BootOptionCommon.c | 45 +-
.../BootOption/v1_0_4/Dxe/BootOptionDxe.c | 86 +-
.../BootOptionCollectionDxe.c | 26 +-
.../v1_13_0/Common/ComputerSystemCommon.c | 68 +-
.../v1_13_0/Dxe/ComputerSystemDxe.c | 85 +-
.../v1_5_0/Common/ComputerSystemCommon.c | 68 +-
.../v1_5_0/Dxe/ComputerSystemDxe.c | 84 +-
.../ComputerSystemCollectionDxe.c | 15 +-
.../Memory/V1_7_1/Common/MemoryCommon.c | 86 +-
.../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 111 +--
.../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 +-
.../EdkIIRedfishResourceConfigLib.c | 6 +-
.../RedfishFeatureUtilityLib.c | 182 +---
.../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ------------------
.../RedfishVersionLib/RedfishVersionLib.c | 24 +-
.github/workflows/uncrustify-check.sh | 17 +-
40 files changed, 328 insertions(+), 1838 deletions(-)
delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.inf
delete mode 100644 RedfishClientPkg/Include/Library/RedfishHttpCacheLib.h
delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLibInternal.h
delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.c
--
2.34.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116405): https://edk2.groups.io/g/devel/message/116405
Mute This Topic: https://groups.io/mt/104640214/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
2024-03-05 17:50 ` Igor Kulchytskyy via groups.io
@ 2024-03-06 6:40 ` Nickle Wang via groups.io
0 siblings, 0 replies; 9+ messages in thread
From: Nickle Wang via groups.io @ 2024-03-06 6:40 UTC (permalink / raw)
To: Igor Kulchytskyy, Mike Maslenkin, devel@edk2.groups.io; +Cc: Abner Chang
[-- Attachment #1: Type: text/plain, Size: 9834 bytes --]
Thanks for your feedback, Igor!
I will create a patch and remove RedfishLib in RedfishClientPkg.
Regards,
Nickle
From: Igor Kulchytskyy <igork@ami.com>
Sent: Wednesday, March 6, 2024 1:50 AM
To: Nickle Wang <nicklew@nvidia.com>; Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
Cc: Abner Chang <abner.chang@amd.com>
Subject: RE: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
External email: Use caution opening links or attachments
Hi Nickle,
Sorry, for late response.
AMI does not use RedfishLib in RedfishClientPkg, but library in RedfishPkg used.
Thank you,
Igor
From: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
Sent: Thursday, February 29, 2024 8:24 PM
To: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
Subject: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**
Hi Mike,
> May I know why didn't you remove
> RedfishClientPkg/PrivateLibrary/RedfishLib completely?
Yes, Abner and I had discussed this before. RedfishLib brings some difficulty to maintain because it is private library in two separated repositories.
Before we go and remove it, we like to make sure that no one is using it. @Igor Kulchytskyy<mailto:igork@ami.com>, if my memory serves me well, you mentioned that AMI is using RedfishLib. Is it ok for us to remove RedfishLib in RedfishCientPkg (not RedfishPkg)?
Thanks,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com<mailto:mike.maslenkin@gmail.com>>
> Sent: Friday, March 1, 2024 8:08 AM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>; Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP
> protocol
>
> External email: Use caution opening links or attachments
>
>
> Good work, Nickle!
>
> On Thu, Feb 29, 2024 at 11:53 AM Nickle Wang via groups.io
> <nicklew=nvidia.com@groups.io<mailto:nicklew=nvidia.com@groups.io>> wrote:
> >
> > Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
> > RedfishClientPkg to use RedfishHttpLib. And remove the use of
> > RedfishHttpCacheLib.
> >
> > I also replace several functions from RedfishLib with the function
> > provided in RedfishHttpLib. In this way, there is no dependency on
> > RedfishLib in RedfishClientPkg.
>
> May I know why didn't you remove
> RedfishClientPkg/PrivateLibrary/RedfishLib completely?
> I've been looking at this library for a long time and started improving it with this
> set.
> Eventually I realized that the improved functions are not used in RedfishClientPkg.
> Then I just deleted RedfishClientPkg/PrivateLibrary and
> RedfishClientPkg/PrivateInclude/Library/RedfishLib.h,
> tuned the dec and dsc files, and I successfully built the package.
> Removing this library is a big improvement since it duplicates RedfishLib from
> RedfishPkg.
> and their headers no longer conflict.
>
> Regards,
> Mike.
>
>
> >
> > I noticed that there is false alarm in uncrustify check. When there
> > are deleted files, uncrustiry cannot check them and trigger uncrustify
> > failure.
> >
> > Pull request is created here for testing CI:
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith%2F&data=05%7C02%7Cnicklew%40nvidia.com%7C05c61959f6604763e61208dc3d3cbe64%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638452578319230226%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=4reM%2FifNUi4hskVe5ZazRuNX07Yt1hf4IHkJowqzl5I%3D&reserved=0>
> > ub.com%2Ftianocore%2Fedk2-redfish-
> client%2Fpull%2F79&data=05%7C02%7Cni
> >
> cklew%40nvidia.com%7C44d7d139b40b4acff94508dc3983b3df%7C43083d1572
> 7340
> >
> c1b7db39efd9ccc17a%7C0%7C0%7C638448485034820142%7CUnknown%7CTW
> FpbGZsb3
> >
> d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
> %7
> >
> C0%7C%7C%7C&sdata=ocqaIR0%2BtKvx8ETphWlWFX2uZIQbQvDKWkn7D36c2z
> 0%3D&res
> > erved=0
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>
> > Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> > Cc: Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>>
> >
> > Nickle Wang (13):
> > RedfishClientPkg/.github: do not run uncrustify to deleted file.
> > RedfishClientPkg: remove RedfishHttpCacheLib
> > RedfishClientPkg: ues RedfishHttpLib
> > RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib
> > RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib
> > RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib
> > RedfishClientPkg/BiosDxe: ues RedfishHttpLib
> > RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib
> > RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
> > RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib
> > RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib
> > RedfishClientPkg/MemoryDxe: ues RedfishHttpLib
> > RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib
> >
> > RedfishClientPkg/RedfishClientPkg.dec | 1 -
> > RedfishClientPkg/RedfishClientLibs.dsc.inc | 2 +-
> > RedfishClientPkg/RedfishClientPkg.dsc | 1 -
> > .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +-
> > .../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +-
> > .../BootOptionCollectionDxe.inf | 5 +-
> > .../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +-
> > .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +-
> > .../ComputerSystemCollectionDxe.inf | 3 +-
> > .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +-
> > .../MemoryCollectionDxe.inf | 3 +-
> > .../EdkIIRedfishResourceConfigLib.inf | 2 +-
> > .../RedfishFeatureUtilityLib.inf | 3 +-
> > .../RedfishHttpCacheLib.inf | 48 --
> > .../RedfishVersionLib/RedfishVersionLib.inf | 3 +-
> > .../Library/EdkIIRedfishResourceConfigLib.h | 4 +-
> > .../Library/RedfishFeatureUtilityLib.h | 46 +-
> > .../Include/Library/RedfishHttpCacheLib.h | 59 --
> > .../Include/RedfishCollectionCommon.h | 3 +-
> > .../Include/RedfishResourceCommon.h | 3 +-
> > .../RedfishFeatureUtilityInternal.h | 3 +-
> > .../RedfishHttpCacheLibInternal.h | 63 --
> > .../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +--
> > .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 113 +--
> > .../v1_0_4/Common/BootOptionCommon.c | 45 +-
> > .../BootOption/v1_0_4/Dxe/BootOptionDxe.c | 86 +-
> > .../BootOptionCollectionDxe.c | 26 +-
> > .../v1_13_0/Common/ComputerSystemCommon.c | 68 +-
> > .../v1_13_0/Dxe/ComputerSystemDxe.c | 85 +-
> > .../v1_5_0/Common/ComputerSystemCommon.c | 68 +-
> > .../v1_5_0/Dxe/ComputerSystemDxe.c | 84 +-
> > .../ComputerSystemCollectionDxe.c | 15 +-
> > .../Memory/V1_7_1/Common/MemoryCommon.c | 86 +-
> > .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 111 +--
> > .../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 +-
> > .../EdkIIRedfishResourceConfigLib.c | 6 +-
> > .../RedfishFeatureUtilityLib.c | 182 +---
> > .../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ------------------
> > .../RedfishVersionLib/RedfishVersionLib.c | 24 +-
> > .github/workflows/uncrustify-check.sh | 17 +-
> > 40 files changed, 328 insertions(+), 1838 deletions(-) delete mode
> > 100644
> > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.inf
> > delete mode 100644
> > RedfishClientPkg/Include/Library/RedfishHttpCacheLib.h
> > delete mode 100644
> > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLibIntern
> > al.h delete mode 100644
> > RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.c
> >
> > --
> > 2.34.1
> >
> >
> >
> >
> >
> >
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116421): https://edk2.groups.io/g/devel/message/116421
Mute This Topic: https://groups.io/mt/104640214/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 24134 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-03-06 6:40 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-29 8:52 [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol Nickle Wang via groups.io
2024-02-29 9:04 ` Laszlo Ersek
2024-02-29 9:08 ` Nickle Wang via groups.io
2024-03-01 0:07 ` Mike Maslenkin
2024-03-01 1:24 ` Nickle Wang via groups.io
2024-03-05 17:50 ` Igor Kulchytskyy via groups.io
2024-03-06 6:40 ` Nickle Wang via groups.io
2024-03-04 2:03 ` Chang, Abner via groups.io
2024-03-05 18:14 ` Igor Kulchytskyy via groups.io
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox